[Mesa-dev] [Bug 57969] New: [softpipe] piglit timer_query regression

2012-12-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=57969 Priority: medium Bug ID: 57969 Keywords: regression CC: jfons...@vmware.com Assignee: mesa-dev@lists.freedesktop.org Summary: [softpipe] piglit timer_query regression S

Re: [Mesa-dev] [PATCH 1/3] Set es_version to false when using FF fragment shading in meta ops

2012-12-06 Thread Kenneth Graunke
On 12/06/2012 05:53 PM, Ian Romanick wrote: From: Paul Berry --- src/mesa/main/ff_fragment_shader.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/main/ff_fragment_shader.cpp b/src/mesa/main/ff_fragment_shader.cpp index 3a80ab7..02b4707 100644 --- a/src/mesa/main/ff_fragment

Re: [Mesa-dev] [PATCH 0/3] Meta and fixed-function fixes for GLES3

2012-12-06 Thread Ian Romanick
On 12/06/2012 08:09 PM, Matt Turner wrote: On Thu, Dec 6, 2012 at 5:53 PM, Ian Romanick wrote: There are more changes to meta coming. The BlitFramebuffer paths in meta all use fixed-function, and that doesn't exist on ES3. Those patches should be out on the list shortly. Are you doing that?

Re: [Mesa-dev] [PATCH 0/3] Meta and fixed-function fixes for GLES3

2012-12-06 Thread Matt Turner
On Thu, Dec 6, 2012 at 5:53 PM, Ian Romanick wrote: > There are more changes > to meta coming. The BlitFramebuffer paths in meta all use > fixed-function, and that doesn't exist on ES3. Those patches should be > out on the list shortly. Are you doing that? Anuj was working on a GLSL implementat

Re: [Mesa-dev] [PATCH v2 0/2] Use hash table for variable refcount rather than a linked list

2012-12-06 Thread Ian Romanick
The series is: Reviewed-by: Ian Romanick On 12/06/2012 05:51 PM, Jordan Justen wrote: In the gles3conform uniform_buffer_object_max_uniform_block_size test case, this dramatically improves performance of the compiler frontend. v2: * Add main/hash_table for Android (build not verified) * U

[Mesa-dev] [PATCH 3/3] meta: Use #version 300 es for _mesa_glsl_Clear's integer shaders on ES3.

2012-12-06 Thread Ian Romanick
From: Kenneth Graunke Fixes es3conform's color_buffer_float_clamp_(fixed|on|off) tests. Reviewed-by: Ian Romanick --- src/mesa/drivers/common/meta.c | 44 ++ 1 file changed, 27 insertions(+), 17 deletions(-) diff --git a/src/mesa/drivers/common/meta.c b

[Mesa-dev] [PATCH 2/3] meta: Use #version 300 es in GenerateMipmap shaders on ES3.

2012-12-06 Thread Ian Romanick
From: Kenneth Graunke Reviewed-by: Ian Romanick --- src/mesa/drivers/common/meta.c | 24 +--- 1 file changed, 13 insertions(+), 11 deletions(-) diff --git a/src/mesa/drivers/common/meta.c b/src/mesa/drivers/common/meta.c index ad21fa8..0fba681 100644 --- a/src/mesa/drivers/

[Mesa-dev] [PATCH 1/3] Set es_version to false when using FF fragment shading in meta ops

2012-12-06 Thread Ian Romanick
From: Paul Berry --- src/mesa/main/ff_fragment_shader.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/main/ff_fragment_shader.cpp b/src/mesa/main/ff_fragment_shader.cpp index 3a80ab7..02b4707 100644 --- a/src/mesa/main/ff_fragment_shader.cpp +++ b/src/mesa/main/ff_fragment_shad

[Mesa-dev] [PATCH 0/3] Meta and fixed-function fixes for GLES3

2012-12-06 Thread Ian Romanick
I think all of these patches were already on the list before too. They're small fixes to meta and fixed-function. There are more changes to meta coming. The BlitFramebuffer paths in meta all use fixed-function, and that doesn't exist on ES3. Those patches should be out on the list shortly. I wo

[Mesa-dev] [PATCH v2 1/2] program/hash_table.c: rename to program/prog_hash_table.c

2012-12-06 Thread Jordan Justen
Removes a collision of the object file name for main/hash_table and program/hash_table. Signed-off-by: Jordan Justen --- src/glsl/Makefile.am |4 +- src/glsl/SConscript|4 +- src/glsl/builtin_compiler/Makefile.am |2 +- src/glsl/glcpp/Makefile.a

[Mesa-dev] [PATCH v2 2/2] mesa: Use the new hash table for the variable refcount visitor.

2012-12-06 Thread Jordan Justen
From: Eric Anholt Reviewed-by: Jordan Justen [jordan.l.jus...@intel.com: open_hash_table => hash_table] Signed-off-by: Jordan Justen --- src/glsl/Makefile.am |2 ++ src/glsl/SConscript|4 src/glsl/builtin_compiler/Makefile.am |1 + src/gl

[Mesa-dev] [PATCH v2 0/2] Use hash table for variable refcount rather than a linked list

2012-12-06 Thread Jordan Justen
In the gles3conform uniform_buffer_object_max_uniform_block_size test case, this dramatically improves performance of the compiler frontend. v2: * Add main/hash_table for Android (build not verified) * Use delete rather than free in free_entry. * Make use of hash_table_foreach where useful * R

[Mesa-dev] [PATCH 13/13] intel: Enable ETC2 support on intel hardware

2012-12-06 Thread Ian Romanick
From: Anuj Phogat This patch enables support for ETC2 compressed textures on all intel hardware. At present, ETC2 texture decoding is not available on intel hardware. So, compressed ETC2 texture data is decoded in software and stored in a suitable uncompressed MESA_FORMAT at the time of glCompres

[Mesa-dev] [PATCH 12/13] mesa: Add decoding functions for GL_COMPRESSED_SRGB8_PUNCHTHROUGH_ALPHA1_ETC2

2012-12-06 Thread Ian Romanick
From: Anuj Phogat Data in GL_COMPRESSED_SRGB8_PUNCHTHROUGH_ALPHA1_ETC2 format is decoded and stored in MESA_FORMAT_SARGB. Signed-off-by: Anuj Phogat Reviewed-by: Brian Paul --- src/mesa/main/texcompress.c | 2 +- src/mesa/main/texcompress_etc.c | 78 +

[Mesa-dev] [PATCH 11/13] mesa: Add decoding functions for GL_COMPRESSED_RGB8_PUNCHTHROUGH_ALPHA1_ETC2

2012-12-06 Thread Ian Romanick
From: Anuj Phogat Data in GL_COMPRESSED_RGB8_PUNCHTHROUGH_ALPHA1_ETC2 format is decoded and stored in MESA_FORMAT_RGBA_REV. Signed-off-by: Anuj Phogat Reviewed-by: Brian Paul --- src/mesa/main/texcompress.c | 2 +- src/mesa/main/texcompress_etc.c | 180 ++

[Mesa-dev] [PATCH 09/13] mesa: Add decoding functions for GL_COMPRESSED_SIGNED_R11_EAC

2012-12-06 Thread Ian Romanick
From: Anuj Phogat Data in GL_COMPRESSED_SIGNED_R11_EAC format is decoded and stored in MESA_FORMAT_SIGNED_R16. v2: 16 bit signed data is converted to 16 bit unsigned data by adding 2 ^ 15 and stored in an unsigned texture format. v3: 1. Handle a corner case when base code word value is -128. As

[Mesa-dev] [PATCH 10/13] mesa: Add decoding functions for GL_COMPRESSED_SIGNED_RG11_EAC

2012-12-06 Thread Ian Romanick
From: Anuj Phogat Data in GL_COMPRESSED_SIGNED_RG11_EAC format is decoded and stored in MESA_FORMAT_SIGNED_GR1616. Signed-off-by: Anuj Phogat Reviewed-by: Brian Paul --- src/mesa/main/texcompress.c | 2 +- src/mesa/main/texcompress_etc.c | 87 + sr

[Mesa-dev] [PATCH 07/13] mesa: Add decoding functions for GL_COMPRESSED_R11_EAC

2012-12-06 Thread Ian Romanick
From: Anuj Phogat Data in GL_COMPRESSED_R11_EAC format is decoded and stored in MESA_FORMAT_R16. Signed-off-by: Anuj Phogat Reviewed-by: Brian Paul --- src/mesa/main/texcompress.c | 2 +- src/mesa/main/texcompress_etc.c | 122 +++- src/mesa/main/texco

[Mesa-dev] [PATCH 08/13] mesa: Add decoding functions for GL_COMPRESSED_RG11_EAC

2012-12-06 Thread Ian Romanick
From: Anuj Phogat Data in GL_COMPRESSED_RG11_EAC format is decoded and stored in MESA_FORMAT_RG1616. Signed-off-by: Anuj Phogat Reviewed-by: Brian Paul --- src/mesa/main/texcompress.c | 2 +- src/mesa/main/texcompress_etc.c | 89 + src/mesa/main/te

[Mesa-dev] [PATCH 06/13] mesa: Add decoding functions for GL_COMPRESSED_SRGB8_ALPHA8_ETC2_EAC

2012-12-06 Thread Ian Romanick
From: Anuj Phogat Data in GL_COMPRESSED_SRGB8_ALPHA8_ETC2_EAC format is decoded and stored in MESA_FORMAT_SARGB8. Signed-off-by: Anuj Phogat Reviewed-by: Brian Paul --- src/mesa/main/texcompress.c | 2 +- src/mesa/main/texcompress_etc.c | 80 + src

[Mesa-dev] [PATCH 05/13] mesa: Add decoding functions for GL_COMPRESSED_RGBA8_ETC2_EAC

2012-12-06 Thread Ian Romanick
From: Anuj Phogat Data in GL_COMPRESSED_RGBA8_ETC2_EAC format is decoded and stored in MESA_FORMAT_RGBA_REV. Signed-off-by: Anuj Phogat Reviewed-by: Brian Paul --- src/mesa/main/texcompress.c | 2 +- src/mesa/main/texcompress_etc.c | 145 ++-- src

[Mesa-dev] [PATCH 04/13] mesa: Add decoding functions for GL_COMPRESSED_SRGB8_ETC2

2012-12-06 Thread Ian Romanick
From: Anuj Phogat Data in GL_COMPRESSED_SRGB8_ETC2 format is decoded and stored in MESA_FORMAT_SARGB8. Signed-off-by: Anuj Phogat Reviewed-by: Brian Paul --- src/mesa/main/texcompress.c | 2 +- src/mesa/main/texcompress_etc.c | 83 +++-- src/mesa/main/

[Mesa-dev] [PATCH 03/13] mesa: Add decoding functions for GL_COMPRESSED_RGB8_ETC2

2012-12-06 Thread Ian Romanick
From: Anuj Phogat Data in GL_COMPRESSED_RGB8_ETC2 format is decoded and stored in MESA_FORMAT_RGBX_REV. v2: Use CLAMP macro and stdbool.h Signed-off-by: Anuj Phogat Reviewed-by: Brian Paul --- src/mesa/main/texcompress.c | 2 +- src/mesa/main/texcompress_etc.c | 460

[Mesa-dev] [PATCH 02/13] mesa: Make nonlinear_to_linear() function available outside file

2012-12-06 Thread Ian Romanick
From: Anuj Phogat This patch changes nonlinear_to_linear() function to non static inline and makes it available outside format_unpack.c. Also, removes the duplicate copies in other files. Signed-off-by: Anuj Phogat Reviewed-by: Brian Paul --- src/mesa/main/format_unpack.c| 26 ++--

[Mesa-dev] [PATCH 01/13] mesa: Add new MESA_FORMATs for ETC2 compressed textures

2012-12-06 Thread Ian Romanick
From: Anuj Phogat It is required by OpenGL ES 3.0 to support ETC2 textures. This patch adds new MESA_FORMATs for following etc2 texture formats: GL_COMPRESSED_RGB8_ETC2 GL_COMPRESSED_SRGB8_ETC2 GL_COMPRESSED_RGBA8_ETC2_EAC GL_COMPRESSED_SRGB8_ALPHA8_ETC2_EAC GL_COMPRESSED_R11_EAC GL_COMPRES

[Mesa-dev] [PATCH 00/13] ETC2 support resend

2012-12-06 Thread Ian Romanick
These patches have already circulated through the list once. Since that time, Paul modified a couple of the patches so that every patch will build (for git-bisect happiness), and Anuj has fixed a few bugs (and squashed the bug fixes in to the original patches). If there are no objections, I'd lik

Re: [Mesa-dev] [PATCH 1/4] gallivm, llvmpipe, draw: Support multiple constant buffers.

2012-12-06 Thread Dave Airlie
On Fri, Dec 7, 2012 at 3:35 AM, wrote: > From: José Fonseca > > Support 4 (defined in LP_MAX_TGSI_CONST_BUFFERS) as opposed to 32 (as > defined by PIPE_MAX_CONSTANT_BUFFERS) because that would make the jit > context become unnecessarily large. For GL ARB_uniform_buffer_object, we need at least

Re: [Mesa-dev] [PATCH 2/6] st/mesa: add texture buffer object support to state tracker

2012-12-06 Thread Dave Airlie
>> + } else { >> + const struct st_texture_image *firstImage = >> + >> st_texture_image(stObj->base.Image[0][stObj->base.BaseLevel]); >> + texFormat = firstImage->base.TexFormat; >> + } >> + firstImageFormat = st_mesa_format_to_pipe_format(texFormat); > > > I haven't

Re: [Mesa-dev] [PATCH v3 0/7] Delay exec table initialization until version is computed

2012-12-06 Thread Jordan Justen
I tested this series on i965 and llvmpipe. Does anyone want to test this branch on other hardware since it modifies the initialization path for all drivers? git://people.freedesktop.org/~jljusten/mesa version-gles3-dispatch (This branch is the series rebased on the current master.) Thanks, -Jor

[Mesa-dev] [PATCH 2/2] r600g: add htile support v13

2012-12-06 Thread j . glisse
From: Jerome Glisse htile is used for HiZ and HiS support and fast Z/S clears. This commit just adds the htile setup and Fast Z clear. We don't take full advantage of HiS with that patch. v2 really use fast clear, still random issue with some tiles need to try more flush combination, fix dept

[Mesa-dev] [PATCH 1/2] r600g: rework flusing and synchronization pattern v4

2012-12-06 Thread j . glisse
From: Jerome Glisse This bring r600g allmost inline with closed source driver when it comes to flushing and synchronization pattern. Signed-off-by: Jerome Glisse --- src/gallium/drivers/r600/evergreen_compute.c | 8 +- .../drivers/r600/evergreen_compute_internal.c | 4 +- src/ga

[Mesa-dev] [RFC] r600g hyperz support

2012-12-06 Thread j . glisse
So i finally have something that doesn't seem to lockup (i run in loop several things that used to lockup on various GPU over 24hour without a single lockup), or regress anything. It's a bundle deal the first patch is needed for lockup avoidance. Tested on : rv610, rv635, rv670, rv710, rv730, rv740

[Mesa-dev] [PATCH] glsl: Don't add structure fields to the symbol table

2012-12-06 Thread Ian Romanick
From: Ian Romanick I erroneously added this back in January 2011 in commit 88421589. Looking at the commit message, I have no idea why I added it. It only added non-array structure fields to the symbol table, so array structure fields are treated correctly. Fixes piglit tests structure-and-fiel

Re: [Mesa-dev] llvmpipe perf regression

2012-12-06 Thread Brian Paul
On 12/06/2012 03:33 PM, Dave Airlie wrote: On Thu, Dec 6, 2012 at 9:57 PM, Dave Airlie wrote: I haven't investigated to see exactly what the issue is. Can you take a look? I'd suspect its the discard handling, lp_setup.c:lp_setup_set_rasterizer_discard set_scene_state( setup, SETUP_FLUSHED,

Re: [Mesa-dev] llvmpipe perf regression

2012-12-06 Thread Dave Airlie
On Thu, Dec 6, 2012 at 9:57 PM, Dave Airlie wrote: >> I haven't investigated to see exactly what the issue is. >> >> Can you take a look? > > I'd suspect its the discard handling, > > lp_setup.c:lp_setup_set_rasterizer_discard > set_scene_state( setup, SETUP_FLUSHED, __FUNCTION__ ); > > try removi

[Mesa-dev] [PATCH 1/2] R600: Fix use iterator in custom select of ISD::Constant

2012-12-06 Thread Tom Stellard
From: Tom Stellard The use list may change during the execution of the loop, so we need to manually keep track of the next item in the list. --- lib/Target/AMDGPU/AMDILISelDAGToDAG.cpp | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/lib/Target/AMDGPU/AMDILISelDAGToDAG.cp

[Mesa-dev] [PATCH 2/2] R600: Convert global store address to dword offset during isel

2012-12-06 Thread Tom Stellard
From: Tom Stellard --- lib/Target/AMDGPU/AMDGPUISelLowering.cpp | 1 + lib/Target/AMDGPU/AMDGPUISelLowering.h | 1 + lib/Target/AMDGPU/AMDGPUInstrInfo.td | 3 +++ lib/Target/AMDGPU/AMDGPUInstructions.td | 5 lib/Target/AMDGPU/R600ISelLowering.cpp | 45 +++---

Re: [Mesa-dev] llvmpipe perf regression

2012-12-06 Thread Dave Airlie
> I haven't investigated to see exactly what the issue is. > > Can you take a look? I'd suspect its the discard handling, lp_setup.c:lp_setup_set_rasterizer_discard set_scene_state( setup, SETUP_FLUSHED, __FUNCTION__ ); try removing that line, seeing it speed comes back. I'll see if I can do so

Re: [Mesa-dev] Mesa (master): r600g: Use default mul/mad function for tgsi-to-llvm

2012-12-06 Thread Tom Stellard
On Thu, Dec 06, 2012 at 01:35:22PM -0500, Alex Deucher wrote: > On Thu, Dec 6, 2012 at 1:27 PM, Alex Deucher wrote: > > On Thu, Dec 6, 2012 at 1:21 PM, Vincent Lejeune wrote: > >> Sorry for the inconvenience. > >> I think the r600g backend work because of this patch, which switch MUL and > >> MU

[Mesa-dev] llvmpipe perf regression

2012-12-06 Thread Brian Paul
Hi Dave, llvmpipe is running gears at about half speed for me since your commit: 77b26564c3f0395bf3e744abbf6d0e7aa9d2c8da is the first bad commit commit 77b26564c3f0395bf3e744abbf6d0e7aa9d2c8da Author: Dave Airlie Date: Wed Dec 5 06:50:07 2012 +1000 llvmpipe: EXT_transform_feedback suppo

[Mesa-dev] [PATCH] gallivm: Lower TGSI_OPCODE_MUL to fmul by default

2012-12-06 Thread Tom Stellard
From: Tom Stellard This fixes a number of crashes on r600g due to the fact that lp_build_mul assumes vector types when optimizing mul to bit shifts. This bug was uncovered by 0ad1fefd6951aa47ab58a41dc9ee73083cbcf85c --- src/gallium/auxiliary/gallivm/lp_bld_tgsi_action.c |5 +++-- 1 files ch

Re: [Mesa-dev] Mesa (master): r600g: Use default mul/mad function for tgsi-to-llvm

2012-12-06 Thread Alex Deucher
On Thu, Dec 6, 2012 at 2:37 PM, Michel Dänzer wrote: > On Don, 2012-12-06 at 10:52 -0800, Tom Stellard wrote: >> On Thu, Dec 06, 2012 at 07:25:55PM +0100, Michel Dänzer wrote: >> > On Don, 2012-12-06 at 09:05 -0800, Tom Stellard wrote: >> > > On Thu, Dec 06, 2012 at 05:08:07PM +0100, Michel Dänzer

Re: [Mesa-dev] Mesa (master): r600g: Use default mul/mad function for tgsi-to-llvm

2012-12-06 Thread Michel Dänzer
On Don, 2012-12-06 at 10:52 -0800, Tom Stellard wrote: > On Thu, Dec 06, 2012 at 07:25:55PM +0100, Michel Dänzer wrote: > > On Don, 2012-12-06 at 09:05 -0800, Tom Stellard wrote: > > > On Thu, Dec 06, 2012 at 05:08:07PM +0100, Michel Dänzer wrote: > > > > On Mit, 2012-12-05 at 09:32 -0800, Vincen

Re: [Mesa-dev] [PATCH] build: Fix GLES linkage without libglapi

2012-12-06 Thread Andreas Boll
2012/12/6 Andreas Boll : > fixes a regression introduced with > fc9ea7c74dc5cb996c3d9fe6663fd6da080e8360 NOTE: This is a candidate for the 9.0 branch. > > Cc: Brian Paul > Cc: Matt Turner > --- > > Steps to reproduce the regression: > > $ ./autogen.sh --enable-xlib-glx --disable-driglx-direct -

Re: [Mesa-dev] [PATCH] build: Fix GLES linkage without libglapi

2012-12-06 Thread Matt Turner
On Thu, Dec 6, 2012 at 10:59 AM, Andreas Boll wrote: > fixes a regression introduced with > fc9ea7c74dc5cb996c3d9fe6663fd6da080e8360 > > Cc: Brian Paul > Cc: Matt Turner > --- > > Steps to reproduce the regression: > > $ ./autogen.sh --enable-xlib-glx --disable-driglx-direct --disable-dri > --e

Re: [Mesa-dev] [PATCH] linker: Allow aliased location assignments for shader inputs / outputs

2012-12-06 Thread Matt Turner
On Thu, Dec 6, 2012 at 11:00 AM, Matt Turner wrote: > On Thu, Dec 6, 2012 at 10:41 AM, Matt Turner wrote: >> On Thu, Dec 6, 2012 at 10:08 AM, Ian Romanick wrote: >>> Reviewed-and-Tested-by: Matt Turner >> >> Looks like this fixes >> explicit_attrib_location_vertex_input_aliased.test but breaks

Re: [Mesa-dev] [PATCH] linker: Allow aliased location assignments for shader inputs / outputs

2012-12-06 Thread Matt Turner
On Thu, Dec 6, 2012 at 10:41 AM, Matt Turner wrote: > On Thu, Dec 6, 2012 at 10:08 AM, Ian Romanick wrote: >> Reviewed-and-Tested-by: Matt Turner > > Looks like this fixes > explicit_attrib_location_vertex_input_aliased.test but breaks > explicit_attrib_location_overlapping_ranges.test. Crap. E

[Mesa-dev] [PATCH] build: Fix GLES linkage without libglapi

2012-12-06 Thread Andreas Boll
fixes a regression introduced with fc9ea7c74dc5cb996c3d9fe6663fd6da080e8360 Cc: Brian Paul Cc: Matt Turner --- Steps to reproduce the regression: $ ./autogen.sh --enable-xlib-glx --disable-driglx-direct --disable-dri --enable-debug --enable-gles1 --enable-gles2 --enable-openvg --enable-galli

Re: [Mesa-dev] [PATCH 16/26] glsl: Clean up shading language mixing check for GLSL 3.00 ES.

2012-12-06 Thread Ian Romanick
On 12/01/2012 04:52 AM, Kenneth Graunke wrote: On 11/30/2012 10:07 AM, Ian Romanick wrote: From: Paul Berry Previously, we prohibited mixing of shading language versions if min_version == 100 or max_version >= 130. This was technically correct (since desktop GLSL 1.30 and beyond prohibit mixi

Re: [Mesa-dev] Mesa (master): r600g: Use default mul/mad function for tgsi-to-llvm

2012-12-06 Thread Tom Stellard
On Thu, Dec 06, 2012 at 07:25:55PM +0100, Michel Dänzer wrote: > On Don, 2012-12-06 at 09:05 -0800, Tom Stellard wrote: > > On Thu, Dec 06, 2012 at 05:08:07PM +0100, Michel Dänzer wrote: > > > On Mit, 2012-12-05 at 09:32 -0800, Vincent Lejeune wrote: > > > > Module: Mesa > > > > Branch: master >

Re: [Mesa-dev] [PATCH] linker: Allow aliased location assignments for shader inputs / outputs

2012-12-06 Thread Matt Turner
On Thu, Dec 6, 2012 at 10:08 AM, Ian Romanick wrote: > Reviewed-and-Tested-by: Matt Turner Looks like this fixes explicit_attrib_location_vertex_input_aliased.test but breaks explicit_attrib_location_overlapping_ranges.test. Crap. ___ mesa-dev mailing

Re: [Mesa-dev] Mesa (master): r600g: Use default mul/mad function for tgsi-to-llvm

2012-12-06 Thread Alex Deucher
On Thu, Dec 6, 2012 at 1:27 PM, Alex Deucher wrote: > On Thu, Dec 6, 2012 at 1:21 PM, Vincent Lejeune wrote: >> Sorry for the inconvenience. >> I think the r600g backend work because of this patch, which switch MUL and >> MUL_IEEE definition : >> http://lists.freedesktop.org/archives/mesa-dev/20

Re: [Mesa-dev] [PATCH 1/3] mesa: add set support (stores a set of pointers)

2012-12-06 Thread Ian Romanick
On 12/05/2012 03:28 PM, Justen, Jordan L wrote: On Wed, 2012-12-05 at 11:26 -0800, Ian Romanick wrote: On 12/05/2012 07:32 AM, Brian Paul wrote: On 12/04/2012 04:55 PM, Jordan Justen wrote: +/** + * This function is an iterator over the hash table. + * + * Pass in NULL for the first entry, as

Re: [Mesa-dev] Mesa (master): r600g: Use default mul/mad function for tgsi-to-llvm

2012-12-06 Thread Alex Deucher
On Thu, Dec 6, 2012 at 1:21 PM, Vincent Lejeune wrote: > Sorry for the inconvenience. > I think the r600g backend work because of this patch, which switch MUL and > MUL_IEEE definition : > http://lists.freedesktop.org/archives/mesa-dev/2012-November/030748.html > > The rationale behind the patch

Re: [Mesa-dev] Mesa (master): r600g: Use default mul/mad function for tgsi-to-llvm

2012-12-06 Thread Michel Dänzer
On Don, 2012-12-06 at 09:05 -0800, Tom Stellard wrote: > On Thu, Dec 06, 2012 at 05:08:07PM +0100, Michel Dänzer wrote: > > On Mit, 2012-12-05 at 09:32 -0800, Vincent Lejeune wrote: > > > Module: Mesa > > > Branch: master > > > Commit: 0ad1fefd6951aa47ab58a41dc9ee73083cbcf85c > > > URL: > > >

Re: [Mesa-dev] Mesa (master): r600g: Use default mul/mad function for tgsi-to-llvm

2012-12-06 Thread Vincent Lejeune
Sorry for the inconvenience. I think the r600g backend work because of this patch, which switch MUL and MUL_IEEE definition : http://lists.freedesktop.org/archives/mesa-dev/2012-November/030748.html The rationale behind the patch is use the fmul instead of a custom intrinsic for OpenGL path. Gls

Re: [Mesa-dev] [PATCH 2/4] gallivm: Allow indirection from TEMP registers too.

2012-12-06 Thread Jose Fonseca
- Original Message - > On 12/06/2012 10:35 AM, jfons...@vmware.com wrote: > > From: José Fonseca > > > > The ADDR file is cumbersome for native integer capable drivers. We > > should consider deprecating it eventually, but this just adds > > support > > for indirection from TEMP register

[Mesa-dev] [PATCH] linker: Allow aliased location assignments for shader inputs / outputs

2012-12-06 Thread Ian Romanick
From: Ian Romanick The linker quotes two bits of OpenGL 4.0 spec text and claims that either two paragraphs are contradictory or misunderstood. It appears that the later was the case. Page 61 of the OpenGL 4.0 spec: "LinkProgram will fail if the attribute bindings assigned by BindAtt

Re: [Mesa-dev] [PATCH 4/4] gallivm: Rudimentary native integer support.

2012-12-06 Thread Brian Paul
On 12/06/2012 10:35 AM, jfons...@vmware.com wrote: From: José Fonseca Just enough for draw module to work ok. This improves "piglit attribs GL3", though something fishy is still happening with certain unsigned integer values. --- src/gallium/auxiliary/gallivm/lp_bld_format_aos.c |4 ++--

Re: [Mesa-dev] [PATCH 3/4] draw: Dump LLVM shader key.

2012-12-06 Thread Brian Paul
On 12/06/2012 10:35 AM, jfons...@vmware.com wrote: From: José Fonseca Just like we do in llvmpipe for the fragment shader compilation key. --- src/gallium/auxiliary/draw/draw_llvm.c | 31 ++- src/gallium/auxiliary/draw/draw_llvm.h |3 +++ 2 files changed, 33

Re: [Mesa-dev] [PATCH 2/4] gallivm: Allow indirection from TEMP registers too.

2012-12-06 Thread Brian Paul
On 12/06/2012 10:35 AM, jfons...@vmware.com wrote: From: José Fonseca The ADDR file is cumbersome for native integer capable drivers. We should consider deprecating it eventually, but this just adds support for indirection from TEMP registers. --- src/gallium/auxiliary/gallivm/lp_bld_tgsi_soa

Re: [Mesa-dev] [PATCH 1/4] gallivm, llvmpipe, draw: Support multiple constant buffers.

2012-12-06 Thread Brian Paul
On 12/06/2012 10:35 AM, jfons...@vmware.com wrote: From: José Fonseca Support 4 (defined in LP_MAX_TGSI_CONST_BUFFERS) as opposed to 32 (as defined by PIPE_MAX_CONSTANT_BUFFERS) because that would make the jit context become unnecessarily large. --- src/gallium/auxiliary/draw/draw_llvm.c

[Mesa-dev] [PATCH 4/4] gallivm: Rudimentary native integer support.

2012-12-06 Thread jfonseca
From: José Fonseca Just enough for draw module to work ok. This improves "piglit attribs GL3", though something fishy is still happening with certain unsigned integer values. --- src/gallium/auxiliary/gallivm/lp_bld_format_aos.c |4 ++-- .../auxiliary/gallivm/lp_bld_format_aos_array.c|

[Mesa-dev] [PATCH 3/4] draw: Dump LLVM shader key.

2012-12-06 Thread jfonseca
From: José Fonseca Just like we do in llvmpipe for the fragment shader compilation key. --- src/gallium/auxiliary/draw/draw_llvm.c | 31 ++- src/gallium/auxiliary/draw/draw_llvm.h |3 +++ 2 files changed, 33 insertions(+), 1 deletion(-) diff --git a/src/gallium

[Mesa-dev] [PATCH 2/4] gallivm: Allow indirection from TEMP registers too.

2012-12-06 Thread jfonseca
From: José Fonseca The ADDR file is cumbersome for native integer capable drivers. We should consider deprecating it eventually, but this just adds support for indirection from TEMP registers. --- src/gallium/auxiliary/gallivm/lp_bld_tgsi_soa.c | 20 +--- 1 file changed, 17 in

[Mesa-dev] [PATCH 1/4] gallivm, llvmpipe, draw: Support multiple constant buffers.

2012-12-06 Thread jfonseca
From: José Fonseca Support 4 (defined in LP_MAX_TGSI_CONST_BUFFERS) as opposed to 32 (as defined by PIPE_MAX_CONSTANT_BUFFERS) because that would make the jit context become unnecessarily large. --- src/gallium/auxiliary/draw/draw_llvm.c |5 +- src/gallium/auxiliary/draw/draw_llv

Re: [Mesa-dev] [PATCH] AMDGPU/SI: Only allow selecting VGPRs with V_CNDMASK_B32.

2012-12-06 Thread Tom Stellard
On Thu, Dec 06, 2012 at 11:55:15AM +0100, Michel Dänzer wrote: > From: Michel Dänzer > > VALU instructions can only read from one SGPR, and that's the condition code > mask in this case. > > Fixes a number of radeonsi piglit regressions from Vincent's max/min changes > (which means the matching

Re: [Mesa-dev] Mesa (master): r600g: Use default mul/mad function for tgsi-to-llvm

2012-12-06 Thread Tom Stellard
On Thu, Dec 06, 2012 at 05:08:07PM +0100, Michel Dänzer wrote: > On Mit, 2012-12-05 at 09:32 -0800, Vincent Lejeune wrote: > > Module: Mesa > > Branch: master > > Commit: 0ad1fefd6951aa47ab58a41dc9ee73083cbcf85c > > URL: > > http://cgit.freedesktop.org/mesa/mesa/commit/?id=0ad1fefd6951aa47ab58

[Mesa-dev] [Bug 57802] including GL/gl.h and another gl header causes redefinition warnings

2012-12-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=57802 Brian Paul changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] Mesa (master): r600g: Use default mul/mad function for tgsi-to-llvm

2012-12-06 Thread Michel Dänzer
On Mit, 2012-12-05 at 09:32 -0800, Vincent Lejeune wrote: > Module: Mesa > Branch: master > Commit: 0ad1fefd6951aa47ab58a41dc9ee73083cbcf85c > URL: > http://cgit.freedesktop.org/mesa/mesa/commit/?id=0ad1fefd6951aa47ab58a41dc9ee73083cbcf85c > > Author: Vincent Lejeune > Date: Wed Nov 28 00:

Re: [Mesa-dev] [PATCH 4/4] r300g: Remove an incorrect comment

2012-12-06 Thread Michel Dänzer
On Mit, 2012-12-05 at 23:08 +0100, Stefan Dösinger wrote: > This occurred because I started this patch by reverting another patch and > forgot to remove it. > --- > src/gallium/drivers/r300/r300_screen.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/src/gallium/d

Re: [Mesa-dev] [PATCH 6/6] mesa/st: add ARB_uniform_buffer_object support

2012-12-06 Thread Brian Paul
On 12/05/2012 11:24 PM, Dave Airlie wrote: From: Dave Airlie this adds UBO support to the state tracker, it works with softpipe as-is. It uses UARL + CONST[x][ADDR[0].x] type constructs. Signed-off-by: Dave Airlie --- src/mesa/state_tracker/st_atom.c | 2 + src/mesa/state_track

Re: [Mesa-dev] [PATCH 2/6] st/mesa: add texture buffer object support to state tracker

2012-12-06 Thread Brian Paul
On 12/05/2012 11:24 PM, Dave Airlie wrote: From: Dave Airlie This adds the necessary changes to the st to allow texture buffer object support if the driver advertises it. Signed-off-by: Dave Airlie --- src/mesa/state_tracker/st_atom_texture.c | 18 -- src/mesa/state_tracker

Re: [Mesa-dev] [PATCH 1/4] gallium/os: Fix os_time_sleep() on Windows for small durations.

2012-12-06 Thread Brian Paul
On 12/06/2012 06:17 AM, jfons...@vmware.com wrote: From: José Fonseca Prevents undetermined sleeps. --- src/gallium/auxiliary/os/os_time.c |6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/os/os_time.c b/src/gallium/auxiliary/os/os_time.c index

Re: [Mesa-dev] [PATCH 2/2] gallivm: Fix lerping of (un)signed normalized numbers.

2012-12-06 Thread Brian Paul
On 12/06/2012 06:20 AM, jfons...@vmware.com wrote: From: José Fonseca Several issues acutally: "actually" - Fix a regression in unsigned normalized in the rescaling [0, 255] to [0, 256] - Ensure we use signed shifts where appropriate (instead of unsigned shifts) - Refactor the code

Re: [Mesa-dev] [PATCH 1/2] gallivm: Fix lp_build_print_value of small integers

2012-12-06 Thread Brian Paul
OK, by "small integers" you mean 8 and 16-bit ints. At first I thought you meant 1, 2, 3, etc. On 12/06/2012 06:20 AM, jfons...@vmware.com wrote: From: José Fonseca They need to be converted to native integers to prevent garbagge in "garbage" higher order bits from being printed. ---

Re: [Mesa-dev] [PATCH] AMDGPU: Match fdiv for SI.

2012-12-06 Thread Tom Stellard
On Thu, Dec 06, 2012 at 11:02:35AM +0100, Michel Dänzer wrote: > From: Michel Dänzer > > Fixes hundreds of radeonsi piglit regressions from commit > 62c8e1ec4a93b28c55c1c7accb6cbd64952e59c2 ('AMDGPU: replace int_AMDGPU_rcp by > fdiv (1.0, x) in RECIP pattern'). > Sorry, I missed this. Reviewed-

Re: [Mesa-dev] [PATCH 6/6] mesa/st: add ARB_uniform_buffer_object support

2012-12-06 Thread Jose Fonseca
Series looks good AFAICT. Jose - Original Message - > From: Dave Airlie > > this adds UBO support to the state tracker, it works with softpipe > as-is. > > It uses UARL + CONST[x][ADDR[0].x] type constructs. > > Signed-off-by: Dave Airlie > --- > src/mesa/state_tracker/st_atom.c

Re: [Mesa-dev] [PATCH] draw: remove some dead constant buffer code

2012-12-06 Thread Jose Fonseca
LGTM! - Original Message - > Remove the draw_vs_set_constants() and draw_gs_set_constants() > functions and the draw->vs.aligned_constants, > draw->vs.aligned_constant_storage and draw->vs.const_storage_size > fields. None of it was used. > --- > src/gallium/auxiliary/draw/draw_context.c

[Mesa-dev] [PATCH 2/2] gallivm: Fix lerping of (un)signed normalized numbers.

2012-12-06 Thread jfonseca
From: José Fonseca Several issues acutally: - Fix a regression in unsigned normalized in the rescaling [0, 255] to [0, 256] - Ensure we use signed shifts where appropriate (instead of unsigned shifts) - Refactor the code slightly -- move all the logic inside lp_build_lerp_simple(). This

[Mesa-dev] [PATCH 1/2] gallivm: Fix lp_build_print_value of small integers

2012-12-06 Thread jfonseca
From: José Fonseca They need to be converted to native integers to prevent garbagge in higher order bits from being printed. --- src/gallium/auxiliary/gallivm/lp_bld_printf.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/gallivm/lp_bld_

[Mesa-dev] [PATCH 4/4] util: Add util_copy_box helper.

2012-12-06 Thread jfonseca
From: José Fonseca Must users of util_copy_rect() need or should deal with volumes. --- src/gallium/auxiliary/util/u_surface.c | 55 +++ src/gallium/auxiliary/util/u_surface.h | 10 ++ src/gallium/auxiliary/util/u_transfer.c | 28 3 files

[Mesa-dev] [PATCH 3/4] gallium/util: Move the util_copy/fill_rect into u_surface.

2012-12-06 Thread jfonseca
From: José Fonseca u_rect.h said these should move to a different file, and u_surface seems a better home. Leave #include "util/u_surface.h" to avoid having to touch thousand of files. --- src/gallium/auxiliary/Makefile.sources |1 - src/gallium/auxiliary/util/u_rect.c| 158 ---

[Mesa-dev] [PATCH 2/4] gallium/os: Cleanup up os_time_get/os_time_get_nano.

2012-12-06 Thread jfonseca
From: José Fonseca - Re-implement os_time_get in terms of os_time_get_nano() for consistency - Use CLOCK_MONOTONIC as recommended - Only use clock_gettime on Linux for now. --- scons/gallium.py |2 +- src/gallium/auxiliary/os/os_time.c | 28 s

[Mesa-dev] [PATCH 1/4] gallium/os: Fix os_time_sleep() on Windows for small durations.

2012-12-06 Thread jfonseca
From: José Fonseca Prevents undetermined sleeps. --- src/gallium/auxiliary/os/os_time.c |6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/os/os_time.c b/src/gallium/auxiliary/os/os_time.c index 4055125..f943e0f 100644 --- a/src/gallium/auxiliary/o

[Mesa-dev] [PATCH] AMDGPU/SI: Only allow selecting VGPRs with V_CNDMASK_B32.

2012-12-06 Thread Michel Dänzer
From: Michel Dänzer VALU instructions can only read from one SGPR, and that's the condition code mask in this case. Fixes a number of radeonsi piglit regressions from Vincent's max/min changes (which means the matching to AMDGPUfmax/min doesn't work for some reason). Signed-off-by: Michel Dänze

[Mesa-dev] [PATCH] AMDGPU: Match fdiv for SI.

2012-12-06 Thread Michel Dänzer
From: Michel Dänzer Fixes hundreds of radeonsi piglit regressions from commit 62c8e1ec4a93b28c55c1c7accb6cbd64952e59c2 ('AMDGPU: replace int_AMDGPU_rcp by fdiv (1.0, x) in RECIP pattern'). Signed-off-by: Michel Dänzer --- lib/Target/AMDGPU/SIInstructions.td |5 + 1 file changed, 5 inse

[Mesa-dev] [PATCH 6/6] mesa/st: add ARB_uniform_buffer_object support

2012-12-06 Thread Dave Airlie
From: Dave Airlie this adds UBO support to the state tracker, it works with softpipe as-is. It uses UARL + CONST[x][ADDR[0].x] type constructs. Signed-off-by: Dave Airlie --- src/mesa/state_tracker/st_atom.c | 2 + src/mesa/state_tracker/st_atom.h | 2 + src/mesa/sta

[Mesa-dev] [PATCH 5/6] softpipe: enable GLSL 1.40

2012-12-06 Thread Dave Airlie
From: Dave Airlie This enables GLSL 1.40 advertising by softpipe. Signed-off-by: Dave Airlie --- src/gallium/drivers/softpipe/sp_screen.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/softpipe/sp_screen.c b/src/gallium/drivers/softpipe/sp_screen.c ind

[Mesa-dev] [PATCH 3/6] st/mesa: add option to enable GLSL 1.40

2012-12-06 Thread Dave Airlie
From: Dave Airlie Allow GLSL 1.40 to be enabled if the driver advertises it. Signed-off-by: Dave Airlie --- src/mesa/state_tracker/st_extensions.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/mesa/state_tracker/st_extensions.c b/src/mesa/state_tracker/st_extensio

[Mesa-dev] [PATCH 2/6] st/mesa: add texture buffer object support to state tracker

2012-12-06 Thread Dave Airlie
From: Dave Airlie This adds the necessary changes to the st to allow texture buffer object support if the driver advertises it. Signed-off-by: Dave Airlie --- src/mesa/state_tracker/st_atom_texture.c | 18 -- src/mesa/state_tracker/st_cb_texture.c | 16 s

[Mesa-dev] [PATCH 4/6] softpipe: add texture buffer object support

2012-12-06 Thread Dave Airlie
From: Dave Airlie This adds TBO support to softpipe. Signed-off-by: Dave Airlie --- src/gallium/drivers/softpipe/sp_screen.c | 2 ++ src/gallium/drivers/softpipe/sp_tex_sample.c | 8 +++- 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/softpipe/sp_scre

[Mesa-dev] [PATCH 1/6] gallium: add new texture buffer object capability

2012-12-06 Thread Dave Airlie
From: Dave Airlie this just adds the define to the header. Signed-off-by: Dave Airlie --- src/gallium/include/pipe/p_defines.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/include/pipe/p_defines.h b/src/gallium/include/pipe/p_defines.h index fa2fb07..a751b

[Mesa-dev] [rfc] gallium ubo/tbo support (softpipe only)

2012-12-06 Thread Dave Airlie
Hi, So I got UBOs working with softpipe today (well one demo and most piglit tests pass), so I've cleaned up the tbo/ubo enablement code for gallium. This only includes the softpipe TBO and gallium TBO/UBO work, (softpipe didn't need changes for UBOs). I've got an initial hack at r600 TBO, but I

[Mesa-dev] [Bug 47607] [advocacy] Make Anomaly Warzone Earth work with Mesa

2012-12-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=47607 --- Comment #5 from imamdxl8...@gmail.com --- does not work with Intel HD either even with glsl extension behavior warn Tested On: Ubuntu 12.10 Linux 3.5 (both 32 and 64 bit) X.Org X Server 1.13.0 xf86-video-intel 2.20.15 libdrm 2.4.40 Mesa 8, 9

[Mesa-dev] [Bug 57802] including GL/gl.h and another gl header causes redefinition warnings

2012-12-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=57802 --- Comment #3 from Matthew Waters --- (In reply to comment #2) > Just curious: why are you including both OpenGL's gl.h and other Khronos > (ES?) headers in the same file? I am experimenting with having both opengl and ES support in an applicat

Re: [Mesa-dev] [PATCH 1/3] mesa: Disallow deprecated SNORM formats for renderbuffers

2012-12-06 Thread Marek Olšák
On Wed, Dec 5, 2012 at 8:39 PM, Eric Anholt wrote: > Marek Olšák writes: > >> On Tue, Dec 4, 2012 at 7:56 PM, Eric Anholt wrote: >>> Ian Romanick writes: >>> From: Ian Romanick The OpenGL 3.2 core profile spec says: "The following base internal formats from table 3

[Mesa-dev] [PATCH 6/8] glcpp: Add --disable-line-continuations argument to standalone glcpp

2012-12-06 Thread Carl Worth
This will allow testing of disabled line-continuation on a case-by-case basis, (with the option communicated to the preprocessor via the GL context). --- src/glsl/glcpp/glcpp.c | 43 +-- 1 file changed, 41 insertions(+), 2 deletions(-) diff --git a/src/gl

[Mesa-dev] [PATCH 8/8] glcpp: Add tests for line continuation

2012-12-06 Thread Carl Worth
First we test that line continuations are honored within a comment, (as recently changed in glcpp), then we test that line continuations can be disabled via an option within the context. This is tested via the new support for a test-specific command-line option passed to glcpp. --- src/glsl/glcpp/

[Mesa-dev] [PATCH 7/8] glcpp: Rewrite line-continuation support to act globally.

2012-12-06 Thread Carl Worth
Previously, we were only supporting line-continuation backslash characters within lines of pre-processor directives, (as per the specification). With OpenGL 4.2 and GLES3, line continuations are now supported anywhere within a shader. While changing this, also fix a bug where the preprocessor was

  1   2   >