Re: [Mesa-dev] [PATCH 2/2] i965/msaa: Allow GL_SAMPLES to be set to 1 prior to Gen6.

2012-07-27 Thread Jordan Justen
For series: Reviewed-by: Jordan Justen On Fri, Jul 27, 2012 at 10:35 AM, Paul Berry wrote: > This patch allows GL_SAMPLES to be set to either 0 or 1 on i965 > platforms that don't support MSAA (those prior to Gen6). Setting > GL_SAMPLES=1 has the same effect as setting it to 0 on these platform

[Mesa-dev] [Bug 52608] Account request

2012-07-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=52608 Brian Paul changed: What|Removed |Added AssignedTo|mesa-dev@lists.freedesktop. |sitewranglers@lists.freedes

[Mesa-dev] [Bug 47375] Blender crash on startup after upgrade to mesa 8.0.1

2012-07-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=47375 Brian Paul changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

[Mesa-dev] [Bug 47375] Blender crash on startup after upgrade to mesa 8.0.1

2012-07-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=47375 --- Comment #47 from Brian Paul 2012-07-27 21:59:45 UTC --- OK, I'm closing this bug. These 3 commits fix the assertion and performance issue: 906febaf8bd37fffa4fc14c56eda1dd6e4b4dcda 38184dcd54e77c8f9adc89d337a97afd630b2c07 0e893b42610a2e8f27

[Mesa-dev] [Bug 52608] Account request

2012-07-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=52608 --- Comment #1 from Olivier Galibert 2012-07-27 21:54:37 PDT --- Created attachment 64810 --> https://bugs.freedesktop.org/attachment.cgi?id=64810 Public ssh key -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email

Re: [Mesa-dev] [PATCH v4 2/7] mesa: add api check functions

2012-07-27 Thread Brian Paul
On 07/27/2012 03:45 PM, Jordan Justen wrote: These functions make it easier to check for multiple API types. Signed-off-by: Jordan Justen --- src/mesa/main/mtypes.h | 19 +++ 1 file changed, 19 insertions(+) diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h index

[Mesa-dev] [Bug 52608] New: Account request

2012-07-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=52608 Bug #: 52608 Summary: Account request Classification: Unclassified Product: Mesa Version: unspecified Platform: Other OS/Version: All Status: NEW Severity: n

Re: [Mesa-dev] some radeon/r200 cleanup/fixes

2012-07-27 Thread Brian Paul
On 07/27/2012 03:12 PM, Barto wrote: I can try, I have a radeon 9000 ( rv250 ), but I don't find the Roland's patch in my mails, can you post again his patch ? See the mail list archive at http://lists.freedesktop.org/mailman/listinfo/mesa-dev Roland's patches start here: http://lists.freed

[Mesa-dev] [PATCH v4 7/7] mesa: don't enable legacy GL functions when using API_OPENGL_CORE

2012-07-27 Thread Jordan Justen
Signed-off-by: Jordan Justen --- src/mesa/main/api_exec.c | 227 -- src/mesa/main/api_exec.h |3 +- src/mesa/main/context.c |2 +- src/mesa/main/vtxfmt.c | 167 ++ 4 files changed, 232 insertions(+), 167 dele

[Mesa-dev] [PATCH v4 6/7] intel: add support for using API_OPENGL_CORE

2012-07-27 Thread Jordan Justen
Signed-off-by: Jordan Justen --- src/mesa/drivers/dri/intel/intel_extensions.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/intel/intel_extensions.c b/src/mesa/drivers/dri/intel/intel_extensions.c index c2bc072..b752216 100755 --- a/src/mesa/drivers

[Mesa-dev] [PATCH v4 5/7] meta: add support for using API_OPENGL_CORE

2012-07-27 Thread Jordan Justen
Signed-off-by: Jordan Justen --- src/mesa/drivers/common/meta.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/common/meta.c b/src/mesa/drivers/common/meta.c index fa15423..e73880d 100644 --- a/src/mesa/drivers/common/meta.c +++ b/src/mesa/drivers/common/m

[Mesa-dev] [PATCH v4 3/7] mesa: add support for using API_OPENGL_CORE

2012-07-27 Thread Jordan Justen
Signed-off-by: Jordan Justen --- src/mesa/main/api_validate.c |1 + src/mesa/main/context.c |6 -- src/mesa/main/extensions.c |4 +++- src/mesa/main/fbobject.c | 14 +++--- src/mesa/main/get.c | 11 +++ src/mesa/main/getstring.c|1 +

[Mesa-dev] [PATCH v4 4/7] glsl: add support for using API_OPENGL_CORE

2012-07-27 Thread Jordan Justen
Signed-off-by: Jordan Justen --- src/glsl/glsl_parser_extras.cpp | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/src/glsl/glsl_parser_extras.cpp b/src/glsl/glsl_parser_extras.cpp index df40459..7e85f41 100644 --- a/src/glsl/glsl_parser_extras.cpp +++ b/src/gls

[Mesa-dev] [PATCH v4 1/7] mesa: add API_OPENGL_CORE api

2012-07-27 Thread Jordan Justen
Signed-off-by: Jordan Justen --- src/mesa/main/mtypes.h |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h index 3d59dc6..7d7213f 100644 --- a/src/mesa/main/mtypes.h +++ b/src/mesa/main/mtypes.h @@ -3334,9 +3334,10 @@ struct

[Mesa-dev] [PATCH v4 2/7] mesa: add api check functions

2012-07-27 Thread Jordan Justen
These functions make it easier to check for multiple API types. Signed-off-by: Jordan Justen --- src/mesa/main/mtypes.h | 19 +++ 1 file changed, 19 insertions(+) diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h index 7d7213f..0730ff3 100644 --- a/src/mesa/main/mty

[Mesa-dev] [PATCH v4 0/7] Support Desktop GL Core contexts

2012-07-27 Thread Jordan Justen
These patches introduce a MESA API type of API_OPENGL_CORE, which will not support legacy/non-CORE features. The intended usage will be with contexts for Desktop GL >= 3.1. The series will currently cause legacy/non-CORE functions to generate a GL_INVALID_OPERATION error if an API_OPENGL_CORE cont

Re: [Mesa-dev] [PATCH v3 6/6] intel: add support for using API_OPENGL_CORE

2012-07-27 Thread Jordan Justen
Hmm. It seems I mistakenly combined patches 6 & 7 in the series. I'll send out a fixed v4. Sorry for the extra mail. -Jordan On Fri, Jul 27, 2012 at 2:07 PM, Jordan Justen wrote: > Signed-off-by: Jordan Justen > --- > src/mesa/drivers/dri/intel/intel_extensions.c |2 +- > src/mesa/main/ap

Re: [Mesa-dev] some radeon/r200 cleanup/fixes

2012-07-27 Thread Barto
I can try, I have a radeon 9000 ( rv250 ), but I don't find the Roland's patch in my mails, can you post again his patch ? Le 27/07/2012 22:41, Alex Deucher a écrit : > On Thu, Jul 26, 2012 at 10:14 PM, Roland Scheidegger > wrote: >> This patches are just some cleanups and fixes however only co

[Mesa-dev] [PATCH v3 6/6] intel: add support for using API_OPENGL_CORE

2012-07-27 Thread Jordan Justen
Signed-off-by: Jordan Justen --- src/mesa/drivers/dri/intel/intel_extensions.c |2 +- src/mesa/main/api_exec.c | 227 +++-- src/mesa/main/api_exec.h |3 +- src/mesa/main/context.c |2 +- src/mesa/main

[Mesa-dev] [PATCH v3 5/6] meta: add support for using API_OPENGL_CORE

2012-07-27 Thread Jordan Justen
Signed-off-by: Jordan Justen --- src/mesa/drivers/common/meta.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/common/meta.c b/src/mesa/drivers/common/meta.c index fa15423..e73880d 100644 --- a/src/mesa/drivers/common/meta.c +++ b/src/mesa/drivers/common/m

[Mesa-dev] [PATCH v3 4/6] glsl: add support for using API_OPENGL_CORE

2012-07-27 Thread Jordan Justen
Signed-off-by: Jordan Justen --- src/glsl/glsl_parser_extras.cpp | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/src/glsl/glsl_parser_extras.cpp b/src/glsl/glsl_parser_extras.cpp index df40459..7e85f41 100644 --- a/src/glsl/glsl_parser_extras.cpp +++ b/src/gls

[Mesa-dev] [PATCH v3 3/6] mesa: add support for using API_OPENGL_CORE

2012-07-27 Thread Jordan Justen
Signed-off-by: Jordan Justen --- src/mesa/main/api_validate.c |1 + src/mesa/main/context.c |6 -- src/mesa/main/extensions.c |4 +++- src/mesa/main/fbobject.c | 14 +++--- src/mesa/main/get.c | 11 +++ src/mesa/main/getstring.c|1 +

[Mesa-dev] [PATCH v3 2/6] mesa: add api check functions

2012-07-27 Thread Jordan Justen
These functions make it easier to check for multiple API types. Signed-off-by: Jordan Justen --- src/mesa/main/mtypes.h | 19 +++ 1 file changed, 19 insertions(+) diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h index 7d7213f..0730ff3 100644 --- a/src/mesa/main/mty

[Mesa-dev] [PATCH v3 1/6] mesa: add API_OPENGL_CORE api

2012-07-27 Thread Jordan Justen
Signed-off-by: Jordan Justen --- src/mesa/main/mtypes.h |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h index 3d59dc6..7d7213f 100644 --- a/src/mesa/main/mtypes.h +++ b/src/mesa/main/mtypes.h @@ -3334,9 +3334,10 @@ struct

[Mesa-dev] [PATCH v3 0/6] Support Desktop GL Core contexts

2012-07-27 Thread Jordan Justen
These patches introduce a MESA API type of API_OPENGL_CORE, which will not support legacy/non-CORE features. The intended usage will be with contexts for Desktop GL >= 3.1. The series will currently cause legacy/non-CORE functions to generate a GL_INVALID_OPERATION error if an API_OPENGL_CORE cont

Re: [Mesa-dev] [PATCH v2 3/7] mesa: add support for using API_OPENGL_CORE

2012-07-27 Thread Brian Paul
On 07/27/2012 01:59 PM, Jordan Justen wrote: On Fri, Jul 27, 2012 at 8:06 AM, Brian Paul wrote: On 07/27/2012 12:43 AM, Jordan Justen wrote: diff --git a/src/mesa/main/extensions.c b/src/mesa/main/extensions.c index 0675ce7..fbc1bb7 100644 --- a/src/mesa/main/extensions.c +++ b/src/mesa/main/e

Re: [Mesa-dev] some radeon/r200 cleanup/fixes

2012-07-27 Thread Alex Deucher
On Thu, Jul 26, 2012 at 10:14 PM, Roland Scheidegger wrote: > This patches are just some cleanups and fixes however only compile tested > (my r100 got broken and the r200 isn't in a useful box right now) so testers > would be great. They look good to me as well, but I'm not sure when I'll have a

[Mesa-dev] [Bug 47375] Blender crash on startup after upgrade to mesa 8.0.1

2012-07-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=47375 --- Comment #46 from Barto 2012-07-27 20:24:42 PDT --- (In reply to comment #45) > (In reply to comment #44) > Anyway, I think we can close out this particular bug if the above-mentioned > patches look OK to everyone. for me it's Ok with your

Re: [Mesa-dev] [PATCH v2 3/7] mesa: add support for using API_OPENGL_CORE

2012-07-27 Thread Jordan Justen
On Fri, Jul 27, 2012 at 8:06 AM, Brian Paul wrote: > On 07/27/2012 12:43 AM, Jordan Justen wrote: >> diff --git a/src/mesa/main/extensions.c b/src/mesa/main/extensions.c >> index 0675ce7..fbc1bb7 100644 >> --- a/src/mesa/main/extensions.c >> +++ b/src/mesa/main/extensions.c >> @@ -41,7 +41,9 @@ >>

Re: [Mesa-dev] [PATCH 7/7] ir_to_mesa: Don't set component for ir_dereference in ir_quadop_vector

2012-07-27 Thread Olivier Galibert
On Fri, Jul 27, 2012 at 10:49:25AM -0700, Kenneth Graunke wrote: > From: Ian Romanick > > There can only be one variable used in an ir_quadop_vector. Accesses > of this variable must be swizzled. There's nothing anywhere ensuring the presence of the swizzle. I completely agree that trashing th

Re: [Mesa-dev] [PATCH 1/4] mesa: Add a Version field to the context with VersionMajor*10+VersionMinor.

2012-07-27 Thread Kenneth Graunke
On 07/27/2012 06:47 AM, Brian Paul wrote: > How about a simple inline helper function like this: > > /** > * Check if the OpenGL version is greater than or equal to "major.minor" > */ > static inline GLboolean > _mesa_have_version(const struct gl_context *ctx, int major, int minor) > { > ret

Re: [Mesa-dev] [PATCH 1/4] mesa: Add a Version field to the context with VersionMajor*10+VersionMinor.

2012-07-27 Thread Jordan Justen
On Fri, Jul 27, 2012 at 6:47 AM, Brian Paul wrote: > On 07/27/2012 01:51 AM, Kenneth Graunke wrote: >> >> On 07/27/2012 12:19 AM, Jordan Justen wrote: >>> >>> On Thu, Jul 26, 2012 at 11:52 PM, Kenneth Graunke >>> wrote: On 07/26/2012 05:54 PM, Jordan Justen wrote: > > On Thu, Jul

Re: [Mesa-dev] [PATCH 4/7] glsl: Request an Nx1 type instance in ir_quadop_vector lowering pass.

2012-07-27 Thread Kenneth Graunke
On 07/27/2012 11:20 AM, Olivier Galibert wrote: > On Fri, Jul 27, 2012 at 10:49:22AM -0700, Kenneth Graunke wrote: >> From: Ian Romanick >> >> No types have 0 columns. The glsl_type::get_instance method contains >> >>if ((rows < 1) || (rows > 4) || (columns < 1) || (columns > 4)) >> ret

[Mesa-dev] [Bug 52595] New: WebGL conformance tests failures on cubemap tests (Sandybridge Mobible)

2012-07-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=52595 Bug #: 52595 Summary: WebGL conformance tests failures on cubemap tests (Sandybridge Mobible) Classification: Unclassified Product: Mesa Version: 8.0 Platform: x86-64

Re: [Mesa-dev] [PATCH 6/7] glsl: Fix ir_last_opcode value.

2012-07-27 Thread Olivier Galibert
On Fri, Jul 27, 2012 at 10:49:24AM -0700, Kenneth Graunke wrote: > From: Ian Romanick > > Now that ir_quadop_vector exists, ir_last_binop and ir_last_opcode are > no longer the same. Only one place currently uses this enumeration, and > already handles ir_quadop_vector correctly. > > Signed-off

Re: [Mesa-dev] [PATCH 5/7] glsl: Add "typeless" constructor for quadop ir_expressions

2012-07-27 Thread Olivier Galibert
On Fri, Jul 27, 2012 at 10:49:23AM -0700, Kenneth Graunke wrote: > From: Ian Romanick > > This matches the typeless constructors for unop and binop > ir_expressions. > > Signed-off-by: Ian Romanick > Reviewed-by: Kenneth Graunke > --- > src/glsl/ir.cpp | 17 + > src/glsl/ir.h

Re: [Mesa-dev] [PATCH 4/7] glsl: Request an Nx1 type instance in ir_quadop_vector lowering pass.

2012-07-27 Thread Olivier Galibert
On Fri, Jul 27, 2012 at 10:49:22AM -0700, Kenneth Graunke wrote: > From: Ian Romanick > > No types have 0 columns. The glsl_type::get_instance method contains > >if ((rows < 1) || (rows > 4) || (columns < 1) || (columns > 4)) > return error_type; > > To get a vector, use columns = 1.

Re: [Mesa-dev] [PATCH 2/7] glsl: Add glsl_type::get_sampler_instance method.

2012-07-27 Thread Olivier Galibert
On Fri, Jul 27, 2012 at 10:49:20AM -0700, Kenneth Graunke wrote: > +/** > + * Convert sampler type attributes into an index in the sampler_types array > + */ > +#define SAMPLER_TYPE_INDEX(dim, sample_type, array, shadow) \ > + ((unsigned(dim) * 12) + (sample_type * 4) + (unsigned(array)

Re: [Mesa-dev] [PATCH 1/7] glsl: Make bvec and ivec types accessible without using get_instance.

2012-07-27 Thread Olivier Galibert
On Fri, Jul 27, 2012 at 10:49:19AM -0700, Kenneth Graunke wrote: > It's more convenient to use shortcuts like glsl_type::bvec2_type than > the longwinded glsl_type::get_instance(GLSL_TYPE_BOOL, 2, 1). Yay, code in zones I understand :-) Reviewed-by: Olivier Galibert _

Re: [Mesa-dev] Support for EXT/ARB_geometry_shader4

2012-07-27 Thread Brian Paul
On 07/27/2012 09:40 AM, Bryan Cain wrote: Some of you already know about this from IRC, but recently I've been working on adding support for GL_EXT_geometry_shader4 and GL_ARB_geometry_shader4 (which are essentially identical) to Mesa. A significant amount of the required code was already there

[Mesa-dev] [PATCH 7/7] ir_to_mesa: Don't set component for ir_dereference in ir_quadop_vector

2012-07-27 Thread Kenneth Graunke
From: Ian Romanick There can only be one variable used in an ir_quadop_vector. Accesses of this variable must be swizzled. The component should have already been set by the ir_type_swizzle handler. Setting the component to SWIZZLE_X here would overwrite whatever the ir_type_swizzle handler had

[Mesa-dev] [PATCH 6/7] glsl: Fix ir_last_opcode value.

2012-07-27 Thread Kenneth Graunke
From: Ian Romanick Now that ir_quadop_vector exists, ir_last_binop and ir_last_opcode are no longer the same. Only one place currently uses this enumeration, and already handles ir_quadop_vector correctly. Signed-off-by: Ian Romanick Signed-off-by: Kenneth Graunke --- src/glsl/ir.h | 2 +- 1

[Mesa-dev] [PATCH 5/7] glsl: Add "typeless" constructor for quadop ir_expressions

2012-07-27 Thread Kenneth Graunke
From: Ian Romanick This matches the typeless constructors for unop and binop ir_expressions. Signed-off-by: Ian Romanick Reviewed-by: Kenneth Graunke --- src/glsl/ir.cpp | 17 + src/glsl/ir.h | 2 ++ 2 files changed, 19 insertions(+) diff --git a/src/glsl/ir.cpp b/src/glsl

[Mesa-dev] [PATCH 4/7] glsl: Request an Nx1 type instance in ir_quadop_vector lowering pass.

2012-07-27 Thread Kenneth Graunke
From: Ian Romanick No types have 0 columns. The glsl_type::get_instance method contains if ((rows < 1) || (rows > 4) || (columns < 1) || (columns > 4)) return error_type; To get a vector, use columns = 1. Signed-off-by: Ian Romanick --- src/glsl/lower_vector.cpp | 2 +- 1 file chan

[Mesa-dev] [PATCH 3/7] glsl/tests: Add unit test for glsl_type::get_sampler_instance

2012-07-27 Thread Kenneth Graunke
From: Ian Romanick The table logic in the previous commit is somewhat fragile. Adding a unit test will ensure that it remains in sync. v2/Kayden: Use NULL instead of (void *) 0 in pointer checks. Signed-off-by: Ian Romanick Signed-off-by: Kenneth Graunke --- src/glsl/tests/Makefile.am

[Mesa-dev] [PATCH 2/7] glsl: Add glsl_type::get_sampler_instance method.

2012-07-27 Thread Kenneth Graunke
From: Ian Romanick v2/Kayden: Use enum glsl_base_type instead of unsigned for the glsl_type::get_sampler_instance base type parameter. Signed-off-by: Ian Romanick Signed-off-by: Kenneth Graunke --- src/glsl/glsl_types.cpp | 124 src/glsl/glsl_t

[Mesa-dev] Misc compiler patches from Ian

2012-07-27 Thread Kenneth Graunke
I've been going through Ian's asm-to-ir branch, pulling out some of the more standalone patches we could land prior to finishing up the rest, just to make his branch a bit more manageable. So here you are - 7 misc compiler patches. ___ mesa-dev mailing

[Mesa-dev] [PATCH 1/7] glsl: Make bvec and ivec types accessible without using get_instance.

2012-07-27 Thread Kenneth Graunke
It's more convenient to use shortcuts like glsl_type::bvec2_type than the longwinded glsl_type::get_instance(GLSL_TYPE_BOOL, 2, 1). Signed-off-by: Ian Romanick Signed-off-by: Kenneth Graunke --- src/glsl/builtin_types.h | 5 + src/glsl/glsl_types.h| 5 + 2 files changed, 10 insertio

Re: [Mesa-dev] Support for EXT/ARB_geometry_shader4

2012-07-27 Thread Olivier Galibert
On Fri, Jul 27, 2012 at 10:40:28AM -0500, Bryan Cain wrote: > https://github.com/Plombo/mesa/tree/geometry-shaders . Quick remarks from a fast read: - you missed draw_pipe_clip.c:clip_init_state, where you need to plug in the gs info where appropriate. Should be easy. It will take care of th

[Mesa-dev] [PATCH 2/2] i965/msaa: Allow GL_SAMPLES to be set to 1 prior to Gen6.

2012-07-27 Thread Paul Berry
This patch allows GL_SAMPLES to be set to either 0 or 1 on i965 platforms that don't support MSAA (those prior to Gen6). Setting GL_SAMPLES=1 has the same effect as setting it to 0 on these platforms (because MSAA is unsupported), but is distinguishable via the GL API. Bugzilla: https://bugs.free

[Mesa-dev] [PATCH 1/2] i965/msaa: Treat GL_SAMPLES=1 as equivalent to GL_SAMPLES=0.

2012-07-27 Thread Paul Berry
EXT_framebuffer_multisample is a required subpart of ARB_framebuffer_object, which means that we must support it even on platforms that don't support MSAA. Fortunately EXT_framebuffer_multisample allows for this by allowing GL_MAX_SAMPLES to be set to 1. This leads to a tricky quirk in the GL spe

Re: [Mesa-dev] [PATCH] intel: increase wm thread number to 80 on gen6 GT2

2012-07-27 Thread Kenneth Graunke
On 07/26/2012 03:04 PM, Zou Nan hai wrote: > It seems reset is not required for setting the max_wm_threads to 80 gen6 GT2. > > Signed-off-by: Zou Nan hai > --- > src/mesa/drivers/dri/i965/brw_context.c |6 +- > 1 files changed, 1 insertions(+), 5 deletions(-) > > diff --git a/src/mesa/d

Re: [Mesa-dev] [PATCH 2/2] mesa: add _mesa_feature_removed() helper

2012-07-27 Thread Ian Romanick
On 07/27/2012 10:11 AM, Ian Romanick wrote: On 07/27/2012 09:19 AM, nobled wrote: And a more trivial _mesa_feature_deprecated(). I don't think this patch is going to be useful. There are only three pieces of functionality that are deprecated but not removed. 1. Line widths > 1.0. 2. The que

Re: [Mesa-dev] [PATCH 2/2] mesa: add _mesa_feature_removed() helper

2012-07-27 Thread Ian Romanick
On 07/27/2012 09:19 AM, nobled wrote: And a more trivial _mesa_feature_deprecated(). I don't think this patch is going to be useful. There are only three pieces of functionality that are deprecated but not removed. 1. Line widths > 1.0. 2. The queries for MAX_VARYING_COMPONENTS and MAX_VAR

[Mesa-dev] [Bug 52405] Openarena 0.8.8 performance regression with current master.

2012-07-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=52405 --- Comment #5 from Iaroslav 2012-07-27 16:41:49 PDT --- I made a mistake, I can not specify what is the problem. I found old package with mesa-git_2012.05.07 and copied only r600_dri.so, and the FPS has doubled, but if i build snapshot Mesa-git_

[Mesa-dev] [PATCH] i965/msaa: Use MESA_FORMAT_R8 for MCS buffer.

2012-07-27 Thread Paul Berry
No functional change. This patch modifies intel_miptree_alloc_mcs to allocate the 4x MCS buffer using MESA_FORMAT_R8 instead of MESA_FORMAT_A8. In principle it doesn't matter, since we only access the buffer using MCS-specific hardware mechanisms, so all that's important is to use a format with t

Re: [Mesa-dev] [PATCH v2 7/7] mesa: don't enable legacy GL functions when using API_OPENGL_CORE

2012-07-27 Thread nobled
On Fri, Jul 27, 2012 at 6:43 AM, Jordan Justen wrote: > Signed-off-by: Jordan Justen > --- > src/mesa/main/api_exec.c | 227 > -- > src/mesa/main/api_exec.h |3 +- > src/mesa/main/context.c |2 +- > src/mesa/main/vtxfmt.c | 167 ++

Re: [Mesa-dev] Thoughts on Haiku's OpenGL implementation (hardware rendering)

2012-07-27 Thread Alexander von Gluck
On 27.07.2012 09:10, Alexander von Gluck wrote: I'm trying to get together a solid plan for Haiku's OpenGL kit. It should be kept in mind that we indend to keep Mesa upstream code minimal to keep from Haiku code suffering the same state as BeOS code :) Currently we are using swrast for softwa

[Mesa-dev] [PATCH 2/2] mesa: add _mesa_feature_removed() helper

2012-07-27 Thread nobled
And a more trivial _mesa_feature_deprecated(). --- src/mesa/main/context.c | 29 + src/mesa/main/context.h | 14 ++ 2 files changed, 43 insertions(+) diff --git a/src/mesa/main/context.c b/src/mesa/main/context.c index 18a9ac8..1a025e8 100644 --- a/src

[Mesa-dev] [PATCH 1/2] mesa: set CORE profile by default

2012-07-27 Thread nobled
a) Per the OpenGL 3.2 spec, this is the default value unless the user overrides it at context creation; b) The client can't query this state until Mesa exposes OpenGL 3.2 anyway, so it doesn't really matter yet. --- src/mesa/main/context.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(

[Mesa-dev] Support for EXT/ARB_geometry_shader4

2012-07-27 Thread Bryan Cain
Some of you already know about this from IRC, but recently I've been working on adding support for GL_EXT_geometry_shader4 and GL_ARB_geometry_shader4 (which are essentially identical) to Mesa. A significant amount of the required code was already there from Zack Rusin's work on geometry shaders a

Re: [Mesa-dev] [PATCH v2 0/7] Support Desktop GL Core contexts

2012-07-27 Thread Ian Romanick
On 07/27/2012 08:05 AM, Brian Paul wrote: On 07/27/2012 12:43 AM, Jordan Justen wrote: These patches introduce a MESA API type of API_OPENGL_CORE, which will not support legacy/non-CORE features. The intended usage will be with contexts for Desktop GL>= 3.1. The series will currently cause lega

Re: [Mesa-dev] [PATCH] meta: fix glDrawPixels fallback test, stencil drawing

2012-07-27 Thread Roland Scheidegger
Looks certainly good to me though maybe one of the intel guys should take a look as they are the main user of this. Reviewed-by: Roland Scheidegger Am 27.07.2012 16:26, schrieb Brian Paul: > Remove the check for pixel transfer ops. If any RGB/depth scale/bias > is in effect, it'll be applied in

Re: [Mesa-dev] [PATCH v2 7/7] mesa: don't enable legacy GL functions when using API_OPENGL_CORE

2012-07-27 Thread Ian Romanick
On 07/27/2012 08:06 AM, Brian Paul wrote: On 07/27/2012 12:43 AM, Jordan Justen wrote: Signed-off-by: Jordan Justen --- src/mesa/main/api_exec.c | 227 -- src/mesa/main/api_exec.h |3 +- src/mesa/main/context.c |2 +- src/mesa/main/vtxfm

[Mesa-dev] [Bug 47375] Blender crash on startup after upgrade to mesa 8.0.1

2012-07-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=47375 --- Comment #45 from Brian Paul 2012-07-27 15:12:02 PDT --- (In reply to comment #44) > (In reply to comment #43) > > > Also fog fallback shouldn't apply to depth/stencil buffer drawing neither > > > (but > > > OTOH enabled texturing should cau

Re: [Mesa-dev] [PATCH v2 7/7] mesa: don't enable legacy GL functions when using API_OPENGL_CORE

2012-07-27 Thread Brian Paul
On 07/27/2012 12:43 AM, Jordan Justen wrote: Signed-off-by: Jordan Justen --- src/mesa/main/api_exec.c | 227 -- src/mesa/main/api_exec.h |3 +- src/mesa/main/context.c |2 +- src/mesa/main/vtxfmt.c | 167 ++

Re: [Mesa-dev] [PATCH v2 3/7] mesa: add support for using API_OPENGL_CORE

2012-07-27 Thread Brian Paul
On 07/27/2012 12:43 AM, Jordan Justen wrote: Signed-off-by: Jordan Justen --- src/mesa/main/api_validate.c |1 + src/mesa/main/context.c |6 -- src/mesa/main/extensions.c |4 +++- src/mesa/main/fbobject.c | 14 +++--- src/mesa/main/get.c | 11

Re: [Mesa-dev] [PATCH v2 2/7] mesa: add api check macros

2012-07-27 Thread Brian Paul
On 07/27/2012 12:43 AM, Jordan Justen wrote: These macros make it easier to check for multiple API types. Signed-off-by: Jordan Justen --- src/mesa/main/mtypes.h |4 1 file changed, 4 insertions(+) diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h index 7d77956..7a715b3 1

Re: [Mesa-dev] [PATCH v2 1/7] mesa: add API_OPENGL_CORE api

2012-07-27 Thread Brian Paul
On 07/27/2012 12:43 AM, Jordan Justen wrote: Signed-off-by: Jordan Justen --- src/mesa/main/mtypes.h |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h index 3d59dc6..7d77956 100644 --- a/src/mesa/main/mtypes.h +++ b/src/mes

Re: [Mesa-dev] [PATCH 1/4] mesa: Add a Version field to the context with VersionMajor*10+VersionMinor.

2012-07-27 Thread Olivier Galibert
On Thu, Jul 26, 2012 at 05:27:43PM -0700, Eric Anholt wrote: > As we get into supporting GL 3.x core, we come across more and more features > of the API that depend on the version number as opposed to just the extension > list. This will let us more sanely do version checks than "(VersionMajor ==

Re: [Mesa-dev] [PATCH v2 0/7] Support Desktop GL Core contexts

2012-07-27 Thread Brian Paul
On 07/27/2012 12:43 AM, Jordan Justen wrote: These patches introduce a MESA API type of API_OPENGL_CORE, which will not support legacy/non-CORE features. The intended usage will be with contexts for Desktop GL>= 3.1. The series will currently cause legacy/non-CORE functions to generate a GL_INVA

[Mesa-dev] [Bug 47375] Blender crash on startup after upgrade to mesa 8.0.1

2012-07-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=47375 --- Comment #44 from Roland Scheidegger 2012-07-27 14:54:22 PDT --- (In reply to comment #43) > > Also fog fallback shouldn't apply to depth/stencil buffer drawing neither > > (but > > OTOH enabled texturing should cause a fallback for color bu

[Mesa-dev] [PATCH] meta: fix glDrawPixels fallback test, stencil drawing

2012-07-27 Thread Brian Paul
Remove the check for pixel transfer ops. If any RGB/depth scale/bias is in effect, it'll be applied in the glTexImage step. If drawing stencil pixels we need to disable pixel transfer so that alpha scale/bias are not applied to the stencil data. These issues were spotted by Roland. Fixes Blende

Re: [Mesa-dev] [PATCH] intel: increase wm thread number to 80 on gen6 GT2

2012-07-27 Thread Matt Turner
On Thu, Jul 26, 2012 at 3:04 PM, Zou Nan hai wrote: > It seems reset is not required for setting the max_wm_threads to 80 gen6 GT2. > > Signed-off-by: Zou Nan hai > --- > src/mesa/drivers/dri/i965/brw_context.c |6 +- > 1 files changed, 1 insertions(+), 5 deletions(-) > > diff --git a/sr

[Mesa-dev] Thoughts on Haiku's OpenGL implementation (hardware rendering)

2012-07-27 Thread Alexander von Gluck
I'm trying to get together a solid plan for Haiku's OpenGL kit. It should be kept in mind that we indend to keep Mesa upstream code minimal to keep from Haiku code suffering the same state as BeOS code :) Currently we are using swrast for software rendering (which is working very well at this po

[Mesa-dev] [Bug 47375] Blender crash on startup after upgrade to mesa 8.0.1

2012-07-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=47375 --- Comment #43 from Brian Paul 2012-07-27 14:16:09 PDT --- (In reply to comment #40) > I was actually wondering, do we really need the fallback when there's > PixelTransfer state? Clearly this applies to DrawPixels, but doesn't this also > appl

Re: [Mesa-dev] [PATCH 1/4] mesa: Add a Version field to the context with VersionMajor*10+VersionMinor.

2012-07-27 Thread Brian Paul
On 07/27/2012 01:51 AM, Kenneth Graunke wrote: On 07/27/2012 12:19 AM, Jordan Justen wrote: On Thu, Jul 26, 2012 at 11:52 PM, Kenneth Graunke wrote: On 07/26/2012 05:54 PM, Jordan Justen wrote: On Thu, Jul 26, 2012 at 5:27 PM, Eric Anholt wrote: As we get into supporting GL 3.x core, we com

Re: [Mesa-dev] Mesa 8.0 branch maintenance

2012-07-27 Thread Brian Paul
On 07/26/2012 07:37 PM, Ian Romanick wrote: We've been really crappy about keeping up on stable releases. The biggest problem has been bug fixes sitting on master never getting cherry picked over. Release time comes along, and either I cherry pick 57 patches over the day before the release or Jak

Re: [Mesa-dev] some radeon/r200 cleanup/fixes

2012-07-27 Thread Brian Paul
On 07/26/2012 08:14 PM, Roland Scheidegger wrote: This patches are just some cleanups and fixes however only compile tested (my r100 got broken and the r200 isn't in a useful box right now) so testers would be great. Looks good to me, but I can't test either. -Brian __

Re: [Mesa-dev] [PATCH 1/9] intel gen4-5: fix the vue view in the fs.

2012-07-27 Thread Olivier Galibert
On Thu, Jul 26, 2012 at 10:18:01AM -0700, Eric Anholt wrote: > Olivier Galibert writes: > > > In some cases the fragment shader view of the vue registers was out of > > sync with the builder. This fixes it. > > s/builder/SF outputs/ ? > > I'd love to see the pre-gen6 code get rearranged so the

Re: [Mesa-dev] [PATCH 5/9] intel gen4-5: Compute the interpolation status for every variable in one place.

2012-07-27 Thread Olivier Galibert
On Thu, Jul 26, 2012 at 10:22:26AM -0700, Eric Anholt wrote: > I don't like seeing this data that should be referenced out of the > program cache key being communicated through brw->. What would you like it being communicated through? OG. ___ mesa-dev

Re: [Mesa-dev] [PATCH 1/4] mesa: Add a Version field to the context with VersionMajor*10+VersionMinor.

2012-07-27 Thread Kenneth Graunke
On 07/27/2012 12:19 AM, Jordan Justen wrote: > On Thu, Jul 26, 2012 at 11:52 PM, Kenneth Graunke > wrote: >> On 07/26/2012 05:54 PM, Jordan Justen wrote: >>> On Thu, Jul 26, 2012 at 5:27 PM, Eric Anholt wrote: As we get into supporting GL 3.x core, we come across more and more feature

Re: [Mesa-dev] [PATCH 1/4] mesa: Add a Version field to the context with VersionMajor*10+VersionMinor.

2012-07-27 Thread Jordan Justen
On Thu, Jul 26, 2012 at 11:52 PM, Kenneth Graunke wrote: > On 07/26/2012 05:54 PM, Jordan Justen wrote: >> On Thu, Jul 26, 2012 at 5:27 PM, Eric Anholt wrote: >>> As we get into supporting GL 3.x core, we come across more and more features >>> of the API that depend on the version number as oppos

Re: [Mesa-dev] [PATCH 1/4] mesa: Add a Version field to the context with VersionMajor*10+VersionMinor.

2012-07-27 Thread Kenneth Graunke
On 07/26/2012 05:54 PM, Jordan Justen wrote: > On Thu, Jul 26, 2012 at 5:27 PM, Eric Anholt wrote: >> As we get into supporting GL 3.x core, we come across more and more features >> of the API that depend on the version number as opposed to just the extension >> list. This will let us more sanely

[Mesa-dev] [PATCH v2 6/7] intel: add support for using API_OPENGL_CORE

2012-07-27 Thread Jordan Justen
Signed-off-by: Jordan Justen --- src/mesa/drivers/dri/intel/intel_extensions.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/intel/intel_extensions.c b/src/mesa/drivers/dri/intel/intel_extensions.c index c2bc072..b93f326 100755 --- a/src/mesa/drivers

[Mesa-dev] [PATCH v2 7/7] mesa: don't enable legacy GL functions when using API_OPENGL_CORE

2012-07-27 Thread Jordan Justen
Signed-off-by: Jordan Justen --- src/mesa/main/api_exec.c | 227 -- src/mesa/main/api_exec.h |3 +- src/mesa/main/context.c |2 +- src/mesa/main/vtxfmt.c | 167 ++ 4 files changed, 232 insertions(+), 167 dele

[Mesa-dev] [PATCH v2 5/7] meta: add support for using API_OPENGL_CORE

2012-07-27 Thread Jordan Justen
Signed-off-by: Jordan Justen --- src/mesa/drivers/common/meta.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/common/meta.c b/src/mesa/drivers/common/meta.c index fa15423..50b0856 100644 --- a/src/mesa/drivers/common/meta.c +++ b/src/mesa/drivers/common/m

[Mesa-dev] [PATCH v2 4/7] glsl: add support for using API_OPENGL_CORE

2012-07-27 Thread Jordan Justen
Signed-off-by: Jordan Justen --- src/glsl/glsl_parser_extras.cpp | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/src/glsl/glsl_parser_extras.cpp b/src/glsl/glsl_parser_extras.cpp index df40459..727d76b 100644 --- a/src/glsl/glsl_parser_extras.cpp +++ b/src/gls

[Mesa-dev] [PATCH v2 3/7] mesa: add support for using API_OPENGL_CORE

2012-07-27 Thread Jordan Justen
Signed-off-by: Jordan Justen --- src/mesa/main/api_validate.c |1 + src/mesa/main/context.c |6 -- src/mesa/main/extensions.c |4 +++- src/mesa/main/fbobject.c | 14 +++--- src/mesa/main/get.c | 11 +++ src/mesa/main/getstring.c|1 +

[Mesa-dev] [PATCH v2 2/7] mesa: add api check macros

2012-07-27 Thread Jordan Justen
These macros make it easier to check for multiple API types. Signed-off-by: Jordan Justen --- src/mesa/main/mtypes.h |4 1 file changed, 4 insertions(+) diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h index 7d77956..7a715b3 100644 --- a/src/mesa/main/mtypes.h +++ b/src/mes

[Mesa-dev] [PATCH v2 1/7] mesa: add API_OPENGL_CORE api

2012-07-27 Thread Jordan Justen
Signed-off-by: Jordan Justen --- src/mesa/main/mtypes.h |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h index 3d59dc6..7d77956 100644 --- a/src/mesa/main/mtypes.h +++ b/src/mesa/main/mtypes.h @@ -3336,7 +3336,8 @@ typedef en

[Mesa-dev] [PATCH v2 0/7] Support Desktop GL Core contexts

2012-07-27 Thread Jordan Justen
These patches introduce a MESA API type of API_OPENGL_CORE, which will not support legacy/non-CORE features. The intended usage will be with contexts for Desktop GL >= 3.1. The series will currently cause legacy/non-CORE functions to generate a GL_INVALID_OPERATION error if an API_OPENGL_CORE cont

[Mesa-dev] [PATCH] intel: increase wm thread number to 80 on gen6 GT2

2012-07-27 Thread Zou Nan hai
It seems reset is not required for setting the max_wm_threads to 80 gen6 GT2. Signed-off-by: Zou Nan hai --- src/mesa/drivers/dri/i965/brw_context.c |6 +- 1 files changed, 1 insertions(+), 5 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_context.c b/src/mesa/drivers/dri/i965/