On 07/27/2012 11:20 AM, Olivier Galibert wrote: > On Fri, Jul 27, 2012 at 10:49:22AM -0700, Kenneth Graunke wrote: >> From: Ian Romanick <ian.d.roman...@intel.com> >> >> No types have 0 columns. The glsl_type::get_instance method contains >> >> if ((rows < 1) || (rows > 4) || (columns < 1) || (columns > 4)) >> return error_type; >> >> To get a vector, use columns = 1. > > Reviewed-by: Olivier Galibert <galib...@pobox.com> > > That's an obvious bugfix. If there's a stable branch with the glsl > compiler in, it probably should go there. > > OG.
Ian originally had it marked as a candidate for stable branches, but nobody actually uses ir_quadop_vector in any release. We could pick it over, but it shouldn't affect anything either way. _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
