Re: [Mesa-dev] [PATCH 4/8] intel: Implement __DRIimage::createSubImage and bump supported version to 5

2012-07-06 Thread Kristian Høgsberg
On Fri, Jul 06, 2012 at 02:16:23PM -0700, Eric Anholt wrote: > Kristian Høgsberg writes: > > +static __DRIimage * > > +intel_create_sub_image(__DRIimage *parent, > > + int width, int height, int dri_format, > > + int offset, int pitch, void *loaderPrivat

Re: [Mesa-dev] [PATCH 3/8] intel: Add offset field to miptree

2012-07-06 Thread Kristian Høgsberg
On Fri, Jul 06, 2012 at 02:11:44PM -0700, Eric Anholt wrote: > Kristian Høgsberg writes: > > > This lets us specify an offset into the bo where the miptree starts, > > which will let us set up a texture for a single plane in a planar buffer. > > While I've not some questions about the other patc

Re: [Mesa-dev] [PATCH 1/8] __DRIimage: version 5, add new formats and createSubImage

2012-07-06 Thread Kristian Høgsberg
On Fri, Jul 06, 2012 at 02:10:57PM -0700, Eric Anholt wrote: > Kristian Høgsberg writes: > > > The additions in version 5 enables creating EGLImages for different planes > > of a YUV buffer. createImageFromName is still used to create the containing > > __DRIimage, and createSubImage can then be

Re: [Mesa-dev] [PATCH] r600g: improve flushed depth texture handling v2

2012-07-06 Thread Marek Olšák
On Wed, Jun 27, 2012 at 1:34 AM, Vadim Girlin wrote: > Use r600_resource_texture::flished_depth_texture for GPU access, and > allocate it in the VRAM. For transfers we'll allocate untiled texture in the > GTT and store it in the r600_transfer::staging. > > Improves performance when flushed depth t

[Mesa-dev] [PATCH 8/8] i965/msaa: Enable CMS layout on Gen7 for the formats that support it.

2012-07-06 Thread Paul Berry
--- src/mesa/drivers/dri/intel/intel_mipmap_tree.c | 19 ++- 1 files changed, 18 insertions(+), 1 deletions(-) diff --git a/src/mesa/drivers/dri/intel/intel_mipmap_tree.c b/src/mesa/drivers/dri/intel/intel_mipmap_tree.c index 84fc477..4f77a65 100644 --- a/src/mesa/drivers/dri/i

[Mesa-dev] [PATCH 7/8] i965/msaa: Add CMS support to blorp.

2012-07-06 Thread Paul Berry
This patch updates the blorp engine to properly handle the case where the surface being textured from uses Gen7's CMS MSAA layout. The following changes were necessary: - Before reading color values from the surface, we need to read from the MCS buffer using the ld_mcs sampler message. This is

[Mesa-dev] [PATCH 6/8] i965/msaa: Add CMS-related sampler messages to brw_defines.h.

2012-07-06 Thread Paul Berry
--- src/mesa/drivers/dri/i965/brw_defines.h |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_defines.h b/src/mesa/drivers/dri/i965/brw_defines.h index 3234b0e..73ade0a 100644 --- a/src/mesa/drivers/dri/i965/brw_defines.h +++ b/src/mesa/driver

[Mesa-dev] [PATCH 5/8] i965/msaa: Set SURFACE_STATE properly when CMS MSAA is in use.

2012-07-06 Thread Paul Berry
When a buffer using Gen7's CMS MSAA layout is bound to a texture or a render target, the SURFACE_STATE structure needs to point to the MCS buffer and to indicate its pitch. This patch updates the functions that emit SURFACE_STATE to handle CMS layout properly. --- src/mesa/drivers/dri/i965/brw_st

[Mesa-dev] [PATCH 4/8] i965/msaa: Add CMS MSAA settings to brw_structs.h.

2012-07-06 Thread Paul Berry
Previously the DWORD used to control the CMS MSAA layout was just a pad value, because we didn't use it. --- src/mesa/drivers/dri/i965/brw_structs.h | 22 -- 1 files changed, 20 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_structs.h b/src/mesa/dr

[Mesa-dev] [PATCH 3/8] i965/msaa: Allocate MCS buffer when CMS MSAA is in use.

2012-07-06 Thread Paul Berry
To implement Gen7's CMS MSAA layout, we need an extra buffer, the MCS (Multisample Control Surface) buffer. This patch introduces code for allocating and deallocating the buffer, and storing a pointer to it in the intel_mipmap_tree struct. No functional change, since the CMS layout is not enabled

[Mesa-dev] [PATCH 2/8] i965/msaa: Add an enum to describe MSAA layout.

2012-07-06 Thread Paul Berry
>From the Ivy Bridge PRM, Vol 1 Part 1, p112: There are three types of multisampled surface layouts designated as follows: - IMS Interleaved Multisampled Surface - CMS Compressed Mulitsampled Surface - UMS Uncompressed Multisampled Surface Previously, the i965 driver onl

[Mesa-dev] [PATCH 1/8] i965/msaa: Move {rt, tex}_interleaved into blorp program key.

2012-07-06 Thread Paul Berry
On Gen6, MSAA buffers always use an interleaved layout and non-MSAA buffers always use a non-interleaved layout, so it is not strictly necessary to keep track of the layout of the texture and render target surfaces in the blorp program key. However, it is cleaner to do so, since (a) it makes the b

[Mesa-dev] [PATCH 0/8] i965/msaa: Implement CMS MSAA layout for Gen7.

2012-07-06 Thread Paul Berry
This patch series adds support for the "Compressed Multisample Surface" layout, which should speed up multisample rendering on Gen7 by decreasing memory bandwidth requirements. Patches 1-2 do preparatory refactoring, including creating a function to determine which MSAA layout should be used based

Re: [Mesa-dev] [PATCH 1/1] glsl: warning: pragma `invariant(all)' not supported in GLSL ES 1.00

2012-07-06 Thread Eric Anholt
Oliver McFadden writes: > The OpenGL(R) ES Shading Language > Version 1.00 Revision 17 (12 May, 2009) > >> 4.6.1 The Invariant Qualifier >> ... To force all output variables to be invariant, use the pragma >> #pragma STDGL invariant(all) > > Signed-off-by: Oliver McFadden Could we get a piglit

Re: [Mesa-dev] [PATCH 4/8] intel: Implement __DRIimage::createSubImage and bump supported version to 5

2012-07-06 Thread Eric Anholt
Kristian Høgsberg writes: > +static __DRIimage * > +intel_create_sub_image(__DRIimage *parent, > + int width, int height, int dri_format, > + int offset, int pitch, void *loaderPrivate) > +{ > +__DRIimage *image; > + > +image = intel_allocate_ima

Re: [Mesa-dev] [PATCH 3/8] intel: Add offset field to miptree

2012-07-06 Thread Eric Anholt
Kristian Høgsberg writes: > This lets us specify an offset into the bo where the miptree starts, > which will let us set up a texture for a single plane in a planar buffer. While I've not some questions about the other patches, this one is: Reviewed-by: Eric Anholt pgpiMU3R6GicJ.pgp Descript

Re: [Mesa-dev] [PATCH 1/8] __DRIimage: version 5, add new formats and createSubImage

2012-07-06 Thread Eric Anholt
Kristian Høgsberg writes: > The additions in version 5 enables creating EGLImages for different planes > of a YUV buffer. createImageFromName is still used to create the containing > __DRIimage, and createSubImage can then be used no that __DRIimage to create > __DRIimages that correspond to the

Re: [Mesa-dev] [PATCH] mesa: Require current libxcb.

2012-07-06 Thread Ian Romanick
On 07/05/2012 03:08 PM, Eric Anholt wrote: Without that, people with buggy apps that looked at just the server string for GLX_ARB_create_context would call this function that just threw an error when you tried to make a context. Google shows plenty of complaints about this. Oh yeah. I never w

[Mesa-dev] [Bug 51782] New: mesa-8.0.3: fails to compile against uclibc

2012-07-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=51782 Bug #: 51782 Summary: mesa-8.0.3: fails to compile against uclibc Classification: Unclassified Product: Mesa Version: 8.0 Platform: All OS/Version: All Status: NEW

[Mesa-dev] [PATCH 1/1] glsl: warning: pragma `invariant(all)' not supported in GLSL ES 1.00

2012-07-06 Thread Oliver McFadden
The OpenGL(R) ES Shading Language Version 1.00 Revision 17 (12 May, 2009) > 4.6.1 The Invariant Qualifier > ... To force all output variables to be invariant, use the pragma > #pragma STDGL invariant(all) Signed-off-by: Oliver McFadden --- src/glsl/glsl_parser.yy |2 +- 1 files changed, 1 i