Re: [Mesa-dev] [PATCH] egl_glx: use casts to silence warnings in GLX_eglDestroyContext()

2011-12-02 Thread Chia-I Wu
On Fri, Dec 2, 2011 at 10:53 PM, Brian Paul wrote: > --- >  src/egl/drivers/glx/egl_glx.c |    2 +- >  1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/src/egl/drivers/glx/egl_glx.c b/src/egl/drivers/glx/egl_glx.c > index bdc8a28..6479daf 100644 > --- a/src/egl/drivers/glx/egl_glx

Re: [Mesa-dev] Please update the Gallium3D pages in the wiki

2011-12-02 Thread Brian Paul
On 12/02/2011 02:16 PM, Kai Wasserbäch wrote: Dear mesa-dev list, I just noticed, that [0] and [1] still reference some of the recently removed drivers. I can't edit those pages ("Immutable Page") but I think it would be good to remove the parts about the cell, i965 and failover drivers/module.

[Mesa-dev] Please update the Gallium3D pages in the wiki

2011-12-02 Thread Kai Wasserbäch
Dear mesa-dev list, I just noticed, that [0] and [1] still reference some of the recently removed drivers. I can't edit those pages ("Immutable Page") but I think it would be good to remove the parts about the cell, i965 and failover drivers/module. Thank you for taking care of this. Kind regards

Re: [Mesa-dev] UBO support update, working on some demo

2011-12-02 Thread Eric Anholt
On Thu, 1 Dec 2011 16:35:30 +0100, Vincent Lejeune wrote: > Hi, > > Here are an updated set of patches adding UBO support to Mesa. > It still work in progress, however I got some demo working on gallium > (namely blinking-teapot submitted to mesa-demos via another patch). > However not every ga

Re: [Mesa-dev] [PATCH 4/9] mesa: Uniform Buffer Objects data structures

2011-12-02 Thread Eric Anholt
On Thu, 1 Dec 2011 16:35:33 +0100, Vincent Lejeune wrote: >v2:Big cleanup of data structures used >v3:Data structures moved to mtypes.h A 100-line commit really needs more than a 1-line commit message. > --- > src/mesa/main/config.h|4 ++ > src/mesa/main/mtypes.h

Re: [Mesa-dev] [PATCH 5/9] glsl: change IR to add UBO information

2011-12-02 Thread Eric Anholt
On Thu, 1 Dec 2011 16:35:34 +0100, Vincent Lejeune wrote: This commit doesn't appear to "change IR to add UBO information". It appears to actually add a member initialized to false and copy it around. The commit message is missing the "why and how" part that should follow that 1-line "what" su

Re: [Mesa-dev] [PATCH 3/9] mesa : advertise GL_ARB_Uniform_Buffer_Object extension

2011-12-02 Thread Eric Anholt
On Thu, 1 Dec 2011 16:35:32 +0100, Vincent Lejeune wrote: From the commit message "mesa: advertise GL_ARB_Uniform_Buffer_Object extension" (please use the actual extension capitalization), I expected the commit to be about the extension advertising in the extension string. This appears to be ab

Re: [Mesa-dev] [PATCH 1/9] glapi: Add Uniform Buffer Object API

2011-12-02 Thread Eric Anholt
On Thu, 1 Dec 2011 16:35:31 +0100, Vincent Lejeune wrote: >v2: Fix a typo spotted by Eric Anholt. > --- > src/mapi/glapi/gen/ARB_Uniform_Buffer_Object.xml | 115 > ++ This should be capitalized like the extension, not Studly_Underscore_Caps (eww). pgp5qk7PfiOxU.pgp De

[Mesa-dev] [PATCH] In emit_math1 check for a zero writemask before emitting the preliminary MOV on gen 6 and up.

2011-12-02 Thread Stuart Abercrombie
Previously a zero writemask would result in dst_chan == -1, meaning an unnecessary MOV with the destination register dictated by undefined memory contents would be emitted before returning. This caused intermittent GPU hangs, e.g. with glean/texCombine. --- src/mesa/drivers/dri/i965/brw_wm_emi

Re: [Mesa-dev] [PATCH 0/6] patches to increase the brw eu instruction store size dynamically

2011-12-02 Thread Eric Anholt
On Thu, 1 Dec 2011 18:26:50 +0800, Yuanhan Liu wrote: > > Actually the first 5 patches are all prepare work for patch 6. > > I checked those patches will all intel oglc testcases, and found no > regressions. > What's better, it fixed something. > > > Yuanhan Liu (6): > i965: let all the b

[Mesa-dev] [PATCH 2/2] vdpau: Handle destination rectangles correctly

2011-12-02 Thread Maarten Lankhorst
The brokenness in vlVdpVideoMixerRender was compensating for brokenness in vlVdpPresentationQueueDisplay, so fix both at the same time. Signed-off-by: Maarten Lankhorst --- src/gallium/state_trackers/vdpau/mixer.c| 22 +- src/gallium/state_trackers/vdpau/presentatio

Re: [Mesa-dev] [PATCH 2/2] gallium : st_glsl_to_tgsi handles UBO

2011-12-02 Thread Fredrik Höglund
On Friday 02 December 2011, Vincent Lejeune wrote: > --- > src/mesa/state_tracker/st_atom_constbuf.c |8 +++ > src/mesa/state_tracker/st_extensions.c |4 + > src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 92 > ++-- > 3 files changed, 59 insertions(+), 45 dele

[Mesa-dev] [PATCH 1/2] vl: Handle custom destination rectangles correctly

2011-12-02 Thread Maarten Lankhorst
When layers are still being added, the total width/height is not known. As such extra care has to be taken to get output rectangle correct. This is required to support a custom dest rectangle, which is currently not used and buggy. Signed-off-by: Maarten Lankhorst --- src/gallium/auxiliary/vl/vl

Re: [Mesa-dev] RFC: remove ctx->Driver.TextureMemCpy() hook

2011-12-02 Thread Keith Whitwell
On Fri, 2011-12-02 at 08:14 -0700, Brian Paul wrote: > This hook was added many years ago to allow using an alternative > implementation of memcpy() for glTexImage() that was faster under some > circumstances. > > The code is still present in the state tracker in st_cb_texture.c > > The hook is

[Mesa-dev] RFC: remove ctx->Driver.TextureMemCpy() hook

2011-12-02 Thread Brian Paul
This hook was added many years ago to allow using an alternative implementation of memcpy() for glTexImage() that was faster under some circumstances. The code is still present in the state tracker in st_cb_texture.c The hook is only used in texstore.c in the memcpy_texture() helper. It's n

[Mesa-dev] [PATCH] egl_glx: use casts to silence warnings in GLX_eglDestroyContext()

2011-12-02 Thread Brian Paul
--- src/egl/drivers/glx/egl_glx.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/egl/drivers/glx/egl_glx.c b/src/egl/drivers/glx/egl_glx.c index bdc8a28..6479daf 100644 --- a/src/egl/drivers/glx/egl_glx.c +++ b/src/egl/drivers/glx/egl_glx.c @@ -724,7 +724,7 @@ GLX_eg

Re: [Mesa-dev] UBO support update, working on some demo

2011-12-02 Thread Brian Paul
On 12/01/2011 08:35 AM, Vincent Lejeune wrote: Hi, Here are an updated set of patches adding UBO support to Mesa. It still work in progress, however I got some demo working on gallium (namely blinking-teapot submitted to mesa-demos via another patch). However not every gallium works, nouveau and

Re: [Mesa-dev] [PATCH 1/2] mesa: add Uniform Buffer Object API implementation

2011-12-02 Thread Brian Paul
On 12/02/2011 06:22 AM, Vincent Lejeune wrote: v2:Move implementation to ubo.cpp and ubo.h as suggested by Brian Paul --- src/mesa/main/api_exec.c |2 + src/mesa/main/bufferobj.c| 11 + src/mesa/main/ubo.cpp| 263 +

Re: [Mesa-dev] [PATCH 1/2] mesa: Fix glCompressedTexSubImage (and non-Sub) for height == 2 or 1.

2011-12-02 Thread Brian Paul
On 12/02/2011 07:15 AM, Brian Paul wrote: On 12/01/2011 09:30 PM, Eric Anholt wrote: Generally this code works with width and height aligned to compressed blocks, but but at the 2x2 and 1x1 levels of a square texture (or Oops, missed the "but but" there. -Brian ___

Re: [Mesa-dev] [PATCH] mesa: Reject glDrawPixels(integer format).

2011-12-02 Thread Brian Paul
On 12/01/2011 09:29 PM, Eric Anholt wrote: When folding GL_EXT_texture_integer into the core, a new (and very sensible) restriction was added. --- src/mesa/main/drawpix.c | 18 ++ 1 files changed, 18 insertions(+), 0 deletions(-) diff --git a/src/mesa/main/drawpix.c b/src/me

Re: [Mesa-dev] [PATCH 1/2] mesa: Fix glCompressedTexSubImage (and non-Sub) for height == 2 or 1.

2011-12-02 Thread Brian Paul
On 12/01/2011 09:30 PM, Eric Anholt wrote: Generally this code works with width and height aligned to compressed blocks, but but at the 2x2 and 1x1 levels of a square texture (or height< bh in general), we were skipping uploading our single row of blocks. Fixes piglit compressedteximage GL_COMP

Re: [Mesa-dev] [PATCH 2/2] mesa: Fix assertions for block size handling in glCompressedTexSubImage2D.

2011-12-02 Thread Brian Paul
On 12/01/2011 09:30 PM, Eric Anholt wrote: Anything of less than (bw, bh) size is possible when you consider rectangular textures, and this code is (now) safe for those. Even for power-of-two textures, width could be 4 for FXT1 while not being aligned to block size. Fixes piglit compressedtexim

Re: [Mesa-dev] [PATCH 4/6] vbo: remove unreachable _mesa_error() call

2011-12-02 Thread Brian Paul
On 12/02/2011 01:36 AM, Jose Fonseca wrote: Brian, The series looks good. BTW, this just remind be of one thing I noticed looking at coverity results before is that it is almost impossible to get zero warnings everywhere. For example, gcc complains that a variable may be used unitialized (whe

Re: [Mesa-dev] [PATCH] mesa: Use VERT_{ATTRIB, BIT}* for ARB input validation.

2011-12-02 Thread Jose Fonseca
Looks good to me. Jose - Original Message - > > Hi, > > Attached is a change to the ARB program parser that should fix > > https://bugs.freedesktop.org/show_bug.cgi?id=43407 > > Please review. > > Thanks > > Mathias > > ___ > mesa-dev mai

[Mesa-dev] [PATCH 2/2] gallium : st_glsl_to_tgsi handles UBO

2011-12-02 Thread Vincent Lejeune
--- src/mesa/state_tracker/st_atom_constbuf.c |8 +++ src/mesa/state_tracker/st_extensions.c |4 + src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 92 ++-- 3 files changed, 59 insertions(+), 45 deletions(-) diff --git a/src/mesa/state_tracker/st_atom_constbuf.c

[Mesa-dev] [PATCH 1/2] mesa: add Uniform Buffer Object API implementation

2011-12-02 Thread Vincent Lejeune
v2:Move implementation to ubo.cpp and ubo.h as suggested by Brian Paul --- src/mesa/main/api_exec.c |2 + src/mesa/main/bufferobj.c| 11 + src/mesa/main/ubo.cpp| 263 ++ src/mesa/main/ubo.h

[Mesa-dev] [PATCH] glsl: change IR to add UBO information

2011-12-02 Thread Vincent Lejeune
--- src/glsl/ir.cpp |1 + src/glsl/ir.h |6 ++ src/glsl/ir_clone.cpp |1 + 3 files changed, 8 insertions(+), 0 deletions(-) diff --git a/src/glsl/ir.cpp b/src/glsl/ir.cpp index a5eca5a..bf11e4f 100644 --- a/src/glsl/ir.cpp +++ b/src/glsl/ir.cpp @@ -1335,6 +1335,7 @@

[Mesa-dev] [PATCH] r600g: check shaders presence in r600_draw_vbo

2011-12-02 Thread Vadim Girlin
This patch should prevent the crashes when some shaders are absent, see https://bugs.freedesktop.org/show_bug.cgi?id=43341 Signed-off-by: Vadim Girlin --- This is not the best solution for the mentioned bug, but probably it's better to prevent crashes until we have something else. src/gallium/

Re: [Mesa-dev] [PATCH 4/6] vbo: remove unreachable _mesa_error() call

2011-12-02 Thread Jose Fonseca
Brian, The series looks good. BTW, this just remind be of one thing I noticed looking at coverity results before is that it is almost impossible to get zero warnings everywhere. For example, gcc complains that a variable may be used unitialized (when often it cannot), and setting an initial va