On Thu, 1 Dec 2011 18:26:50 +0800, Yuanhan Liu <yuanhan....@linux.intel.com> wrote: > > Actually the first 5 patches are all prepare work for patch 6. > > I checked those patches will all intel oglc testcases, and found no > regressions. > What's better, it fixed something. > > > Yuanhan Liu (6): > i965: let all the brw_OPCODE functions return an instruction index > instead
I don't like the brw_insn_of() thing for the common case of "I just emitted an instruction and I want to tweak one parameter." As far as I can see, it should be possible to store the DO/WHILE/BRK/CONT information in struct brw_compile so that the only long-lived brw_instruction * pointers other than p->store go away.
pgp2pjQxx50n2.pgp
Description: PGP signature
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
