Re: paragraph dialog

2007-09-29 Thread Edwin Leuven
Abdelrazak Younes wrote: so letting the depend on a validate would be better Agreed. Could you do it? will have a look when i find some time

Re: paragraph dialog

2007-09-28 Thread Abdelrazak Younes
Edwin Leuven wrote: Abdelrazak Younes wrote: Edwin Leuven wrote: i really don't like this direct apply Would you prefer that it is unchecked by default? I'm OK with that. I can put the last chosen state in the session so that everyone is happy. yes please OK. it also gives nasty resul

Re: paragraph dialog

2007-09-28 Thread Edwin Leuven
Abdelrazak Younes wrote: Edwin Leuven wrote: i really don't like this direct apply Would you prefer that it is unchecked by default? I'm OK with that. I can put the last chosen state in the session so that everyone is happy. yes please it also gives nasty results when i put line spacing to

Re: paragraph dialog

2007-09-28 Thread Abdelrazak Younes
Edwin Leuven wrote: i really don't like this direct apply Would you prefer that it is unchecked by default? I'm OK with that. I can put the last chosen state in the session so that everyone is happy. it also gives nasty results when i put line spacing to custom: it assumes zero and the te

paragraph dialog

2007-09-28 Thread Edwin Leuven
i really don't like this direct apply it also gives nasty results when i put line spacing to custom: it assumes zero and the text becomes garbled

Re: [PATCH] Translation problem in paragraph dialog

2007-07-09 Thread Michael Gerz
Abdelrazak Younes schrieb: While I agree that your patch is good and clean (thus you have my OK), I don't understand why qt_() does not work. Do you? Because the label to be translated does not appear in the po files. I will commit in a minute... Michael

Re: [PATCH] Translation problem in paragraph dialog

2007-07-09 Thread Abdelrazak Younes
Michael Gerz wrote: Koji Yokota schrieb: Michael Gerz wrote: Hi, this patch fixes a translation problem. OK? Michael Yes, I confirmed. Thank you! Thanks. I need one more OK. Anybody, please? While I agree that your patch is good and clean (thus you have my OK), I don't understand why q

Re: [PATCH] Translation problem in paragraph dialog

2007-07-09 Thread Michael Gerz
Koji Yokota schrieb: Michael Gerz wrote: Hi, this patch fixes a translation problem. OK? Michael Yes, I confirmed. Thank you! Thanks. I need one more OK. Anybody, please? Michael

Re: [PATCH] Translation problem in paragraph dialog

2007-07-08 Thread Koji Yokota
Michael Gerz wrote: Hi, this patch fixes a translation problem. OK? Michael Yes, I confirmed. Thank you! Koji

[PATCH] Translation problem in paragraph dialog

2007-07-07 Thread Michael Gerz
Hi, this patch fixes a translation problem. OK? Michael Index: frontends/qt4/QParagraph.cpp === --- frontends/qt4/QParagraph.cpp (Revision 19004) +++ frontends/qt4/QParagraph.cpp (Arbeitskopie) @@ -83,11 +83,11 @@ radioMap[LYX_AL

Re: [PATCH] New Paragraph Dialog with Radio Buttons

2007-04-13 Thread Richard Heck
Jürgen Spitzmüller wrote: >> Is what's troubling you the lack of margin? >> > Yes. Your screenshot looks good. Committed. Richard -- == Richard G Heck, Jr Professor of Philosophy Brown University http://frege.brown.edu/heck/ =

Re: [PATCH] New Paragraph Dialog with Radio Buttons

2007-04-13 Thread Jürgen Spitzmüller
Richard Heck wrote: > I committed the grid version, so that's probably what you're seeing. Yes. > Is what's troubling you the lack of margin? Yes. > I agree that looks less than > perfect and would be happy to add some, thus: > > screenshot Your screenshot looks good. I wonder, though, why

Re: [PATCH] New Paragraph Dialog with Radio Buttons

2007-04-13 Thread Richard Heck
I committed the grid version, so that's probably what you're seeing. Is what's troubling you the lack of margin? I agree that looks less than perfect and would be happy to add some, thus: Richard Jürgen Spitzmüller wrote: Richard Heck wrote: Try the attached. It retains the ex

Re: [PATCH] New Paragraph Dialog with Radio Buttons

2007-04-13 Thread Jürgen Spitzmüller
Richard Heck wrote: > Try the attached. It retains the existing layout but sets a different > size policy. But I can do a grid if you prefer. I'd prefer a grid. I've attached a screenshot of how it looks like now. Jürgen lyx1.png Description: PNG image

Re: [PATCH] New Paragraph Dialog with Radio Buttons

2007-04-12 Thread Richard Heck
Try the attached. It retains the existing layout but sets a different size policy. But I can do a grid if you prefer. rh Jürgen Spitzmüller wrote: > Richard Heck wrote: > >> Attached is a patch fixing bug 1550. It pre-empts my previous effort, >> using radio buttons, as suggested by Abdel a

Re: [PATCH] New Paragraph Dialog with Radio Buttons

2007-04-12 Thread Jürgen Spitzmüller
Richard Heck wrote: > Attached is a patch fixing bug 1550. It pre-empts my previous effort, > using radio buttons, as suggested by Abdel and JMarc, among others, > rather than a combo box, as previously. Could you please layout the dialog in a grid? As it is now, it can be shrinked to almost zero

Re: [PATCH] New Paragraph Dialog with Radio Buttons

2007-04-11 Thread younes . a
Quoting Richard Heck <[EMAIL PROTECTED]>: > [EMAIL PROTECTED] wrote: > >> One question: I would have preferred to make QParagraph::radioMap const > >> but couldn't, because it can only be populated after the dialog is > >> created. Any other ideas? > >> > > I think we don't really need this QPRadi

Re: [PATCH] New Paragraph Dialog with Radio Buttons

2007-04-11 Thread Richard Heck
[EMAIL PROTECTED] wrote: >> One question: I would have preferred to make QParagraph::radioMap const >> but couldn't, because it can only be populated after the dialog is >> created. Any other ideas? >> > I think we don't really need this QPRadioMap. We have only 4 radio buttons, > why > don't

Re: [PATCH] New Paragraph Dialog with Radio Buttons

2007-04-11 Thread younes . a
Quoting [EMAIL PROTECTED]: > Quoting [EMAIL PROTECTED]: > > > > I propose that you commit your patch (taking into account my comments > below) > > with the modal dialog. Then, I'll help you fixing this update issue. > > Here's a cleanup patch based on yours. The patch. ParagraphDialog_abdel.di

Re: [PATCH] New Paragraph Dialog with Radio Buttons

2007-04-11 Thread younes . a
Quoting [EMAIL PROTECTED]: > I propose that you commit your patch (taking into account my comments below) > with the modal dialog. Then, I'll help you fixing this update issue. Here's a cleanup patch based on yours. Abdel.

Re: [PATCH] New Paragraph Dialog with Radio Buttons

2007-04-11 Thread younes . a
Richard Heck wrote: > Attached is a patch fixing bug 1550. It pre-empts my previous effort, > using radio buttons, as suggested by Abdel and JMarc, among others, > rather than a combo box, as previously. Very good work Richard! Thanks for doing this. > > This patch makes the dialog modal, for the

[PATCH] New Paragraph Dialog with Radio Buttons

2007-04-10 Thread Richard Heck
Attached is a patch fixing bug 1550. It pre-empts my previous effort, using radio buttons, as suggested by Abdel and JMarc, among others, rather than a combo box, as previously. This patch makes the dialog modal, for the present. This is not the ideal solution, but the ideal solution is still not

Re: [PATCH] gtk Paragraph dialog

2004-10-01 Thread Lars Gullik Bjønnes
John Spray <[EMAIL PROTECTED]> writes: | Regarding the spacingadj_ pointer, it turned out that it was not | necessary to create one anyway, one came with the spinbutton. > | Requested changes to spacing etc have been made. > | Patch to Makefile.am, Dialogs.C from previous message still applies. J

Re: [PATCH] gtk Paragraph dialog

2004-09-29 Thread Angus Leeming
John Spray wrote: >> > Revised glade file makes dialog modal. >> I don't know what this means. No GUI expert me. > A modal dialog blocks all input to its parent window until it is > dismissed. In this case the dialog's contents become invalid if the > user selects another paragraph, so I prevent t

Re: [PATCH] gtk Paragraph dialog

2004-09-29 Thread John Spray
On Wed, 2004-09-29 at 21:28, Angus Leeming wrote: > > Revised glade file makes dialog modal. > I don't know what this means. No GUI expert me. A modal dialog blocks all input to its parent window until it is dismissed. In this case the dialog's contents become invalid if the user selects another p

Re: [PATCH] gtk Paragraph dialog

2004-09-29 Thread Lars Gullik Bjønnes
John Spray <[EMAIL PROTECTED]> writes: | Regarding the spacingadj_ pointer, it turned out that it was not | necessary to create one anyway, one came with the spinbutton. > | Requested changes to spacing etc have been made. > | Patch to Makefile.am, Dialogs.C from previous message still applies. >

Re: [PATCH] gtk Paragraph dialog

2004-09-29 Thread Angus Leeming
John Spray wrote: > Revised glade file makes dialog modal. I don't know what this means. No GUI expert me. > This would not be necessary if I > could get a signal each time the cursor in the workarea changes position > (to load the present paragraph's settings into the dialog), but that > would

Re: [PATCH] gtk Paragraph dialog

2004-09-29 Thread Lars Gullik Bjønnes
John Spray <[EMAIL PROTECTED]> writes: | On Wed, 2004-09-29 at 15:25, Lars Gullik Bjønnes wrote: >> Two newlines between functions please. | That one doesn't seem to be in the Rules document, maybe you should add | it. > >> drop the if. (and change to use a smart pointer) | Confession time: I have

Re: [PATCH] gtk Paragraph dialog

2004-09-29 Thread Lars Gullik Bjønnes
John Spray <[EMAIL PROTECTED]> writes: | On Wed, 2004-09-29 at 15:25, Lars Gullik Bjønnes wrote: >> Two newlines between functions please. | That one doesn't seem to be in the Rules document, maybe you should add | it. I probably should :-) Anyhow this is done everywhere else in the code. > >> d

Re: [PATCH] gtk Paragraph dialog

2004-09-29 Thread John Spray
io_->get_active()) controller().params().align(LYX_ALIGN_RIGHT); else if (centerradio_->get_active()) controller().params().align(LYX_ALIGN_CENTER); controller().dispatchParams(); } } // namespace frontend } // namespace lyx // -*- C++ -*- /** * \file GParagraph.h * This file is part

Re: [PATCH] gtk Paragraph dialog

2004-09-29 Thread John Spray
On Wed, 2004-09-29 at 15:25, Lars Gullik Bjønnes wrote: > Two newlines between functions please. That one doesn't seem to be in the Rules document, maybe you should add it. > drop the if. (and change to use a smart pointer) Confession time: I have no idea about smart pointers. I've looked at the

Re: [PATCH] gtk Paragraph dialog

2004-09-29 Thread Lars Gullik Bjønnes
John Spray <[EMAIL PROTECTED]> writes: | class ControlParagraph; > | /** This class provides a gtk implementation of the paragraph dialog. | */ | class GParagraph | : public GViewCB { | Gtk::Adjustment * spacingadj_; Do you really need it to be a pointer at all? -- Lgb

Re: [PATCH] gtk Paragraph dialog

2004-09-29 Thread Lars Gullik Bjønnes
John Spray <[EMAIL PROTECTED]> writes: | /** | * \file GParagraph.C | * This file is part of LyX, the document processor. | * Licence details can be found in the file COPYING. | * | * \author John Spray | * | * Full author contact details are available in file CREDITS. | */ > | #include >

[PATCH] gtk Paragraph dialog

2004-09-29 Thread John Spray
Hi, The paragraph dialog. Note that this is the first instant-apply dialog I've done: hopefully that should all work okay. John Index: ChangeLog === RCS file: /cvs/lyx/lyx-devel/src/frontends/gtk/ChangeLog,v retrieving rev

Paragraph dialog patch

2003-03-12 Thread Angus Leeming
For info/review: John's ParagraphParameter::read and write methods have been put to speedy use ;-) Here is the Paragraph dialog receiving its data as a string and returning it to dispatch(). Behaviour of the dialog is unchanged but everything is now controlled by the kernel. I hav

Re: [patch]: xforms paragraph dialog

2002-10-30 Thread Lars Gullik Bjønnes
Angus Leeming <[EMAIL PROTECTED]> writes: | Angus Leeming wrote: > >> 2nd iteration of Rob's changes. >> >> Looks fairly uncontroversial and appears to work fine. >> The patch is as large as it is because I also moved the helper >> functions to the end of the file. >> >> I'm not sure that I like

Re: [patch]: xforms paragraph dialog

2002-10-29 Thread Angus Leeming
Angus Leeming wrote: > 2nd iteration of Rob's changes. > > Looks fairly uncontroversial and appears to work fine. > The patch is as large as it is because I also moved the helper > functions to the end of the file. > > I'm not sure that I like these " (default)" labels appended to the > "Block",

Re: [patch]: xforms paragraph dialog

2002-10-29 Thread Jean-Marc Lasgouttes
> "Angus" == Angus Leeming <[EMAIL PROTECTED]> writes: Angus> It is more expressive, but for now Rob has implemented the Angus> former of these lists. Angus> To implement the latter would involve changing ControlParagraph Angus> more than he feels comfortable with. Angus The second option sh

Re: [patch]: xforms paragraph dialog

2002-10-29 Thread Andre Poenitz
On Tue, Oct 29, 2002 at 10:20:42AM +, Angus Leeming wrote: > To implement the latter would involve changing ControlParagraph > more than he feels comfortable with. Thanks for the explanation. Andre' -- Those who desire to give up Freedom in order to gain Security, will not have, nor do they

Re: [patch]: xforms paragraph dialog

2002-10-29 Thread Angus Leeming
On Tuesday 29 October 2002 10:20 am, Andre Poenitz wrote: > On Tue, Oct 29, 2002 at 09:59:38AM +, Angus Leeming wrote: > > I'm not sure that I like these " (default)" labels appended > > to the "Block", "Center", "Left", "Right" alignment button > > labels, but it's only 30 lines of code and do

Re: [patch]: xforms paragraph dialog

2002-10-29 Thread Andre Poenitz
On Tue, Oct 29, 2002 at 09:59:38AM +, Angus Leeming wrote: > I'm not sure that I like these " (default)" labels appended to the > "Block", "Center", "Left", "Right" alignment button labels, but > it's only 30 lines of code and does no harm ;-) Is it now Block Center (default) Right

[patch]: xforms paragraph dialog

2002-10-29 Thread Angus Leeming
2nd iteration of Rob's changes. Looks fairly uncontroversial and appears to work fine. The patch is as large as it is because I also moved the helper functions to the end of the file. I'm not sure that I like these " (default)" labels appended to the "Block", "Center", "Left", "Right" alignment

Re: [patch]: xforms paragraph dialog

2002-10-26 Thread Rob Lahaye
Angus Leeming wrote: On Thursday 24 October 2002 4:41 pm, Rob Lahaye wrote: The idea for displaying the default as below, came originally from Lars. The dialog says: o Block o Center o Left (default) o Right where the "(default)" is appended to appropriate default value. Ok, understood

Re: [patch]: xforms paragraph dialog

2002-10-25 Thread Jean-Marc Lasgouttes
be the dialog should show Dekel> default (10) 10 11 >> That would be a 1.4.0 issue, of course. The paragraph dialog, >> however, could give a sneak preview to this already in 1.3.0. Dekel> The above is also true for the paragraph dialog. I think that Dekel> we should change

Re: [patch]: xforms paragraph dialog

2002-10-24 Thread Andre Poenitz
On Thu, Oct 24, 2002 at 06:07:08PM +0200, Dekel Tsur wrote: > This is wrong. In my opinion, you should have the option to distinguish > between "I want to use the default font size" and > "I want to use 10 points font". > Maybe the dialog should show >default (10) >10 >11 This looks g

Re: Xforms Radiobuttongroup: Float vs. Paragraph dialog

2002-10-23 Thread Rob Lahaye
Rob Lahaye wrote: > > Angus, > > The Alignment radiobuttongroup of 4 buttons in the Paragraph dialog (with > my patch applied!) behaves differently from the Placement buttongroup of > 3 buttons in the Float dialog. And I can't find the reason for this > different beh

Xforms Radiobuttongroup: Float vs. Paragraph dialog

2002-10-23 Thread Rob Lahaye
Angus, The Alignment radiobuttongroup of 4 buttons in the Paragraph dialog (with my patch applied!) behaves differently from the Placement buttongroup of 3 buttons in the Float dialog. And I can't find the reason for this different behaviour. Requirements for proper radiobuttons (as far

Re: can't open the paragraph dialog anymore...

2002-06-12 Thread Asger K. Alstrup Nielsen
> > I have this theory that football is great to play and crap to watch. I did > > try and watch the England game this morning, but got bored... I can't wait till Denmark beats England this Saturday! I sure hope that some channel in Portugal tramits this moster of a fight ;-) See some of you swi

Re: can't open the paragraph dialog anymore...

2002-06-12 Thread John Levon
On Wed, Jun 12, 2002 at 02:10:42PM +0100, Angus Leeming wrote: > I have this theory that football is great to play and crap to watch. I did > try and watch the England game this morning, but got bored... Hardly surprising given how lacklustre our performance was. > So, I guess I'm in the same

Re: can't open the paragraph dialog anymore...

2002-06-12 Thread Angus Leeming
On Wednesday 12 June 2002 2:09 pm, Jean-Marc Lasgouttes wrote: > Why? At least it will stop this stupid frenzy I had to endure since > 1998. Believe me, it was not easy to leave in france when you don't > care about football (actually, one does not really have the right to > assert such a thing; i

Re: can't open the paragraph dialog anymore...

2002-06-12 Thread Jean-Marc Lasgouttes
> "Angus" == Angus Leeming <[EMAIL PROTECTED]> writes: >> Angus, at least you can run lyx... Angus> Ha. I had to spend 3 weeks upgrading the compiler, sorting out Angus> the licence, fixing compilation. Wasn't it fun to begin with? Angus> Incidentally, my commiserations on the performance

Re: can't open the paragraph dialog anymore...

2002-06-12 Thread Angus Leeming
On Wednesday 12 June 2002 1:52 pm, Jean-Marc Lasgouttes wrote: > > "John" == John Levon <[EMAIL PROTECTED]> writes: > > John> On Wed, Jun 12, 2002 at 01:38:24PM +0100, Angus Leeming wrote: > >> Instant segfault. > >> > >> (ladebug) where > > John> Worked for me. *shrug* > > John> boost stuff I

Re: can't open the paragraph dialog anymore...

2002-06-12 Thread Jean-Marc Lasgouttes
> "John" == John Levon <[EMAIL PROTECTED]> writes: John> On Wed, Jun 12, 2002 at 01:38:24PM +0100, Angus Leeming wrote: >> Instant segfault. >> >> (ladebug) where John> Worked for me. *shrug* John> boost stuff I guess Angus, at least you can run lyx... JMarc

Re: can't open the paragraph dialog anymore...

2002-06-12 Thread John Levon
On Wed, Jun 12, 2002 at 01:38:24PM +0100, Angus Leeming wrote: > Instant segfault. > > (ladebug) where Worked for me. *shrug* boost stuff I guess john -- "All is change; all yields its place and goes" - Euripides

can't open the paragraph dialog anymore...

2002-06-12 Thread Angus Leeming
Instant segfault. (ladebug) where >0 0x120416c34 in ((ControlDialog*)0x1407a6380)->show() "../../../../devel/src/frontends/controllers/ControlDialog.tmpl":42 #1 0x120a95cb8 in call(u=const 0x1407a6380, =0x1407b0bb0) "../../../../devel/boost/boost/bind/mem_fn_template.hpp":37 #2 0x120a95cf8 i

Re: mvc paragraph dialog

2002-05-21 Thread Edwin Leuven
new patch... greets, Ed. mvcpar2.diff.gz Description: GNU Zip compressed data

Re: mvc paragraph dialog

2002-05-21 Thread Angus Leeming
On Monday 20 May 2002 8:27 pm, Edwin Leuven wrote: > > Ed, why have you given the controller all these set/get methods? Wouldn't > > it have been easier to just provide > > > > ParagraphParameters & ControlParagraph::params() > > { > > lyx::Assert(pp_.get()); > > return *pp_; > > } > > > >

Re: mvc paragraph dialog

2002-05-20 Thread Edwin Leuven
> Ed, why have you given the controller all these set/get methods? Wouldn't > it have been easier to just provide > > ParagraphParameters & ControlParagraph::params() > { > lyx::Assert(pp_.get()); > return *pp_; > } > > Or am I mising something? I actually thought about doing that but

Re: mvc paragraph dialog

2002-05-20 Thread Angus Leeming
On Sunday 19 May 2002 2:43 pm, Edwin Leuven wrote: > I had a go at reworking the paragraph dialog to MVC. I attach what I have > now. It seems to work, but perhaps someone (Angus?) could have a look at it > so that it may go in after 1.2. > > Thanks, Ed. Ed, why have you given the

Re: mvc paragraph dialog

2002-05-20 Thread Angus Leeming
On Sunday 19 May 2002 2:43 pm, Edwin Leuven wrote: > I had a go at reworking the paragraph dialog to MVC. I attach what I have > now. It seems to work, but perhaps someone (Angus?) could have a look at it > so that it may go in after 1.2. > > Thanks, Ed. TOP effort Edwin. I&#x

mvc paragraph dialog

2002-05-19 Thread Edwin Leuven
I had a go at reworking the paragraph dialog to MVC. I attach what I have now. It seems to work, but perhaps someone (Angus?) could have a look at it so that it may go in after 1.2. Thanks, Ed. mvcpar.dif.gz Description: GNU Zip compressed data

Small bug in paragraph dialog

2001-08-30 Thread Michael Schmitt
Hi, - In the paragraph layout dialog, it is possible to enter text in the "Below"/"Above" boxes even if the space is fixed (the text is swallowed immediately but nevertheless...) Michael -- == Michael Schmitt

Re: Paragraph dialog

2001-08-29 Thread Angus Leeming
On Wednesday 29 August 2001 15:42, Michael Schmitt wrote: > On Wed, 29 Aug 2001, Michael Schmitt wrote: > > > Hi, > > > > I am happy to see "Label width" back in the dialog! It was always there. Just invisible! > > Unfortunately, a bug has slipped in regarding "Line spacing". You can edit > > t

Re: Paragraph dialog

2001-08-29 Thread Michael Schmitt
On Wed, 29 Aug 2001, Michael Schmitt wrote: > Hi, > > I am happy to see "Label width" back in the dialog! > > Unfortunately, a bug has slipped in regarding "Line spacing". You can edit > the "size" field if "double" is activated (wrong) but you cannot do so if > "Other" is chosen (wrong, too) Ju

Paragraph dialog

2001-08-29 Thread Michael Schmitt
Hi, I am happy to see "Label width" back in the dialog! Unfortunately, a bug has slipped in regarding "Line spacing". You can edit the "size" field if "double" is activated (wrong) but you cannot do so if "Other" is chosen (wrong, too) Michael -- ==