John Spray <[EMAIL PROTECTED]> writes:

| On Wed, 2004-09-29 at 15:25, Lars Gullik Bjønnes wrote:
>> Two newlines between functions please.
| That one doesn't seem to be in the Rules document, maybe you should add
| it.
>
>> drop the if. (and change to use a smart pointer)
| Confession time: I have no idea about smart pointers.  I've looked at
| the boost docs, and I don't Get It.  I see what they're for and why
| they're useful, but I don't understand how to use them.  It would help
| if you could point out exactly how to use the boost pointers in this
| particular situation (since I'm bound to run into very similar
| circumstances in other cases).
>
>> Do you really need it to be a pointer at all?
| I need to construct it with arguments.  Is it possible to do that
| without instantiating it on the heap?  Recall that I'm not very
| C++-experienced.
>
>> Why not call manage on it?
| Because manage is for widgets in containers: it frees the object when
| the container that it's packed into is destroyed.

I think I'll just set up cvs access for you, so that you can commit
the patches yourself. But please send the patches to the list for
review anyway.

I'll send you the info privately.

-- 
        Lgb

Reply via email to