John Spray <[EMAIL PROTECTED]> writes:
| /**
| * \file GParagraph.C
| * This file is part of LyX, the document processor.
| * Licence details can be found in the file COPYING.
| *
| * \author John Spray
| *
| * Full author contact details are available in file CREDITS.
| */
>
| #include <config.h>
>
| #include "GParagraph.h"
| #include "ControlParagraph.h"
>
| #include "ghelpers.h"
| #include <gtkmm.h>
>
| #include "controllers/helper_funcs.h"
>
| #include "ParagraphParameters.h"
| #include "Spacing.h"
>
| #include "support/lstrings.h"
| #include "support/tostr.h"
>
| #include "lyx_forms.h"
Order the includes please.
1. <config.h> first
2. Then order includes in a most local -> most distant kind of way.
(least general to most general)
And you already include gtkmm.h in the .h file.
| GParagraph::GParagraph(Dialog & parent)
| : GViewCB<ControlParagraph, GViewGladeB>(parent, _("Paragraph Settings"),
false)
| {}
>
| GParagraph::~GParagraph()
Two newlines between functions please.
| {
| if (spacingadj_)
| delete spacingadj_;
drop the if. (and change to use a smart pointer)
Why not call manage on it?
| //This is deleted in destructor
| spacingadj_ = new Gtk::Adjustment(1.0f,0.0f,20.0f,0.1f);
| spacingspin_->set_adjustment(*spacingadj_);
| //Load status from controller
space after //
(several places missing space)
| void GParagraph::onDefaultSpacingToggled()
| {
| if (defaultspacingcheck_->get_active()) {
| spacingspin_->set_sensitive(false);
| Spacing const spacing(Spacing::Default, spacingadj_->get_value());
| controller().params().spacing(spacing);
| }
| else {
use "} else {" please
--
Lgb
