Quoting Richard Heck <[EMAIL PROTECTED]>: > [EMAIL PROTECTED] wrote: > >> One question: I would have preferred to make QParagraph::radioMap const > >> but couldn't, because it can only be populated after the dialog is > >> created. Any other ideas? > >> > > I think we don't really need this QPRadioMap. We have only 4 radio buttons, > why > > don't you access them directly instead? > > > I had it that way before, and there were switch statements everywhere. > My thought was that, if we ever managed to figure out what > LYX_ALIGN_SPECIAL was for, or created a new alignment, it would be > easier to maintain the code this way. The thing I can do, of course, is > use const_iterators, which I've done.
OK. > > Thanks for the other comments, and for applying them yourself. It had > occurred to me that the getAlignmentFromDialog routine might be better > off in QParagraphDialog, but the extant division of labor between that > file and QParagraph isn't as clean as it might be, so I wasn't sure. Don't worry about that now. Considering the current spaghetti between QParagraphDialog and QParagraph, it is as good as it can get. FYI, I've started the cleanup of this dialog. This consists basically in getting rid of QParagraph and using ControlParagraph directly. I'll send it once I've something that compile. > > I'll apply this once I've tested it a bit. OK. Abdel.
