[EMAIL PROTECTED] wrote: >> One question: I would have preferred to make QParagraph::radioMap const >> but couldn't, because it can only be populated after the dialog is >> created. Any other ideas? >> > I think we don't really need this QPRadioMap. We have only 4 radio buttons, > why > don't you access them directly instead? > I had it that way before, and there were switch statements everywhere. My thought was that, if we ever managed to figure out what LYX_ALIGN_SPECIAL was for, or created a new alignment, it would be easier to maintain the code this way. The thing I can do, of course, is use const_iterators, which I've done.
Thanks for the other comments, and for applying them yourself. It had occurred to me that the getAlignmentFromDialog routine might be better off in QParagraphDialog, but the extant division of labor between that file and QParagraph isn't as clean as it might be, so I wasn't sure. I'll apply this once I've tested it a bit. Richard -- ================================================================== Richard G Heck, Jr Professor of Philosophy Brown University http://frege.brown.edu/heck/ ================================================================== Get my public key from http://sks.keyserver.penguin.de Hash: 0x1DE91F1E66FFBDEC Learn how to sign your email using Thunderbird and GnuPG at: http://dudu.dyn.2-h.org/nist/gpg-enigmail-howto
