José Matos wrote:
On Tuesday 06 March 2007 5:49:50 pm Abdelrazak Younes wrote:
Dear Jose,
Here is the proposed patch. There's still one bug remaining in the
type's list but it should be easy to solve.
I propose to commit the safe part now (everything that is not in qt4)
and, when the above bug
José Matos wrote:
On Tuesday 06 March 2007 5:49:50 pm Abdelrazak Younes wrote:
Dear Jose,
Here is the proposed patch. There's still one bug remaining in the
type's list but it should be easy to solve.
I propose to commit the safe part now (everything that is not in qt4)
and, when the above bug
On Tuesday 06 March 2007 5:49:50 pm Abdelrazak Younes wrote:
> Dear Jose,
>
> Here is the proposed patch. There's still one bug remaining in the
> type's list but it should be easy to solve.
>
> I propose to commit the safe part now (everything that is not in qt4)
> and, when the above bug is solve
Angus Leeming <[EMAIL PROTECTED]> writes:
> > Another feature request: update the toc on buffer-switch instead of
> > hiding it.
>
> Note that the infrastructure for this one is in place already. You just need
> to tell frontends\Dialogs.C that this is an updateable dialog rather than a
> hidea
Abdelrazak Younes <[EMAIL PROTECTED]> writes:
> Another feature request: update the toc on buffer-switch instead of
> hiding it.
Note that the infrastructure for this one is in place already. You just need
to tell frontends\Dialogs.C that this is an updateable dialog rather than a
hideable one.
Here is an updated patch that solve
Leuven, E. wrote:
it is very nice!
a couple of comments (using the user guide):
initially the level expansion of the tree does not match the slider
this more or less
initially the type combo is empty
this
when switching to type = table i can switch
Leuven, E. wrote:
lyx crashes when openinc the toc with an empty doc
Sorry, I forgot to include the attached change in the former patch...
Abdel.
Index: lyxfunc.C
===
--- lyxfunc.C (revision 17409)
+++ lyxfunc.C (working copy)
lyx crashes when openinc the toc with an empty doc
-Original Message-
From: news on behalf of Abdelrazak Younes
Sent: Wed 3/7/07 16:26
To: lyx-devel@lists.lyx.org
Subject: [Updated Patch] Toc dialog cleanup and a few other things
Abdelrazak Younes wrote:
> Dear Jose,
>
> He
Abdelrazak Younes wrote:
Dear Jose,
Here is the proposed patch. There's still one bug remaining in the
type's list but it should be easy to solve.
I propose to commit the safe part now (everything that is not in qt4)
and, when the above bug is solved, commit the rest.
Here are the main dif
Leuven, E. wrote:
it is very nice!
I think so too :-)
a couple of comments (using the user guide):
initially the level expansion of the tree does not match the slider
Known bug.
initially the type combo is empty
Known bug.
when switching to type = table i can switch to table 1 and
Younes
Sent: Tue 3/6/07 18:49
To: lyx-devel@lists.lyx.org
Subject: [Patch] Toc dialog cleanup
Dear Jose,
Here is the proposed patch. There's still one bug remaining in the
type's list but it should be easy to solve.
I propose to commit the safe part now (everything that is not in qt4)
Dear Jose,
Here is the proposed patch. There's still one bug remaining in the
type's list but it should be easy to solve.
I propose to commit the safe part now (everything that is not in qt4)
and, when the above bug is solved, commit the rest.
I won't work on this until tomorrow evening so,
Leuven, E. wrote:
Excellent Edwin, you're a master!
what are u then?
:-)
I know, I should RTFM but what is the trick?
cast a magic spell i learned from harry potter himself.
some - second rate wizards - have claimed that selecting the base
widget (clicking on it) and then layout in a g
> Excellent Edwin, you're a master!
what are u then?
> I know, I should RTFM but what is the trick?
cast a magic spell i learned from harry potter himself.
some - second rate wizards - have claimed that selecting the base widget
(clicking on it) and then layout in a grid (ctrl+5) also works un
Leuven, E. wrote:
something like the attached?
Excellent Edwin, you're a master!
I know, I should RTFM but what is the trick?
Abdel.
> Edwin! I knew I forgot someone in my call for help ;-)
i am not much help these days, but i still manage to lurk ;-)
Leuven, E. wrote:
Edwin! I knew I forgot someone in my call for help ;-)
something like the attached?
I'll try that, thanks.
Abdel.
something like the attached?
-Original Message-
From: news on behalf of Abdelrazak Younes
Sent: Tue 3/6/07 16:11
To: lyx-devel@lists.lyx.org
Subject: Re: [Patch] TOC Dialog crashes with empty toc list
José Matos wrote:
> On Monday 05 March 2007 6:27:26 pm Abdelrazak Younes wr
Bernhard Roider wrote:
Abdelrazak Younes wrote:
Bernhard Roider wrote:
Hello,
i found a crash when one of the buttons in the TOC dialog is pressed
if the TOC is empty. The attached patch disables the buttons if there
are no entries in the TOC dialog. To be safe it also adds a test to
the bu
Abdelrazak Younes wrote:
Bernhard Roider wrote:
Hello,
i found a crash when one of the buttons in the TOC dialog is pressed
if the TOC is empty. The attached patch disables the buttons if there
are no entries in the TOC dialog. To be safe it also adds a test to
the button handler functions w
On Monday 05 March 2007 6:27:26 pm Abdelrazak Younes wrote:
> > How much time do you need?
>
> A few days...
Granted. :-)
> > I suggested the freeze with a very small window of commit time
> > remaining. I am aware that it is not nice to change the rules in the
> > middle of the game, that
José Matos wrote:
On Monday 05 March 2007 4:47:31 pm Abdelrazak Younes wrote:
Hello Bernhard,
I don't know if you are planning to commit this one but I wanted to let
you know that I integrated your changes already in my local tree. I am
basically rewriting a good part of this code and I hope th
On Monday 05 March 2007 4:47:31 pm Abdelrazak Younes wrote:
> Hello Bernhard,
>
> I don't know if you are planning to commit this one but I wanted to let
> you know that I integrated your changes already in my local tree. I am
> basically rewriting a good part of this code and I hope that it will b
Bernhard Roider wrote:
Hello,
i found a crash when one of the buttons in the TOC dialog is pressed if
the TOC is empty. The attached patch disables the buttons if there are
no entries in the TOC dialog. To be safe it also adds a test to the
button handler functions whether the list has entrie
Lars Gullik Bjønnes wrote:
Abdelrazak Younes <[EMAIL PROTECTED]> writes:
| Lars Gullik Bjønnes wrote:
| > Abdelrazak Younes <[EMAIL PROTECTED]> writes:
| > | Lars Gullik Bjønnes wrote:
| > | > Bernhard Roider <[EMAIL PROTECTED]> writes:
| > | | > | @@ -150,9 +153,12 @@
| > | > | void QTocDialog
Abdelrazak Younes <[EMAIL PROTECTED]> writes:
| Lars Gullik Bjønnes wrote:
| > Abdelrazak Younes <[EMAIL PROTECTED]> writes:
| > | Lars Gullik Bjønnes wrote:
| > | > Bernhard Roider <[EMAIL PROTECTED]> writes:
| > | | > | @@ -150,9 +153,12 @@
| > | > | void QTocDialog::on_moveDownPB_clicked()
| >
Lars Gullik Bjønnes wrote:
Abdelrazak Younes <[EMAIL PROTECTED]> writes:
| Lars Gullik Bjønnes wrote:
| > Bernhard Roider <[EMAIL PROTECTED]> writes:
|
| > | @@ -150,9 +153,12 @@
| > | void QTocDialog::on_moveDownPB_clicked()
| > | {
| > same comment
|
| Same comment to what?
So you didn'
Abdelrazak Younes <[EMAIL PROTECTED]> writes:
| Lars Gullik Bjønnes wrote:
| > Bernhard Roider <[EMAIL PROTECTED]> writes:
|
| > | @@ -150,9 +153,12 @@
| > | void QTocDialog::on_moveDownPB_clicked()
| > | {
| > same comment
|
| Same comment to what?
So you didn't read the patch did you?
| Wh
Lars Gullik Bjønnes wrote:
Bernhard Roider <[EMAIL PROTECTED]> writes:
| @@ -150,9 +153,12 @@
| void QTocDialog::on_moveDownPB_clicked()
| {
same comment
Same comment to what?
| @@ -160,9 +166,12 @@
| void QTocDialog::on_moveInPB_clicked()
| {
same comment
ditto
| @@ -170,9 +17
Lars Gullik Bjønnes wrote:
A space after '&' as well please.
Also; can list be a const reference?
it can be a const reference --> new patch attached - now really
Does the enableButtons() have a default arg?
If that is our own function I think it should be removed so that have
to use true/
Lars Gullik Bjønnes wrote:
A space after '&' as well please.
Also; can list be a const reference?
it can be a const reference --> new patch attached
Does the enableButtons() have a default arg?
If that is our own function I think it should be removed so that have
to use true/false explict
Bernhard Roider <[EMAIL PROTECTED]> writes:
| Hello,
|
| i found a crash when one of the buttons in the TOC dialog is pressed
| if the TOC is empty. The attached patch disables the buttons if there
| are no entries in the TOC dialog. To be safe it also adds a test to
| the button handler function
Hello,
i found a crash when one of the buttons in the TOC dialog is pressed if the TOC is empty. The
attached patch disables the buttons if there are no entries in the TOC dialog. To be safe it also
adds a test to the button handler functions whether the list has entries before accessing the on
I had a chance to have a look at the bug in Toc dialog. I guess I
found the source of the error.
When the updateGui is called, the function
ControlToc::getCurrentTocItem() is called. In this routine, item is
turned by
kernel().buffer().tocBackend().item(type,ParConstIterator it);
and ParConstI
Bo Peng wrote:
Good, then apply it ;-)
The patch looks simple but I do not know that part of the code. Please
evaluate the implementation, modify and apply it. It would be best if
the 'click and move' problem Juergen and I noticed can be corrected.
OK, I've taken the time to review it and to
Good, then apply it ;-)
The patch looks simple but I do not know that part of the code. Please
evaluate the implementation, modify and apply it. It would be best if
the 'click and move' problem Juergen and I noticed can be corrected.
Cheers,
Bo
Juergen Spitzmueller wrote:
sending this again, since it doesn't seem to get through first time. Sorry for
potential double posting.
Ozgur Ugras BARAN wrote:
No problem Abdel and thanks Edwin.. To reduce confusion, I have
attached the patch.
I have tested the patch now, and it seems to fix t
Ozgur Ugras BARAN wrote:
> No problem Abdel and thanks Edwin.. To reduce confusion, I have
> attached the patch.
I have tested the patch now, and it seems to fix the remaining issues (and
yes, Abdel, this *is* an improvement ui-wise).
The only remaining glitch I see is that the tree position is
sending this again, since it doesn't seem to get through first time. Sorry for
potential double posting.
Ozgur Ugras BARAN wrote:
> No problem Abdel and thanks Edwin.. To reduce confusion, I have
> attached the patch.
I have tested the patch now, and it seems to fix the remaining issues (and
ye
Thanks, Bo. Juergen, can you also test it, to see if it is enough for
your taste? At the end, you were the one who asked for the feature.
I am not sure if this exists before the patch, but when I click on any
item, it moves to the end of the dialog. This is very distracting
since I have to re-re
Abdelrazak Younes wrote:
> Only the current top level node is opened. The lower lower level child
> nodes are kept closed. You can navigate (including collapse/open) quite
> easily using the arrow keys. I'd say that this is quicker that to use
> the mouse on the slider.
How? It can't seem to make
Ozgur Ugras BARAN wrote:
> Thanks, Bo. Juergen, can you also test it, to see if it is enough for
> your taste? At the end, you were the one who asked for the feature.
Yes. However, probably not before next week.
Jürgen
Abdel, IMO, the last patch makes the TOC slider very useful.
Otherwise, TOC collapses everytime you change the section, which is
very annoying.
On 11/22/06, Bo Peng <[EMAIL PROTECTED]> wrote:
> Sorry Ugras, but I don't have much time today to test your patch. I
> suggest that you send again the
Sorry Ugras, but I don't have much time today to test your patch. I
suggest that you send again the full patch. Then, maybe someone else can
test and commit for you (Edwin, Bo, Georg?). If not, I'll try to do that
at the end of the week.
I heard my name being called. OK, I will try this patch du
Juergen Spitzmueller wrote:
Abdelrazak Younes wrote:
The more I think about it, the more I think this slider is not useful
for any purpose in the Toc dialog. In the former qt3 dialog, the slider
was useful because the nodes won't collapse/open automatically when you
navigate within the document.
Abdelrazak Younes wrote:
> The more I think about it, the more I think this slider is not useful
> for any purpose in the Toc dialog. In the former qt3 dialog, the slider
> was useful because the nodes won't collapse/open automatically when you
> navigate within the document. This is not the case w
Abdelrazak Younes wrote:
Ozgur Ugras BARAN wrote:
On 11/17/06, Abdelrazak Younes <[EMAIL PROTECTED]>
wrote:
Ozgur Ugras BARAN wrote:
> attached patch implement slider in TOC dialog.
>
> I have implemented a getDepth function to get the model indices. In my
> opinion, somebody should derive a ne
Ozgur Ugras BARAN wrote:
On 11/17/06, Abdelrazak Younes <[EMAIL PROTECTED]>
wrote:
Ozgur Ugras BARAN wrote:
> attached patch implement slider in TOC dialog.
>
> I have implemented a getDepth function to get the model indices. In my
> opinion, somebody should derive a new qvariant class for tocMo
On 11/17/06, Abdelrazak Younes <[EMAIL PROTECTED]> wrote:
Ozgur Ugras BARAN wrote:
> attached patch implement slider in TOC dialog.
>
> I have implemented a getDepth function to get the model indices. In my
> opinion, somebody should derive a new qvariant class for tocModelItem
> which saves the
Ozgur Ugras BARAN wrote:
attached patch implement slider in TOC dialog.
I have implemented a getDepth function to get the model indices. In my
opinion, somebody should derive a new qvariant class for tocModelItem
which saves the string data and depth information. that will save the
depth calcula
On 11/17/06, Jean-Marc Lasgouttes <[EMAIL PROTECTED]> wrote:
> "Ozgur" == Ozgur Ugras BARAN <[EMAIL PROTECTED]> writes:
Ozgur> In short, there is something weird in cursor control for table
Ozgur> floats. (other floats does not have the same problem).
Is it with table floats themselves, or
On 11/17/06, Abdelrazak Younes <[EMAIL PROTECTED]> wrote:
Ozgur Ugras BARAN wrote:
> attached patch implement slider in TOC dialog.
>
> I have implemented a getDepth function to get the model indices. In my
> opinion, somebody should derive a new qvariant class for tocModelItem
> which saves the
> "Ozgur" == Ozgur Ugras BARAN <[EMAIL PROTECTED]> writes:
Ozgur> In short, there is something weird in cursor control for table
Ozgur> floats. (other floats does not have the same problem).
Is it with table floats themselves, or table insets?
JMarc
On 11/16/06, Abdelrazak Younes <[EMAIL PROTECTED]> wrote:
Ozgur Ugras BARAN wrote:
> Following patch corrects some misbehavior in TOC dialog:
>
> - When clicking on Toc insets, dialog switches to correct list.
> - cursor goes to correct entry when clicked..
> - some other fixes..
I have tested a
Ozgur Ugras BARAN wrote:
attached patch implement slider in TOC dialog.
I have implemented a getDepth function to get the model indices. In my
opinion, somebody should derive a new qvariant class for tocModelItem
which saves the string data and depth information. that will save the
depth calcula
Quoting Ozgur Ugras BARAN <[EMAIL PROTECTED]>:
> On 11/16/06, Abdelrazak Younes <[EMAIL PROTECTED]> wrote:
> > Ozgur Ugras BARAN wrote:
> > > Following patch corrects some misbehavior in TOC dialog:
> > >
> > > - When clicking on Toc insets, dialog switches to correct list.
> > > - cursor goes to
attached patch implement slider in TOC dialog.
I have implemented a getDepth function to get the model indices. In my
opinion, somebody should derive a new qvariant class for tocModelItem
which saves the string data and depth information. that will save the
depth calculation.
I'll be glad somebo
Thanks, Abdel..
Ugras
On 11/16/06, Abdelrazak Younes <[EMAIL PROTECTED]> wrote:
Ozgur Ugras BARAN wrote:
> Following patch corrects some misbehavior in TOC dialog:
>
> - When clicking on Toc insets, dialog switches to correct list.
> - cursor goes to correct entry when clicked..
> - some other
Ozgur Ugras BARAN wrote:
Following patch corrects some misbehavior in TOC dialog:
- When clicking on Toc insets, dialog switches to correct list.
- cursor goes to correct entry when clicked..
- some other fixes..
I have tested and committed the patch. Thanks Ugras.
There is one strange prob
Ozgur Ugras BARAN wrote:
Following patch corrects some misbehavior in TOC dialog:
- When clicking on Toc insets, dialog switches to correct list.
- cursor goes to correct entry when clicked..
- some other fixes..
This looks good at first glance.
There is one strange problem, though. After c
Following patch corrects some misbehavior in TOC dialog:
- When clicking on Toc insets, dialog switches to correct list.
- cursor goes to correct entry when clicked..
- some other fixes..
There is one strange problem, though. After clicking table toc
entries, cursor goes to correct table, but th
61 matches
Mail list logo
