On 11/17/06, Abdelrazak Younes <[EMAIL PROTECTED]> wrote:
Ozgur Ugras BARAN wrote:
> attached patch implement slider in TOC dialog.
>
> I have implemented a getDepth function to get the model indices. In my
> opinion, somebody should derive a new qvariant class for tocModelItem
> which saves the string data and depth information. that will save the
> depth calculation.
But is that somebody you? ;-)
Most likely that somebody is me.. But I cannot guarantee that it will
happen before or after the military service ;-)
Anyway, as long as it works now with your patch, this kind cleanup can
wait for 1.6. I've added a FIXME with your idea.
>
> I'll be glad somebody see and commit the patch, please..
I'm on it. Looks good so far.
> By the way there are some items left in the Status15 concerning TOC dialog.
>
> * TOC crashes (simply make a few sections, subsections, sections; then
> add TOC
> before all sections and click on the left button)
> --- Is this happen anymore?
I don't think so, I've fixed that but I forgot to update the Status.
Then, I skip this..
> In my case, only lot creates problem,
> however, as I reported earlier, this has nothing to do with the TOC
> dialog, but a cursor position bug.
Yes but the report was sent to me only... see my other mail.
I forwarded the old mail.. sorry for the confusion.
>
> * Items in the TOC cannot be moved using drag & drop (Joost 4/11/06).
> --- Do we need this feature? and what will this feature supposed to
> do? just replace the titles in the text, or, replace whole sections?
Move whole section and inner subsections as well.
whoa!
> I
> think both are confusing and should be avoided..
They are just candy, one can manage to do exactly what he wants with the
current feature set. This is not 1.5 material anyway.
Then, I skip this one too... A candy can be developed during the lyx
1.5 lifecycle, too.
>
> * In TOC, the buttons "Up", "Down", "Promote", and "Demote" are not
> self-explaining. Why don't we group them in two pairs: Section Up/Down,
> Level
> Up/Down? The arrangement of the buttons may also give some hint to the
> user.
Good Idea.
> --- some arrow glyphs should be enough IMO.
The advantage of text is that you can use keyboard shortcuts.
> Or, If you have a mockup
> showing what you want exactly, I can implement it.
>
> * The items in the treeview are editable
> --- There is something fishy there.. I'm trying to fix it..
Good luck.
thanks..
>
> * When content (sections/captions) is changed, the toc/lof/lot is not
> properly
> updated.
> --- Ah yes, because, tocbackend is not updated while you are typing.
> But the correct signal arrives to TOC dialog. The toc is updated only
> when a new section etc. inserted. This change is immediately becomes
> visible. Abdel, you were dealing with the TocBackend recently. Any
> ideas on that?
I am not sure this is easily solvable. Basically this means that
TocBackend::update() should be called automatically if one edits a
section title. This is tricky and I would tend to say that this should
be classified as a known issue for now.
Good work Ugras.
Abdel.
Well, if we had this, i would easily implement editable selection in
toc dialog. This is not a grave bug, but just annoying one. I guess
we'll have to wait a bit to solve this problem.
Thanks a lot Abdel.
Ugras
