Re: Delete character with alert style crashes lyx.

2007-05-31 Thread Alfredo Braunstein
Bo Peng wrote: >> > >> > I guess I need a more detailed description to reproduce it... >> >> abcdefgh1w >> >> Now do whatever is necessary in your environmet to switch back to the >> first window. > > I see. I need to remove enough chars to make pos > size in the old window. I think something al

Re: [patch] crash fix [was: Re: [patch] RTL cursor display on inset edges]

2007-05-31 Thread Stefan Schimanski
We're redrawing the whole thing, too? Is *that* necessary after every backspace?! Everything = the paragraph. That are the rules of the games currently. I and others have ideas to speed up the drawing considerable for 1.6. Stefan PGP.sig Description: Signierter Teil der Nachricht

Re: Scrolling lag in 1.5svn again, more details.

2007-05-31 Thread Peter Kümmel
Lars Gullik Bjønnes wrote: > Peter Kümmel <[EMAIL PROTECTED]> writes: > > | Peter Kümmel wrote: > | >> | Or happens the dropping only to auto repeated keys? > | >> > | >> Only auto-repeated keys. > | > > | > OK, if you are really sure only auto-repeated keys will be dropped, > | > I think your pa

Re: Release candidate 1 (pre-announce)

2007-05-31 Thread Bo Peng
On 5/31/07, José Matos <[EMAIL PROTECTED]> wrote: Hi, I have tagged the first release candidate for 1.5.0. I have placed the release in the usual place http://www.lyx.org/~jamatos/lyx-1.5/ If there are no last minute problems these packages will be moved to the official place and

Release candidate 1 (pre-announce)

2007-05-31 Thread José Matos
Hi, I have tagged the first release candidate for 1.5.0. I have placed the release in the usual place http://www.lyx.org/~jamatos/lyx-1.5/ If there are no last minute problems these packages will be moved to the official place and a public announcement will be made. Reg

Re: Farsi support re-submission plus a little more

2007-05-31 Thread Uwe Stöhr
Dov Feldstern schrieb: I hereby grant permission to license my contributions to LyX under the GNU General Public License version 2 or later. You can put me as "RTL-related fixes" Thanks, I added you to the credits. regards Uwe

[PATCH] Recover Caption support for tex2lyx and several other enhancements for tex2lyx

2007-05-31 Thread hzluo
Figure/Table caption support is broken in new version. Please see bug: http://bugzilla.lyx.org/show_bug.cgi?id=3750 I implemented a dirty workaround by manually inserting a Caption inset. Details can be found in my reply for that bug. And my patch has several other enhancements: (1) Support for

Re: Farsi support re-submission plus a little more

2007-05-31 Thread Dov Feldstern
Uwe Stöhr wrote: Dov Feldstern schrieb: Could you add me, too, once you're at it? I don't think I'm in there, either... Of course, when you tell me what you have contributed and when you send me a link to your GPL statement in the lyx-devel list in this mail archive: http://marc.info/?l=lyx

Re: Farsi support re-submission plus a little more

2007-05-31 Thread Uwe Stöhr
Dov Feldstern schrieb: Could you add me, too, once you're at it? I don't think I'm in there, either... Of course, when you tell me what you have contributed and when you send me a link to your GPL statement in the lyx-devel list in this mail archive: http://marc.info/?l=lyx-devel regards Uw

Re: Scrolling lag in 1.5svn again, more details.

2007-05-31 Thread José Matos
On Thursday 31 May 2007 22:05:31 Lars Gullik Bjønnes wrote: > Yes, quite sure > > + if (e->isAutoRepeat()) { > +  ... > + } Could you shove it in, please? > -- > Lgb -- José Abílio

Re: Farsi support re-submission plus a little more

2007-05-31 Thread Uwe Stöhr
> Uwe, Mostafa's a veteran... http://permalink.gmane.org/gmane.editors.lyx.devel/82156 Oops. I asked because he is currently not listed in our credits. I'll add him now. thanks and regards Uwe

Re: [PATCH] Allow key=value,key=value1 in listings params.

2007-05-31 Thread José Matos
On Thursday 31 May 2007 22:20:59 Bo Peng wrote: > Currently, key=value,key=value1 is disallowed but this is a valid > usage of listings parameters. (e.g. emph={key1},emph={key2} ) The > attached patch fixes this. OK to apply? Jose? > > Bo OK. -- José Abílio

Re: Scrolling lag in 1.5svn again, more details.

2007-05-31 Thread Lars Gullik Bjønnes
Peter Kümmel <[EMAIL PROTECTED]> writes: | Peter Kümmel wrote: | >> | Or happens the dropping only to auto repeated keys? | >> | >> Only auto-repeated keys. | > | > OK, if you are really sure only auto-repeated keys will be dropped, | > I think your patch should go into RC1. | | BUT, I also had

Re: Farsi support re-submission plus a little more

2007-05-31 Thread Dov Feldstern
Uwe Stöhr wrote: Hello Mostafa, your patch has been applied by José. Many thanks for your work! Would you agree to publish your work together with LyX under the GPL license version 2 or later? If yes, then please reply an email to this list where you state this: "Hereby I grant permission t

Re: Scrolling lag in 1.5svn again, more details.

2007-05-31 Thread Peter Kümmel
Lars Gullik Bjønnes wrote: > Peter Kümmel <[EMAIL PROTECTED]> writes: > > | Lars Gullik Bjønnes wrote: > | > Peter Kümmel <[EMAIL PROTECTED]> writes: > | > > | > | > If you go aab > | > | > then the b, might be dropped. I have not tested. > | > | > > | > | > B

[PATCH] Allow key=value,key=value1 in listings params.

2007-05-31 Thread Bo Peng
Currently, key=value,key=value1 is disallowed but this is a valid usage of listings parameters. (e.g. emph={key1},emph={key2} ) The attached patch fixes this. OK to apply? Jose? Bo Index: src/insets/InsetListingsParams.cpp === --- sr

Re: [patch] crash fix [was: Re: [patch] RTL cursor display on inset edges]

2007-05-31 Thread Dov Feldstern
Dov Feldstern wrote: Stefan Schimanski wrote: Am 31.05.2007 um 22:27 schrieb Stefan Schimanski: The patch: Index: src/Text.cpp === --- src/Text.cpp(Revision 18599) +++ src/Text.cpp(Arbeitskopie) @@ -1330,8 +1331,10 @@

Re: [PATCH-again] Bugs 3741 and 3756: Citation Dialog Bugs

2007-05-31 Thread Lars Gullik Bjønnes
Andre Poenitz <[EMAIL PROTECTED]> writes: | On Thu, May 31, 2007 at 10:08:18PM +0200, Lars Gullik Bjønnes wrote: | > Richard Heck <[EMAIL PROTECTED]> writes: | > | > | Andre Poenitz wrote: | > | > On Thu, May 31, 2007 at 09:12:56PM +0200, Peter Kümmel wrote: | > | > | > | >>> I tried to do someth

Re: RTL question: What is right?

2007-05-31 Thread Dov Feldstern
Stefan, you are aware of http://permalink.gmane.org/gmane.editors.lyx.devel/80783 and http://permalink.gmane.org/gmane.editors.lyx.devel/81100, right? Do they answer your questions? (It's a little hard to tell in your images what the differences are...) Stefan Schimanski wrote: For those who

Re: [patch - different approach] parbox with only width setting, automatic height gets height 0pt (lyx 1.5)

2007-05-31 Thread Micha Feigin
On Thu, 31 May 2007 13:20:16 +0100 José Matos <[EMAIL PROTECTED]> wrote: > On Tuesday 22 May 2007 13:00:35 Micha Feigin wrote: > > > > The patch is attached. > > What is the status of this patch? Would you like us to consider this to rc2 > or to 1.5.x (x>0)? > > > Micha > As far as I'm conc

Re: Scrolling lag in 1.5svn again, more details.

2007-05-31 Thread Peter Kümmel
Peter Kümmel wrote: >> | Or happens the dropping only to auto repeated keys? >> >> Only auto-repeated keys. > > OK, if you are really sure only auto-repeated keys will be dropped, > I think your patch should go into RC1. BUT, I also had a Qt based patch which only discards auto repeated keys, and

Re: [patch] crash fix [was: Re: [patch] RTL cursor display on inset edges]

2007-05-31 Thread Dov Feldstern
Stefan Schimanski wrote: Am 31.05.2007 um 22:54 schrieb Dov Feldstern: Stefan Schimanski wrote: Am 31.05.2007 um 22:27 schrieb Stefan Schimanski: The patch: Index: src/Text.cpp === --- src/Text.cpp(Revision 18599) +++ src

Re: Farsi version of splash.lyx

2007-05-31 Thread Uwe Stöhr
>> Attached find the file splash.lyx which is the translation of the English >> version into Farsi. > > Could you, please, update the patch to support Farsi? Specifically the patch > to Encoding does not apply cleanly anymore... José, you committed the Farsi patch so I think you should also com

Re: Scrolling lag in 1.5svn again, more details.

2007-05-31 Thread Lars Gullik Bjønnes
Peter Kümmel <[EMAIL PROTECTED]> writes: | Lars Gullik Bjønnes wrote: | > Peter Kümmel <[EMAIL PROTECTED]> writes: | > | > | > If you go aab | > | > then the b, might be dropped. I have not tested. | > | > | > | > But sure, quite a few will be dropped. (w

Re: Farsi support re-submission plus a little more

2007-05-31 Thread Uwe Stöhr
Hello Mostafa, your patch has been applied by José. Many thanks for your work! Would you agree to publish your work together with LyX under the GPL license version 2 or later? If yes, then please reply an email to this list where you state this: "Hereby I grant permission to license my contri

Re: [PATCH] Bug 3313 - Exporting unicode to LyX1.4

2007-05-31 Thread Anders Ekberg
José Matos Thu, 31 May 2007 08:26:07 -0700 On Thursday 31 May 2007 10:08:31 Anders Ekberg wrote: > Hi! > > Attached find a patch that aims to (at least partly) solve bug 3313. > Currently, an attempt to export a document containing any unicode > character (for example an en dash) to LyX1.4 result

Re: [patch] crash fix [was: Re: [patch] RTL cursor display on inset edges]

2007-05-31 Thread Dov Feldstern
Stefan Schimanski wrote: Am 31.05.2007 um 22:27 schrieb Stefan Schimanski: The patch: Index: src/Text.cpp === --- src/Text.cpp(Revision 18599) +++ src/Text.cpp(Arbeitskopie) @@ -1330,8 +1331,10 @@ checkBufferStruc

Re: [patch] RTL cursor display on inset edges

2007-05-31 Thread Stefan Schimanski
For those who want to try it out (for reference please look at the single patches), here is everything together in one patch. Stefan rtl.patch Description: Binary data As always, Stefan, you are right :) . I applied your patch (what threw me off was what you said about including anothe

Re: [patch] crash fix [was: Re: [patch] RTL cursor display on inset edges]

2007-05-31 Thread Stefan Schimanski
Am 31.05.2007 um 22:54 schrieb Dov Feldstern: Stefan Schimanski wrote: Am 31.05.2007 um 22:27 schrieb Stefan Schimanski: The patch: Index: src/Text.cpp === --- src/Text.cpp(Revision 18599) +++ src/Text.cpp(Arbeitskopie)

Re: [patch] crash fix [was: Re: [patch] RTL cursor display on inset edges]

2007-05-31 Thread Dov Feldstern
Stefan Schimanski wrote: Am 31.05.2007 um 22:27 schrieb Stefan Schimanski: The patch: Index: src/Text.cpp === --- src/Text.cpp(Revision 18599) +++ src/Text.cpp(Arbeitskopie) @@ -1330,8 +1331,10 @@ checkBufferStruc

RTL question: What is right?

2007-05-31 Thread Stefan Schimanski
For those who know the bidi mechanisms in tex (I cannot compile the example on my system, fonts missing...): Bild 4.png Description: application/applefile <> Bild 6.png Description: application/applefile <> What makes more sense? Explanation: It's about the spaces. In the first example the

Re: [patch] crash fix [was: Re: [patch] RTL cursor display on inset edges]

2007-05-31 Thread Dov Feldstern
Stefan Schimanski wrote: Ok, makes sense. The character then entered should be with the font of the character at that position. Stefan --- once you're at it, should Text2.cpp:768 (in setCurrentFont) be changed: - if ((pos > 0 && cur.boundary()) || pos == cur.lastpos()) --pos; + if

just a little thing i stumbled about

2007-05-31 Thread Bernhard Roider
Hello in void InsetMathNest::doDispatch(Cursor & cur, FuncRequest & cmd) is this still neccessary? case LFUN_SELF_INSERT: ... // Don't record undo steps if we are in macro mode and // cmd.argument is the next character of the macro name. //

Re: [PATCH-again] Bugs 3741 and 3756: Citation Dialog Bugs

2007-05-31 Thread Andre Poenitz
On Thu, May 31, 2007 at 10:08:18PM +0200, Lars Gullik Bjønnes wrote: > Richard Heck <[EMAIL PROTECTED]> writes: > > | Andre Poenitz wrote: > | > On Thu, May 31, 2007 at 09:12:56PM +0200, Peter Kümmel wrote: > | > > | >>> I tried to do something like this so I didn't have the same code in two > | >

Re: [patch] bug 2738: Wrong sorting of languages in Document dialog

2007-05-31 Thread Pavel Sanda
> Actually, I do not think that I like it much, in particular since we > do not use std::locale at other places? $ grep -r std::locale * |wc -l 55 > Isn't it possible to do the same with setlocale? I didn't get what you mean. How can I collate two strings using setlocale ? Or you mean to rewr

Re: Scrolling lag in 1.5svn again, more details.

2007-05-31 Thread Peter Kümmel
Lars Gullik Bjønnes wrote: > Peter Kümmel <[EMAIL PROTECTED]> writes: > > | > If you go aab > | > then the b, might be dropped. I have not tested. > | > > | > But sure, quite a few will be dropped. (which is just what we > | > want if we are too slow to ge

Re: [patch] crash fix [was: Re: [patch] RTL cursor display on inset edges]

2007-05-31 Thread Stefan Schimanski
Am 31.05.2007 um 22:27 schrieb Stefan Schimanski: The patch: Index: src/Text.cpp === --- src/Text.cpp(Revision 18599) +++ src/Text.cpp(Arbeitskopie) @@ -1330,8 +1331,10 @@ checkBufferStructure(cur.b

Re: [PATCH-again] Bugs 3741 and 3756: Citation Dialog Bugs

2007-05-31 Thread Andre Poenitz
On Thu, May 31, 2007 at 04:02:42PM -0400, Richard Heck wrote: > Andre Poenitz wrote: > >On Thu, May 31, 2007 at 09:12:56PM +0200, Peter Kümmel wrote: > > > >>>I tried to do something like this so I didn't have the same code in two > >>>places: > >>>QModelIndex & QCitationDialog::getSelectedIndex(

Re: [Patch] Re: Crash when closing document

2007-05-31 Thread Edwin Leuven
Andre Poenitz wrote: We want to get 1.5 out of the door. we all agree on that one Multiple views make LyX crash. Nobody is seemingly able to fix it in a reasonable time frame. you provided a reproducable way to crash lyx (being the responsible grown-up you are ;) let's see whether abdel or

Re: Scrolling lag in 1.5svn again, more details.

2007-05-31 Thread Lars Gullik Bjønnes
Peter Kümmel <[EMAIL PROTECTED]> writes: | > If you go aab | > then the b, might be dropped. I have not tested. | > | > But sure, quite a few will be dropped. (which is just what we | > want if we are too slow to get them in.) | > | | What if you have a

Re: [PATCH-again] Bugs 3741 and 3756: Citation Dialog Bugs

2007-05-31 Thread Andre Poenitz
On Thu, May 31, 2007 at 04:01:32PM -0400, Richard Heck wrote: > Peter Kümmel wrote: > >Richard Heck wrote: > > > >>I tried to do something like this so I didn't have the same code in two > >>places: > >>QModelIndex & QCitationDialog::getSelectedIndex(QListView *) { > >> QModelIndexList const sel

Re: [patch] crash fix [was: Re: [patch] RTL cursor display on inset edges]

2007-05-31 Thread Stefan Schimanski
The patch: Index: src/Text.cpp === --- src/Text.cpp(Revision 18599) +++ src/Text.cpp(Arbeitskopie) @@ -1330,8 +1331,10 @@ checkBufferStructure(cur.buffer(), cur); } - if (cur.pos() == cur

Re: Scrolling lag in 1.5svn again, more details.

2007-05-31 Thread Peter Kümmel
Lars Gullik Bjønnes wrote: > Peter Kümmel <[EMAIL PROTECTED]> writes: > > | Peter Kümmel wrote: > | > > | > And no keys will be dropped? > | > > | > We could also put in your patch, as it is only a problem on Linux. > | > Do you think we could use QApplication::synxX() instead of the X11 > | > c

Re: Scrolling lag in 1.5svn again, more details.

2007-05-31 Thread Peter Kümmel
Lars Gullik Bjønnes wrote: > Peter Kümmel <[EMAIL PROTECTED]> writes: > > | Lars Gullik Bjønnes wrote: > | > Peter Kümmel <[EMAIL PROTECTED]> writes: > | > > | > | José Matos wrote: > | > | > On Thursday 24 May 2007 18:17:37 Peter Kümmel wrote: > | > | >> The event_1 patch gives better results

Re: [patch] crash fix [was: Re: [patch] RTL cursor display on inset edges]

2007-05-31 Thread Stefan Schimanski
Am 31.05.2007 um 22:10 schrieb Dov Feldstern: Dov Feldstern wrote: Dov Feldstern wrote: Dov Feldstern wrote: Anyhow, to reproduce: 1) type a long long string with no space, until it breaks to the next line. 2) from the last position in the paragraph (it only works from there) start bac

Re: Scrolling lag in 1.5svn again, more details.

2007-05-31 Thread Lars Gullik Bjønnes
Peter Kümmel <[EMAIL PROTECTED]> writes: | Peter Kümmel wrote: | > | > And no keys will be dropped? | > | > We could also put in your patch, as it is only a problem on Linux. | > Do you think we could use QApplication::synxX() instead of the X11 | > call? | | The Qt code: | http://websvn.kde.o

Re: Scrolling lag in 1.5svn again, more details.

2007-05-31 Thread Lars Gullik Bjønnes
Peter Kümmel <[EMAIL PROTECTED]> writes: | Lars Gullik Bjønnes wrote: | > Peter Kümmel <[EMAIL PROTECTED]> writes: | > | > | José Matos wrote: | > | > On Thursday 24 May 2007 18:17:37 Peter Kümmel wrote: | > | >> The event_1 patch gives better results on systems | > | >> with a fast enough grap

[patch] crash fix [was: Re: [patch] RTL cursor display on inset edges]

2007-05-31 Thread Dov Feldstern
Dov Feldstern wrote: Dov Feldstern wrote: Dov Feldstern wrote: Anyhow, to reproduce: 1) type a long long string with no space, until it breaks to the next line. 2) from the last position in the paragraph (it only works from there) start backspacing. When you try to delete the last remaining

Re: [PATCH-again] Bugs 3741 and 3756: Citation Dialog Bugs

2007-05-31 Thread Lars Gullik Bjønnes
Richard Heck <[EMAIL PROTECTED]> writes: | Andre Poenitz wrote: | > On Thu, May 31, 2007 at 09:12:56PM +0200, Peter Kümmel wrote: | > | >>> I tried to do something like this so I didn't have the same code in two | >>> places: | >>> QModelIndex & QCitationDialog::getSelectedIndex(QListView *) { | >

Re: Scrolling lag in 1.5svn again, more details.

2007-05-31 Thread Peter Kümmel
Peter Kümmel wrote: > > And no keys will be dropped? > > We could also put in your patch, as it is only a problem on Linux. > Do you think we could use QApplication::synxX() instead of the X11 > call? The Qt code: http://websvn.kde.org/*checkout*/trunk/qt-copy/src/gui/kernel/qapplication_x11.cpp

Re: [patch] RTL cursor display on inset edges

2007-05-31 Thread Stefan Schimanski
Am 31.05.2007 um 21:57 schrieb Dov Feldstern: Dov Feldstern wrote: Dov Feldstern wrote: As always, Stefan, you are right :) . I applied your patch (what threw me off was what you said about including another patch --- which BTW, I would still commit separately). Then it didn't compile --

Re: Scrolling lag in 1.5svn again, more details.

2007-05-31 Thread Lars Gullik Bjønnes
José Matos <[EMAIL PROTECTED]> writes: | On Thursday 31 May 2007 20:50:54 Lars Gullik Bjønnes wrote: | > My patch works for all "key" variants. that is entered through | > auto-keying. Basically all key events that we failt to handle because | > auto-repeat is too fast are dropped. | | What is

Re: [PATCH-again] Bugs 3741 and 3756: Citation Dialog Bugs

2007-05-31 Thread Richard Heck
Andre Poenitz wrote: On Thu, May 31, 2007 at 09:12:56PM +0200, Peter Kümmel wrote: I tried to do something like this so I didn't have the same code in two places: QModelIndex & QCitationDialog::getSelectedIndex(QListView *) { QModelIndexList const selIdx = availableLV->selectionMode

Re: Delete character with alert style crashes lyx.

2007-05-31 Thread Bo Peng
> > I guess I need a more detailed description to reproduce it... abcdefgh1w Now do whatever is necessary in your environmet to switch back to the first window. I see. I need to remove enough chars to make pos > size in the old window. Bo

Re: Scrolling lag in 1.5svn again, more details.

2007-05-31 Thread Peter Kümmel
Lars Gullik Bjønnes wrote: > Peter Kümmel <[EMAIL PROTECTED]> writes: > > | José Matos wrote: > | > On Thursday 24 May 2007 18:17:37 Peter Kümmel wrote: > | >> The event_1 patch gives better results on systems > | >> with a fast enough graphic card(?) but does not work > | >> an older systems. >

Re: [PATCH-again] Bugs 3741 and 3756: Citation Dialog Bugs

2007-05-31 Thread Richard Heck
Peter Kümmel wrote: Richard Heck wrote: I tried to do something like this so I didn't have the same code in two places: QModelIndex & QCitationDialog::getSelectedIndex(QListView *) { QModelIndexList const selIdx = availableLV->selectionModel()->selectedIndexes(); if (selIdx.em

Re: [Patch] Re: Crash when closing document

2007-05-31 Thread Andre Poenitz
On Thu, May 31, 2007 at 09:53:31PM +0200, Alfredo Braunstein wrote: > Andre Poenitz wrote: > > > I know the rules and I am sometimes even follow them. > > You do? There are some rules that are really hard to break... Andre'

Re: Ready for RC1?

2007-05-31 Thread Lars Gullik Bjønnes
Peter Kümmel <[EMAIL PROTECTED]> writes: | Helge Hafting wrote: | > Lars Gullik Bjønnes wrote: | >> | What is the problem that you are trying to solve here? | >> | >> Is it my old pet? "Countinued scorrling after key-release"? | >> | >> What was wrong with my patch from months back? | >> | >

Re: [patch] RTL cursor display on inset edges

2007-05-31 Thread Dov Feldstern
Dov Feldstern wrote: Dov Feldstern wrote: As always, Stefan, you are right :) . I applied your patch (what threw me off was what you said about including another patch --- which BTW, I would still commit separately). Then it didn't compile --- there's a semicolon missing on line 347 of the p

Re: Delete character with alert style crashes lyx.

2007-05-31 Thread Andre Poenitz
On Thu, May 31, 2007 at 02:41:06PM -0500, Bo Peng wrote: > >#3785 now. > > I guess I need a more detailed description to reproduce it... abcdefgh1w Now do whatever is necessary in your environmet to switch back to the first window. Backtrace: [New Thread -1227621488 (LWP 12202)] wrong pos 8, m

Re: [Patch] Re: Crash when closing document

2007-05-31 Thread Alfredo Braunstein
Andre Poenitz wrote: > I know the rules and I am sometimes even follow them. You do? > I said 'I will prepare a patch', not 'I will disable multiple views'. I know, just teasing you. :-) A/

Re: Scrolling lag in 1.5svn again, more details.

2007-05-31 Thread José Matos
On Thursday 31 May 2007 20:50:54 Lars Gullik Bjønnes wrote: > My patch works for all "key" variants. that is entered through > auto-keying. Basically all key events that we failt to handle because > auto-repeat is too fast are dropped. What is the drawback then? > -- > Lgb -- José Abí

Re: [Patch] Re: Crash when closing document

2007-05-31 Thread Alfredo Braunstein
Andre Poenitz wrote: > On Thu, May 31, 2007 at 09:35:25PM +0200, Alfredo Braunstein wrote: >> Andre Poenitz wrote: >> >> > We want to get 1.5 out of the door. Multiple views make LyX crash. >> > Nobody is seemingly able to fix it in a reasonable time frame. >> > So the only sensibly solution is t

Re: Scrolling lag in 1.5svn again, more details.

2007-05-31 Thread Lars Gullik Bjønnes
Peter Kümmel <[EMAIL PROTECTED]> writes: | José Matos wrote: | > On Thursday 24 May 2007 18:17:37 Peter Kümmel wrote: | >> The event_1 patch gives better results on systems | >> with a fast enough graphic card(?) but does not work | >> an older systems. | >> | >> Jose feel free to do what you wa

Re: Delete character with alert style crashes lyx.

2007-05-31 Thread Abdelrazak Younes
Bo Peng wrote: #3785 now. I guess I need a more detailed description to reproduce it... It will crash in debug mode only. The only thing to fix and complement is DocIterator::fixIfBroken() in order to cover all cases. Some of the test done there are not correct as Alfredo has already noticed.

Re: Ready for RC1?

2007-05-31 Thread Peter Kümmel
Helge Hafting wrote: > Lars Gullik Bjønnes wrote: >> | What is the problem that you are trying to solve here? >> >> Is it my old pet? "Countinued scorrling after key-release"? >> >> What was wrong with my patch from months back? >> > > I tried this with todays svn. > The patch will indeed preve

Re: [Patch] Re: Crash when closing document

2007-05-31 Thread Andre Poenitz
On Thu, May 31, 2007 at 09:35:25PM +0200, Alfredo Braunstein wrote: > Andre Poenitz wrote: > > > We want to get 1.5 out of the door. Multiple views make LyX crash. > > Nobody is seemingly able to fix it in a reasonable time frame. > > So the only sensibly solution is to disable the feature. Note t

Re: [Patch] Re: Crash when closing document

2007-05-31 Thread Andre Poenitz
On Thu, May 31, 2007 at 09:30:29PM +0200, Alfredo Braunstein wrote: > Andre Poenitz wrote: > > > Best thing I can do now is to plead guilty on either not reading your > > patch or not noticing the added signal. In any case the signal can't > > be left in. So either someone comes up with a real fi

Re: Scrolling lag in 1.5svn again, more details.

2007-05-31 Thread José Matos
On Thursday 31 May 2007 20:35:06 Peter Kümmel wrote: > But one patch which at least fixes the pageup/down-key scrolling > should go in before RC1. I intend to release RC1 really soon now, so this patch must wait for RC2. > Peter -- José Abílio

Re: Delete character with alert style crashes lyx.

2007-05-31 Thread Bo Peng
#3785 now. I guess I need a more detailed description to reproduce it... Bo

Re: [Patch] Re: Crash when closing document

2007-05-31 Thread Alfredo Braunstein
Andre Poenitz wrote: > We want to get 1.5 out of the door. Multiple views make LyX crash. > Nobody is seemingly able to fix it in a reasonable time frame. > So the only sensibly solution is to disable the feature. Note that > I said 'disable', not 'remove'. I proposed a reasonable fix avoid the c

Re: [PATCH-again] Bugs 3741 and 3756: Citation Dialog Bugs

2007-05-31 Thread Andre Poenitz
On Thu, May 31, 2007 at 09:12:56PM +0200, Peter Kümmel wrote: > > I tried to do something like this so I didn't have the same code in two > > places: > > QModelIndex & QCitationDialog::getSelectedIndex(QListView *) { > > QModelIndexList const selIdx = > > availableLV->selectionModel()->se

Re: Scrolling lag in 1.5svn again, more details.

2007-05-31 Thread Peter Kümmel
José Matos wrote: > On Thursday 24 May 2007 18:17:37 Peter Kümmel wrote: >> The event_1 patch gives better results on systems >> with a fast enough graphic card(?) but does not work >> an older systems. >> >> Jose feel free to do what you want. > > What is the outcome of your email exchange with

Re: [Patch] Re: Crash when closing document

2007-05-31 Thread Alfredo Braunstein
Andre Poenitz wrote: > Best thing I can do now is to plead guilty on either not reading your > patch or not noticing the added signal. In any case the signal can't > be left in. So either someone comes up with a real fix or I'll prepare > a patch to remove the signal and disable multiple views at

Re: Delete character with alert style crashes lyx.

2007-05-31 Thread Andre Poenitz
On Thu, May 31, 2007 at 12:43:04PM -0500, Bo Peng wrote: > >> At last someone who don't think I've compromised LyX cleanness for > >> eternity :-) > > > >My dog doesn't either. > > Please register your bug to bugzilla and mark it as critical so that > Abdel can have a look; #3785 now. Andre'

Re: [patch] RTL cursor display on inset edges

2007-05-31 Thread Dov Feldstern
Dov Feldstern wrote: As always, Stefan, you are right :) . I applied your patch (what threw me off was what you said about including another patch --- which BTW, I would still commit separately). Then it didn't compile --- there's a semicolon missing on line 347 of the patch file, or at line

Re: [PATCH-again] Bugs 3741 and 3756: Citation Dialog Bugs

2007-05-31 Thread Peter Kümmel
Richard Heck wrote: > > Still seeking comment on this patch, or permission to commit. > > = > > The attached patch addresses these bugs > http://bugzilla.lyx.org/show_bug.cgi?id=3741 > http://bugzilla.lyx.org/show_bug.cgi?id=3756 > in a way that is compatible with earlier discussion with A

Re: Delete character with alert style crashes lyx.

2007-05-31 Thread Andre Poenitz
On Thu, May 31, 2007 at 12:43:04PM -0500, Bo Peng wrote: > >> At last someone who don't think I've compromised LyX cleanness for > >> eternity :-) > > > >My dog doesn't either. > > Please register your bug to bugzilla and mark it as critical so that > Abdel can have a look; or sit down and impleme

Re: Bidi is a mess

2007-05-31 Thread Dov Feldstern
Andre Poenitz wrote: On Thu, May 31, 2007 at 08:22:02PM +0300, Dov Feldstern wrote: Andre Poenitz wrote: On Thu, May 31, 2007 at 11:38:04AM +0200, Stefan Schimanski wrote: What I want to say with this example: the bidi code is in a very bad state. We are lucky that it is more or less working.

[PATCH-again] Bugs 3741 and 3756: Citation Dialog Bugs

2007-05-31 Thread Richard Heck
Still seeking comment on this patch, or permission to commit. = The attached patch addresses these bugs http://bugzilla.lyx.org/show_bug.cgi?id=3741 http://bugzilla.lyx.org/show_bug.cgi?id=3756 in a way that is compatible with earlier discussion with Abdel. Here's what it does: * In

Re: Bidi is a mess

2007-05-31 Thread Andre Poenitz
On Thu, May 31, 2007 at 08:22:02PM +0300, Dov Feldstern wrote: > Andre Poenitz wrote: > >On Thu, May 31, 2007 at 11:38:04AM +0200, Stefan Schimanski wrote: > >>What I want to say with this example: the bidi code is in a very bad > >>state. We are lucky that it is more or less working. > > > >I wa

Re: [Patch] Re: Crash when closing document

2007-05-31 Thread Andre Poenitz
On Thu, May 31, 2007 at 07:13:49PM +0200, Edwin Leuven wrote: > Andre Poenitz wrote: > >So either someone comes up with a real fix > > you're volunteering andre? No. If it were that easy I propbably would have found the time to do so when I had more time then now. > >or I'll prepare a patch to r

Re: [PATCH] Properly support the full unicode range in GuiFontMetrics (fix bug 3759)

2007-05-31 Thread Georg Baum
Am Donnerstag, 31. Mai 2007 18:46 schrieb Abdelrazak Younes: > OK, got it, sorry. I deleted that because I thought it was just about > the toqstr() hack; which it was not. > I've added a more general comment at the top of the file because the > comment is valid for all use of uc4_to_qchar(), not

Re: [Patch] Re: Crash when closing document

2007-05-31 Thread Abdelrazak Younes
Andre Poenitz wrote: On Thu, May 31, 2007 at 06:55:38PM +0200, Abdelrazak Younes wrote: I _never_ said that Angus endorsed the patch, just that he helped me. I just said that *nobody* commented the approach, period. Which in the time of an upcoming release plainly means 'rejected'. Accepte

Re: Another cursor movement bug/feature

2007-05-31 Thread José Matos
On Thursday 31 May 2007 17:09:17 Dov Feldstern wrote: > Stefan has already added it, in a slightly modified form > (http://www.lyx.org/trac/changeset/18532) I will not complain. :-) -- José Abílio

Re: [patch] RTL cursor display on inset edges

2007-05-31 Thread Dov Feldstern
As always, Stefan, you are right :) . I applied your patch (what threw me off was what you said about including another patch --- which BTW, I would still commit separately). Then it didn't compile --- there's a semicolon missing on line 347 of the patch file, or at line 279(?) of bufferview_f

Re: Delete character with alert style crashes lyx.

2007-05-31 Thread Abdelrazak Younes
Andre Poenitz wrote: On Thu, May 31, 2007 at 02:25:57PM +0200, Abdelrazak Younes wrote: Jean-Marc Lasgouttes wrote: "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> Jean-Marc Lasgouttes wrote: Possibly yes. I have a patch Abdelrazak> pending for that issue that is not

Re: [Patch] Re: Crash when closing document

2007-05-31 Thread Andre Poenitz
On Thu, May 31, 2007 at 06:55:38PM +0200, Abdelrazak Younes wrote: > Andre Poenitz wrote: > >>>Also "fully" and "patch" does not help. And not "angus", "2007", > >>>"abdel" (or "signal") and a lot of other combinations. > > > >I also see that Angus solved your C++ related problem. No less, no > >mo

Re: Delete character with alert style crashes lyx.

2007-05-31 Thread Bo Peng
> At last someone who don't think I've compromised LyX cleanness for > eternity :-) My dog doesn't either. Please register your bug to bugzilla and mark it as critical so that Abdel can have a look; or sit down and implement your Alfredo way and demonstrate to us that your method is better. It

Re: Delete character with alert style crashes lyx.

2007-05-31 Thread Andre Poenitz
On Thu, May 31, 2007 at 06:11:25PM +0200, Abdelrazak Younes wrote: > Bo Peng wrote: > >>OK, as this is a fix to a crash and that it also addresses Andre' main > >>complaint about the memory consumption due to the boost::signal in the > >>Inset class I'll commit. > > > >I have no opinion on the use

Re: Delete character with alert style crashes lyx.

2007-05-31 Thread Andre Poenitz
On Thu, May 31, 2007 at 02:25:57PM +0200, Abdelrazak Younes wrote: > Jean-Marc Lasgouttes wrote: > >>"Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: > > > >Abdelrazak> Jean-Marc Lasgouttes wrote: Possibly yes. I have a patch > >Abdelrazak> pending for that issue that is not OKed A

Re: Bidi is a mess

2007-05-31 Thread Dov Feldstern
Andre Poenitz wrote: On Thu, May 31, 2007 at 11:38:04AM +0200, Stefan Schimanski wrote: What I want to say with this example: the bidi code is in a very bad state. We are lucky that it is more or less working. I was about to rip it off in the updateInsetsInInsets times as nobody understood it

Re: Bidi is a mess

2007-05-31 Thread Dov Feldstern
Stefan Schimanski wrote: But, the fact is that it works, I've yet to see a problem which is due to the heart of the bidi algorithm. (Do you think you have found one, now?) Yes, more or less. We have two bidi algorithms at the moment. One is inside the Bidi class, the other one in the font s

Re: [PATCH] Properly support the full unicode range in GuiFontMetrics (fix bug 3759)

2007-05-31 Thread Andre Poenitz
On Thu, May 31, 2007 at 03:06:19PM +0100, José Matos wrote: > On Thursday 31 May 2007 13:50:17 Abdelrazak Younes wrote: > > Thanks. What should I do with the Qt4.1 case? Do I remove the > > assertion and return '?' or does someone wants to implement the > > iconv solution? > > Could that be plac

Re: [Patch] Re: Crash when closing document

2007-05-31 Thread Edwin Leuven
Andre Poenitz wrote: So either someone comes up with a real fix you're volunteering andre? or I'll prepare a patch to remove the signal and disable multiple views at the weekend. small kids act like this with their even smaller brothers...

Re: Bidi is a mess

2007-05-31 Thread Abdelrazak Younes
Andre Poenitz wrote: The main problem is that new features (aka "multiple views") crop up faster than the core can provided the necessary infrastructure, leading to a mess of 'fixes' just to make it work. The the feature's developer leaves, nobody understands the code anymore and why a particula

Re: Bidi is a mess

2007-05-31 Thread Stefan Schimanski
This is not totally fair. The fact is, it's implementing a well- known, standard, function. To understand it, you probably have to read up on the Bidi algorithm (I've never done it thoroughly, I don't know this code, either, and have been trying to avoid it as much as possible, partly for th

Re: Bidi is a mess

2007-05-31 Thread Andre Poenitz
On Thu, May 31, 2007 at 11:55:17AM +0200, Stefan Schimanski wrote: > >Feel free to unleash yourself and clean up this mess in the 1.6 > >frame ;-) > > That said... are there any tools around supporting refactoring of C++ > code like Eclipse can do it for Java? Partially. The problem is that C

Re: Bidi is a mess

2007-05-31 Thread Andre Poenitz
On Thu, May 31, 2007 at 11:44:06AM +0200, Abdelrazak Younes wrote: > Stefan Schimanski wrote: > >Hi! > > > >Can anybody please explain me Text::bidi? It keeps a cache of RTL<->LTR > >levels for a row. But this variable is in the Text class, in the public > >section. It does not store for which pa

Re: [patch] cursor misplaced after a linebreak, #2475

2007-05-31 Thread Stefan Schimanski
I've tested it yesterday and it was OK so OK :-) Is this in? Yes: r18576 Stefan Abdel. -- José Abílio PGP.sig Description: Signierter Teil der Nachricht

  1   2   >