Re: [PATCH] GUI API Cleanup Merge patch

2006-06-19 Thread Lars Gullik Bjønnes
Andre Poenitz <[EMAIL PROTECTED]> writes: | On Mon, Jun 19, 2006 at 03:11:58PM +0200, Lars Gullik Bjønnes wrote: | > | I can't use reference because I want to be able to change work_area_ | > | at run-time. This work_area_ is not created nor deleted here so it is | > | a _safe_ use of pointer. Fee

Re: PCH/gcc of lyx

2006-06-19 Thread Bo Peng
I thought this was were the pch.cpp came in, only used for generating the pch.pch file. My understanding is that pch.cpp is needed for pch.pch, but msvc will still scan source files for #progma or #include . Passing include=pch.h does not count. Bo

Re: Updated Windows Installer

2006-06-19 Thread Angus Leeming
Joost Verburg wrote: Hello, A new Windows installer for LyX 1.4.2svn is available for testing: ftp://ftp.devel.lyx.org/pub/lyx/pre/lyx-142svn-20060617.exe ftp://ftp.devel.lyx.org/pub/lyx/pre/lyx-142svn-20060617-bundle.exe Again there are a number of improvements: English thesaurus (Aiksaurus)

Re: PCH/gcc of lyx

2006-06-19 Thread Lars Gullik Bjønnes
"Bo Peng" <[EMAIL PROTECTED]> writes: | > | How is '#pragma hdrstop' less intrusive than '#include ' | > | > I thought that the pragma wan only needed in a pch.cpp file, not in | > all source files. | > | > | | I am not sure about this one. (Need to read MSDN.) Certainly the | stopping header me

Re: Qt4 frontend save/restore geoemtry patch

2006-06-19 Thread Bo Peng
But when you prefer the (-1,-1) solution I'll change it. Since (-1, -1) will save a significant amount of coding, I prefer this. Bo

Re: Two issues for LyX 1.4.2

2006-06-19 Thread Uwe Stöhr
Jean-Marc Lasgouttes schrieb: Uwe> - http://bugzilla.lyx.org/show_bug.cgi?id=2653 Simple fix for Uwe> broken doc file The fix to the tutorial is straightforward, but the same should be done in the userguide. You're right the german userguide is also broken. This is now bug 2660: http://bugzil

Re: Aspell / Windows Fixed

2006-06-19 Thread Angus Leeming
Angus Leeming wrote: I'll try and find some time to run that script again. Might take me a few days to do so. Ok, Joost. Now done. Files are currently uploading to the usual place. Rather nicely, because I'm overwriting existing files with apache:wiki ownership, the new versions of these file

Re: [PATCH] GUI API Cleanup Merge patch

2006-06-19 Thread Lars Gullik Bjønnes
Andre Poenitz <[EMAIL PROTECTED]> writes: | On Mon, Jun 19, 2006 at 06:02:52PM +0200, Lars Gullik Bjønnes wrote: | > Perhaps the wrong heading but... from development/Code_rules/Rules: | > | > * Naming rules for classes | > | > - Use descriptive but simple and short nam

Re: [PATCH] GUI API Cleanup Merge patch

2006-06-19 Thread Lars Gullik Bjønnes
Andre Poenitz <[EMAIL PROTECTED]> writes: | And to not try to force Lars making changes. We'd end up with ideas like | 'do not use virtual functions in the public interface of classes' and a | free demonstration that it hurts nicely (aka 'doDispatch') Oh, but I don't agree. I still belive the ab

Re: [PATCH] GUI API Cleanup Merge patch

2006-06-19 Thread Lars Gullik Bjønnes
Andre Poenitz <[EMAIL PROTECTED]> writes: | On Mon, Jun 19, 2006 at 06:29:14PM +0200, Lars Gullik Bjønnes wrote: | > Then it is misleading. We use the same naming scheme for member | > functions and member variables. | | 'We' as in the old days? 'We' as we have documented it. | Could well be, b

Re: [PATCH] GUI API Cleanup Merge patch

2006-06-19 Thread Lars Gullik Bjønnes
Andre Poenitz <[EMAIL PROTECTED]> writes: | On Mon, Jun 19, 2006 at 05:48:29PM +0200, Abdelrazak Younes wrote: | > By the way, this is written nowhere and I had the impression that | > "gui_instance_" style was the rule in the current code. Could you | > confirm that please because I used the "g

Re: PCH/gcc of lyx

2006-06-19 Thread Bo Peng
| How is '#pragma hdrstop' less intrusive than '#include ' I thought that the pragma wan only needed in a pch.cpp file, not in all source files. I am not sure about this one. (Need to read MSDN.) Certainly the stopping header mechanism does not work for --include=pch.h since msvc need to sca

Re: PCH/gcc of lyx

2006-06-19 Thread Lars Gullik Bjønnes
Andre Poenitz <[EMAIL PROTECTED]> writes: | On Mon, Jun 19, 2006 at 06:36:25PM +0200, Lars Gullik Bjønnes wrote: | > | stdafx.h contains all commonly used headers. msvc knows from a | > | compiler flag (or by default) that stdafx.h (stopping header) is | > | pre-processed and skip it. | > | > Use

Re: PCH/gcc of lyx

2006-06-19 Thread Andre Poenitz
On Mon, Jun 19, 2006 at 06:36:25PM +0200, Lars Gullik Bjønnes wrote: > | stdafx.h contains all commonly used headers. msvc knows from a > | compiler flag (or by default) that stdafx.h (stopping header) is > | pre-processed and skip it. > > Use #pragma hdrstop instead. Looks like I have a really b

Re: [PATCH] GUI API Cleanup Merge patch

2006-06-19 Thread Andre Poenitz
On Mon, Jun 19, 2006 at 06:29:14PM +0200, Lars Gullik Bjønnes wrote: > Then it is misleading. We use the same naming scheme for member > functions and member variables. 'We' as in the old days? Could well be, but that does not mean that the other n-1 do. > | Really if you look at current source

Re: [PATCH] GUI API Cleanup Merge patch

2006-06-19 Thread Andre Poenitz
On Mon, Jun 19, 2006 at 05:48:29PM +0200, Abdelrazak Younes wrote: > By the way, this is written nowhere and I had the impression that > "gui_instance_" style was the rule in the current code. Could you > confirm that please because I used the "gui_instance_" style everywhere > already :-( I th

Re: [PATCH] GUI API Cleanup Merge patch

2006-06-19 Thread Andre Poenitz
On Mon, Jun 19, 2006 at 06:02:52PM +0200, Lars Gullik Bjønnes wrote: > Perhaps the wrong heading but... from development/Code_rules/Rules: > > * Naming rules for classes > > - Use descriptive but simple and short names. For stuff specific to > LyX >

Re: [PATCH] GUI API Cleanup Merge patch

2006-06-19 Thread Andre Poenitz
On Mon, Jun 19, 2006 at 06:17:58PM +0200, Abdelrazak Younes wrote: > > - Long variables are named like thisLongVariableName. > > So without the trailing underscore then? > > For me variables are temporary variables inside a function or variable > passed to a function. We are talking her

Re: PCH/gcc of lyx

2006-06-19 Thread Andre Poenitz
On Mon, Jun 19, 2006 at 12:55:07PM +0200, Lars Gullik Bjønnes wrote: > no. (pch should not be intrusive... bugger off msvc) Hm? MSVC could automatically include some file pretty much the way gcc's '-include' works. Andre'

Re: PCH/gcc of lyx

2006-06-19 Thread Andre Poenitz
On Mon, Jun 19, 2006 at 10:43:20AM -0500, Bo Peng wrote: > >and how will that change if you include pch.h in all the source files, > >excepti being overly intrusive? or having some files compiled iwth pch > >and some not...=? > > I do not think this is a matter of intrusiveness. > > By definition

Re: [PATCH] GUI API Cleanup Merge patch

2006-06-19 Thread Andre Poenitz
On Mon, Jun 19, 2006 at 03:11:58PM +0200, Lars Gullik Bjønnes wrote: > | I can't use reference because I want to be able to change work_area_ > | at run-time. This work_area_ is not created nor deleted here so it is > | a _safe_ use of pointer. Feel free to suggest something else that > | retain po

Updated Windows Installer

2006-06-19 Thread Joost Verburg
Hello, A new Windows installer for LyX 1.4.2svn is available for testing: ftp://ftp.devel.lyx.org/pub/lyx/pre/lyx-142svn-20060617.exe ftp://ftp.devel.lyx.org/pub/lyx/pre/lyx-142svn-20060617-bundle.exe Again there are a number of improvements: English thesaurus (Aiksaurus) is included, Aspell h

Re: WARNING: GUI Cleanup merge

2006-06-19 Thread Lars Gullik Bjønnes
Abdelrazak Younes <[EMAIL PROTECTED]> writes: | Abdelrazak Younes wrote: | > Hello, | > I am going to merge my branch now so please wait for a few minutes | > if you want to commit something that touches the GUI API cleanup | > work. | | I will wait until tomorrow because I need to find out how r

Re: [PATCH] Re-orgnization of scons and generatiion of multiple config.h

2006-06-19 Thread Abdelrazak Younes
Bo Peng wrote: Abdel, please check if the attached patch has addressed all your concerns. Not now, sorry I have to hurry up. Tunisia is playing tonight. Abdel.

Re: WARNING: GUI Cleanup merge

2006-06-19 Thread Abdelrazak Younes
Abdelrazak Younes wrote: Hello, I am going to merge my branch now so please wait for a few minutes if you want to commit something that touches the GUI API cleanup work. I will wait until tomorrow because I need to find out how renamed files are handled when you do a merging. Right now I see

Re: [PATCH] Re-orgnization of scons and generatiion of multiple config.h

2006-06-19 Thread Bo Peng
Abdel, please check if the attached patch has addressed all your concerns. Bo Index: development/scons/SConstruct === --- development/scons/SConstruct (revision 14150) +++ development/scons/SConstruct (working copy) @@ -254,7 +254,7

Re: [Patch] a few cosmetic changes in the GUI cleanup branch.

2006-06-19 Thread Abdelrazak Younes
Lars Gullik Bjønnes wrote: Abdelrazak Younes <[EMAIL PROTECTED]> writes: | Lars Gullik Bjønnes wrote: | > Abdelrazak Younes <[EMAIL PROTECTED]> writes: | > | > | -// workarea().setScrollbarParams(t->height(), top_y(), | > defaultRowHeight()); | > | > | +// work_area_->.setScrollbarParams

Re: [Patch] a few cosmetic changes in the GUI cleanup branch.

2006-06-19 Thread Lars Gullik Bjønnes
Abdelrazak Younes <[EMAIL PROTECTED]> writes: | Lars Gullik Bjønnes wrote: | > Abdelrazak Younes <[EMAIL PROTECTED]> writes: | > | > | -// workarea().setScrollbarParams(t->height(), top_y(), | > defaultRowHeight()); | > | > | +// work_area_->.setScrollbarParams(t->height(), top_y(), defaultRo

Re: [PATCH] GUI API Cleanup Merge patch

2006-06-19 Thread Lars Gullik Bjønnes
Abdelrazak Younes <[EMAIL PROTECTED]> writes: | Lars Gullik Bjønnes wrote: | > Abdelrazak Younes <[EMAIL PROTECTED]> writes: | > | Lars Gullik Bjønnes wrote: | > | > Abdelrazak Younes <[EMAIL PROTECTED]> writes: | > | > | | Do you mean this one: | > | > | | > - Long variables are named l

Re: [Patch] a few cosmetic changes in the GUI cleanup branch.

2006-06-19 Thread Abdelrazak Younes
Lars Gullik Bjønnes wrote: Abdelrazak Younes <[EMAIL PROTECTED]> writes: | > | -//workarea().setScrollbarParams(t->height(), top_y(), defaultRowHeight()); | > | +//work_area_->.setScrollbarParams(t->height(), top_y(), defaultRowHeight()); | > | } | > The commented code got mangeld. |

Re: PCH/gcc of lyx

2006-06-19 Thread Bo Peng
So if you have ten .h files which of nine needs foo.h then foo.h cannot be placed in pch.hpp? Maybe we should say 7/10 in, 6/10 out? :-) | Unless you want more than commonly used headers in pch.h. I want commonly used headers but not just the intersection. I finally see the differences betw

Re: PCH/gcc of lyx

2006-06-19 Thread Lars Gullik Bjønnes
"Bo Peng" <[EMAIL PROTECTED]> writes: | > And 2. is the thing that smells most foul to me. | > There must exist another solution. | | pch.h means precompiled-headers. Will std_headers.h make you happier? No it won't. | (I do not know what afx in stdafx means.) application framework. --

Re: PCH/gcc of lyx

2006-06-19 Thread Lars Gullik Bjønnes
"Bo Peng" <[EMAIL PROTECTED]> writes: | > | As I have said, I see no reason why | > | not include pch.h. | > | > I do. | > | > by adding pch.h and removing the now duplicated headers you no longer | > have control over the actually required headers for that particular | > source file. | | I still

Re: PCH/gcc of lyx

2006-06-19 Thread Bo Peng
And 2. is the thing that smells most foul to me. There must exist another solution. pch.h means precompiled-headers. Will std_headers.h make you happier? (I do not know what afx in stdafx means.) Bo

Re: [Patch] a few cosmetic changes in the GUI cleanup branch.

2006-06-19 Thread Lars Gullik Bjønnes
Abdelrazak Younes <[EMAIL PROTECTED]> writes: | > | -// workarea().setScrollbarParams(t->height(), top_y(), defaultRowHeight()); | > | +// work_area_->.setScrollbarParams(t->height(), top_y(), defaultRowHeight()); | > | } | > The commented code got mangeld. | | I plan to remove thi

Re: [PATCH] GUI API Cleanup Merge patch

2006-06-19 Thread Abdelrazak Younes
Lars Gullik Bjønnes wrote: Abdelrazak Younes <[EMAIL PROTECTED]> writes: | Lars Gullik Bjønnes wrote: | > Abdelrazak Younes <[EMAIL PROTECTED]> writes: | > | | Do you mean this one: | > | | > - Long variables are named like thisLongVariableName. | > | | So without the trailing undersco

Re: PCH/gcc of lyx

2006-06-19 Thread Bo Peng
| As I have said, I see no reason why | not include pch.h. I do. by adding pch.h and removing the now duplicated headers you no longer have control over the actually required headers for that particular source file. I still do not get it. pch.h has only headers that are needed for every source

Re: PCH/gcc of lyx

2006-06-19 Thread Lars Gullik Bjønnes
"Bo Peng" <[EMAIL PROTECTED]> writes: | > Feels that some intrusiveness is required to make this work... | > We should try hard to avoid that. | > | | According to the link I sent to you, the best solution, as far as I know, is | | 1. make pch.h contains commonly used header files | 2. include p

Re: PCH/gcc of lyx

2006-06-19 Thread Lars Gullik Bjønnes
"Bo Peng" <[EMAIL PROTECTED]> writes: | > | stdafx.h contains all commonly used headers. msvc knows from a | > | compiler flag (or by default) that stdafx.h (stopping header) is | > | pre-processed and skip it. | > | > Use #pragma hdrstop instead. | | We do not have this in .C either. This would

Re: [Better patch] Re: [Patch] Re: Drawing error with collapsable insets.

2006-06-19 Thread Bennett Helm
On Jun 19, 2006, at 12:36 PM, Martin Vermeer wrote: On Mon, Jun 19, 2006 at 10:44:27AM -0400, Bennett Helm wrote: On Jun 18, 2006, at 5:24 AM, Martin Vermeer wrote: ... Here's the patch you've been looking for... it simplifies things which is always a good sign. This is much faster on M

Re: [PATCH] GUI API Cleanup Merge patch

2006-06-19 Thread Lars Gullik Bjønnes
Abdelrazak Younes <[EMAIL PROTECTED]> writes: | Lars Gullik Bjønnes wrote: | > Abdelrazak Younes <[EMAIL PROTECTED]> writes: | > | | Do you mean this one: | > | | > - Long variables are named like thisLongVariableName. | > | | So without the trailing underscore then? | > No. Private cla

Re: [Patch] a few cosmetic changes in the GUI cleanup branch.

2006-06-19 Thread Abdelrazak Younes
Lars Gullik Bjønnes wrote: Abdelrazak Younes <[EMAIL PROTECTED]> writes: | Hello, | | With this patch I am satisfying Lars desiderata. The only remaining | issue is the naming of the TheGui class. Lars, could you please make | up your mind about that: MainGui, QtGui, GuiInstance ? Hmm da hmm.

Re: PCH/gcc of lyx

2006-06-19 Thread Bo Peng
Feels that some intrusiveness is required to make this work... We should try hard to avoid that. According to the link I sent to you, the best solution, as far as I know, is 1. make pch.h contains commonly used header files 2. include pch.h in all source files 3. have a pch.cpp with #include p

Re: [Patch] a few cosmetic changes in the GUI cleanup branch.

2006-06-19 Thread Lars Gullik Bjønnes
Abdelrazak Younes <[EMAIL PROTECTED]> writes: | Hello, | | With this patch I am satisfying Lars desiderata. The only remaining | issue is the naming of the TheGui class. Lars, could you please make | up your mind about that: MainGui, QtGui, GuiInstance ? Hmm da hmm class GuiImplementation :

Re: PCH/gcc of lyx

2006-06-19 Thread Bo Peng
| That is what I meant. our pch.h contains headers that are not commonly | used. (and in pch mode, they are included.) Then they should be regenerated/reviewed. I actually only looked at src/mathed/pch.h. But if pch.h indeed has headers that are commonly included, why not include it and remove

Re: [PATCH] GUI API Cleanup Merge patch

2006-06-19 Thread Abdelrazak Younes
Lars Gullik Bjønnes wrote: Abdelrazak Younes <[EMAIL PROTECTED]> writes: | | Do you mean this one: | | > - Long variables are named like thisLongVariableName. | | So without the trailing underscore then? No. Private class member variables get a _ at the end. Where is that wr

Re: [Cvslog] r14136 - in /lyx-devel/trunk/src/frontends/qt4: Action.C ...

2006-06-19 Thread Andre Poenitz
On Sat, Jun 17, 2006 at 09:15:01AM -, [EMAIL PROTECTED] wrote: > Author: younes > Date: Sat Jun 17 11:14:58 2006 > New Revision: 14136 > > Log: > Those classes (and their associated [Ch] files) are renamed : > > QLAction -> Action > lcolorcache -> ColorCache > qfont_loader.C -> FontLoader Go

Re: [PATCH] GUI API Cleanup Merge patch

2006-06-19 Thread Andre Poenitz
On Sat, Jun 17, 2006 at 08:52:12AM +0200, Abdelrazak Younes wrote: > Andre Poenitz wrote: > >On Thu, Jun 15, 2006 at 12:39:32PM +0200, Abdelrazak Younes wrote: > >>Minus potential compilation problems with gtk and/or xforms I think I am > >>ready to merge my branch with trunk. Please find attached

Re: PCH/gcc of lyx

2006-06-19 Thread Lars Gullik Bjønnes
[EMAIL PROTECTED] (Lars Gullik Bjønnes) writes: | I need good examples to understand this properly. | | http://msdn.microsoft.com/library/default.asp?url=/library/en-us/vclang/html/_PREDIR_hdrstop.asp | http://msdn.microsoft.com/library/default.asp?url=/library/en-us/vccore/html/_core_.2f.yc.a

Re: [Better patch] Re: [Patch] Re: Drawing error with collapsable insets.

2006-06-19 Thread Martin Vermeer
On Mon, Jun 19, 2006 at 10:44:27AM -0400, Bennett Helm wrote: > On Jun 18, 2006, at 5:24 AM, Martin Vermeer wrote: ... > >Here's the patch you've been looking for... it simplifies things which > >is always a good sign. > > This is much faster on Mac than the previous patches, but still a bit

Re: PCH/gcc of lyx

2006-06-19 Thread Lars Gullik Bjønnes
"Bo Peng" <[EMAIL PROTECTED]> writes: | > some sourcefiles will get includes | > they strictly speaking did not need. | | That is what I meant. our pch.h contains headers that are not commonly | used. (and in pch mode, they are included.) Then they should be regenerated/reviewed. | > | In pch m

[Patch] a few cosmetic changes in the GUI cleanup branch.

2006-06-19 Thread Abdelrazak Younes
Hello, With this patch I am satisfying Lars desiderata. The only remaining issue is the naming of the TheGui class. Lars, could you please make up your mind about that: MainGui, QtGui, GuiInstance ? Abdel. Log: * Use work_area_ member instead of workarea() access method. * Correct some spaci

Re: [PATCH] GUI API Cleanup Merge patch

2006-06-19 Thread Lars Gullik Bjønnes
Abdelrazak Younes <[EMAIL PROTECTED]> writes: | Lars Gullik Bjønnes wrote: | > Abdelrazak Younes <[EMAIL PROTECTED]> writes: | | > | By the way, this is written nowhere and I had the impression that | > | "gui_instance_" style was the rule in the current code. Could you | > | confirm that please

Re: PCH/gcc of lyx

2006-06-19 Thread Bo Peng
some sourcefiles will get includes they strictly speaking did not need. That is what I meant. our pch.h contains headers that are not commonly used. (and in pch mode, they are included.) | In pch mode, | --include=pch.h is passed. This will *not* work with msvc since msvc | scans source file f

Re: [PATCH] GUI API Cleanup Merge patch

2006-06-19 Thread Abdelrazak Younes
Abdelrazak Younes wrote: Really if you look at current source code it is mostly this style: class ThisIsOneClass { void thisIsOneMethod(OneType one_type); OneType one_type_; } I think this coding style is nice as it is not misleading. So either we update the code rules or we change t

Re: [PATCH] GUI API Cleanup Merge patch

2006-06-19 Thread Abdelrazak Younes
Lars Gullik Bjønnes wrote: Abdelrazak Younes <[EMAIL PROTECTED]> writes: | By the way, this is written nowhere and I had the impression that | "gui_instance_" style was the rule in the current code. Could you | confirm that please because I used the "gui_instance_" style | everywhere already :

Re: [Better patch] Re: [Patch] Re: Drawing error with collapsable insets.

2006-06-19 Thread Martin Vermeer
On Mon, Jun 19, 2006 at 04:16:20PM +0200, Jean-Marc Lasgouttes wrote: > > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: > > Martin> On Mon, 2006-06-19 at 12:52 +0200, Jean-Marc Lasgouttes wrote: > >> > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: > >> > Martin> Here's t

Re: PCH/gcc of lyx

2006-06-19 Thread Lars Gullik Bjønnes
"Bo Peng" <[EMAIL PROTECTED]> writes: | > and how will that change if you include pch.h in all the source files, | > excepti being overly intrusive? or having some files compiled iwth pch | > and some not...=? | | I do not think this is a matter of intrusiveness. | By definition, PCH separates

Re: [PATCH] some scons correction (wa Re: [PATCH] Re-orgnization of scons and generatiion of multiple config.h)

2006-06-19 Thread Abdelrazak Younes
Bo Peng wrote: If I add /ID:\devel\lyx\GUI\src to it, it compiles fine. Why intl needs to include $TOP_SRCDIR/src? This was with the version in trunk, that is before your config.h separation. I guess that with your patch you need to add $TOP_SRCDIR/intl to the include path. Abdel.

Re: [PATCH] GUI API Cleanup Merge patch

2006-06-19 Thread Lars Gullik Bjønnes
Abdelrazak Younes <[EMAIL PROTECTED]> writes: | Lars Gullik Bjønnes wrote: | > Abdelrazak Younes <[EMAIL PROTECTED]> writes: | > | Lars Gullik Bjønnes wrote: | > | > [EMAIL PROTECTED] (Lars Gullik Bjønnes) writes: | > | > | Abdelrazak Younes <[EMAIL PROTECTED]> writes: | > | > | | | UniqueGui | >

Re: [PATCH] GUI API Cleanup Merge patch

2006-06-19 Thread Abdelrazak Younes
Lars Gullik Bjønnes wrote: Abdelrazak Younes <[EMAIL PROTECTED]> writes: | Lars Gullik Bjønnes wrote: | > [EMAIL PROTECTED] (Lars Gullik Bjønnes) writes: | > | Abdelrazak Younes <[EMAIL PROTECTED]> writes: | > | | | UniqueGui | > | | UniqueGuiInstance | > | | GuiImplementation | > | | GuiInstanc

Re: [PATCH] some scons correction (wa Re: [PATCH] Re-orgnization of scons and generatiion of multiple config.h)

2006-06-19 Thread Bo Peng
If I add /ID:\devel\lyx\GUI\src to it, it compiles fine. Why intl needs to include $TOP_SRCDIR/src? Bo

Re: PCH/gcc of lyx

2006-06-19 Thread Bo Peng
and how will that change if you include pch.h in all the source files, excepti being overly intrusive? or having some files compiled iwth pch and some not...=? I do not think this is a matter of intrusiveness. By definition, PCH separates commonly used headers from all source files, compile the

Re: [patch] font selection redesign completed

2006-06-19 Thread Juergen Spitzmueller
Bennett Helm wrote: > Wow -- a very nice feature! thanks. > Of course, now that you've whetted my > appetite, I want more. > > The standard TeX distributions on Mac now include support for various > standard Mac fonts, such as Baskerville, Didot, Georgia, Hoefler, > Gill Sans, Futura, Lucida Gr

Re: [PATCH] GUI API Cleanup Merge patch

2006-06-19 Thread Abdelrazak Younes
Lars Gullik Bjønnes wrote: Abdelrazak Younes <[EMAIL PROTECTED]> writes: | > Then QtGui (Oh!) | | I really don't like it but that's the only thing that would please you Ok. I am not sure that I like it either but I am also unsure if we are discussing the same thing; ref other mail.

Re: [PATCH] GUI API Cleanup Merge patch

2006-06-19 Thread Lars Gullik Bjønnes
Abdelrazak Younes <[EMAIL PROTECTED]> writes: | > Then QtGui (Oh!) | | I really don't like it but that's the only thing that would please you Ok. I am not sure that I like it either but I am also unsure if we are discussing the same thing; ref other mail. | We kind of agreed to stay wit

Re: [PATCH] GUI API Cleanup Merge patch

2006-06-19 Thread Lars Gullik Bjønnes
[EMAIL PROTECTED] (Lars Gullik Bjønnes) writes: | | Index: src/frontends/gtk/GView.h | | === | | --- src/frontends/gtk/GView.h (revision 14120) | | +++ src/frontends/gtk/GView.h (working copy) | | @@ -12,9 +12,12 @@ | | #

Re: [PATCH] Re-orgnization of scons and generatiion of multiple config.h

2006-06-19 Thread Bo Peng
Please find attached a patch for restore the old behaviour for gcc/debug (by default we don't have debug libraries with mingw). I will change the patch. I have a problem with MSVC/debug. The binary complains about missing MSVCP80D.dll. I think you have to link with QtCored4.dll.manifest and Qt

Re: [PATCH] some scons correction (wa Re: [PATCH] Re-orgnization of scons and generatiion of multiple config.h)

2006-06-19 Thread Abdelrazak Younes
Abdelrazak Younes wrote: Bo Peng wrote: intl should have its own config.h. Do you see that generated (intl/config.h) Yes it is in trunk/intl/config.h which is bad (see my other mail). The problem lies in the include options I think. Yes that's an include path problem. With the unpatched

Re: [PATCH] Re-orgnization of scons and generatiion of multiple config.h

2006-06-19 Thread Bo Peng
I think that instead of config/ subdir, you should put - boost_config.h in scons/build_dir/boost - intl config.h in scons/build_dir/intl (instead of the source dir) - lyx config.h in scons/build_dir/common Sounds reasonable. I will do it. Bo

Re: [PATCH] GUI API Cleanup Merge patch

2006-06-19 Thread Abdelrazak Younes
Lars Gullik Bjønnes wrote: Abdelrazak Younes <[EMAIL PROTECTED]> writes: | Lars Gullik Bjønnes wrote: | > [EMAIL PROTECTED] (Lars Gullik Bjønnes) writes: | > | Abdelrazak Younes <[EMAIL PROTECTED]> writes: | > | | | UniqueGui | > | | UniqueGuiInstance | > | | GuiImplementation | > | | GuiInstanc

Re: [PATCH] GUI API Cleanup Merge patch

2006-06-19 Thread Abdelrazak Younes
Lars Gullik Bjønnes wrote: Abdelrazak Younes <[EMAIL PROTECTED]> writes: | | This has nothing to do with the "theApp" global variable. I have not mentioned TheApp one single time... only TheGui. Man, we were talking about the "theApp" pointer! You were answering to my remark: | If you re

Re: bug in italian version of lyx

2006-06-19 Thread Jean-Marc Lasgouttes
> "Massimiliano" == Massimiliano Sist <[EMAIL PROTECTED]> writes: Massimiliano> Hi I'm an italian user of lyx. Sorry for my english. I Massimiliano> find a possible bug in lyx 1.4.1. I use debian etch Massimiliano> (testing). This error appear in italian version of lyx, Massimiliano> but I tra

Re: [PATCH] GUI API Cleanup Merge patch

2006-06-19 Thread Lars Gullik Bjønnes
Abdelrazak Younes <[EMAIL PROTECTED]> writes: | Lars Gullik Bjønnes wrote: | > Abdelrazak Younes <[EMAIL PROTECTED]> writes: | > | > | LyXGui | > | > | GuiGui | > | > | MyGui | > | > | MyGuiIsBig | > | > I think I liked 'GuiInstance' | > | | Good. | > | | > | If you really insist I will use MainGu

Re: [PATCH] GUI API Cleanup Merge patch

2006-06-19 Thread Lars Gullik Bjønnes
Abdelrazak Younes <[EMAIL PROTECTED]> writes: | Lars Gullik Bjønnes wrote: | > [EMAIL PROTECTED] (Lars Gullik Bjønnes) writes: | > | Abdelrazak Younes <[EMAIL PROTECTED]> writes: | > | | | UniqueGui | > | | UniqueGuiInstance | > | | GuiImplementation | > | | GuiInstance | > | | LarsGui | > | | Ahh

Re: image dialog question

2006-06-19 Thread Enrico Forestieri
On Mon, Jun 19, 2006 at 02:28:31PM +0200, Georg Baum wrote: > Jean-Marc Lasgouttes wrote: > > > The path which is passed to edit or view is of the internal type, I > > guess. Shouldn't we do something special before putting it on the > > command line? > > Yes, we should. This was already wrong be

Re: [patch] font selection redesign completed

2006-06-19 Thread Bennett Helm
On Jun 17, 2006, at 12:55 PM, Juergen Spitzmueller wrote: Please find attached the completed and fully functional version of the font selection rewrite (posted patch + working screen font family switch + scale gui implementation + lyx2lyx from Georg (modified) + xforms & qt4 gui + support

Re: [PATCH] GUI API Cleanup Merge patch

2006-06-19 Thread Abdelrazak Younes
Lars Gullik Bjønnes wrote: Abdelrazak Younes <[EMAIL PROTECTED]> writes: | > | LyXGui | > | GuiGui | > | MyGui | > | MyGuiIsBig | > I think I liked 'GuiInstance' | | Good. | | > | If you really insist I will use MainGui because the kernel won't | > see | > | it anyway and the rest will just u

Re: [Better patch] Re: [Patch] Re: Drawing error with collapsable insets.

2006-06-19 Thread Bennett Helm
On Jun 18, 2006, at 5:24 AM, Martin Vermeer wrote: On Sat, Jun 17, 2006 at 11:24:51PM +0300, Martin Vermeer wrote: On Wed, Jun 14, 2006 at 11:14:19AM +0300, Martin Vermeer wrote: ... PS Getting rid of Wide() would only be possible if you have, inside insettext, access to the _maximum_ left a

Re: [PATCH] GUI API Cleanup Merge patch

2006-06-19 Thread Abdelrazak Younes
Lars Gullik Bjønnes wrote: [EMAIL PROTECTED] (Lars Gullik Bjønnes) writes: | Abdelrazak Younes <[EMAIL PROTECTED]> writes: | | | UniqueGui | | UniqueGuiInstance | | GuiImplementation | | GuiInstance | | LarsGui | | Ahh... you are tickling my ego. | | | LyXGui | | GuiGui | | MyGui | | MyGuiI

Re: [PATCH] GUI API Cleanup Merge patch

2006-06-19 Thread Lars Gullik Bjønnes
Abdelrazak Younes <[EMAIL PROTECTED]> writes: | > | LyXGui | > | GuiGui | > | MyGui | > | MyGuiIsBig | > I think I liked 'GuiInstance' | | Good. | | > | If you really insist I will use MainGui because the kernel won't | > see | > | it anyway and the rest will just use "theApp->gui()". | > with q

Re: [PATCH] GUI API Cleanup Merge patch

2006-06-19 Thread Abdelrazak Younes
Lars Gullik Bjønnes wrote: Abdelrazak Younes <[EMAIL PROTECTED]> writes: | UniqueGui | UniqueGuiInstance | GuiImplementation | GuiInstance | LarsGui Ahh... you are tickling my ego. ;-) | LyXGui | GuiGui | MyGui | MyGuiIsBig I think I liked 'GuiInstance' Good. | If you really insist I

Re: [PATCH] GUI API Cleanup Merge patch

2006-06-19 Thread Lars Gullik Bjønnes
[EMAIL PROTECTED] (Lars Gullik Bjønnes) writes: | Abdelrazak Younes <[EMAIL PROTECTED]> writes: | | | UniqueGui | | UniqueGuiInstance | | GuiImplementation | | GuiInstance | | LarsGui | | Ahh... you are tickling my ego. | | | LyXGui | | GuiGui | | MyGui | | MyGuiIsBig | | I think I liked 'GuiI

Re: [PATCH] GUI API Cleanup Merge patch

2006-06-19 Thread Lars Gullik Bjønnes
Abdelrazak Younes <[EMAIL PROTECTED]> writes: | UniqueGui | UniqueGuiInstance | GuiImplementation | GuiInstance | LarsGui Ahh... you are tickling my ego. | LyXGui | GuiGui | MyGui | MyGuiIsBig I think I liked 'GuiInstance' | If you really insist I will use MainGui because the kernel won't see

Re: [Better patch] Re: [Patch] Re: Drawing error with collapsable insets.

2006-06-19 Thread Jean-Marc Lasgouttes
> "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: Martin> On Mon, 2006-06-19 at 12:52 +0200, Jean-Marc Lasgouttes wrote: >> > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: >> Martin> Here's the patch you've been looking for... it simplifies Martin> things which is always a

Re: [PATCH] GUI API Cleanup Merge patch

2006-06-19 Thread Abdelrazak Younes
Lars Gullik Bjønnes wrote: Abdelrazak Younes <[EMAIL PROTECTED]> writes: | Lars Gullik Bjønnes wrote: | > Abdelrazak Younes <[EMAIL PROTECTED]> writes: | | > | > | + lyx::frontend::WorkArea * work_area_; | > | > Do we want bald pointers? Even just as cache? | > | | I can't use reference becaus

Re: [PATCH] Re-orgnization of scons and generatiion of multiple config.h

2006-06-19 Thread Abdelrazak Younes
Bo Peng wrote: Abdel, Attached patch adds $BUILDDIR/config/config.h $BUILDDIR/config/boost_config.h with the following behaviors: 1. boost only uses boost_config.h 2. config.h includes boost_config.h 3. different builds have different config.h (nls etc may change from build to build). Tested

Re: [PATCH] some scons correction (wa Re: [PATCH] Re-orgnization of scons and generatiion of multiple config.h)

2006-06-19 Thread Abdelrazak Younes
Bo Peng wrote: intl should have its own config.h. Do you see that generated (intl/config.h) Yes it is in trunk/intl/config.h which is bad (see my other mail). The problem lies in the include options I think. One scenario this fails is that the first run does not have gettext=included, s

Re: [PATCH] GUI API Cleanup Merge patch

2006-06-19 Thread Lars Gullik Bjønnes
Abdelrazak Younes <[EMAIL PROTECTED]> writes: | Lars Gullik Bjønnes wrote: | > Abdelrazak Younes <[EMAIL PROTECTED]> writes: | | > | > | + lyx::frontend::WorkArea * work_area_; | > | > Do we want bald pointers? Even just as cache? | > | | I can't use reference because I want to be able to cha

Re: [PATCH] some scons correction (wa Re: [PATCH] Re-orgnization of scons and generatiion of multiple config.h)

2006-06-19 Thread Abdelrazak Younes
Abdelrazak Younes wrote: I have fixed with brute force the manifest problem. Feel free to find a better solution. Patch attached. Sorry, this patch was against my branch. Please find attached the patch against trunk. Abdel. Index: SConstruct ===

Re: [PATCH] some scons correction (wa Re: [PATCH] Re-orgnization of scons and generatiion of multiple config.h)

2006-06-19 Thread Bo Peng
On 6/19/06, Abdelrazak Younes <[EMAIL PROTECTED]> wrote: Abdelrazak Younes wrote: > Bo Peng wrote: >> Abdel, >> >> Attached patch adds >> >> $BUILDDIR/config/config.h >> $BUILDDIR/config/boost_config.h >> >> with the following behaviors: >> 1. boost only uses boost_config.h >> 2. config.h include

Re: [PATCH] some scons correction (wa Re: [PATCH] Re-orgnization of scons and generatiion of multiple config.h)

2006-06-19 Thread Abdelrazak Younes
Abdelrazak Younes wrote: Bo Peng wrote: Abdel, Attached patch adds $BUILDDIR/config/config.h $BUILDDIR/config/boost_config.h with the following behaviors: 1. boost only uses boost_config.h 2. config.h includes boost_config.h 3. different builds have different config.h (nls etc may change from

Re: [PATCH] GUI API Cleanup Merge patch

2006-06-19 Thread Abdelrazak Younes
Lars Gullik Bjønnes wrote: [EMAIL PROTECTED] (Lars Gullik Bjønnes) writes: | | > | +lyx::frontend::WorkArea * work_area_; | | > Do we want bald pointers? Even just as cache? | | | | I can't use reference because I want to be able to change work_area_ | | at run-time. This work_area_ is not

Re: [PATCH] GUI API Cleanup Merge patch

2006-06-19 Thread Abdelrazak Younes
Lars Gullik Bjønnes wrote: Abdelrazak Younes <[EMAIL PROTECTED]> writes: | > | + lyx::frontend::WorkArea * work_area_; | > Do we want bald pointers? Even just as cache? | | I can't use reference because I want to be able to change work_area_ | at run-time. This work_area_ is not created

Re: [patch] font selection redesign completed

2006-06-19 Thread Juergen Spitzmueller
Georg Baum wrote: > It would only make sense with GUI support. If that would mean that a > QSpinbox can't be used then I think it is not worth it. There are plenty of (unofficial) QFloatSpinboxes around in the Web. Perhaps we should just implement one of those (or derive our own) eventually, if t

Re: [PATCH] GUI API Cleanup Merge patch

2006-06-19 Thread Lars Gullik Bjønnes
[EMAIL PROTECTED] (Lars Gullik Bjønnes) writes: | | > | + lyx::frontend::WorkArea * work_area_; | | > Do we want bald pointers? Even just as cache? | | | | I can't use reference because I want to be able to change work_area_ | | at run-time. This work_area_ is not created nor deleted here s

Re: The advantage of any

2006-06-19 Thread Angus Leeming
Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: > Note that unicode is currently held up by the inability to send > anything else than std::string as args to FuncRequest. (And I don't > want to convert back and forth uft-8 <-> ucs-4 (or utf-16) all the > time.) > So I am currently stalled by boost

Re: [PATCH] GUI API Cleanup Merge patch

2006-06-19 Thread Lars Gullik Bjønnes
Abdelrazak Younes <[EMAIL PROTECTED]> writes: | > | |// Build temporary cursor. | > | - cmd.y = min(max(cmd.y,-1), workarea().workHeight()); | > | + cmd.y = min(max(cmd.y,-1), workarea().height()); | > spacing | | You mean: | | cmd.y = min(max(cmd.y, -1), workarea().height()); |

[PATCH] some scons correction (wa Re: [PATCH] Re-orgnization of scons and generatiion of multiple config.h)

2006-06-19 Thread Abdelrazak Younes
Bo Peng wrote: Abdel, Attached patch adds $BUILDDIR/config/config.h $BUILDDIR/config/boost_config.h with the following behaviors: 1. boost only uses boost_config.h 2. config.h includes boost_config.h 3. different builds have different config.h (nls etc may change from build to build). Tested

Re: The advantage of any

2006-06-19 Thread Lars Gullik Bjønnes
Angus Leeming <[EMAIL PROTECTED]> writes: | Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: | > Yes, but we have been through this ealier as well. Remember that this | > is not the first time I have posted the any patch. | | Only vaguely (as in I remember a patch but not what it contained). It w

  1   2   >