On Mon, Jun 19, 2006 at 02:28:31PM +0200, Georg Baum wrote: > Jean-Marc Lasgouttes wrote: > > > The path which is passed to edit or view is of the internal type, I > > guess. Shouldn't we do something special before putting it on the > > command line? > > Yes, we should. This was already wrong before (but will hurt more often with > the full path). I simply overlooked that. Can some windows person please > confirm that the attached patch (for 1.5) works, especially for > 'problematic' file names? > Maybe we should keep this in 1.5 a while before putting it into 1.4.
Notice that there many places where the internal path is used. This has never been a problem, rather the introduction of external_path() and internal_path() has been, I would say. The only difference in Windows is the use of \ instead of /, and this is quite useless, as both are acceptable. The funny thing is that external_path() and internal_path() were introduced specifically for Windows whereas they would have maked sense only for cygwin to distinguish between posix and native paths. I regularly patch LyX such that I have the kind of path styles I like (both external_path and internal_path return the same style), so I am able to say that this game is useless. IMO, external_path() makes sense only for cygwin, to be sure that a native style path is returned where a truly native path is required. There are very few places where this is really required. Until external_path() and internal_path() are used the way they currently are, I will continue to patch LyX as explained above. -- Enrico
