Re: Format hack in client.C

2004-11-08 Thread Georg Baum
Herbert Voss wrote: > Georg Baum wrote: > >> Here comes the patch. I removed the useless "user" format in the process. >> Now getFormatFromContents() either returns a format name or an empty >> string if it cannot determine the format. I even found two cases where >> the return value of getFormat

Re: [PATCH/FYI] NVI for the masses.

2004-11-08 Thread Vladimir Prus
Lars Gullik Bj?nnes wrote: > | I'm not sure I understand the separation argument -- the extra > | forwarding layer just adds complexity (e.g. your change to inMatched() > | in insets/insetbase.h just double the number of characters ;-) ), but > | anyway... > > For a grand total of _one_ line. :-

Re: [PATCH/FYI] NVI for the masses.

2004-11-08 Thread Lars Gullik Bjønnes
Vladimir Prus <[EMAIL PROTECTED]> writes: | Lars Gullik Bj?nnes wrote: > >> | Maybe I shouldn't comment on C++ programming style, but for >> | a Java programmer NVI doesn't feel good. Do you have a scenario >> | where NVI saves the day? >> >> Depends on your definition of saves the day. To me sep

Re: [PATCH/FYI] NVI for the masses.

2004-11-08 Thread Vladimir Prus
Lars Gullik Bj?nnes wrote: > | Maybe I shouldn't comment on C++ programming style, but for > | a Java programmer NVI doesn't feel good. Do you have a scenario > | where NVI saves the day? > > Depends on your definition of saves the day. To me separation of > implementation and interface should be

Re: [PATCH/FYI] NVI for the masses.

2004-11-08 Thread Lars Gullik Bjønnes
Andreas Vox <[EMAIL PROTECTED]> writes: | Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: > >> What price is payed? >> (there is one extra line in the base class, and a bit different way of >> thinking about interfaces vs. implementation.) > | That seems to be the price, yes. I don't want to disc

[CoordBranch] Selection

2004-11-08 Thread Alfredo Braunstein
now that drawSelection is separated from draw and called before it, the background painting of colored insets overwrites the selection. A possible way of solving this is to draw the background in InsetText::drawSelection instead of InsetText::draw (need to change LyXText::drawSelection a little bi

Re: [CoordBranch] ascent_of_text

2004-11-08 Thread Alfredo Braunstein
Andre Poenitz wrote: >> It seems it was used to introduce some extra space above rows (for adding >> the "Bibliography" label for instance). > > That's my assumption, too. > >> Is the extra information really not needed? > > I don't think so, at least if the assumption is correct. We always dra

Re: LyX Status

2004-11-08 Thread Alfredo Braunstein
Josà AbÃlio Oliveira Matos wrote: > Hi all, >cutting the nonsense and being objective what needs to be done to >release > a stable 1.4.0? > >Is it reasonable to have a HEAD that has problems while Alfredo is >fixing > the bugs in the other branch? Mmmm I'm not fixing bugs that ar

Re: [PATCH/FYI] NVI for the masses.

2004-11-08 Thread Andreas Vox
Lars Gullik BjÃnnes <[EMAIL PROTECTED]> writes: > What price is payed? > (there is one extra line in the base class, and a bit different way of > thinking about interfaces vs. implementation.) That seems to be the price, yes. I don't want to discuss if it's a high price or a small price; I don't

Re: [PATCH][Bug 1720] LyX/Mac: Menus are not correctly disabled when a dialog has focus

2004-11-08 Thread Andreas Vox
Josà AbÃlio Oliveira Matos <[EMAIL PROTECTED]> writes: > > Why is everyone flame-baiting always Lars, I wonder? > > FWIW I wasn't flame-baiting Lars, there times where Lars (as any of us) > deserves criticism, but not this time. What I meant by flame-baiting is more "deliberately attracting cr

Re: [PATCH][Bug 1720] LyX/Mac: Menus are not correctly disabled when a dialog has focus

2004-11-08 Thread José Abílio Oliveira Matos
On Mon, Nov 08, 2004 at 10:55:53PM +, Andreas Vox wrote: > > > (Are you listening Lars?) > > > > :-D > > Why is everyone flame-baiting always Lars, I wonder? FWIW I wasn't flame-baiting Lars, there times where Lars (as any of us) deserves criticism, but not this time. For those who

LyX Status

2004-11-08 Thread José Abílio Oliveira Matos
Hi all, cutting the nonsense and being objective what needs to be done to release a stable 1.4.0? Is it reasonable to have a HEAD that has problems while Alfredo is fixing the bugs in the other branch? Looking in bugzilla for bugs related with 1.4.0, blocker, critical, major and normal I

Re: [PATCH][Bug 1720] LyX/Mac: Menus are not correctly disabled when a dialog has focus

2004-11-08 Thread Lars Gullik Bjønnes
Andreas Vox <[EMAIL PROTECTED]> writes: | José Abílio Oliveira Matos <[EMAIL PROTECTED]> writes: > >> On Mon, Nov 08, 2004 at 01:43:40PM +, Andreas Vox wrote: >> > >> > BTW, what do you think of switching to Java for LyX 1.5.0? >> >> Python would be a lot faster, and it has good interfac

Re: [PATCH/FYI] NVI for the masses.

2004-11-08 Thread Lars Gullik Bjønnes
Andreas Vox <[EMAIL PROTECTED]> writes: | Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: > >> | | In my country there used to be a law against selling overprized goods >> | | by bundling it with free giveaways >> > >> | I am not quite sure why you consider this overprized goods. >> | (I presume

Re: [PATCH][Bug 1720] LyX/Mac: Menus are not correctly disabled when a dialog has focus

2004-11-08 Thread Andreas Vox
Josà AbÃlio Oliveira Matos <[EMAIL PROTECTED]> writes: > On Mon, Nov 08, 2004 at 01:43:40PM +, Andreas Vox wrote: > > > > BTW, what do you think of switching to Java for LyX 1.5.0? > > Python would be a lot faster, and it has good interfaces for xform, qt, > gtk and curses. But with Java

Re: booktabs

2004-11-08 Thread Andreas Vox
Alfredo Braunstein <[EMAIL PROTECTED]> writes: > I see. And what's the improvement wrt to plain LaTeX tables? The ability to > put horizontal lines independently in any column? LaTeX does support that AFAIK. The improvement should be that you *can't* put lines anywhere you want. Or, as the maste

Re: [PATCH/FYI] NVI for the masses.

2004-11-08 Thread Andreas Vox
Lars Gullik BjÃnnes <[EMAIL PROTECTED]> writes: > | | In my country there used to be a law against selling overprized goods > | | by bundling it with free giveaways > > > | I am not quite sure why you consider this overprized goods. > | (I presume you are talking about NVI) Yes. > | If you have

Re: [PATCH][Bug 1720] LyX/Mac: Menus are not correctly disabled when a dialog has focus

2004-11-08 Thread Lars Gullik Bjønnes
José Abílio Oliveira Matos <[EMAIL PROTECTED]> writes: | On Mon, Nov 08, 2004 at 01:43:40PM +, Andreas Vox wrote: >> >> BTW, what do you think of switching to Java for LyX 1.5.0? > | Python would be a lot faster, and it has good interfaces for xform, qt, | gtk and curses. (Are you listening

Re: [PATCH][Bug 1720] LyX/Mac: Menus are not correctly disabled when a dialog has focus

2004-11-08 Thread José Abílio Oliveira Matos
On Mon, Nov 08, 2004 at 01:43:40PM +, Andreas Vox wrote: > > BTW, what do you think of switching to Java for LyX 1.5.0? Python would be a lot faster, and it has good interfaces for xform, qt, gtk and curses. (Are you listening Lars?) ;-) :-D > Ciao > /Andreas -- José Abílio Matos LyX

Re: booktabs

2004-11-08 Thread Alfredo Braunstein
Andreas Vox wrote: > "Any layout with a vertical line can be improved immediately by removing > that line" -- I don't remember where this quote comes from, but as you > will have noticed, most LaTeX tables have lots of vertical lines which can > be improved ;-) > > Formal tables have only one hor

Re: Hints to test new branch.

2004-11-08 Thread José Abílio Oliveira Matos
On Mon, Nov 08, 2004 at 09:06:15PM +0100, Andre Poenitz wrote: > > I should be quite a bit faster when loading long documents as the > 'fullRebreak' is gone... That is visible when loading the User Guide. > Andre' -- José Abílio Matos LyX and docbook a perfect match. :-)

Re: booktabs

2004-11-08 Thread Andreas Vox
Alfredo Braunstein <[EMAIL PROTECTED]> writes: > > I might be swayed if all three of you test and "perfect" this patch. > > I offer myself to test it if somebody explain me what's about "Any layout with a vertical line can be improved immediately by removing that line" -- I don't remember where

Re: [PATCH/FYI] NVI for the masses.

2004-11-08 Thread Lars Gullik Bjønnes
[EMAIL PROTECTED] (Lars Gullik Bjønnes) writes: | Andreas Vox <[EMAIL PROTECTED]> writes: > | | Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: >> | | | One, obvious benefit, albeit minor, is that after I go throught the | | | code, it will all look the same. And as I mentioned: bug has also been

Re: [PATCH/FYI] NVI for the masses.

2004-11-08 Thread Lars Gullik Bjønnes
Andreas Vox <[EMAIL PROTECTED]> writes: | Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: > | | One, obvious benefit, albeit minor, is that after I go throught the | | code, it will all look the same. And as I mentioned: bug has also been | | found because of this work. > | In my country there us

Re: [PATCH/FYI] NVI for the masses.

2004-11-08 Thread Andreas Vox
Lars Gullik BjÃnnes <[EMAIL PROTECTED]> writes: | One, obvious benefit, albeit minor, is that after I go throught the | code, it will all look the same. And as I mentioned: bug has also been | found because of this work. In my country there used to be a law against selling overprized goods by bun

Re: [CoordBranch] ascent_of_text

2004-11-08 Thread Andre Poenitz
On Mon, Nov 08, 2004 at 08:45:41PM +0100, Alfredo Braunstein wrote: > Andre, do you have an idea of exactly what ascent_of_text was (wrt. ascent)? Not "exactly". See below. > Because we are having weird text painting problems, probably related to its > removal. > > It seems it was used to intro

Re: Hints to test new branch.

2004-11-08 Thread Andre Poenitz
On Mon, Nov 08, 2004 at 03:38:22PM +0100, Alfredo Braunstein wrote: > - scrollbar (needs an approximated heuristic, because we don't know the full > y size of the document) - see Andre's post Maybe I should clarify a bit what I wrote there. Our 'new' problem is that in the new scheme we don't ha

Re: [PATCH][Bug 1720] LyX/Mac: Menus are not correctly disabled when a dialog has focus

2004-11-08 Thread Andre Poenitz
On Mon, Nov 08, 2004 at 01:43:40PM +, Andreas Vox wrote: > BTW, what do you think of switching to Java for LyX 1.5.0? I am definitely missing a smiley here. It's not Friday, after all. Andre'

Re: [PATCH] Some code factorization in toolbars

2004-11-08 Thread Andre Poenitz
On Mon, Nov 08, 2004 at 05:54:09PM +0100, Jean-Marc Lasgouttes wrote: > > The following patch introduce the new free-standing function > layoutSelected that replaces three similar pieces of code in the > frontends. > > I'll apply shortly. I'd rather see strings passed as reference. Andre'

Re: Hints to test new branch.

2004-11-08 Thread Andre Poenitz
On Mon, Nov 08, 2004 at 02:16:12PM +, José Abílio Oliveira Matos wrote: > I have placed it side by side with HEAD and it is faster. I should be quite a bit faster when loading long documents as the 'fullRebreak' is gone... Andre'

Re: Format hack in client.C

2004-11-08 Thread Lars Gullik Bjønnes
Georg Baum <[EMAIL PROTECTED]> writes: | +string Formats::getFormatFromFile(string const & filename) const | +{ | + if (filename.empty()) | + return string(); | + | + string const format = | lyx::support::getFormatFromContents(filename) This is a wrapper... is formatlist a

Re: Format hack in client.C

2004-11-08 Thread Lars Gullik Bjønnes
Herbert Voss <[EMAIL PROTECTED]> writes: | Georg Baum wrote: > >> Here comes the patch. I removed the useless "user" format in the process. >> Now getFormatFromContents() either returns a format name or an empty string >> if it cannot determine the format. I even found two cases where the return >

Re: Format hack in client.C

2004-11-08 Thread Lars Gullik Bjønnes
Georg Baum <[EMAIL PROTECTED]> writes: | Lars Gullik Bjønnes wrote: > >> Georg Baum <[EMAIL PROTECTED]> >> writes: >> | Would it be ok with you to have something like >> | Format const *Formats::getFormatFromFile(string filename) >> | that does what getFormatFromContents() did before your patch? >

Re: [PATCH] Some code factorization in toolbars

2004-11-08 Thread Lars Gullik Bjønnes
Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: | The following patch introduce the new free-standing function | layoutSelected that replaces three similar pieces of code in the | frontends. > | I'll apply shortly. > | JMarc > > | Index: src/frontends/ChangeLog | =

Re: [PATCH][Bug 1720] LyX/Mac: Menus are not correctly disabled when a dialog has focus

2004-11-08 Thread Andre Poenitz
On Mon, Nov 08, 2004 at 01:13:34PM +0100, Lars Gullik Bjønnes wrote: > NVI. > > bool hasFocus() const { return doHasFocus(); } > > private: > > virtual bool doHasFocus() const = 0; > > > Ooohh... so nice. > > separation of interface and implementation. Isn't it surprising tha

Re: [PATCH/FYI] NVI for the masses.

2004-11-08 Thread Andre Poenitz
On Mon, Nov 08, 2004 at 01:09:09PM +0100, Lars Gullik Bjønnes wrote: > | I don't think the ideas are completely wrong but I don't see the big > | benefit either. > > One, obvious benefit, albeit minor, is that after I go throught the > code, it will all look the same. And as I mentioned: bug has a

Re: booktabs

2004-11-08 Thread Alfredo Braunstein
Lars Gullik BjÃnnes wrote: > | I never did that before. But if it is so much work, I do not want that > | anymore. I just did not want to pass patches around, because that can > | quickly become a pain, too. > | Note that I am in favour of the feature freeze, too, and that I do not > | come up wit

Re: Format hack in client.C

2004-11-08 Thread Herbert Voss
Georg Baum wrote: Here comes the patch. I removed the useless "user" format in the process. Now getFormatFromContents() either returns a format name or an empty string if it cannot determine the format. I even found two cases where the return value of getFormatFromContents() needed to be checked. t

Re: booktabs

2004-11-08 Thread Lars Gullik Bjønnes
Georg Baum <[EMAIL PROTECTED]> writes: | Alfredo Braunstein wrote: > >> Andre Poenitz wrote: >> That'd be good (so we could work on it together). I never created a branch myself, though. >>> >>> Working with branches is a pain, frustrates people and eats into already >>> scrace resourc

[CoordBranch] ascent_of_text

2004-11-08 Thread Alfredo Braunstein
Andre, do you have an idea of exactly what ascent_of_text was (wrt. ascent)? Because we are having weird text painting problems, probably related to its removal. It seems it was used to introduce some extra space above rows (for adding the "Bibliography" label for instance). Is the extra informat

Re: booktabs

2004-11-08 Thread Georg Baum
Alfredo Braunstein wrote: > Andre Poenitz wrote: > >>> That'd be good (so we could work on it together). I never created a >>> branch myself, though. >> >> Working with branches is a pain, frustrates people and eats into already >> scrace resources. I never did that before. But if it is so much

Re: Format hack in client.C

2004-11-08 Thread Georg Baum
Lars Gullik Bjønnes wrote: > Georg Baum <[EMAIL PROTECTED]> > writes: > | Would it be ok with you to have something like > | Format const *Formats::getFormatFromFile(string filename) > | that does what getFormatFromContents() did before your patch? > > Yes. > > One solution will be a wrapper fun

Re: About bug 1682

2004-11-08 Thread Jean-Marc Lasgouttes
> "Juergen" == Juergen Spitzmueller <[EMAIL PROTECTED]> writes: Juergen> http://bugzilla.lyx.org/show_bug.cgi?id=1682 LyX 1.4 crashes Juergen> when you insert something like "1.3a" into a length widget Juergen> (e.g. VSpace, Margins). The reason is that Juergen> isValidGlueLength("1.3a") retur

[PATCH] Some code factorization in toolbars

2004-11-08 Thread Jean-Marc Lasgouttes
The following patch introduce the new free-standing function layoutSelected that replaces three similar pieces of code in the frontends. I'll apply shortly. JMarc Index: src/frontends/ChangeLog === RCS file: /usr/local/lyx/cvsroot/

Re: [PATCH][Bug 1720] LyX/Mac: Menus are not correctly disabled when a dialog has focus

2004-11-08 Thread Jean-Marc Lasgouttes
> "Bennett" == Bennett Helm <[EMAIL PROTECTED]> writes: Bennett> The trouble in part is that the Mac's native file open/save Bennett> dialogs (which we now use) are drop-down sheets. When a Bennett> dialog is open in front of the main application window, these Bennett> sheets drop down from th

postscript preview: convert problem in Cygwin

2004-11-08 Thread Kayvan A. Sylvan
Hi everyone, Under Cygwin, I can't seem to see postscript images in LyX, though the output looks just fine. I have traced the issue to an ImageMagick/convert problem. Does any of this ring a bell? Does anyone have postscript image preview working under Cygwin? $ convert -depth 8 eps:/home/ksylva

Re: [PATCH][Bug 1720] LyX/Mac: Menus are not correctly disabled when a dialog has focus

2004-11-08 Thread Bennett Helm
On Nov 8, 2004, at 10:46 AM, Jean-Marc Lasgouttes wrote: Bennett> Mostly it works. However, some menu options are still Bennett> available when they shouldn't be, IMO. These are: Bennett> File > New Bennett> File > New from Template ... Bennett> File > Open ... Bennett> File > Open recent > [everyt

Re: [PATCH][Bug 1720] LyX/Mac: Menus are not correctly disabled when a dialog has focus

2004-11-08 Thread Jean-Marc Lasgouttes
> "Bennett" == Bennett Helm <[EMAIL PROTECTED]> writes: Bennett> On Nov 8, 2004, at 6:49 AM, Jean-Marc Lasgouttes wrote: >> The following patch tries to fix properly bug 1720. Obviously, I >> do not have LyX/Mac, so I would be grateful if Andreas or Bennett >> could test it for me :) Bennett

Re: [PATCH][Bug 1720] LyX/Mac: Menus are not correctly disabled when a dialog has focus

2004-11-08 Thread Bennett Helm
On Nov 8, 2004, at 6:49 AM, Jean-Marc Lasgouttes wrote: The following patch tries to fix properly bug 1720. Obviously, I do not have LyX/Mac, so I would be grateful if Andreas or Bennett could test it for me :) Mostly it works. However, some menu options are still available when they shouldn't be,

Re: Hints to test new branch.

2004-11-08 Thread Alfredo Braunstein
Lars Gullik BjÃnnes wrote: > I have been running HEAD a bit with X-forwarding over a 802.11b net, > and that is not fast at all... (to much redrawing I think). > I'll check with the coord branch as well. If I'm not mistaken, you shouldn't see much: the difference is in rebreaking and painting in

Re: Hints to test new branch.

2004-11-08 Thread Lars Gullik Bjønnes
José Abílio Oliveira Matos <[EMAIL PROTECTED]> writes: >> IMO, it should even be much faster... we are probably wasting cycles >> somewhere. Work for later. > | For the user guide it seems as if lyx2lyx is now the bottleneck. :-) | But still acceptable on my laptop. :-) I have been running HE

Re: [PATCH][Bug 1720] LyX/Mac: Menus are not correctly disabled when a dialog has focus

2004-11-08 Thread Lars Gullik Bjønnes
Andreas Vox <[EMAIL PROTECTED]> writes: | Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: > | < NVI. | < | < bool hasFocus() const { return doHasFocus(); } | < | < private: | < | < virtual bool doHasFocus() const = 0; | < | < Ooohh... so nice. > | As a Java programmer it makes

Re: [PATCH][Bug 1720] LyX/Mac: Menus are not correctly disabled when a dialog has focus

2004-11-08 Thread Lars Gullik Bjønnes
Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: >> "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: > | Lars> NVI! > | Yes, I thought about that, and decided to stay in VI world for now :) > | What I do not like about NVI is that, when I am trying to look at a | piece of code I can o

Re: Hints to test new branch.

2004-11-08 Thread José Abílio Oliveira Matos
On Mon, Nov 08, 2004 at 03:38:22PM +0100, Alfredo Braunstein wrote: > > The most prominent I see are: > > - cursor movement that needs coordinates outside screen (like cursor up in > the first line, cursor down in the last one, pgup, pgdown, the cursor X > target) are non-functional. I'll work on

Re: Hints to test new branch.

2004-11-08 Thread Alfredo Braunstein
Alfredo Braunstein wrote: > - for some reason selecting with the mouse only works if you start your > selection with double click. Go figure. in xforms I mean. qt works well. Alfredo

Re: Hints to test new branch.

2004-11-08 Thread Alfredo Braunstein
Josà AbÃlio Oliveira Matos wrote: > On Mon, Nov 08, 2004 at 03:08:31PM +0100, Alfredo Braunstein wrote: >> >> > That is it doesn't work at all. Only when I can move the scrool bar >> > the >> > cursor is moved, else it stays always in the same place. >> >> As it should ;-) > > Good. > >

Re: Hints to test new branch.

2004-11-08 Thread José Abílio Oliveira Matos
On Mon, Nov 08, 2004 at 03:08:31PM +0100, Alfredo Braunstein wrote: > > > That is it doesn't work at all. Only when I can move the scrool bar the > > cursor is moved, else it stays always in the same place. > > As it should ;-) Good. What needs to be done in this branch? I have plac

Re: Hints to test new branch.

2004-11-08 Thread Alfredo Braunstein
Josà AbÃlio Oliveira Matos wrote: >> Yep... there's an error on how the scrollbar size and jump amount are >> computed. But since what we have now is just a rough approximation... >> there's no use in fine-tuning it. >> I thought that you were saying that the scrollwheel didn't do anything at >> a

Re: [PATCH][Bug 1720] LyX/Mac: Menus are not correctly disabled when a dialog has focus

2004-11-08 Thread Andreas Vox
Lars Gullik BjÃnnes <[EMAIL PROTECTED]> writes: < NVI. < < bool hasFocus() const { return doHasFocus(); } < < private: < < virtual bool doHasFocus() const = 0; < < Ooohh... so nice. As a Java programmer it makes me for sure shudder with envy ... ;-) < < separation of interfa

Re: [PATCH][Bug 1720] LyX/Mac: Menus are not correctly disabled when a dialog has focus

2004-11-08 Thread Jean-Marc Lasgouttes
> "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: Lars> NVI! Yes, I thought about that, and decided to stay in VI world for now :) What I do not like about NVI is that, when I am trying to look at a piece of code I can only follow it if I go inside headers to check if the method re

Re: Hints to test new branch.

2004-11-08 Thread José Abílio Oliveira Matos
On Mon, Nov 08, 2004 at 01:32:42PM +0100, Alfredo Braunstein wrote: > José Abílio Oliveira Matos wrote: > > > > I hope you see what I mean. :-) > > Yep... there's an error on how the scrollbar size and jump amount are > computed. But since what we have now is just a rough approximation... > the

Re: [PATCH][Bug 1720] LyX/Mac: Menus are not correctly disabled when a dialog has focus

2004-11-08 Thread Lars Gullik Bjønnes
Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: | Index: src/frontends/LyXView.h | === | RCS file: /usr/local/lyx/cvsroot/lyx-devel/src/frontends/LyXView.h,v | retrieving revision 1.33 | diff -u -p -r1.33 LyXView.h | --- src/frontend

Re: Hints to test new branch.

2004-11-08 Thread Alfredo Braunstein
Josà AbÃlio Oliveira Matos wrote: > On Sun, Nov 07, 2004 at 10:22:46PM +0100, Alfredo Braunstein wrote: >> >> > - the wheel mouse doesn't work for navigating the document; >> >> it seems to work here. There's still the problem that the finest >> scrolling is 1 par... > > As I have told

Re: [PATCH][Bug 1720] LyX/Mac: Menus are not correctly disabled when a dialog has focus

2004-11-08 Thread Lars Gullik Bjønnes
Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: | All it needs to do its magic is to introduce a new virtual method | LyXView::hasFocus, which is only meaningfully implemented for Qt right | now. NVI! -- Lgb

About bug 1682

2004-11-08 Thread Juergen Spitzmueller
http://bugzilla.lyx.org/show_bug.cgi?id=1682 LyX 1.4 crashes when you insert something like "1.3a" into a length widget (e.g. VSpace, Margins). The reason is that isValidGlueLength("1.3a") returns true, so widgetsToLength returns this as the length value. LyX crashes because this is an invalid

Re: [PATCH/FYI] NVI for the masses.

2004-11-08 Thread Lars Gullik Bjønnes
Andre Poenitz <[EMAIL PROTECTED]> writes: | On Mon, Nov 08, 2004 at 02:20:26AM +0100, Lars Gullik Bjønnes wrote: >> NVI - Nonvirtual Interface pattern. >> >> As some of you might know, I am a sucker for books. >> >> This time I have read "Exceptional C++ Style" by Herb Sutter. There I >> came ac

Re: Hints to test new branch.

2004-11-08 Thread José Abílio Oliveira Matos
On Sun, Nov 07, 2004 at 10:22:46PM +0100, Alfredo Braunstein wrote: > > > - the wheel mouse doesn't work for navigating the document; > > it seems to work here. There's still the problem that the finest scrolling > is 1 par... As I have told you in another message, I'm using xforms to te

[PATCH][Bug 1720] LyX/Mac: Menus are not correctly disabled when a dialog has focus

2004-11-08 Thread Jean-Marc Lasgouttes
The following patch tries to fix properly bug 1720. Obviously, I do not have LyX/Mac, so I would be grateful if Andreas or Bennett could test it for me :) All it needs to do its magic is to introduce a new virtual method LyXView::hasFocus, which is only meaningfully implemented for Qt right now.

Re: [PATCH] Encode origin of request in FuncRequest

2004-11-08 Thread Jean-Marc Lasgouttes
> "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: Lars> Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: >>> "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: >> Lars> | Lars> This should probably get "explcit" now. >> Lars> | I did that and committed. Lars> I hope you s

Re: [PATCH/FYI] NVI for the masses.

2004-11-08 Thread Andre Poenitz
On Mon, Nov 08, 2004 at 02:20:26AM +0100, Lars Gullik Bjønnes wrote: > NVI - Nonvirtual Interface pattern. > > As some of you might know, I am a sucker for books. > > This time I have read "Exceptional C++ Style" by Herb Sutter. There I > came across Item 18, about Virtuality. > > The conclusion

Re: booktabs

2004-11-08 Thread Andre Poenitz
On Sun, Nov 07, 2004 at 08:58:55PM +, John Levon wrote: > > I did try not to respond to this. > > On Sun, Nov 07, 2004 at 08:57:10PM +0100, Andre Poenitz wrote: > > > I'd rather officially lift the freeze for a short while and let > > everybody work on his pet project in this time. This also

Re: [patch] fix qt pref converters mess & crash

2004-11-08 Thread Andre Poenitz
On Sun, Nov 07, 2004 at 09:30:21PM +, John Levon wrote: > On Sun, Nov 07, 2004 at 09:32:50PM +0100, Andre Poenitz wrote: > > > + connect(convertersModule->converterToCO, SIGNAL(activated(const > > QString&)), this, SLOT(converter_changed())); > > > > LyXStyle would be 'QString con

Re: [patch] fix qt pref converters mess & crash

2004-11-08 Thread Jürgen Spitzmüller
Also sprach Jean-Marc Lasgouttes: > This crash was 1.4.0cvs only, right? yes. Jürgen

Re: [PATCH] Encode origin of request in FuncRequest

2004-11-08 Thread Lars Gullik Bjønnes
Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: >> "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: > | Lars> This should probably get "explcit" now. > | I did that and committed. I hope you spell better than me. -- Lgb

Re: [PATCH/FYI] NVI for the masses.

2004-11-08 Thread Lars Gullik Bjønnes
Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: >> "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: > | Lars> NVI - Nonvirtual Interface pattern. > | Lars> As some of you might know, I am a sucker for books. > | And programming concepts ;) > | Lars> The conclusion of that chapter is:

Re: [patch] fix qt pref converters mess & crash

2004-11-08 Thread Jean-Marc Lasgouttes
> "Juergen" == Juergen Spitzmueller <[EMAIL PROTECTED]> writes: Juergen> While doing this, I have also fixed the crash when adding a Juergen> new file format, as described in bug 1692: Juergen> http://bugzilla.lyx.org/show_bug.cgi?id=1692 The crash was Juergen> cured by adding converters().upd

Re: [PATCH] Problem building with the s/SUFFIX/SUFFIXES/ patch

2004-11-08 Thread Jean-Marc Lasgouttes
> "Jean-Marc" == Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: Jean-Marc> Automake 1.6.3 is not happy of setting SUFFIXES twice (once Jean-Marc> in config/common.am and once in Jean-Marc> src/frontends/xforms/forms/Makefile.am) and I need the Jean-Marc> following patch to build. Applied.

Re: [PATCH] Encode origin of request in FuncRequest

2004-11-08 Thread Jean-Marc Lasgouttes
> "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: Lars> This should probably get "explcit" now. I did that and committed. JMarc

Re: [PATCH/FYI] NVI for the masses.

2004-11-08 Thread Jean-Marc Lasgouttes
> "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: Lars> NVI - Nonvirtual Interface pattern. Lars> As some of you might know, I am a sucker for books. And programming concepts ;) Lars> The conclusion of that chapter is: Lars> "Prefer to make base class virtual functions private (o

Re: [PATCH] Problem building with the s/SUFFIX/SUFFIXES/ patch

2004-11-08 Thread Jean-Marc Lasgouttes
> "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: Lars> ah... gch Indeed. JMarc

Re: [PATCH] Problem building with the s/SUFFIX/SUFFIXES/ patch

2004-11-08 Thread Lars Gullik Bjønnes
[EMAIL PROTECTED] (Lars Gullik Bjønnes) writes: | What do we set hte SUFFIXES in common.am for? ah... gch -- Lgb

Re: booktabs

2004-11-08 Thread Alfredo Braunstein
Juergen Spitzmueller wrote: > As to me: don't hold your breath (but at least I fixed two critical bugs > in the last week, and that's surprising enough for a human scientist) ;-) I know. That's more than most of us go human sciences! Alfredo

Re: [PATCH] Problem building with the s/SUFFIX/SUFFIXES/ patch

2004-11-08 Thread Lars Gullik Bjønnes
Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: | Automake 1.6.3 is not happy of setting SUFFIXES twice (once in | config/common.am and once in src/frontends/xforms/forms/Makefile.am) | and I need the following patch to build. > | OK? > | JMarc > > | Index: src/frontends/xforms/forms/Makefile.am

[PATCH] Problem building with the s/SUFFIX/SUFFIXES/ patch

2004-11-08 Thread Jean-Marc Lasgouttes
Automake 1.6.3 is not happy of setting SUFFIXES twice (once in config/common.am and once in src/frontends/xforms/forms/Makefile.am) and I need the following patch to build. OK? JMarc Index: src/frontends/xforms/forms/Makefile.am ==

Re: [patch] fix bug 1730

2004-11-08 Thread Georg Baum
Lars Gullik Bjønnes wrote: > Feel free to change those as well :-) Done. Georg