Andre Poenitz wrote: >> It seems it was used to introduce some extra space above rows (for adding >> the "Bibliography" label for instance). > > That's my assumption, too. > >> Is the extra information really not needed? > > I don't think so, at least if the assumption is correct. We always draw > a densely packes array of rows with no space inbetween. [If we don't, > this it's a bug...] So if we need some extra space somewhere, this > has to be added to the ascent or descent of some row.
Of course. But the information was used to draw the text/label. It may be possible to recompute it (I think I've done it for chapter labels), but I feel we are duplicating not-so-well understood code, and that's bad. > In the bibliography case I'd think it should be sufficient to add enough > room for the label to the ascent of the very first row in the first > bibliography paragraph. Yes, that's what you have done I think. In the case of chapter labels, it had the effect of drawing the word "Chapter" at the wrong coordinates: ascent_of_text was used to compute them. PS: it's not very nice that you have changed so many things unrelated to coordinates in this patch. </rant> Alfredo
