[Lldb-commits] [PATCH] D63052: [Target] Remove Process::GetObjCLanguageRuntime

This revision was automatically updated to reflect the committed changes. Closed by commit rL362981: [Target] Remove Process::GetObjCLanguageRuntime (authored by xiaobai, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LA

[Lldb-commits] [PATCH] D63181: [Target] Decouple ObjCLanguageRuntime from LanguageRuntime

xiaobai created this revision. xiaobai added reviewers: labath, JDevlieghere, davide, compnerd. ObjCLanguageRuntime was being pulled into LanguageRuntime because of Breakpoint Preconditions. I tried a few ideas, but I felt like this was the last invasive. Other ideas I had and reasons I rejected

[Lldb-commits] [PATCH] D63181: [Target] Decouple ObjCLanguageRuntime from LanguageRuntime

xiaobai added a comment. In D63181#1539291 , @JDevlieghere wrote: > Have you considered making just `AddExceptionPrecondition` virtual? Wouldn't > that solve the problem too, without the code duplication of making > `CreateExceptionBreakpoint` virtual?

[Lldb-commits] [PATCH] D63181: [Target] Decouple ObjCLanguageRuntime from LanguageRuntime

xiaobai marked an inline comment as done. xiaobai added a comment. In D63181#1539620 , @labath wrote: > Moving BreakpointPrecondition to a forward-declarable place sounds good to me. Alright, so I think I'll go ahead and change this patch to make that ha

[Lldb-commits] [PATCH] D62797: [Expression] Add PersistentExpressionState::GetCompilerTypeFromPersistentDecl

This revision was automatically updated to reflect the committed changes. Closed by commit rL363183: [Expression] Add PersistentExpressionState::GetCompilerTypeFromPersistentDecl (authored by xiaobai, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Reposito

[Lldb-commits] [PATCH] D63240: [Core] Generalize ValueObject::IsRuntimeSupportValue

xiaobai created this revision. xiaobai added reviewers: labath, compnerd, JDevlieghere, davide. Instead of falling back to ObjCLanguageRuntime, we should be falling back to every loaded language runtime. This makes ValueObject more language agnostic. https://reviews.llvm.org/D63240 Files: inc

[Lldb-commits] [PATCH] D63240: [Core] Generalize ValueObject::IsRuntimeSupportValue

xiaobai marked 3 inline comments as done. xiaobai added inline comments. Comment at: include/lldb/Target/LanguageRuntime.h:160-162 + /// Identify whether a name is a runtime value that should not be hidden by + /// from the user interface. + virtual bool IsWhitelistedRuntimeVa

[Lldb-commits] [PATCH] D63240: [Core] Generalize ValueObject::IsRuntimeSupportValue

xiaobai updated this revision to Diff 204615. xiaobai added a comment. Simplify ValueObject::IsRuntimeSupportValue CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63240/new/ https://reviews.llvm.org/D63240 Files: include/lldb/Target/CPPLanguageRuntime.h include/lldb/Target/LanguageRu

[Lldb-commits] [PATCH] D63181: [Target] Decouple ObjCLanguageRuntime from LanguageRuntime

xiaobai updated this revision to Diff 204648. xiaobai added a comment. Herald added a subscriber: mgorny. Implement suggestion Address feedback CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63181/new/ https://reviews.llvm.org/D63181 Files: include/lldb/Breakpoint/Breakpoint.h inclu

[Lldb-commits] [PATCH] D63357: [Process] Remove unused field from HistoryThread

xiaobai created this revision. xiaobai added reviewers: compnerd, JDevlieghere, davide, labath. Herald added a subscriber: kubamracek. These fields are unused and have been since their inception, from what I can tell. https://reviews.llvm.org/D63357 Files: source/Plugins/InstrumentationRunti

[Lldb-commits] [PATCH] D63363: [Signals] Create a plugin directory just for signals

xiaobai created this revision. xiaobai added reviewers: compnerd, JDevlieghere, labath, clayborg, davide. Herald added subscribers: atanasyan, mgorny, sdardis, emaste. Herald added a reviewer: jfb. I plan on setting up a plugin architecture for UnixSignals since I don't think it makes sense for Un

[Lldb-commits] [PATCH] D63363: [Signals] Create a plugin directory just for signals

xiaobai updated this revision to Diff 204862. xiaobai added a comment. Fix up include in gtest CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63363/new/ https://reviews.llvm.org/D63363 Files: source/Plugins/CMakeLists.txt source/Plugins/Platform/gdb-server/PlatformRemoteGDBServer.cp

[Lldb-commits] [PATCH] D63370: Specify log level for CMake messages (less stderr)

xiaobai added a reviewer: sgraenitz. xiaobai added a comment. Seems alright to me. I'd like to see 1 message changed from a STATUS to a WARNING though. Comment at: lldb/cmake/modules/LLDBConfig.cmake:131 if ("${PYTHON_HOME}" STREQUAL "") -message("LLDB embedded Python o

[Lldb-commits] [PATCH] D63363: [Signals] Create a plugin directory just for signals

xiaobai added a comment. In D63363#1545427 , @labath wrote: > Although this is technically correct and pretty consistent with our other > "plugins", I can't help but feel that it's incredibly wasteful. Each of the > XXXSignals.cpp files is less than a 10

[Lldb-commits] [PATCH] D63363: [Signals] Create a plugin directory just for signals

xiaobai added a comment. In D63363#1546464 , @jfb wrote: > Can you describe what the goal of your plugin architecture is? Maybe you need > an RFC by email before moving stuff around. > > I want to understand what you're going for because as they are today

[Lldb-commits] [PATCH] D63357: [Process] Remove unused field from HistoryThread

This revision was automatically updated to reflect the committed changes. Closed by commit rL363881: [Process] Remove unused field from HistoryThread (authored by xiaobai, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE L

[Lldb-commits] [PATCH] D63622: [Target] Hoist LanguageRuntime::GetDeclVendor

xiaobai created this revision. xiaobai added reviewers: JDevlieghere, labath, compnerd, davide. It's possible that each LanguageRuntime could have its own DeclVendor, so let's hoist that out of ObjCLanguageRuntime into LanguageRuntime. Additionally, this gives the opportunity to remove SBTarget's

[Lldb-commits] [PATCH] D63240: [Core] Generalize ValueObject::IsRuntimeSupportValue

xiaobai added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63240/new/ https://reviews.llvm.org/D63240 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D63622: [Target] Hoist LanguageRuntime::GetDeclVendor

xiaobai marked an inline comment as done. xiaobai added a comment. In D63622#1552717 , @jingham wrote: > This change makes it clear that SBTarget::FindFirstType should take a > language, but that is orthogonal to this change. Yep, it definitely should.

[Lldb-commits] [PATCH] D62504: Avoid calling LoadModules twice when modules change

xiaobai added a comment. ping @labath @clayborg any issues with this one? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62504/new/ https://reviews.llvm.org/D62504 ___ lldb-commits mailing list lldb-com

[Lldb-commits] [PATCH] D63181: [Target] Decouple ObjCLanguageRuntime from LanguageRuntime

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG7f9c9f226423: [Target] Decouple ObjCLanguageRuntime from LanguageRuntime (authored by xiaobai). Herald added a project: LL

[Lldb-commits] [PATCH] D63622: [Target] Hoist LanguageRuntime::GetDeclVendor

xiaobai marked an inline comment as done. xiaobai added inline comments. Comment at: source/API/SBTarget.cpp:1854-1859 + if (vendor->FindDecls(const_typename, /*append*/ true, +/*max_matches*/ 1, decls) > 0) { +if (CompilerType

[Lldb-commits] [PATCH] D63622: [Target] Hoist LanguageRuntime::GetDeclVendor

xiaobai marked an inline comment as done. xiaobai added inline comments. Comment at: source/API/SBTarget.cpp:1851 +if (ProcessSP process_sp = target_sp->GetProcessSP()) { + for (auto *runtime : process_sp->GetLanguageRuntimes()) { +if (auto vendor = runtime->GetD

[Lldb-commits] [PATCH] D63622: [Target] Hoist LanguageRuntime::GetDeclVendor

xiaobai updated this revision to Diff 206054. xiaobai added a comment. Add a few autos CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63622/new/ https://reviews.llvm.org/D63622 Files: include/lldb/Target/LanguageRuntime.h include/lldb/Target/ObjCLanguageRuntime.h source/API/SBTarg

[Lldb-commits] [PATCH] D63622: [Target] Hoist LanguageRuntime::GetDeclVendor

xiaobai marked an inline comment as done. xiaobai added inline comments. Comment at: source/API/SBTarget.cpp:1854-1859 + if (vendor->FindDecls(const_typename, /*append*/ true, +/*max_matches*/ 1, decls) > 0) { +if (CompilerType

[Lldb-commits] [PATCH] D62213: [ABI] Implement Windows ABI for x86_64

This revision was automatically updated to reflect the committed changes. Closed by commit rL364216: [ABI] Implement Windows ABI for x86_64 (authored by xiaobai, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.

[Lldb-commits] [PATCH] D63622: [Target] Hoist LanguageRuntime::GetDeclVendor

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL364229: [Target] Hoist LanguageRuntime::GetDeclVendor (authored by xiaobai, committed by ). Herald added a project: LLVM.

[Lldb-commits] [PATCH] D63240: [Core] Generalize ValueObject::IsRuntimeSupportValue

xiaobai marked an inline comment as done. xiaobai added inline comments. Comment at: include/lldb/Target/LanguageRuntime.h:157 + virtual bool IsRuntimeSupportValue(ValueObject &valobj) { +return valobj.GetVariable() && valobj.GetVariable()->IsArtificial(); + } -

[Lldb-commits] [PATCH] D63240: [Core] Generalize ValueObject::IsRuntimeSupportValue

xiaobai updated this revision to Diff 206351. xiaobai added a comment. Address feedback CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63240/new/ https://reviews.llvm.org/D63240 Files: include/lldb/Target/CPPLanguageRuntime.h include/lldb/Target/LanguageRuntime.h include/lldb/Targ

[Lldb-commits] [PATCH] D63745: [CMake] Check that a certificate for lldb is present at build time.

xiaobai added a comment. In D63745#1556773 , @JDevlieghere wrote: > On second thought, let's check that LLDB_CODESIGN_IDENTITY equals > `lldb_codesign` before doing this check. This question isn't important but I'm kind of curious: Does it have to be

[Lldb-commits] [PATCH] D63745: [CMake] Check that a certificate for lldb is present at build time.

xiaobai added a comment. In D63745#1556941 , @labath wrote: > This code should go to `tools/debugserver/source/CMakeLists.txt` so that it > is next to the code which performs the actual code signing. Doing that will > make it easier to keep it in sync wi

[Lldb-commits] [PATCH] D63240: [Core] Generalize ValueObject::IsRuntimeSupportValue

xiaobai updated this revision to Diff 206506. xiaobai added a comment. Address feedback CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63240/new/ https://reviews.llvm.org/D63240 Files: include/lldb/Target/CPPLanguageRuntime.h include/lldb/Target/LanguageRuntime.h include/lldb/Targ

[Lldb-commits] [PATCH] D63240: [Core] Generalize ValueObject::IsRuntimeSupportValue

xiaobai marked an inline comment as done. xiaobai added inline comments. Comment at: source/Core/ValueObject.cpp:1706-1708 + for (auto *runtime : process->GetLanguageRuntimes()) { +if (runtime->IsWhitelistedRuntimeValue(GetName())) + return false; apran

[Lldb-commits] [PATCH] D63240: [Core] Generalize ValueObject::IsRuntimeSupportValue

xiaobai added a comment. In D63240#1559913 , @jingham wrote: > Shouldn't ValueObjectVariables figure out their runtime language from their > defining frame, not their CompilerType? For a ValueObject you get from an > expression, you probably can't do th

[Lldb-commits] [PATCH] D63240: [Core] Generalize ValueObject::IsRuntimeSupportValue

xiaobai added a comment. In D63240#1559994 , @jingham wrote: > To be more precise, "frame" is the wrong word to use, Variables have > "scopes"... All Variables have a scope, though not every scope is contained > in a Function. > > But just to back up a

[Lldb-commits] [PATCH] D63853: [Symbol] Add DeclVendor::FindTypes

xiaobai created this revision. xiaobai added reviewers: jingham, labath, JDevlieghere. Herald added a subscriber: mgorny. Following up on the plan I outlined in D63622 , we can remove the dependence on clang in all the places where we only want to find the types f

[Lldb-commits] [PATCH] D63240: [Core] Generalize ValueObject::IsRuntimeSupportValue

xiaobai added a comment. In D63240#1560074 , @jingham wrote: > I was talking specifically about which runtime should be asked the question. > It seemed to me most straightforward to invert the order in which the > question was asked, but another way to

[Lldb-commits] [PATCH] D63240: [Core] Generalize ValueObject::IsRuntimeSupportValue

xiaobai added a comment. @jingham: Okay, so I tried to do what you suggested and that solution doesn't work because of ObjC++. After looking into it, it looks like Variable and Function just ask the CompileUnit for the language type instead of determining it themselves meaning that we determini

[Lldb-commits] [PATCH] D63240: [Core] Generalize ValueObject::IsRuntimeSupportValue

xiaobai added a comment. In D63240#1561531 , @jingham wrote: > In D63240#1561488 , @xiaobai wrote: > > > @jingham: Okay, so I tried to do what you suggested and that solution > > doesn't work because of ObjC++. Aft

[Lldb-commits] [PATCH] D63240: [Core] Generalize ValueObject::IsRuntimeSupportValue

xiaobai updated this revision to Diff 206994. xiaobai added a comment. Herald added a subscriber: jdoerfert. - Implement @jingham's suggestion - Change Function::GetLanguage to first guess the language from the name of the function you're in. - Fix a bug in DWARFASTParserClang::ParseFunctionFromD

[Lldb-commits] [PATCH] D63240: [Core] Generalize ValueObject::IsRuntimeSupportValue

xiaobai added a comment. Centralizing it means changing the classes that inherit from SymbolContextScope, so I will refactor that in a seaparate change and stack this change on top of that one. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63240/new/ https://reviews.llvm.org/D63240

[Lldb-commits] [PATCH] D63240: [Core] Generalize ValueObject::IsRuntimeSupportValue

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL364845: [Core] Generalize ValueObject::IsRuntimeSupportValue (authored by xiaobai, committed by ). Herald added a project:

[Lldb-commits] [PATCH] D64042: [Symbol] Improve Variable::GetLanguage

xiaobai created this revision. xiaobai added reviewers: jingham, clayborg. Herald added a subscriber: jdoerfert. When trying to ascertain what language a variable belongs to, just checking the compilation unit is often not enough. In r364845 I added a way to check for a variable's language type, b

[Lldb-commits] [PATCH] D63853: [Symbol] Add DeclVendor::FindTypes

xiaobai updated this revision to Diff 207425. xiaobai added a comment. Pavel's suggestion CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63853/new/ https://reviews.llvm.org/D63853 Files: include/lldb/Symbol/DeclVendor.h source/API/SBTarget.cpp source/Plugins/Language/ObjC/ObjCLang

[Lldb-commits] [PATCH] D63853: [Symbol] Add DeclVendor::FindTypes

This revision was automatically updated to reflect the committed changes. Closed by commit rL364962: [Symbol] Add DeclVendor::FindTypes (authored by xiaobai, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION h

[Lldb-commits] [PATCH] D64118: [lldb_test_suite] Fix lldb test suite targeting remote Android

xiaobai added a reviewer: labath. xiaobai added a subscriber: labath. xiaobai added a comment. This patch looks fine to me overall. I'm unsure if LLDB has a guarantee about which NDK version its compatible with, but I'm alright with staying up to date with the latest release @labath: Maybe you'

[Lldb-commits] [PATCH] D64154: [Docs] Unify build instructions

xiaobai added a comment. Thanks for doing this! :D Comment at: lldb/docs/resources/build.rst:145 - cmake -G Ninja -DLLDB_TEST_DEBUG_TEST_CRASHES=1 -DPYTHON_HOME=C:\Python35 -DLLDB_TEST_USE_CUSTOM_C_COMPILER=ON -DLLDB_TEST_C_COMPILER=d:\src\llvmbuild\ninja_release\bin\clang

[Lldb-commits] [PATCH] D64159: [Core] Generalize ValueObject::MaybeCalculateCompleteType

xiaobai created this revision. xiaobai added reviewers: jingham, clayborg, JDevlieghere. Instead of hardcoding ClangASTContext and ObjCLanguageRuntime, we can generalize this by creating the method CalculateCompleteType in LanguageRuntime and moving the current MaybeCalculateCompleteType implement

[Lldb-commits] [PATCH] D64042: [Symbol] Improve Variable::GetLanguage

xiaobai added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64042/new/ https://reviews.llvm.org/D64042 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D64159: [Core] Generalize ValueObject::MaybeCalculateCompleteType

xiaobai marked 2 inline comments as done. xiaobai added inline comments. Comment at: include/lldb/Target/ObjCLanguageRuntime.h:253 + CompilerType CalculateCompleteType(CompilerType base_type) override; + clayborg wrote: > Is this named correctly? Maybe this sh

[Lldb-commits] [PATCH] D64042: [Symbol] Improve Variable::GetLanguage

xiaobai added a comment. In D64042#1574438 , @jingham wrote: > Why did you make this a function of Variable, rather than SymbolContextScope? After thinking about it more, I realized that the implementation inside of SymbolContextScope would be identical

[Lldb-commits] [PATCH] D64365: [lldb] Let table gen create command option initializers.

xiaobai added a comment. This is awesome, thanks for doing this! I was also thinking about doing something like this at some point as well. :) Comment at: lldb/cmake/modules/AddLLDB.cmake:17 + if( NOT LTG_SOURCE ) +message(FATAL_ERROR "SOURCE source-file required by clang

[Lldb-commits] [PATCH] D64408: [CMake] `install-distribution` for LLDB on Darwin

xiaobai accepted this revision. xiaobai added a comment. This revision is now accepted and ready to land. I like the idea a lot and the implementation looks alright. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64408/new/ https://reviews.llvm

[Lldb-commits] [PATCH] D64397: [CMake] Remove extra lldb-framework target

xiaobai accepted this revision. xiaobai added a comment. This revision is now accepted and ready to land. Thanks for cleaning this up! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64397/new/ https://reviews.llvm.org/D64397 _

[Lldb-commits] [PATCH] D64118: [lldb_test_suite] Fix lldb test suite targeting remote Android

This revision was automatically updated to reflect the committed changes. Closed by commit rL365561: [lldb_test_suite] Fix lldb test suite targeting remote Android (authored by xiaobai, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D64434: [lldb] Quick Fix: IRExecutionUnit check pointer before access it

This revision was automatically updated to reflect the committed changes. Closed by commit rL365567: [lldb] Quick Fix: IRExecutionUnit check pointer before access it (authored by xiaobai, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commi

[Lldb-commits] [PATCH] D64159: [Core] Generalize ValueObject::MaybeCalculateCompleteType

xiaobai updated this revision to Diff 208841. xiaobai marked an inline comment as done. xiaobai added a comment. Switch to using llvm::Optional for the return type Rename method from CalculateCompleteType to GetRuntimeType CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64159/new/ https:/

[Lldb-commits] [PATCH] D64159: [Core] Generalize ValueObject::MaybeCalculateCompleteType

xiaobai added inline comments. Comment at: source/Target/ObjCLanguageRuntime.cpp:403 +CompilerType +ObjCLanguageRuntime::CalculateCompleteType(CompilerType base_type) { + CompilerType type_to_return; jingham wrote: > xiaobai wrote: > > clayborg wrote: > > > So a

[Lldb-commits] [PATCH] D64591: [Expression] Move IRDynamicChecks to ClangExpressionParser

xiaobai created this revision. xiaobai added reviewers: compnerd, clayborg, jingham, JDevlieghere. Herald added a subscriber: mgorny. IRDynamicChecks in its current form is specific to Clang since it deals with the C language family. It is possible that we may want to instrument code generated for

[Lldb-commits] [PATCH] D64583: [lldb][test_suite] Fix skipIfTargetAndroid decorator

xiaobai added a comment. Can you add more context to this diff? I can't see the code surrounding the changes. You can get the whole context with something like `git show -U`. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64583/new/ https://reviews.llvm.org

[Lldb-commits] [PATCH] D64599: [LanguageRuntime] Move CPPLanguageRuntime into a plugin

xiaobai created this revision. xiaobai added reviewers: JDevlieghere, clayborg, jingham, compnerd, labath. Herald added a subscriber: mgorny. This seems better suited to be in a plugin. https://reviews.llvm.org/D64599 Files: include/lldb/Target/CPPLanguageRuntime.h source/Plugins/Expression

[Lldb-commits] [PATCH] D64591: [Expression] Move IRDynamicChecks to ClangExpressionParser

xiaobai updated this revision to Diff 209335. xiaobai added a comment. Reflow comment Remove newline CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64591/new/ https://reviews.llvm.org/D64591 Files: include/lldb/Expression/DynamicCheckerFunctions.h include/lldb/Expression/IRDynamicCh

[Lldb-commits] [PATCH] D64591: [Expression] Move IRDynamicChecks to ClangExpressionParser

xiaobai added inline comments. Comment at: include/lldb/Expression/DynamicCheckerFunctions.h:19 + +/// \class DynamicCheckerFunctions DynamicCheckerFunctions.h +/// "lldb/Expression/DynamicCheckerFunctions.h" Encapsulates dynamic check JDevlieghere wrote: > Can w

[Lldb-commits] [PATCH] D64599: [LanguageRuntime] Move CPPLanguageRuntime into a plugin

xiaobai marked an inline comment as done. xiaobai added inline comments. Comment at: source/Plugins/ExpressionParser/Clang/ClangExpressionDeclMap.cpp:55 #include "Plugins/Language/CPlusPlus/CPlusPlusLanguage.h" +#include "Plugins/LanguageRuntime/CPlusPlus/CPPLanguageRuntime.h"

[Lldb-commits] [PATCH] D64591: [Expression] Move IRDynamicChecks to ClangExpressionParser

xiaobai updated this revision to Diff 209351. xiaobai added a comment. Remove documentation boilerplate CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64591/new/ https://reviews.llvm.org/D64591 Files: include/lldb/Expression/DynamicCheckerFunctions.h include/lldb/Expression/IRDynami

[Lldb-commits] [PATCH] D64599: [LanguageRuntime] Move CPPLanguageRuntime into a plugin

xiaobai marked an inline comment as done. xiaobai added a comment. In D64599#1581620 , @labath wrote: > In D64599#1581598 , @jingham wrote: > > > My model for this was that there was a CPPLanguageRuntime.cpp that co

[Lldb-commits] [PATCH] D64599: [LanguageRuntime] Move CPPLanguageRuntime into a plugin

xiaobai added a comment. In D64599#1581718 , @jingham wrote: > Anyway, if you can make all the generic parts of lldb not depend on the > language specific - but still abstract - part of the plugin, that would be > fine. Then just LanguageRuntime.h would

[Lldb-commits] [PATCH] D64591: [Expression] Move IRDynamicChecks to ClangExpressionParser

xiaobai added a comment. In D64591#1581775 , @jingham wrote: > This is a little unclear to me. LLVMUserExpression is the class that > represents "anything that uses LLVM at its back end." Both the Swift & Clang > user expressions are instances of this.

[Lldb-commits] [PATCH] D64591: [Expression] Move IRDynamicChecks to ClangExpressionParser

xiaobai added a comment. In D64591#1581820 , @jingham wrote: > Then the IRDynamicCheck part would go with LLVMUserExpression, and the > C-specific checks in Clang... Except IRDynamicChecks has special knowledge of the clang-specific instrumenters. I ca

[Lldb-commits] [PATCH] D64591: [Expression] Move IRDynamicChecks to ClangExpressionParser

xiaobai added a comment. In D64591#1581878 , @jingham wrote: > That would be cleaner. > > OTOH, the original reason for these checkers was to help people understand > crashes in their expressions more clearly. Supposedly, modern languages > "don't have

[Lldb-commits] [PATCH] D64591: [Expression] Move IRDynamicChecks to ClangExpressionParser

This revision was automatically updated to reflect the committed changes. Closed by commit rL365853: [Expression] Move IRDynamicChecks to ClangExpressionParser (authored by xiaobai, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: h

[Lldb-commits] [PATCH] D64159: [Core] Generalize ValueObject::MaybeCalculateCompleteType

This revision was automatically updated to reflect the committed changes. Closed by commit rL365939: [Core] Generalize ValueObject::MaybeCalculateCompleteType (authored by xiaobai, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGE

[Lldb-commits] [PATCH] D64661: [ObjectContainerBSDArchive] Simplify a few things (NFC)

xiaobai accepted this revision. xiaobai added a comment. This revision is now accepted and ready to land. LGTM Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64661/new/ https://reviews.llvm.org/D64661 ___ lldb-commi

[Lldb-commits] [PATCH] D64599: [LanguageRuntime] Move CPPLanguageRuntime into a plugin

This revision was automatically updated to reflect the committed changes. Closed by commit rL365951: [LanguageRuntime] Move CPPLanguageRuntime into a plugin (authored by xiaobai, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: http

[Lldb-commits] [PATCH] D64763: [LanguageRuntime] Move ObjCLanguageRuntime into a plugin

xiaobai created this revision. xiaobai added reviewers: JDevlieghere, compnerd, jingham, clayborg. Herald added subscribers: arphaman, mgorny. Following up to my CPPLanguageRuntime change, I'm moving ObjCLanguageRuntime into a plugin as well. https://reviews.llvm.org/D64763 Files: include/lld

[Lldb-commits] [PATCH] D64763: [LanguageRuntime] Move ObjCLanguageRuntime into a plugin

This revision was automatically updated to reflect the committed changes. Closed by commit rL366148: [LanguageRuntime] Move ObjCLanguageRuntime into a plugin (authored by xiaobai, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: htt

[Lldb-commits] [PATCH] D64812: [CMake] Fail when Python interpreter doesn't match Python libraries version

xiaobai accepted this revision. xiaobai added a comment. This revision is now accepted and ready to land. This definitely caused me some pain a few months ago. Thanks for adding this! Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64812/new/ https://reviews.llvm

[Lldb-commits] [PATCH] D64844: [Target] Remove Target::GetScratchClangASTContext

xiaobai created this revision. xiaobai added reviewers: teemperor, shafik, jingham, JDevlieghere, aprantl. Herald added subscribers: arphaman, emaste. Target doesn't really need to know about ClangASTContext more than any other TypeSystem. We can create a method ClangASTContext::GetScratch for any

[Lldb-commits] [PATCH] D64844: [Target] Remove Target::GetScratchClangASTContext

xiaobai updated this revision to Diff 210229. xiaobai added a comment. Remove ClangASTContext header from Target.cpp CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64844/new/ https://reviews.llvm.org/D64844 Files: include/lldb/Symbol/ClangASTContext.h include/lldb/Target/Target.h

[Lldb-commits] [PATCH] D64806: [CMake] Always build debugserver on Darwin and allow tests to use the system's one

xiaobai added a comment. I think that this is a good change overall to do but the name `LLDB_USE_SYSTEM_DEBUGSERVER` is kind of a confusing to me. The name itself doesn't really convey to me that the system debugserver is going to be used for just testing. Before this change, that flag indicate

[Lldb-commits] [PATCH] D64823: [CMake] Default LLDB_PATH_TO_LLVM_BUILD to LLVM_DIR

xiaobai added inline comments. Comment at: lldb/cmake/modules/LLDBStandalone.cmake:45 if(CMAKE_CROSSCOMPILING) set(LLVM_NATIVE_BUILD "${LLDB_PATH_TO_LLVM_BUILD}/NATIVE") if (NOT EXISTS "${LLVM_NATIVE_BUILD}") sgraenitz wrote: > @xiaobai Can this be c

[Lldb-commits] [PATCH] D64583: [lldb][test_suite] Fix skipIfTargetAndroid decorator

xiaobai accepted this revision. xiaobai added a comment. This revision is now accepted and ready to land. LGTM Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64583/new/ https://reviews.llvm.org/D64583 ___ lldb-commi

[Lldb-commits] [PATCH] D64844: [Target] Remove Target::GetScratchClangASTContext

xiaobai added a comment. In D64844#1589794 , @jingham wrote: > This seems partly wrong to me. The point is that the Target holds scratch > AST contexts for all the languages it supports. They are the central > repository for the accumulation of effects

[Lldb-commits] [PATCH] D64844: [Target] Remove Target::GetScratchClangASTContext

xiaobai added a comment. Yes, I agree that replacing ClangASTContext uses with TypeSystem would be the right thing to do, and it's what I plan on doing next. There are instances where you really do want a ClangASTContext (e.g. in plugins related to clang expression parsing and objc), and so hav

[Lldb-commits] [PATCH] D64806: [CMake] Always build debugserver on Darwin and allow tests to use the system's one

xiaobai added inline comments. Comment at: lldb/trunk/tools/debugserver/source/CMakeLists.txt:50 - -option(LLDB_NO_DEBUGSERVER "Disable the debugserver target" OFF) -option(LLDB_USE_SYSTEM_DEBUGSERVER "Use the system's debugserver instead of building it from source (Darwin only)

[Lldb-commits] [PATCH] D64964: [API] Remove use of ClangASTContext from SBTarget

xiaobai created this revision. xiaobai added reviewers: JDevlieghere, jingham, clayborg, compnerd. The methods to find types in a Target aren't clang specific and are pretty generalizable to type systems. Additionally, to support some of the use cases in SBTarget, I've added a "GetScratchTypeSyste

[Lldb-commits] [PATCH] D64964: [API] Remove use of ClangASTContext from SBTarget

xiaobai added a comment. In D64964#1592851 , @JDevlieghere wrote: > All uses of this new function drop the error on the ground. Does that mean it > doesn't matter? If it does, should we return an expected instead? Should we > stop on the first error, or

[Lldb-commits] [PATCH] D64994: [CMake] Align debugserver with lldb-server on Darwin

xiaobai accepted this revision. xiaobai added a comment. Excellent, thanks for taking care of this! :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64994/new/ https://reviews.llvm.org/D64994 ___ lldb-

[Lldb-commits] [PATCH] D65025: [Symbol] Improve TypeSystemMap mutex safety

xiaobai created this revision. xiaobai added reviewers: JDevlieghere, clayborg, davide, labath, jingham. Relying on m_clear_in_progress is dangerous for modifying m_map. It's entirely possible for one thread to invoke TypeSystemMap::Clear(), lock the mutex, and copy the map for finalization while

[Lldb-commits] [PATCH] D64042: [Symbol] Improve Variable::GetLanguage

xiaobai added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64042/new/ https://reviews.llvm.org/D64042 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D65025: [Symbol] Improve TypeSystemMap mutex safety

xiaobai abandoned this revision. xiaobai added a comment. Actually from the looks of it, I completely misunderstood what's going on here. It looks like `AddToMap` should only be called by things that hold the mutex, meaning that this change isn't actually necessary. I do think that makes this c

[Lldb-commits] [PATCH] D64042: [Symbol] Improve Variable::GetLanguage

This revision was automatically updated to reflect the committed changes. Closed by commit rL366733: [Symbol] Improve Variable::GetLanguage (authored by xiaobai, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.

[Lldb-commits] [PATCH] D65122: [Symbol] Use llvm::Expected when getting TypeSystems

xiaobai created this revision. xiaobai added reviewers: JDevlieghere, davide, compnerd. Herald added a subscriber: jdoerfert. This commit achieves the following: - Functions used to return a `TypeSystem *` return an `llvm::Expected` now. This means that the result of a call is always checked, f

[Lldb-commits] [PATCH] D65123: Restore tests for lldb-server and lldb-vscode removed at rL366590

xiaobai accepted this revision. xiaobai added a comment. This revision is now accepted and ready to land. Thanks for restoring them. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65123/new/ https://reviews.llvm.org/D65123 ___

[Lldb-commits] [PATCH] D79752: [lldb] Move ClangModulesDeclVendor ownership to ClangPersistentVariables

xiaobai created this revision. xiaobai added reviewers: teemperor, labath, JDevlieghere. Herald added subscribers: yaxunl, mgorny. Herald added a project: LLDB. This is another step in moving plugin dependencies out of non-plugins. Target doesn't need to know about this, and ClangPersistentVariabl

[Lldb-commits] [PATCH] D79823: [lldb][Core] Remove dead codepath in Mangled

xiaobai created this revision. xiaobai added reviewers: friss, JDevlieghere, shafik. Herald added a project: LLDB. Objective-C names are stored in m_demangled, not in m_mangled. The method in the condition will never return true. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D7

[Lldb-commits] [PATCH] D79823: [lldb][Core] Remove dead codepath in Mangled

xiaobai added a comment. In D79823#2032827 , @davide wrote: > I'm curious what happens if you end up here with something like `_T`. Did you > check? I assume you're talking about swift, which should be handled by a `SwiftLanguage` plugin. Can Objective

[Lldb-commits] [PATCH] D79823: [lldb][Core] Remove dead codepath in Mangled

This revision was automatically updated to reflect the committed changes. Closed by commit rG1079978b3c50: [lldb][Core] Remove dead codepath in Mangled (authored by xiaobai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79823/new/ https://reviews.l

[Lldb-commits] [PATCH] D79752: [lldb] Move ClangModulesDeclVendor ownership to ClangPersistentVariables

xiaobai updated this revision to Diff 266389. xiaobai added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79752/new/ https://reviews.llvm.org/D79752 Files: lldb/include/lldb/Target/Target.h lldb/source/Plugins/ExpressionParse

[Lldb-commits] [PATCH] D64844: [Target] Remove Target::GetScratchClangASTContext

xiaobai updated this revision to Diff 232927. xiaobai added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64844/new/ https://reviews.llvm.org/D64844 Files: lldb/include/lldb/Symbol/ClangASTContext.h lldb/include/lldb/Target/T

<    8   9   10   11   12   13   14   >