xiaobai added a comment. In D63745#1556941 <https://reviews.llvm.org/D63745#1556941>, @labath wrote:
> This code should go to `tools/debugserver/source/CMakeLists.txt` so that it > is next to the code which performs the actual code signing. Doing that will > make it easier to keep it in sync with changes to code signing, as well as > make it obvious that it is not in sync with them right now (there's a pretty > complex interaction of various cmake options (LLDB_CODESIGN_IDENTITY, > LLVM_CODESIGNING_IDENTITY, LLDB_USE_SYSTEM_DEBUGSERVER, etc.) which affects > code signing, and this code is ignoring all of those)... +1 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63745/new/ https://reviews.llvm.org/D63745 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
