xiaobai marked an inline comment as done.
xiaobai added inline comments.
================
Comment at: include/lldb/Target/LanguageRuntime.h:157
+ virtual bool IsRuntimeSupportValue(ValueObject &valobj) {
+ return valobj.GetVariable() && valobj.GetVariable()->IsArtificial();
+ }
----------------
aprantl wrote:
> I think this function should not be part of LanguageRuntime any more since
> there is nothing runtime-specific about it any more.Instead, it should
> probably be a function implemented by ValueObjectVariable. The Whitelist make
> still sense in the runtime of course.
I think you're right. No LanguageRuntime currently overrides this and
ValueObject uses this anyway as a fallback. If any language runtime needs to
implement this kind of behavior, we can add it back at that time.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63240/new/
https://reviews.llvm.org/D63240
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
