xiaobai added a comment. In D63745#1556773 <https://reviews.llvm.org/D63745#1556773>, @JDevlieghere wrote:
> On second thought, let's check that LLDB_CODESIGN_IDENTITY equals > `lldb_codesign` before doing this check. This question isn't important but I'm kind of curious: Does it have to be called lldb_codesign? Could you have an arbitrary identity and then sign with that, assuming the cert exists, or does debugserver expect a cert with that name exactly? ================ Comment at: lldb/CMakeLists.txt:77 + # of failing in the middle of the build. + if(CMAKE_SYSTEM_NAME MATCHES "Darwin" AND TARGET debugserver) + execute_process( ---------------- I think `CMAKE_SYSTEM_NAME MATCHES "Darwin"` is redundant because debugserver should only be a target if you're running on Darwin, per the logic in `tools/CMakeLists.txt`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63745/new/ https://reviews.llvm.org/D63745 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
