[Lldb-commits] [PATCH] D66507: Generalize FindTypes with CompilerContext to support fuzzy lookup

aprantl updated this revision to Diff 216425. aprantl added a comment. Address feedback from Pavel. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66507/new/ https://reviews.llvm.org/D66507 Files: lldb/include/lldb/Symbol/SymbolFile.h lldb/include/lldb/Symbol/Type.h lldb/include/l

[Lldb-commits] [PATCH] D66546: Extend FindTypes w/ CompilerContext to allow filtering by language

aprantl created this revision. aprantl added reviewers: labath, clayborg, jasonmolenda, JDevlieghere. This patch is also motivated by the Swift branch and is effectively NFC for the single-TypeSystem llvm.org branch. In multi-language projects it is extremely common to have, e.g., a Clang type

[Lldb-commits] [PATCH] D66546: Extend FindTypes w/ CompilerContext to allow filtering by language

aprantl added a comment. I also just discovered void ClangASTContext::EnumerateSupportedLanguages() and will incorporate that into the next revision, too. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66546/new/ https://reviews.llvm.org/D66546 ___

[Lldb-commits] [PATCH] D66546: Extend FindTypes w/ CompilerContext to allow filtering by language

aprantl updated this revision to Diff 216508. aprantl added a comment. Address review feedback. (This was quite a trip down the rabbit hole, but on the plus side I got to remove a few (now) completely useless callback APIs). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66546/new/ htt

[Lldb-commits] [PATCH] D66546: Extend FindTypes w/ CompilerContext to allow filtering by language

aprantl updated this revision to Diff 216518. aprantl added a comment. More feedback from Jonas. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66546/new/ https://reviews.llvm.org/D66546 Files: lldb/include/lldb/Core/PluginManager.h lldb/include/lldb/Symbol/ClangASTContext.h lldb/

[Lldb-commits] [PATCH] D66546: Extend FindTypes w/ CompilerContext to allow filtering by language

aprantl updated this revision to Diff 216644. aprantl added a comment. Here's an improved version: - got rid of the completely unnecessary optimization that use memcpy - made the struct have a SmallBitVector member instead of inheriting from it. The new struct has an LLVM-like interface for many

[Lldb-commits] [PATCH] D66546: Extend FindTypes w/ CompilerContext to allow filtering by language

aprantl added a comment. > Looks good overall. Just a question of it we want to return "const > LanguageSet &" to avoid copies. Also switch static functions that currently > return "LanguageSet" over to use static variables and llvm::once to init them > and then return "const LanguageSet &". T

[Lldb-commits] [PATCH] D66546: Extend FindTypes w/ CompilerContext to allow filtering by language

aprantl added a comment. In D66546#1641435 , @aprantl wrote: > > Looks good overall. Just a question of it we want to return "const > > LanguageSet &" to avoid copies. Also switch static functions that currently > > return "LanguageSet" over to use stati

[Lldb-commits] [PATCH] D66546: Extend FindTypes w/ CompilerContext to allow filtering by language

aprantl added a comment. In D66546#1641492 , @clayborg wrote: > Sounds good about LanguageSet being cheap to pass by value. Are there any > paths that will call this over and over where we still will be calculating > the LangaugeSet over and over in a ty

[Lldb-commits] [PATCH] D66546: Extend FindTypes w/ CompilerContext to allow filtering by language

aprantl added a comment. In D66546#1641534 , @aprantl wrote: > No, the most "expensive" function is > ClangASTContext::GetSupportedLanguagesForTypes() which is called once by the > ClangASTContext constructor. ... "expensive" in quotes, because a suffi

[Lldb-commits] [PATCH] D66546: Extend FindTypes w/ CompilerContext to allow filtering by language

aprantl marked an inline comment as done. aprantl added inline comments. Comment at: lldb/include/lldb/Symbol/SymbolFile.h:197 + virtual size_t FindTypes(llvm::ArrayRef pattern, + llvm::SmallBitVector languages, bool append,

[Lldb-commits] [PATCH] D66546: Extend FindTypes w/ CompilerContext to allow filtering by language

aprantl added a comment. Yeah, I'm trying to get behind what happened there, but I may need some help later on. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66546/new/ https://reviews.llvm.org/D66546 ___ lldb-commit

[Lldb-commits] [PATCH] D66546: Extend FindTypes w/ CompilerContext to allow filtering by language

aprantl added a comment. Looks like this also broke other platforms, which is good because I can debug it! I reverted the patch for now. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66546/new/ https://reviews.llvm.org/D66546 __

[Lldb-commits] [PATCH] D66546: Extend FindTypes w/ CompilerContext to allow filtering by language

aprantl added a comment. Turns out I accidentally deleted the constructor of LanguageSet in my very last refactoring. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66546/new/ https://reviews.llvm.org/D66546 ___ lldb-

[Lldb-commits] [PATCH] D66845: [lit] Don't set DYLD_LIBRARY_PATH when DYLD_INSERT_LIBRARIES is set.

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. It's a hack, but it's a well-documented one. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66845/new/ https://reviews.llvm.org/D66845 __

[Lldb-commits] [PATCH] D66966: [test] Fix various module cache bugs and inconsistencies

aprantl added inline comments. Comment at: lldb/lit/CMakeLists.txt:18 +set(LLDB_TEST_MODULE_CACHE_LLDB "${LLDB_TEST_BUILD_DIRECTORY}/module-cache-lldb" CACHE PATH "The module cache used by lldb for running tests.") +set(LLDB_TEST_MODULE_CACHE_CLANG "${LLDB_TEST_BUILD_DIRECTO

[Lldb-commits] [PATCH] D66966: [test] Fix various module cache bugs and inconsistencies

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. Thanks, this looks great (few comments inside). Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66966/new/ https://reviews.llvm.org/D66966 ___

[Lldb-commits] [PATCH] D66975: [lit] Print exit code in for unresolved (lldb)tests.

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. If it helps... Is there anything else we can print for a crashed dotest? Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66975/new/ https://reviews.llvm.org/

[Lldb-commits] [PATCH] D67083: [dotest] Avoid the need for LEVEL= makefile boilerplate

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. This looks like a very good idea! Comment at: packages/Python/lldbsuite/test/lldbinline.py:116 -makefile.write("include $(LEVEL)/Makefile.rules\n") +makef

[Lldb-commits] [PATCH] D67083: [dotest] Avoid the need for LEVEL= makefile boilerplate

aprantl added inline comments. Comment at: packages/Python/lldbsuite/test/lldbinline.py:116 -makefile.write("include $(LEVEL)/Makefile.rules\n") +makefile.write("include Makefile.rules\n") makefile.write("\ncleanup:\n\trm -f Makefile *.d\n\n") -

[Lldb-commits] [PATCH] D67369: Implement DW_OP_convert

aprantl created this revision. aprantl added reviewers: jasonmolenda, davide, labath, clayborg. Herald added a project: LLDB. aprantl added a reviewer: jakubjelinek. This patch adds basic support for DW_OP_convert[1] for integer types. Recent versions of LLVM's optimizer may insert this opcode in

[Lldb-commits] [PATCH] D67369: Implement DW_OP_convert

aprantl marked an inline comment as done. aprantl added inline comments. Comment at: lldb/source/Utility/Scalar.cpp:423 +if (bit_size <= sizeof(int)*8) return Scalar::e_sint; +if (bit_size <= sizeof(long)*8) return Scalar::e_slong; +if (bit_size <= sizeof(long long)*8

[Lldb-commits] [PATCH] D67376: [DWARF] Evaluate DW_OP_entry_value

aprantl added a comment. This is very exciting! Comment at: lldb/packages/Python/lldbsuite/test/functionalities/param_entry_vals/basic_entry_values/Makefile:4 +include $(LEVEL)/Makefile.rules +CXXFLAGS += -g -O1 -glldb -Xclang -femit-debug-entry-values The -g

[Lldb-commits] [PATCH] D67369: Implement DW_OP_convert

aprantl marked an inline comment as done. aprantl added inline comments. Comment at: lldb/source/Utility/Scalar.cpp:423 +if (bit_size <= sizeof(int)*8) return Scalar::e_sint; +if (bit_size <= sizeof(long)*8) return Scalar::e_slong; +if (bit_size <= sizeof(long long)*8

[Lldb-commits] [PATCH] D67369: Implement DW_OP_convert

aprantl marked an inline comment as done. aprantl added inline comments. Comment at: lldb/source/Expression/DWARFExpression.cpp:2571 + if (stack.size() < 1) { +if (error_ptr) + error_ptr->SetErrorString( JDevlieghere wrote: > Can we wrap thi

[Lldb-commits] [PATCH] D67376: [DWARF] Evaluate DW_OP_entry_value

aprantl added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:3752 +LocationInCaller = parse_simple_location(i); +break; + } vsk wrote: > aprantl wrote: > > default? > I don't believe any action is needed

[Lldb-commits] [PATCH] D67369: Implement DW_OP_convert

aprantl marked an inline comment as done. aprantl added inline comments. Comment at: lldb/include/lldb/Utility/Scalar.h:107 + /// Return the most efficient Scalar::Type for the requested size. + static Type GetBestType(size_t bit_size, bool sign); + vsk wrote:

[Lldb-commits] [PATCH] D67369: Implement DW_OP_convert

aprantl marked 5 inline comments as done. aprantl added inline comments. Comment at: lldb/source/Expression/DWARFExpression.cpp:2571 + if (stack.size() < 1) { +if (error_ptr) + error_ptr->SetErrorString( vsk wrote: > JDevlieghere wrote: > >

[Lldb-commits] [PATCH] D67111: Adding caching to libc++ std::function formatter for lookups that require scanning symbols

aprantl added inline comments. Comment at: source/Plugins/LanguageRuntime/CPlusPlus/CPPLanguageRuntime.cpp:248 + if (CallableLookupCache.count(func_to_match)) +return CallableLookupCache[func_to_match]; This is performing the lookup twice. ``` auto it = Ca

[Lldb-commits] [PATCH] D67376: [DWARF] Evaluate DW_OP_entry_value

aprantl added inline comments. Comment at: lldb/include/lldb/Symbol/Function.h:258 + +using CallSiteParameterArray = std::unique_ptr>; + vsk wrote: > grandinj wrote: > > the way this is being used seems to indicate it can be > >std::vector > > no need for un

[Lldb-commits] [PATCH] D67376: [DWARF] Evaluate DW_OP_entry_value

aprantl added a comment. Looking great! I have one more question inline, but that is mostly about documenting the algorithm. Comment at: lldb/include/lldb/Symbol/Function.h:258 + +using CallSiteParameterArray = std::unique_ptr>; + vsk wrote: > vsk wrote: > > a

[Lldb-commits] [PATCH] D67376: [DWARF] Evaluate DW_OP_entry_value

aprantl added inline comments. Comment at: lldb/source/Expression/DWARFExpression.cpp:497 + + finish_subexpressions_to(end_offset); } labath wrote: > aprantl wrote: > > We should probably just let llvm's libDebugInfo do the printing here, but > > this works fi

[Lldb-commits] [PATCH] D67111: Adding caching to libc++ std::function formatter for lookups that require scanning symbols

aprantl added inline comments. Comment at: source/Plugins/LanguageRuntime/CPlusPlus/CPPLanguageRuntime.cpp:196 + +auto contains_lambda_identifier = []( llvm::StringRef & str_ref ) { +return str_ref.contains("$_") || str_ref.contains("'lambda'"); S

[Lldb-commits] [PATCH] D67111: Adding caching to libc++ std::function formatter for lookups that require scanning symbols

aprantl added a comment. Otherwise this LGTM now. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67111/new/ https://reviews.llvm.org/D67111 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/list

[Lldb-commits] [PATCH] D67376: [DWARF] Evaluate DW_OP_entry_value

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. Thanks, that's exactly what I was looking for! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67376/new/ https://reviews.llvm.org/D67376 __

[Lldb-commits] [PATCH] D67760: [lldb] Decouple importing the std C++ module from the way the program is compiled

aprantl added a comment. I understand the motivation, just a few questions about the approach: - Can we make it such that *if* the program was compiled with -gmodules LLDB is using the DWARF module info as authoritative source instead of using this heuristic? - Is there a path towards supportin

[Lldb-commits] [PATCH] D67760: [lldb] Decouple importing the std C++ module from the way the program is compiled

aprantl added inline comments. Comment at: lldb/include/lldb/Symbol/CompileUnit.h:228 + /// Apply a lambda to each external module referenced by this compilation + /// unit. Recursively also descends into the referenced external modules What does "external mo

[Lldb-commits] [PATCH] D67869: [ABISysV] Fix regression for Simulator and MacABI

aprantl accepted this revision. aprantl added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/Plugins/ABI/SysV-x86_64/ABISysV_x86_64.cpp:233 + case llvm::Triple::EnvironmentType::Simulator: + case llvm::Triple::Environme

[Lldb-commits] [PATCH] D67869: [ABISysV] Fix regression for Simulator and MacABI

aprantl added a comment. What does `x86_64-apple-darwin` canonicalize to? Do we need an extra case for that? Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67869/new/ https://reviews.llvm.org/D67869 ___ lldb-commit

[Lldb-commits] [PATCH] D67869: [ABISysV] Fix regression for Simulator and MacABI

aprantl added inline comments. Comment at: lldb/source/Plugins/ABI/SysV-x86_64/ABISysV_x86_64.cpp:231 + case llvm::Triple::OSType::WatchOS: +switch(os_env) { + case llvm::Triple::EnvironmentType::Simulator: clang-format? Repository: rLLD

[Lldb-commits] [PATCH] D67966: Use llvm for dumping DWARF expressions

aprantl added a comment. Awesome! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67966/new/ https://reviews.llvm.org/D67966 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commit

[Lldb-commits] [PATCH] D67965: Have ABI plugins vend llvm MCRegisterInfo data

aprantl added inline comments. Comment at: source/Plugins/ABI/CMakeLists.txt:1 -add_subdirectory(SysV-arm) -add_subdirectory(SysV-arm64) -add_subdirectory(SysV-hexagon) -add_subdirectory(SysV-ppc) -add_subdirectory(SysV-ppc64) -add_subdirectory(SysV-mips) -add_subdirectory(SysV-m

[Lldb-commits] [PATCH] D67984: Canonicalize variable usage in testsuite Makefiles

aprantl created this revision. aprantl added reviewers: jasonmolenda, JDevlieghere, labath. Herald added subscribers: arphaman, christof. This test streamlines our use of variables that are expected by Makefile.rules throughout the test suite. Mostly it replaced potentially dangerous overrides a

[Lldb-commits] [PATCH] D67984: Canonicalize variable usage in testsuite Makefiles

aprantl updated this revision to Diff 221592. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67984/new/ https://reviews.llvm.org/D67984 Files: lldb/packages/Python/lldbsuite/test/arm/breakpoint-it/Makefile lldb/packages/Python/lldbsuite/test/arm/breakpoint-thumb-codesection/Makefile

[Lldb-commits] [PATCH] D67984: Canonicalize variable usage in testsuite Makefiles

aprantl added a comment. I checked, and Makefile.rules does initialize CXXFLAGS lazily, but it's still better to not depend on that implementation detail. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67984/new/ https://reviews.llvm.org/D67984 ___

[Lldb-commits] [PATCH] D67984: Canonicalize variable usage in testsuite Makefiles

aprantl updated this revision to Diff 221613. aprantl added a comment. Address feedback from Jonas. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67984/new/ https://reviews.llvm.org/D67984 Files: lldb/packages/Python/lldbsuite/test/arm/breakpoint-it/Makefile lldb/packages/Python/ll

[Lldb-commits] [PATCH] D67991: [CMake] Copy over the system debugserver when using LLDB_USE_SYSTEM_DEBUGSERVER

aprantl added inline comments. Comment at: lldb/trunk/packages/Python/lldbsuite/test/functionalities/thread/concurrent_events/TestConcurrentManyBreakpoints.py:18 @expectedFailureNetBSD +@skipIfOutOfTreeDebugserver def test(self): It may be more for

[Lldb-commits] [PATCH] D67994: [WIP] Modify lldb-test to print out ASTs from symbol file

aprantl added inline comments. Comment at: source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:3077 + ParseType(sc, die, &type_is_new).get(); + printf( "pubname: %s is_type = %d\n", die.GetPubname(), true); + break; You also probably do

[Lldb-commits] [PATCH] D68005: Make dw_tag_t a llvm::dwarf::Tag

aprantl added inline comments. Comment at: lldb/trunk/include/lldb/Core/dwarf.h:23 typedef int32_t dw_sleb128_t; typedef uint16_t dw_attr_t; typedef uint16_t dw_form_t; so should this be `llvm::dwarf::Attribute`? Comment at: lldb/trunk/inclu

[Lldb-commits] [PATCH] D68003: [dotest] Support specifying a version for skipIfOutOfTreeDebugserver

aprantl added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/commands/register/register/register_command/TestRegisters.py:73 @skipIf(archs=no_match(['amd64', 'i386', 'x86_64'])) -@skipIfOutOfTreeDebugserver +@skipIfOutOfTreeDebugserver(['<', '1100'

[Lldb-commits] [PATCH] D68003: [dotest] Support specifying a version for skipIfOutOfTreeDebugserver

aprantl added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/commands/register/register/register_command/TestRegisters.py:73 @skipIf(archs=no_match(['amd64', 'i386', 'x86_64'])) -@skipIfOutOfTreeDebugserver +@skipIfOutOfTreeDebugserver(['<', '1100'

[Lldb-commits] [PATCH] D68010: [lldb] Fix string summary of an empty NSPathStore2

aprantl added inline comments. Comment at: lldb/include/lldb/DataFormatters/StringPrinter.h:120 + +bool GetHasSourceSize() const { return m_has_source_size; } + I don't know the LLDB rules that well: is the convention really `GetHas` instead of `Has`?

[Lldb-commits] [PATCH] D68003: [dotest] Support specifying a version for skipIfOutOfTreeDebugserver

aprantl accepted this revision. aprantl added inline comments. This revision is now accepted and ready to land. Comment at: lldb/packages/Python/lldbsuite/test/decorators.py:513 +debugserver_version[0], debugserver_version[1], +actual_debugserver_version)

[Lldb-commits] [PATCH] D68039: [lit] Do a better job at parsing unsupported tests.

aprantl added inline comments. Comment at: lldb/lit/Suite/lldbtest.py:105 +has_unsupported_tests = 'UNSUPPORTED:' in out or 'UNSUPPORTED:' in err +has_passing_tests = 'PASS:' in out or 'PASS:' in err `'UNSUPPORTED:' in out + err` ? Repository:

[Lldb-commits] [PATCH] D68039: [lit] Do a better job at parsing unsupported tests.

aprantl added inline comments. Comment at: lldb/lit/Suite/lldbtest.py:105 +has_unsupported_tests = 'UNSUPPORTED:' in out or 'UNSUPPORTED:' in err +has_passing_tests = 'PASS:' in out or 'PASS:' in err JDevlieghere wrote: > aprantl wrote: > > `'UN

[Lldb-commits] [PATCH] D61101: Hide stderr output from lldb-argdumper

aprantl created this revision. aprantl added reviewers: jasonmolenda, jingham. Herald added a project: LLDB. Under very specific circumstances the default shell `/bin/sh` might print stuff to stderr before launching lldb-argdumper, which then confuses the JSON parser. This patch suppresses stder

[Lldb-commits] [PATCH] D61218: Fix a stack-smasher in PlatformMacOSX::GetSDKDirectory()

aprantl created this revision. aprantl added reviewers: jingham, jasonmolenda. Herald added a project: LLDB. GetSDKVersion expects the number of version fields not their byte size and will happily overwrite later contents of the stack. I just found this by accident while stepping through the fun

[Lldb-commits] [PATCH] D61240: Implement GetSystemIncludeDirectories for macOS

aprantl added inline comments. Comment at: lldb/source/Plugins/Platform/MacOSX/PlatformMacOSX.cpp:244 + case lldb::eLanguageTypeObjC_plus_plus: +return {sys_root + "/usr/include/"}; + default: I'm not 100% sure if that is how Clang header search works, but

[Lldb-commits] [PATCH] D61240: Implement GetSystemIncludeDirectories for macOS

aprantl added inline comments. Comment at: lldb/source/Plugins/Platform/MacOSX/PlatformMacOSX.cpp:244 + case lldb::eLanguageTypeObjC_plus_plus: +return {sys_root + "/usr/include/"}; + default: aprantl wrote: > aprantl wrote: > > I'm not 100% sure if that is

[Lldb-commits] [PATCH] D61240: Implement GetSystemIncludeDirectories for macOS

aprantl added inline comments. Comment at: lldb/source/Plugins/Platform/MacOSX/PlatformMacOSX.cpp:244 + case lldb::eLanguageTypeObjC_plus_plus: +return {sys_root + "/usr/include/"}; + default: aprantl wrote: > I'm not 100% sure if that is how Clang header s

[Lldb-commits] [PATCH] D61233: Refactor ObjectFile::GetSDKVersion

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. Awesome. I should have done that right away. This isn't super important, but I feel like just returning a vector (with potentially zero elements would be just as good) and the Optional doesn

[Lldb-commits] [PATCH] D59537: Instantiate 'std' templates explicitly in the expression evaluator

aprantl added inline comments. Comment at: lldb/include/lldb/Symbol/ClangASTContext.h:1005 +// May be null if we are already done parsing this ASTContext or the +// ASTContext wasn't created by parsing source code. +clang::Sema * m_se

[Lldb-commits] [PATCH] D59537: Instantiate 'std' templates explicitly in the expression evaluator

aprantl added inline comments. Comment at: lldb/include/lldb/Symbol/ClangASTImporter.h:249 +/// it at the end of the scope. Supports being used multiple times on the +/// same Minion instance in nested scopes. +class CxxModuleScope { teemperor wrote:

[Lldb-commits] [PATCH] D61146: Set a CXXRecordDecl to not be passed in registers if DW_CC_pass_by_reference when loading from DWARF

aprantl added inline comments. Comment at: packages/Python/lldbsuite/test/expression_command/argument_passing_restrictions/TestArgumentPassingRestrictions.py:26 +lldbutil.run_to_source_breakpoint(self, '// break here', +lldb.SBFileSpec("main.cpp", False)) + -

[Lldb-commits] [PATCH] D61299: Rename Minion to ASTImporterDelegate

aprantl accepted this revision. aprantl added inline comments. Comment at: lldb/include/lldb/Symbol/ClangASTImporter.h:238 - class Minion : public clang::ASTImporter { + class ASTImporterDelegate : public clang::ASTImporter { public: Is there some sort of

[Lldb-commits] [PATCH] D61451: Hide runtime support values such as clang's __vla_expr from frame variable

aprantl created this revision. aprantl added a reviewer: jingham. Herald added a project: LLDB. by respecting the "artificial" attribute on variables. Function arguments that are artificial and useful to end-users are being whitelisted by the language runtime. Repository: rG LLVM Github Mono

[Lldb-commits] [PATCH] D61394: Remove unnecessary check in SymbolFileDWARF::ParseImportedModules

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. True. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61394/new/ https://reviews.llvm.org/D61394 ___ lldb-comm

[Lldb-commits] [PATCH] D61451: Hide runtime support values such as clang's __vla_expr from frame variable

aprantl added a comment. In D61451#1488186 , @jingham wrote: > Could you add a comment (probably best in LanguageRuntime.h) saying what a > RuntimeSupportValue is? Done. > Also, so far as I can tell, this patch works because we use the CPP language >

[Lldb-commits] [PATCH] D61451: Hide runtime support values such as clang's __vla_expr from frame variable

aprantl updated this revision to Diff 197843. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61451/new/ https://reviews.llvm.org/D61451 Files: lldb/include/lldb/Target/CPPLanguageRuntime.h lldb/include/lldb/Target/LanguageRuntime.h lldb/include/lldb/Target/ObjCLanguageRuntime.h ll

[Lldb-commits] [PATCH] D61451: Hide runtime support values such as clang's __vla_expr from frame variable

aprantl updated this revision to Diff 197871. aprantl added a comment. Thanks you! There was indeed a bug that prevented us from recognizing the correct runtime for the C++ `this` pointer. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61451/new/ https://reviews.llvm.org/D61451 Files:

[Lldb-commits] [PATCH] D61451: Hide runtime support values such as clang's __vla_expr from frame variable

aprantl added a comment. In D61451#1489109 , @labath wrote: > I think there is a problem with this patch. I don't believe the TestVLA part > would work on any non-darwin platform (it doesn't on linux: > http://lab.llvm.org:8014/builders/lldb-x86_64-debia

[Lldb-commits] [PATCH] D61565: Ignore generated @import statements in the expression evaluator to fix import-std-module tests on macOS

aprantl added a comment. A slightly more elegant solution might be to inject a #line directive that changes to a different source file for the code that the user entered. I've been long wanting to make `expr -g` more palatable to end users by hiding the LLDB-injected code in a separate source f

[Lldb-commits] [PATCH] D61565: Ignore generated @import statements in the expression evaluator to fix import-std-module tests on macOS

aprantl added a comment. To clarify: I'd like `expr -g` to write out one temporary file (`lldb-expr.mm`) that only contains the code the user typed and in the expression. The expression should say @implementation $__lldb_objc_class ($__lldb_category) +(void)%s:(void *)$__lldb_arg { #lin

[Lldb-commits] [PATCH] D61606: Add support for importing general C++ modules into the LLDB expression evaluator

aprantl added inline comments. Comment at: lldb/include/lldb/Symbol/CompileUnit.h:397 std::vector m_imported_modules; + /// All modules, including the current module, used directly or indirectly + /// by this compile unit. All *Clang/Source* modules? Otherwi

[Lldb-commits] [PATCH] D61579: Propagate command interpreter errors from lldlbinit

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. Seems plausible. Comment at: lldb/source/Interpreter/CommandInterpreter.cpp:2472 + flags |= eHandleCommandFlagPrintErrors; +} else if (m_command_source_flags.back(

[Lldb-commits] [PATCH] D61438: [ASTImporter] Use llvm::Expected and Error in the importer API

aprantl added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:5039 + if (!ToOrErr) +// FIXME: return the error? +consumeError(ToOrErr.takeError()); We don't typically commit FIXME's into LLVM code. Why not just deal wit

[Lldb-commits] [PATCH] D61438: [ASTImporter] Use llvm::Expected and Error in the importer API

aprantl added inline comments. Comment at: clang/include/clang/AST/ASTImporter.h:203 /// context, or the import error. -llvm::Expected Import_New(TypeSourceInfo *FromTSI); -// FIXME: Remove this version. -TypeSourceInfo *Import(TypeSourceInfo *FromTSI); +llvm

[Lldb-commits] [PATCH] D61805: Add nullptr check in FindLibCppStdFunctionCallableInfo()

aprantl added inline comments. Comment at: source/Target/CPPLanguageRuntime.cpp:217 if (symbol != NULL && symbol->GetName().GetStringRef().contains("__invoke")) { davide wrote: > This should probably be `nullptr`, anyway, my general comment is tha

[Lldb-commits] [PATCH] D61438: [ASTImporter] Use llvm::Expected and Error in the importer API

aprantl added inline comments. Comment at: clang/include/clang/AST/ASTImporter.h:203 /// context, or the import error. -llvm::Expected Import_New(TypeSourceInfo *FromTSI); -// FIXME: Remove this version. -TypeSourceInfo *Import(TypeSourceInfo *FromTSI); +llvm

[Lldb-commits] [PATCH] D61438: [ASTImporter] Use llvm::Expected and Error in the importer API

aprantl accepted this revision. aprantl added a comment. Alright, thanks for taking the time to walk me through the thought process! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61438/new/ https://reviews.llvm.org/D61438 ___

[Lldb-commits] [PATCH] D61913: [WIP] Get back the navigation sidebar on the LLDB website

aprantl marked an inline comment as done. aprantl added inline comments. Comment at: lldb/docs/_static/lldb.css:27 +div.sphinxsidebar h3, div.sphinxsidebar h4, +div.sphinxsidebar p, div.sphinxsidebar p a { This is copied & pasted from the old static website.

[Lldb-commits] [PATCH] D61913: [WIP] Get back the navigation sidebar on the LLDB website

aprantl created this revision. aprantl added a reviewer: JDevlieghere. Herald added subscribers: lldb-commits, arphaman. Herald added a project: LLDB. This is a little experiment to get back the navigation sidebar on the LLDB website like it used to be: https://web.archive.org/web/20170204135403

[Lldb-commits] [PATCH] D61913: [WIP] Get back the navigation sidebar on the LLDB website

aprantl marked an inline comment as done. aprantl added inline comments. Comment at: lldb/docs/index.rst:73 + * `Public Python API Reference `_ * `Public C++ API Reference

[Lldb-commits] [PATCH] D61913: [WIP] Get back the navigation sidebar on the LLDB website

aprantl updated this revision to Diff 199510. aprantl added a comment. Make Doxygen links in sidebar work. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61913/new/ https://reviews.llvm.org/D61913 Files: lldb/docs/_static/lldb.css lldb/docs/conf.py lldb/docs/index.rst Index: lldb

[Lldb-commits] [PATCH] D61913: Get back the navigation sidebar on the LLDB website

aprantl added a comment. Do you think the fact that sphinx doesn't update the css will be a problem on lldb.llvm.org with the way the script is run? (ninja clean does not delete the html directory either). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61913/new/ https://reviews.llvm.o

[Lldb-commits] [PATCH] D61942: DWARFContext: Return empty data extractors instead of null pointers

aprantl accepted this revision. aprantl added inline comments. This revision is now accepted and ready to land. Comment at: source/Plugins/SymbolFile/DWARF/DWARFContext.h:26 - const DWARFDataExtractor *getOrLoadArangesData(); + const DWARFDataExtractor &getOrLoadArangesData()

[Lldb-commits] [PATCH] D61913: Get back the navigation sidebar on the LLDB website

aprantl updated this revision to Diff 199641. aprantl added a comment. Herald added a subscriber: mgorny. I think I addressed most/all of the outstanding bugs. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61913/new/ https://reviews.llvm.org/D61913 Files: lldb/docs/CMakeLists.txt l

[Lldb-commits] [PATCH] D61913: Get back the navigation sidebar on the LLDB website

aprantl updated this revision to Diff 199642. aprantl added a comment. Add more context to the diff. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61913/new/ https://reviews.llvm.org/D61913 Files: lldb/docs/CMakeLists.txt lldb/docs/_static/lldb.css lldb/docs/conf.py lldb/docs/i

[Lldb-commits] [PATCH] D61956: [CMake] Add first CMake cache files

aprantl added inline comments. Comment at: lldb/cmake/caches/Apple-lldb-osx.cmake:1 +include(${CMAKE_CURRENT_LIST_DIR}/Apple-lldb-base.cmake) + Filename: Apple-lldb-macOS or apple-lldb-macos? MacOS X has been renamed to OS X which has been renamed to macOS :-)

[Lldb-commits] [PATCH] D61913: Get back the navigation sidebar on the LLDB website

aprantl updated this revision to Diff 199676. aprantl added a comment. More tweaks from Jonas & me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61913/new/ https://reviews.llvm.org/D61913 Files: lldb/docs/CMakeLists.txt lldb/docs/_static/lldb.css lldb/docs/conf.py lldb/docs/in

[Lldb-commits] [PATCH] D62015: Make sure GetObjectDescription falls back to the Objective-C runtime.

aprantl marked an inline comment as done. aprantl added inline comments. Comment at: lldb/source/Core/ValueObject.cpp:1112 - bool is_signed; - if (compiler_type.IsIntegerType(is_signed) || - compiler_type.IsPointerType()) { This check was redun

[Lldb-commits] [PATCH] D62015: Make sure GetObjectDescription falls back to the Objective-C runtime.

aprantl created this revision. aprantl added reviewers: jingham, jasonmolenda. Herald added a project: LLDB. This fixes an unintended regression introduced by https://reviews.llvm.org/D61451 by making sure the Objective-C runtime is also tried when the "correct" language runtime failed to return

[Lldb-commits] [PATCH] D62015: Make sure GetObjectDescription falls back to the Objective-C runtime.

aprantl updated this revision to Diff 199859. aprantl added a comment. Address review feedback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62015/new/ https://reviews.llvm.org/D62015 Files: lldb/packages/Python/lldbsuite/test/lang/objcxx/cxx-bridged-po/Makefile lldb/packages/Pyt

[Lldb-commits] [PATCH] D62015: Make sure GetObjectDescription falls back to the Objective-C runtime.

aprantl updated this revision to Diff 199860. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62015/new/ https://reviews.llvm.org/D62015 Files: lldb/packages/Python/lldbsuite/test/lang/objcxx/cxx-bridged-po/Makefile lldb/packages/Python/lldbsuite/test/lang/objcxx/cxx-bridged-po/TestOb

[Lldb-commits] [PATCH] D62015: Make sure GetObjectDescription falls back to the Objective-C runtime.

aprantl updated this revision to Diff 199862. aprantl added a comment. Added test for raw pointer values. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62015/new/ https://reviews.llvm.org/D62015 Files: lldb/packages/Python/lldbsuite/test/lang/objcxx/cxx-bridged-po/Makefile lldb/pa

[Lldb-commits] [PATCH] D62073: Introduce DWARFUnitHeader and use it to parse type units out of .debug_info

aprantl added a comment. Nice! FYI, we have a bot that runs the LLDB dotests against DWARF5 (the last stage http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake-matrix/) to track the progress. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62073/new/ https://reviews.llvm.org/D62073

[Lldb-commits] [PATCH] D62073: Introduce DWARFUnitHeader and use it to parse type units out of .debug_info

aprantl added inline comments. Comment at: source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp:882 + case llvm::dwarf::DW_UT_partial: +return GetVersion() < 5 ? 11 :12; + case llvm::dwarf::DW_UT_skeleton: clang-format? CHANGES SINCE LAST ACTION https://review

[Lldb-commits] [PATCH] D62008: DWARF: Introduce DWARFTypeUnit class

aprantl added inline comments. Comment at: lit/SymbolFile/DWARF/debug-types-expressions.test:28 +# CHECK-LABEL: print ns::A() +# CHECK: (ns::A) $1 = (i = 147) [This is more a meta-point and I don't care very strongly about it] For a test of the DWARF parser, is i

[Lldb-commits] [PATCH] D62246: DWARF: Implement DW_AT_signature lookup for type unit support

aprantl added inline comments. Comment at: source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:255 TypeList *type_list = dwarf->GetTypeList(); if (type_ptr == NULL) { + Not your code, but it would be easier to follow the logic if we pulled these ca

[Lldb-commits] [PATCH] D62570: [WIP] Use LLVM's debug line parser in LLDB

aprantl added a comment. Very nice! Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:874 + data.GetByteOrder() == eByteOrderLittle, data.GetAddressByteSize()); +} should this be a `getAsLLVM()` member function or even an `operator()`?

<    8   9   10   11   12   13   14   15   16   >