aprantl added inline comments.
================
Comment at: source/Plugins/LanguageRuntime/CPlusPlus/CPPLanguageRuntime.cpp:196
+
+ auto contains_lambda_identifier = []( llvm::StringRef & str_ref ) {
+ return str_ref.contains("$_") || str_ref.contains("'lambda'");
----------------
StringRefs are meant to be value types. A StringRef is only a ptr+offset so we
are not being much more efficient by passing a pointer to a StringRef to a
function. This should just be a StringRef value argument.
================
Comment at: source/Plugins/LanguageRuntime/CPlusPlus/CPPLanguageRuntime.cpp:275
+ if (contains_lambda_identifier(first_template_parameter) ||
(symbol != nullptr &&
symbol->GetName().GetStringRef().contains("__invoke"))) {
----------------
Not your code, but since you're there: `symbol &&`
Actually, this would really benefit from another descriptive helper methid
since this is used in several places and not obvious to me what is being
checked here. Lambda invokes, block invokes, both?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D67111/new/
https://reviews.llvm.org/D67111
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
