aprantl added a comment. In D61451#1488186 <https://reviews.llvm.org/D61451#1488186>, @jingham wrote:
> Could you add a comment (probably best in LanguageRuntime.h) saying what a > RuntimeSupportValue is? Done. > Also, so far as I can tell, this patch works because we use the CPP language > runtime for C++ methods is an ObjC++ file, and the ObjCLanguageRuntime for > ObjC methods in ditto. That is surely the right thing to do, but it would be > good to ensure that there's a test that asserts this behavior. I'm sure > there must be but didn't see on a quick scan. Can you make sure there's such > tests and if not add one? I'm not sure what exactly you want me to test there. Can you elaborate? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61451/new/ https://reviews.llvm.org/D61451 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
