aprantl added inline comments.
================
Comment at: source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:255
TypeList *type_list = dwarf->GetTypeList();
if (type_ptr == NULL) {
+
----------------
Not your code, but it would be easier to follow the logic if we pulled these
cases up front:
```
if (type_ptr == DIE_IS_BEING_PARSED)
return type_sp;
if (type_ptr)
return type_ptr->shared_from_this();
...
```
================
Comment at: source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:258
+ if (DWARFDIE signature_die =
die.GetAttributeValueAsReferenceDIE(DW_AT_signature)) {
+ type_sp = ParseTypeFromDWARF(sc, signature_die, log, type_is_new_ptr);
+ if (type_sp) {
----------------
`if (type_sp = ParseTypeFromDWARF(sc, signature_die, log, type_is_new_ptr))`
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62246/new/
https://reviews.llvm.org/D62246
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
