aprantl added inline comments.

================
Comment at: lldb/include/lldb/Symbol/ClangASTImporter.h:249
+    /// it at the end of the scope. Supports being used multiple times on the
+    /// same Minion instance in nested scopes.
+    class CxxModuleScope {
----------------
teemperor wrote:
> aprantl wrote:
> > I really wish we could rename Minion with something actually descriptive...
> I'm still trying to come up with a good name. The whole purpose of the class 
> is to actually extend and listen to the actual ASTImporter. So what about 
> `ASTImporterDecorator`?
ASTImporterDelegate perhaps? https://en.wikipedia.org/wiki/Delegation_pattern


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59537/new/

https://reviews.llvm.org/D59537



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to