aprantl accepted this revision.
aprantl added inline comments.
This revision is now accepted and ready to land.
================
Comment at: source/Plugins/SymbolFile/DWARF/DWARFContext.h:26
- const DWARFDataExtractor *getOrLoadArangesData();
+ const DWARFDataExtractor &getOrLoadArangesData();
};
----------------
lgtm
================
Comment at: source/Plugins/SymbolFile/DWARF/DWARFDebugAranges.cpp:44
llvm::Error
DWARFDebugAranges::extract(const DWARFDataExtractor &debug_aranges_data) {
lldb::offset_t offset = 0;
----------------
lgtm
================
Comment at: source/Plugins/SymbolFile/DWARF/DWARFDebugInfo.cpp:49
m_context.getOrLoadArangesData();
- if (debug_aranges_data) {
- llvm::Error error = m_cu_aranges_up->extract(*debug_aranges_data);
- if (error)
- return std::move(error);
- }
+ if (llvm::Error error = m_cu_aranges_up->extract(debug_aranges_data))
+ return std::move(error);
----------------
ltgm
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61942/new/
https://reviews.llvm.org/D61942
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
