[Lldb-commits] [PATCH] D77444: [commands] Support autorepeat in SBCommands

labath added inline comments. Comment at: lldb/unittests/API/CMakeLists.txt:2 +add_lldb_unittest(APITests + TestSBCommandInterpreterTest.cpp + Well.. this is now definitely going to get tested well. :P While we do have some inconsistency where some test files p

[Lldb-commits] [lldb] 1d3b737 - [lldb] Fixing the bug that the "log timer" has no tab completion

Author: Shu Anzai Date: 2020-04-09T08:58:52+02:00 New Revision: 1d3b7370c466eba4bf22dce4a51f885f76698053 URL: https://github.com/llvm/llvm-project/commit/1d3b7370c466eba4bf22dce4a51f885f76698053 DIFF: https://github.com/llvm/llvm-project/commit/1d3b7370c466eba4bf22dce4a51f885f76698053.diff LOG

[Lldb-commits] [PATCH] D77662: [lldb/test] Make TestLoadUnload compatible with windows

labath marked 4 inline comments as done. labath added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/make/Makefile.rules:477 ifeq (1,$(USE_LIBDL)) - ifneq ($(OS),NetBSD) + ifeq (,$(filter $(OS), NetBSD Windows_NT)) LDFLAGS += -ldl --

[Lldb-commits] [PATCH] D77771: [lldb/Docs] Document driver and inline replay.

labath added a comment. This is really great, and a lot more than I hoped for (I was expecting a couple of doxygen comments). I have just two remarks: - the "Inline Replay" section is written in past tense, while the rest of the document uses present statement-of-fact tense. It would be good to

[Lldb-commits] [PATCH] D76906: [lldb] Fixing the bug that the "log timer" has no tab completion

This revision was automatically updated to reflect the committed changes. Closed by commit rG1d3b7370c466: [lldb] Fixing the bug that the "log timer" has no tab completion (authored by gedatsu217, committed by teemperor). Herald added a subscriber: lldb-commits. Changed prior to commit: https:

[Lldb-commits] [PATCH] D77588: [lldb/Reproducers] Make it possible to capture reproducers for the Python test suite.

labath added a comment. Ok, I'm starting to understand what's going on here. This patch looks mostly fine, but IIUC, it won't really do anything until the subsequent patch lands as that is what implements the inline/api/passive replay. I'm going to start looking at that other patch now. Repos

[Lldb-commits] [PATCH] D77765: Fix incorrect L1 inferior memory cache flushing

jarin updated this revision to Diff 256207. jarin marked 10 inline comments as done. jarin added a comment. Addressed some of the reviewer comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77765/new/ https://reviews.llvm.org/D77765 Files:

[Lldb-commits] [PATCH] D77765: Fix incorrect L1 inferior memory cache flushing

jarin added a comment. I rewrote parts of the test, hopefully making it a bit clearer. Please let me know if this made it better. Comment at: lldb/source/Target/Memory.cpp:23-24 // MemoryCache constructor -MemoryCache::MemoryCache(Process &process) +MemoryCache::MemoryCache(M

[Lldb-commits] [PATCH] D77602: [lldb/Reproducers] Support inline replay

labath added a comment. I haven't looked at the code in details, but some of my high-level concerns are: - the `LLDB_RECORD_***` macros are getting rather long and repetitive. We should try to find a way to move some of that stuff into a regular function and keep the macros for the stuff that c

[Lldb-commits] [PATCH] D77765: Fix incorrect L1 inferior memory cache flushing

labath added a comment. Thanks for tackling this. I believe this should be split into two patches: an NFC patch which makes it possible to unit test this code, and then a follow-up patch to fix the actual bug. The first patch can include the general testing infrastructure, and a some tests for

[Lldb-commits] [PATCH] D77327: [nfc] [lldb] 2/2: Introduce DWARF callbacks

labath added a comment. I just had one more idea. The `bool` return value on all of these methods, is that here just to implement the `fallback` mechanism in DebugNamesDWARFIndex? Could it be avoided if debug_names index calls the "fallback" *after* it has done its own processing? Repository:

[Lldb-commits] [PATCH] D75750: [lldb] integrate debuginfod

labath added a comment. In D75750#1967019 , @fche2 wrote: > >> So it might be good to have the SymbolVendors use one or more SymbolServer > >> plug-ins. > > > > I don't believe we have anything that would require all modules in a given > > target (or wh

[Lldb-commits] [PATCH] D77047: AArch64 SVE register infos and ptrace support

labath added a comment. In D77047#1966539 , @omjavaid wrote: > @labath Core file FP register access is not supported on AArch64. I am > working on a follow up patch to fix it. This patch only has linux changes so > can we get this through? This patch i

[Lldb-commits] [PATCH] D77043: Fix process gdb-remote usage of value_regs/invalidate_regs

labath added a comment. Register infos in lldb are a mess. However lldb seems to be able to communicate (more or less successfully) with stub which know nothing about lldb or numbers it assigns to various registers. So it does not seem like there needs to be (or even _can_ be) one universal con

[Lldb-commits] [lldb] ebb0713 - [lldb/Core] Fix a race in the Communication class

Author: Pavel Labath Date: 2020-04-09T12:06:47+02:00 New Revision: ebb071345cdae2509c55f9eec76090926fee86a2 URL: https://github.com/llvm/llvm-project/commit/ebb071345cdae2509c55f9eec76090926fee86a2 DIFF: https://github.com/llvm/llvm-project/commit/ebb071345cdae2509c55f9eec76090926fee86a2.diff

[Lldb-commits] [PATCH] D76806: Remove m_last_file_sp from SourceManager

labath requested changes to this revision. labath added a comment. This revision now requires changes to proceed. I am afraid that the last patch in this series introduces a bunch of failures for me. The failures appear to be more-or-less consistent, but the impacted tests seem pretty random:

[Lldb-commits] [PATCH] D77295: [lldb/Core] Fix a race in the Communication class

This revision was automatically updated to reflect the committed changes. Closed by commit rGebb071345cda: [lldb/Core] Fix a race in the Communication class (authored by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77295/new/ https://revie

[Lldb-commits] [lldb] 76975c7 - Revert "[lldb/Core] Fix a race in the Communication class"

Author: Pavel Labath Date: 2020-04-09T12:49:56+02:00 New Revision: 76975c744da1e82ca6bdbe6883c799340acaf4f0 URL: https://github.com/llvm/llvm-project/commit/76975c744da1e82ca6bdbe6883c799340acaf4f0 DIFF: https://github.com/llvm/llvm-project/commit/76975c744da1e82ca6bdbe6883c799340acaf4f0.diff

[Lldb-commits] [lldb] 769d704 - Recommit "[lldb/Core] Fix a race in the Communication class"

Author: Pavel Labath Date: 2020-04-09T13:39:00+02:00 New Revision: 769d7041cc1457dc2c5bcd040f24d530af48b76b URL: https://github.com/llvm/llvm-project/commit/769d7041cc1457dc2c5bcd040f24d530af48b76b DIFF: https://github.com/llvm/llvm-project/commit/769d7041cc1457dc2c5bcd040f24d530af48b76b.diff

[Lldb-commits] [PATCH] D77790: [NFC] Add a test for the inferior memory cache (mainly L1)

jarin created this revision. jarin added reviewers: labath, clayborg. jarin added a project: LLDB. Herald added subscribers: lldb-commits, mgorny. This patch adds a test for L1 of the inferior's memory cache and makes the cache testable. This is mostly in preparation

[Lldb-commits] [PATCH] D77790: [NFC] Add a test for the inferior memory cache (mainly L1)

labath added a comment. Thanks for splitting this up. This looks fine to me, modulo some nits, but lets wait @clayborg has to say. Comment at: lldb/source/Target/Memory.cpp:63 if (pos != m_L1_cache.begin()) { - --pos; + pos--; } I guess th

[Lldb-commits] [lldb] a9406da - [lldb] Add parts accidentally left out of 769d704: Recommit "[lldb/Core] Fix a race in the Communication class"

Author: Pavel Labath Date: 2020-04-09T14:45:23+02:00 New Revision: a9406daaa60f9899955a59c27f39db5519a9 URL: https://github.com/llvm/llvm-project/commit/a9406daaa60f9899955a59c27f39db5519a9 DIFF: https://github.com/llvm/llvm-project/commit/a9406daaa60f9899955a59c27f39db5519a9.diff

[Lldb-commits] [PATCH] D77790: [NFC] Add a test for the inferior memory cache (mainly L1)

jarin updated this revision to Diff 256257. jarin marked 2 inline comments as done. jarin added a comment. Addressed reviewer comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77790/new/ https://reviews.llvm.org/D77790 Files: lldb/include/

[Lldb-commits] [PATCH] D77793: Fix LLDB elf core dump register access for ARM/AArch64

omjavaid created this revision. omjavaid added a reviewer: labath. Herald added subscribers: danielkiss, kristof.beyls. This patch adds support to access AArch64 FP SIMD core dump registers and adds a test case to verify registers. This patches fixes a bug where doing "register read --all" cause

[Lldb-commits] [PATCH] D77790: [NFC] Add a test for the inferior memory cache (mainly L1)

jarin added inline comments. Comment at: lldb/source/Target/Memory.cpp:63 if (pos != m_L1_cache.begin()) { - --pos; + pos--; } labath wrote: > I guess this is a leftover from splitting the patches? > > Speaking of post-increment the [[ > htt

[Lldb-commits] [PATCH] D77327: [nfc] [lldb] 2/2: Introduce DWARF callbacks

jankratochvil updated this revision to Diff 256259. jankratochvil marked an inline comment as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77327/new/ https://reviews.llvm.org/D77327 Files: lldb/include/lldb/Core/UniqueCStringMap.h lldb/so

[Lldb-commits] [PATCH] D77327: [nfc] [lldb] 2/2: Introduce DWARF callbacks

jankratochvil added a comment. In D77327#1971435 , @labath wrote: > The `bool` return value on all of these methods, is that here just to > implement the `fallback` mechanism in DebugNamesDWARFIndex? Most of them yes. There are still some functions need

[Lldb-commits] [lldb] 9aa5fbb - [lldb] Disable the new Communication test on windows

Author: Pavel Labath Date: 2020-04-09T15:19:24+02:00 New Revision: 9aa5fbb3afed00deb2faad4ac7963c5d3247815d URL: https://github.com/llvm/llvm-project/commit/9aa5fbb3afed00deb2faad4ac7963c5d3247815d DIFF: https://github.com/llvm/llvm-project/commit/9aa5fbb3afed00deb2faad4ac7963c5d3247815d.diff

[Lldb-commits] [PATCH] D77765: Fix incorrect L1 inferior memory cache flushing

jarin added a comment. As labath@ suggested, I have teased apart the test and the testability refactoring into a separate patch. The patch lives at https://reviews.llvm.org/D77790, could you please take a look? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[Lldb-commits] [PATCH] D77587: [SVE] Add new VectorType subclasses

ctetreau updated this revision to Diff 256129. ctetreau added a comment. Move getMinNumElements to ScalableVectorType. There's no reason for it to be in base VectorType Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77587/new/ https://reviews.llvm.

[Lldb-commits] [PATCH] D77587: [SVE] Add new VectorType subclasses

efriedma added a comment. Looks right, generally. Comment at: llvm/include/llvm-c/Core.h:163 + * value of enum variants after the removal of LLVMVectorTypeKind + */ + LLVMMetadataTypeKind = LLVMPointerTypeKind + 2, /**< Metadata */ The C API is officially

[Lldb-commits] [PATCH] D77662: [lldb/test] Make TestLoadUnload compatible with windows

amccarth accepted this revision. amccarth added a comment. This revision is now accepted and ready to land. Well, it looks to go _me_. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77662/new/ https://reviews.llvm.org/D77662 _

[Lldb-commits] [PATCH] D77771: [lldb/Docs] Document driver and inline replay.

JDevlieghere updated this revision to Diff 256330. JDevlieghere added a comment. Thanks for the feedback! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1/new/ https://reviews.llvm.org/D1 Files: lldb/docs/resources/reproducers.rst Index: lldb/docs/resources/reproducers.rst =

[Lldb-commits] [lldb] 680082a - [lldb/Reproducers] Add a small artificial delay before exiting

Author: Jonas Devlieghere Date: 2020-04-09T11:03:24-07:00 New Revision: 680082a408dd2df7410d77696100eac8ce9d5530 URL: https://github.com/llvm/llvm-project/commit/680082a408dd2df7410d77696100eac8ce9d5530 DIFF: https://github.com/llvm/llvm-project/commit/680082a408dd2df7410d77696100eac8ce9d5530.d

[Lldb-commits] [PATCH] D76906: [lldb] Fixing the bug that the "log timer" has no tab completion

gedatsu217 added a comment. [39/575] Linking CXX shared library lib/libc++abi.1.0.dylib FAILED: lib/libc++abi.1.0.dylib : && /Library/Developer/CommandLineTools/usr/bin/c++ -fPIC -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-par

[Lldb-commits] [lldb] 143d507 - Preserve the owning module information from DWARF in the synthesized AST

Author: Adrian Prantl Date: 2020-04-09T11:09:44-07:00 New Revision: 143d507c9ff90db93e547f0e1131e92db06e2675 URL: https://github.com/llvm/llvm-project/commit/143d507c9ff90db93e547f0e1131e92db06e2675 DIFF: https://github.com/llvm/llvm-project/commit/143d507c9ff90db93e547f0e1131e92db06e2675.diff

[Lldb-commits] [PATCH] D77588: [lldb/Reproducers] Make it possible to capture reproducers for the Python test suite.

JDevlieghere added a comment. In D77588#1971345 , @labath wrote: > Ok, I'm starting to understand what's going on here. This patch looks mostly > fine, but IIUC, it won't really do anything until the subsequent patch lands > as that is what implements th

[Lldb-commits] [PATCH] D77588: [lldb/Reproducers] Make it possible to capture reproducers for the Python test suite.

JDevlieghere updated this revision to Diff 256341. JDevlieghere added a comment. Update naming to passive replay. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77588/new/ https://reviews.llvm.org/D77588 Files: lldb/bindings/headers.swig lldb/bindings/inter

Re: [Lldb-commits] [lldb] 680082a - [lldb/Reproducers] Add a small artificial delay before exiting

> On Apr 9, 2020, at 11:05, Jonas Devlieghere via lldb-commits > wrote: > > > Author: Jonas Devlieghere > Date: 2020-04-09T11:03:24-07:00 > New Revision: 680082a408dd2df7410d77696100eac8ce9d5530 > > URL: > https://github.com/llvm/llvm-project/commit/680082a408dd2df7410d77696100eac8ce9d5530

[Lldb-commits] [lldb] 8fbac4e - [nfc] [lldb] Unindent code

Author: Jan Kratochvil Date: 2020-04-09T20:43:00+02:00 New Revision: 8fbac4e1a2f2506671ca06226e4513a5965bdbf5 URL: https://github.com/llvm/llvm-project/commit/8fbac4e1a2f2506671ca06226e4513a5965bdbf5 DIFF: https://github.com/llvm/llvm-project/commit/8fbac4e1a2f2506671ca06226e4513a5965bdbf5.diff

Re: [Lldb-commits] [lldb] 680082a - [lldb/Reproducers] Add a small artificial delay before exiting

On Thu, Apr 9, 2020 at 11:39 AM Davide Italiano wrote: > > > > On Apr 9, 2020, at 11:05, Jonas Devlieghere via lldb-commits < > lldb-commits@lists.llvm.org> wrote: > > > > > > Author: Jonas Devlieghere > > Date: 2020-04-09T11:03:24-07:00 > > New Revision: 680082a408dd2df7410d77696100eac8ce9d5530

[Lldb-commits] [lldb] 68c04a4 - [lldb] Disable failing register tests for reproducers

Author: Med Ismail Bennani Date: 2020-04-09T21:05:17+02:00 New Revision: 68c04a4f73ac10b0881db31c99282955765e4c8f URL: https://github.com/llvm/llvm-project/commit/68c04a4f73ac10b0881db31c99282955765e4c8f DIFF: https://github.com/llvm/llvm-project/commit/68c04a4f73ac10b0881db31c99282955765e4c8f.

[Lldb-commits] [lldb] 98b47f4 - [lldb/test] Fix typo to disable reproducer's test phase

Author: Med Ismail Bennani Date: 2020-04-09T21:54:45+02:00 New Revision: 98b47f447c93e531db8cc70841bad8c867d76134 URL: https://github.com/llvm/llvm-project/commit/98b47f447c93e531db8cc70841bad8c867d76134 DIFF: https://github.com/llvm/llvm-project/commit/98b47f447c93e531db8cc70841bad8c867d76134.

[Lldb-commits] [PATCH] D77326: 1/2: [nfc] [lldb] Unindent code

This revision was automatically updated to reflect the committed changes. Closed by commit rG8fbac4e1a2f2: [nfc] [lldb] Unindent code (authored by jankratochvil). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77326/new/ https://reviews.llvm.org/D773

[Lldb-commits] [PATCH] D76806: Remove m_last_file_sp from SourceManager

emrekultursay updated this revision to Diff 256416. emrekultursay added a comment. Fix broken tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76806/new/ https://reviews.llvm.org/D76806 Files: lldb/include/lldb/Core/SourceManager.h lldb/so

[Lldb-commits] [PATCH] D76806: Remove m_last_file_sp from SourceManager

emrekultursay added a comment. Thanks for noticing the test breakages Pavel. I fixed the bug, and verified that the tests you mentioned pass. PTAL. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76806/new/ https://reviews.llvm.org/D76806 __

[Lldb-commits] [lldb] 0d525ce - [lldb] Fix breakeage introduced by llvm::LoadInst api change

Author: Med Ismail Bennani Date: 2020-04-10T00:11:00+02:00 New Revision: 0d525ce068c95a73558ed88ec3a1272c0ffe0e96 URL: https://github.com/llvm/llvm-project/commit/0d525ce068c95a73558ed88ec3a1272c0ffe0e96 DIFF: https://github.com/llvm/llvm-project/commit/0d525ce068c95a73558ed88ec3a1272c0ffe0e96.

[Lldb-commits] [PATCH] D77698: [DWARF] Assign the correct scope to constant variables

aprantl added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugInfoEntry.cpp:1028 +case DW_TAG_inlined_subroutine: + return false; + [Sorry for showing up late.] This seems unintuitive. How is ``` void f() { static int g_i =

[Lldb-commits] [PATCH] D77698: [DWARF] Assign the correct scope to constant variables

davide marked an inline comment as done. davide added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugInfoEntry.cpp:1029 + return false; + +case DW_TAG_compile_unit: aprantl wrote: > To save everyone the trouble: > ``` > 0x000

[Lldb-commits] [lldb] 6612b82 - [lldb] Reformat 'Fix breakage introduced by llvm::LoadInst api change' (NFC)

Author: Med Ismail Bennani Date: 2020-04-10T00:37:08+02:00 New Revision: 6612b826d05cc9fd1beb47a6a93f9e2b093b48af URL: https://github.com/llvm/llvm-project/commit/6612b826d05cc9fd1beb47a6a93f9e2b093b48af DIFF: https://github.com/llvm/llvm-project/commit/6612b826d05cc9fd1beb47a6a93f9e2b093b48af.

[Lldb-commits] [PATCH] D77698: [DWARF] Assign the correct scope to constant variables

aprantl added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugInfoEntry.cpp:1029 + return false; + +case DW_TAG_compile_unit: davide wrote: > aprantl wrote: > > To save everyone the trouble: > > ``` > > 0x002a: DW_TAG_su

[Lldb-commits] [PATCH] D77790: [NFC] Add a test for the inferior memory cache (mainly L1)

clayborg added a comment. Mostly good, but it seems weird to supply the cache line size when calling the MemoryCache::Clear() function. We also don't seem to be catching updates to the cache line size property and invalidating the cache when and only when the property is modified, but we seem t

[Lldb-commits] [PATCH] D77842: Fix setting Python3_ROOT_DIR on Windows

isuruf created this revision. Herald added subscribers: lldb-commits, mgorny. Herald added a project: LLDB. isuruf added a reviewer: LLDB. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D77842 Files: lldb/cmake/modules/FindPythonInterpAndLibs.cmake Index: lldb/cmake/modules/F

[Lldb-commits] [PATCH] D77843: [lldb/DataFormatters] Delete GetStringPrinterEscapingHelper

vsk created this revision. vsk added reviewers: JDevlieghere, davide. Herald added a subscriber: mgorny. Herald added a project: LLDB. Languages can have different ways of formatting special characters. E.g. when debugging C++ code a string might look like "\b", but when debugging Swift code the s

[Lldb-commits] [PATCH] D77842: Fix setting Python3_ROOT_DIR on Windows

JDevlieghere added a comment. Can you explain why this is necessary? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77842/new/ https://reviews.llvm.org/D77842 ___ lldb-commits mailing list lldb-commits@

[Lldb-commits] [PATCH] D77842: Fix setting Python3_ROOT_DIR on Windows

isuruf added a comment. The intention of the code is to set the variable `Python3_ROOT_DIR` to the value of the variable `PYTHON_HOME`, but it was using just the string `"PYTHON_HOME"` instead. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77842/n

[Lldb-commits] [PATCH] D77602: [lldb/Reproducers] Support inline replay

JDevlieghere updated this revision to Diff 256505. JDevlieghere added a comment. - Simplify `LLDB_RECORD_CONSTRUCTOR` macro. The other macros have `return` statements that need to be inlined in the caller for replay, and the boundary tracking needs to be updated right, so I'm not convinced the e

[Lldb-commits] [lldb] a4da4e3 - [lldb/Reproducers] Fix typo introduced when disabling register failing tests

Author: Med Ismail Bennani Date: 2020-04-10T08:37:06+02:00 New Revision: a4da4e3292834b5f93f54440f825dd90876d6615 URL: https://github.com/llvm/llvm-project/commit/a4da4e3292834b5f93f54440f825dd90876d6615 DIFF: https://github.com/llvm/llvm-project/commit/a4da4e3292834b5f93f54440f825dd90876d6615.