jarin added inline comments.

================
Comment at: lldb/source/Target/Memory.cpp:63
     if (pos != m_L1_cache.begin()) {
-      --pos;
+      pos--;
     }
----------------
labath wrote:
> I guess this is a leftover from splitting the patches?
> 
> Speaking of post-increment the [[ 
> http://llvm.org/docs/CodingStandards.html#prefer-preincrement | llvm rule ]] 
> is to use pre-increment whereever possible. I see the test uses 
> post-increment exclusively for no good reason.
But, but,... I only increment/decrement in statement position!

Just kidding, I am sorry, fixed now...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77790/new/

https://reviews.llvm.org/D77790



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to