labath added a comment.
Thanks for tackling this. I believe this should be split into two patches: an
NFC patch which makes it possible to unit test this code, and then a follow-up
patch to fix the actual bug. The first patch can include the general testing
infrastructure, and a some tests for the functionality which *is* working at
the moment.
================
Comment at: lldb/source/Target/Memory.cpp:31
-void MemoryCache::Clear(bool clear_invalid_ranges) {
+void MemoryCache::Clear(uint64_t cache_line_size, bool clear_invalid_ranges) {
std::lock_guard<std::recursive_mutex> guard(m_mutex);
----------------
clayborg wrote:
> remove "cache_line_size" if we add a new virtual function to
> MemoryFromInferiorReader
I agree with @jarin that `cache_line_size` looks out of place on the
`MemoryFromInferiorReader` inferface. Maybe this would look better if `Clear`
is renamed to `Reset` ?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77765/new/
https://reviews.llvm.org/D77765
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
