labath added inline comments.

================
Comment at: lldb/unittests/API/CMakeLists.txt:2
+add_lldb_unittest(APITests
+  TestSBCommandInterpreterTest.cpp
+
----------------
Well.. this is now definitely going to get tested well. :P

While we do have some inconsistency where some test files put "Test" as a 
prefix and others as a suffix, we definitely don't need to have both in the 
same file. The Test suffix is a prevailing convention (792 vs. 62), so I 
recommend sticking to that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77444/new/

https://reviews.llvm.org/D77444



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to