Re: [Lldb-commits] [lldb] r359575 - XFAIL x86-64-zmm-read on Darwin

On Tue, 2019-04-30 at 21:00 +0200, Pavel Labath wrote: > On 30/04/2019 20:24, Jonas Devlieghere wrote: > > Hey Pavel, > > > > Apologies if I was too hasty, given the number of XFAILs I assumed the > > test was a WIP and the missing darwin was an oversight. > > > > Here's the output on my machine

[Lldb-commits] [PATCH] D61360: Initialization: remove ObjectContainer from Common

xiaobai added inline comments. Comment at: source/API/CMakeLists.txt:99-100 lldbUtility +lldbPluginObjectContainerBSDArchive +lldbPluginObjectContainerMachOArchive ${LLDB_ALL_PLUGINS} These should get sucked into LLDB_ALL_PLUGINS right? Reposi

[Lldb-commits] [lldb] r359645 - [CMake] Correct lldbPluginProcessPOSIX dependencies

Author: xiaobai Date: Tue Apr 30 20:23:09 2019 New Revision: 359645 URL: http://llvm.org/viewvc/llvm-project?rev=359645&view=rev Log: [CMake] Correct lldbPluginProcessPOSIX dependencies This plugin does not depend on lldbInterpreter. It only depends on lldbUtility. Modified: lldb/trunk/sourc

[Lldb-commits] [PATCH] D61362: lldb-server: remove link against lldbInterpreter

compnerd created this revision. compnerd added reviewers: davide, aprantl, clayborg. Herald added a subscriber: mgorny. Herald added a project: LLDB. This dependency is unused. Remove the extraneous link. Repository: rLLDB LLDB https://reviews.llvm.org/D61362 Files: tools/lldb-server/CMak

[Lldb-commits] [PATCH] D61361: PluginInstructionARM: avoid unnecessary link

compnerd created this revision. compnerd added reviewers: davide, aprantl, clayborg. Herald added subscribers: kristof.beyls, javed.absar, mgorny. Herald added a project: LLDB. lldbPluginInstructionARM does not depend on lldbProcessUtility at link time. The dependency is for defines and helper fu

[Lldb-commits] [PATCH] D61360: Initialization: remove ObjectContainer from Common

compnerd created this revision. compnerd added reviewers: davide, aprantl, clayborg. Herald added subscribers: abidh, mgorny. Herald added a project: LLDB. This restructures the initialization path to move the ObjectContainer initialization into the *full* initialization path. This is not needed

[Lldb-commits] [PATCH] D61299: Rename Minion to ASTImporterDelegate

shafik accepted this revision. shafik added a comment. This is a good change! Comment at: lldb/include/lldb/Symbol/ClangASTImporter.h:259 public: - CxxModuleScope(Minion &minion, clang::ASTContext *dst_ctx) + CxxModuleScope(ASTImporterDelegate &minion, clang::AST

[Lldb-commits] [PATCH] D61311: PostfixExpression: Use signed integers in IntegerNode

clayborg added inline comments. Comment at: include/lldb/Symbol/PostfixExpression.h:97 private: - uint32_t m_value; + int64_t m_value; }; Do we want to try and use lldb_private::Scalar here? Then this could handle signed/unsigned ints, floats and anything el

[Lldb-commits] [PATCH] D61146: Set a CXXRecordDecl to not be passed in registers if DW_CC_pass_by_reference when loading from DWARF

shafik updated this revision to Diff 197426. shafik marked 9 inline comments as done. shafik added a comment. Changed to reflect comments. - Added comments to test to explain what it is doing. - Formatting and other minor fixes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61146/new/

[Lldb-commits] [PATCH] D61146: Set a CXXRecordDecl to not be passed in registers if DW_CC_pass_by_reference when loading from DWARF

shafik added inline comments. Comment at: packages/Python/lldbsuite/test/expression_command/argument_passing_restrictions/main.cpp:22 + bounds.y = 2; + return; +} aprantl wrote: > what's the point of the return? This is vestigial return left over f

[Lldb-commits] [PATCH] D61235: Add more information to the log timer dump

aadsm updated this revision to Diff 197420. aadsm added a comment. Use EXPECT_NEAR for tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61235/new/ https://reviews.llvm.org/D61235 Files: lldb/include/lldb/Utility/Timer.h lldb/source/Utility/

[Lldb-commits] [PATCH] D59826: [expression] Explicitly build the lookup table of any TagDecl's context

martong abandoned this revision. martong added a comment. During writing the tests, I realized that this is only a partial solution. So I abandon this patch in favor for https://reviews.llvm.org/D61333 , please take a look at that. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://

[Lldb-commits] [PATCH] D61333: [ASTImporter] Fix LLDB lookup in transparent ctx and with ext src

martong marked 2 inline comments as done. martong added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/lang/c/modules/main.c:8 int b; -} FILE; +} MYFILE; In TestCmodules.py we have `import Darwin` and then `expr *fopen("/dev/zero", "w")`

[Lldb-commits] [PATCH] D61333: [ASTImporter] Fix LLDB lookup in transparent ctx and with ext src

martong created this revision. martong added reviewers: shafik, teemperor, jingham, clayborg, a_sidorin. Herald added subscribers: lldb-commits, cfe-commits, gamesh411, Szelethus, dkrupp, rnkovacs. Herald added a reviewer: a.sidorin. Herald added projects: clang, LLDB. With LLDB we use localUncac

Re: [Lldb-commits] [lldb] r359575 - XFAIL x86-64-zmm-read on Darwin

On 30/04/2019 20:24, Jonas Devlieghere wrote: Hey Pavel, Apologies if I was too hasty, given the number of XFAILs I assumed the test was a WIP and the missing darwin was an oversight. Here's the output on my machine: https://reviews.llvm.org/P8142 No worries. Darwin is actually the one place

Re: [Lldb-commits] [lldb] r359575 - XFAIL x86-64-zmm-read on Darwin

Hey Pavel, Apologies if I was too hasty, given the number of XFAILs I assumed the test was a WIP and the missing darwin was an oversight. Here's the output on my machine: https://reviews.llvm.org/P8142 CHECK-DAG: expected string not found in input # CHECK-DAG: xmm16 = {0x00 0x0f 0x0d 0x0b 0x09 0

[Lldb-commits] [lldb] r359593 - Add CxxModuleHandler to Xcode project

Author: jdevlieghere Date: Tue Apr 30 11:21:14 2019 New Revision: 359593 URL: http://llvm.org/viewvc/llvm-project?rev=359593&view=rev Log: Add CxxModuleHandler to Xcode project Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj URL: http:

Re: [Lldb-commits] [lldb] r359575 - XFAIL x86-64-zmm-read on Darwin

On 30/04/2019 19:21, Jonas Devlieghere via lldb-commits wrote: Author: jdevlieghere Date: Tue Apr 30 10:21:05 2019 New Revision: 359575 URL: http://llvm.org/viewvc/llvm-project?rev=359575&view=rev Log: XFAIL x86-64-zmm-read on Darwin Modified: lldb/trunk/lit/Register/x86-64-zmm-read.test

[Lldb-commits] [PATCH] D61303: [lldb] [lit] Add write tests for MM/XMM/r8-r15 registers

labath marked an inline comment as done. labath added inline comments. Comment at: lldb/lit/Register/Inputs/x86-mm-xmm-write.cpp:10 +int main() { + constexpr uint64_t mm_fill = 0x0F0F0F0F0F0F0F0F; + constexpr xmm_t xmm_fill = { mm_fill, mm_fill }; mgorny wrote:

[Lldb-commits] [PATCH] D61299: Rename Minion to ASTImporterDelegate

martong added inline comments. Comment at: lldb/include/lldb/Symbol/ClangASTImporter.h:259 public: - CxxModuleScope(Minion &minion, clang::ASTContext *dst_ctx) + CxxModuleScope(ASTImporterDelegate &minion, clang::ASTContext *dst_ctx) : m_minion(minion) {

[Lldb-commits] [PATCH] D61299: Rename Minion to ASTImporterDelegate

martong added inline comments. Comment at: lldb/include/lldb/Symbol/ClangASTImporter.h:328 clang::ASTContext *m_dst_ctx; -MinionMap m_minions; +DelegateMap m_minions; OriginMap m_origins; Would it make sense to rename the variables too? E.g. `m_

[Lldb-commits] [PATCH] D61303: [lldb] [lit] Add write tests for MM/XMM/r8-r15 registers

mgorny updated this revision to Diff 197376. mgorny added a comment. Ok, I see that Darwin doesn't implement writing to xmm* registers at the moment. Added XFAIL for it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61303/new/ https://reviews.llvm.org/D61303 Files: lldb/lit/Register

[Lldb-commits] [PATCH] D61303: [lldb] [lit] Add write tests for MM/XMM/r8-r15 registers

JDevlieghere added inline comments. Comment at: lldb/lit/Register/x86-64-write.test:1 +# XFAIL: system-windows +# REQUIRES: native && (target-x86 || target-x86_64) && native-cpu-sse mgorny wrote: > JDevlieghere wrote: > > This fails on Darwin for me: > > ``` > >

[Lldb-commits] [PATCH] D61303: [lldb] [lit] Add write tests for MM/XMM/r8-r15 registers

mgorny marked an inline comment as done. mgorny added inline comments. Comment at: lldb/lit/Register/Inputs/x86-mm-xmm-write.cpp:10 +int main() { + constexpr uint64_t mm_fill = 0x0F0F0F0F0F0F0F0F; + constexpr xmm_t xmm_fill = { mm_fill, mm_fill }; labath wrote:

[Lldb-commits] [lldb] r359577 - Sort Symbol/CMakeLists.txt

Author: jdevlieghere Date: Tue Apr 30 10:22:29 2019 New Revision: 359577 URL: http://llvm.org/viewvc/llvm-project?rev=359577&view=rev Log: Sort Symbol/CMakeLists.txt This makes resolving merge conflicts downstream a tad easier. Modified: lldb/trunk/source/Symbol/CMakeLists.txt Modified: lld

[Lldb-commits] [lldb] r359575 - XFAIL x86-64-zmm-read on Darwin

Author: jdevlieghere Date: Tue Apr 30 10:21:05 2019 New Revision: 359575 URL: http://llvm.org/viewvc/llvm-project?rev=359575&view=rev Log: XFAIL x86-64-zmm-read on Darwin Modified: lldb/trunk/lit/Register/x86-64-zmm-read.test Modified: lldb/trunk/lit/Register/x86-64-zmm-read.test URL: http:

[Lldb-commits] [PATCH] D61303: [lldb] [lit] Add write tests for MM/XMM/r8-r15 registers

JDevlieghere added inline comments. Comment at: lldb/lit/Register/x86-64-write.test:1 +# XFAIL: system-windows +# REQUIRES: native && (target-x86 || target-x86_64) && native-cpu-sse This fails on Darwin for me: ``` # CHECK-DAG: xmm8 = 0x030507090b0d0f00020406080a

[Lldb-commits] [PATCH] D61305: Add std::stack and std::queue support to CxxModuleHandler

shafik accepted this revision. shafik added a comment. LGTM Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61305/new/ https://reviews.llvm.org/D61305 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https:/

[Lldb-commits] [PATCH] D61266: Skip TestClassTemplateParameterPack.py on all platforms

friss accepted this revision. friss added a comment. This revision is now accepted and ready to land. LGTM if no one else objects. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61266/new/ https://reviews.llvm.org/D61266 ___ lldb-commits mai

[Lldb-commits] [PATCH] D61266: Skip TestClassTemplateParameterPack.py on all platforms

shafik added a comment. @friss makes sense, updated comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61266/new/ https://reviews.llvm.org/D61266 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/m

[Lldb-commits] [PATCH] D61266: Skip TestClassTemplateParameterPack.py on all platforms

shafik updated this revision to Diff 197360. shafik added a comment. Updated comment to be more precise. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61266/new/ https://reviews.llvm.org/D61266 Files: packages/Python/lldbsuite/test/lang/cpp/class-template-parameter-pack/TestClassTem

[Lldb-commits] [PATCH] D61303: [lldb] [lit] Add write tests for MM/XMM/r8-r15 registers

mgorny updated this revision to Diff 197355. mgorny marked an inline comment as done. mgorny retitled this revision from "[lldb] [lit] Add write tests for MM/XMM registers" to "[lldb] [lit] Add write tests for MM/XMM/r8-r15 registers". mgorny edited the summary of this revision. mgorny added a com

[Lldb-commits] [lldb] r359573 - Un-xfail the TestMiniDump tests on Windows

Author: stella.stamenova Date: Tue Apr 30 09:42:39 2019 New Revision: 359573 URL: http://llvm.org/viewvc/llvm-project?rev=359573&view=rev Log: Un-xfail the TestMiniDump tests on Windows After Aaron's commit for ObjectFilePECOFF:: GetUUID, the tests are now passing Modified: lldb/trunk/packa

[Lldb-commits] [PATCH] D61310: [lldb] [Process/NetBSD] Fix handling piod_len from PT_IO calls

This revision was automatically updated to reflect the committed changes. Closed by commit rL359572: [lldb] [Process/NetBSD] Fix handling piod_len from PT_IO calls (authored by mgorny, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [lldb] r359572 - [lldb] [Process/NetBSD] Fix handling piod_len from PT_IO calls

Author: mgorny Date: Tue Apr 30 09:30:32 2019 New Revision: 359572 URL: http://llvm.org/viewvc/llvm-project?rev=359572&view=rev Log: [lldb] [Process/NetBSD] Fix handling piod_len from PT_IO calls Fix bugs in piod_len return value processing in ReadMemory() and WriteMemory() methods. In particula

[Lldb-commits] [PATCH] D61299: Rename Minion to ASTImporterDelegate

aprantl accepted this revision. aprantl added inline comments. Comment at: lldb/include/lldb/Symbol/ClangASTImporter.h:238 - class Minion : public clang::ASTImporter { + class ASTImporterDelegate : public clang::ASTImporter { public: Is there some sort of

[Lldb-commits] [PATCH] D61299: Rename Minion to ASTImporterDelegate

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. Herald added a subscriber: rnkovacs. yay :) Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61299/new/ https://reviews.llvm.org/D61299 _

[Lldb-commits] [PATCH] D61310: [lldb] [Process/NetBSD] Fix handling piod_len from PT_IO calls

mgorny updated this revision to Diff 197326. mgorny retitled this revision from "[lldb] [Process/NetBSD] Fix handling piod_len when reading memory" to "[lldb] [Process/NetBSD] Fix handling piod_len from PT_IO calls". mgorny edited the summary of this revision. mgorny added a comment. Also includ

[Lldb-commits] [PATCH] D61311: PostfixExpression: Use signed integers in IntegerNode

amccarth accepted this revision. amccarth added a comment. This revision is now accepted and ready to land. This looks fine to me, and the rationale sounds right. I'll be curious to see if any other reviewers see a potential problem with this. CHANGES SINCE LAST ACTION https://reviews.llvm.o

[Lldb-commits] [PATCH] D61310: [lldb] [Process/NetBSD] Fix handling piod_len when reading memory

mgorny updated this revision to Diff 197325. mgorny retitled this revision from "[lldb] [Process/NetBSD] Fix handling EOF in PT_IO when reading memory" to "[lldb] [Process/NetBSD] Fix handling piod_len when reading memory". mgorny edited the summary of this revision. CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D61310: [lldb] [Process/NetBSD] Fix handling EOF in PT_IO when reading memory

krytarowski requested changes to this revision. krytarowski added a comment. This revision now requires changes to proceed. I think there is a bug thought in the code. 1. bytes_read should return the bytes transferred from the function, it returns the value from the previous iteration only 2. `b

[Lldb-commits] [PATCH] D61310: [lldb] [Process/NetBSD] Fix handling EOF in PT_IO when reading memory

mgorny created this revision. mgorny added reviewers: labath, krytarowski, joerg. Fix NativeProcessNetBSD::ReadMemory() to account for the possibility of the ptrace() PT_IO call returning piod_len == 0, to indicate EOF. This could happen if LLDB attempts to read past vm.maxaddress, e.g. as a resul

[Lldb-commits] [PATCH] D61311: PostfixExpression: Use signed integers in IntegerNode

labath created this revision. labath added reviewers: amccarth, clayborg, aleksandr.urakov. This is necessary to support parsing expressions like ".cfa -16 + ^", as that format is used in breakpad STACK CFI expressions. Since the PDB expressions use the same parser, this change will affect them t

[Lldb-commits] [PATCH] D61183: PostfixExpression: Introduce CFANode

labath marked an inline comment as done. labath added inline comments. Comment at: source/Symbol/PostfixExpression.cpp:150 + /// InitialValueNodes in our input expression, we assume the initial stack + /// will contain their value (hence we start with m_stack_depth = 1). If we

[Lldb-commits] [PATCH] D61183: PostfixExpression: Introduce CFANode

This revision was automatically updated to reflect the committed changes. Closed by commit rL359560: PostfixExpression: Introduce InitialValueNode (authored by labath, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews

[Lldb-commits] [lldb] r359560 - PostfixExpression: Introduce InitialValueNode

Author: labath Date: Tue Apr 30 06:33:18 2019 New Revision: 359560 URL: http://llvm.org/viewvc/llvm-project?rev=359560&view=rev Log: PostfixExpression: Introduce InitialValueNode Summary: This node represents can be used to refer to the initial value, which is sometimes pushed onto the DWARF stac

[Lldb-commits] [PATCH] D61303: [lldb] [lit] Add write tests for MM/XMM registers

mgorny updated this revision to Diff 197306. mgorny marked 2 inline comments as done. mgorny added a comment. Switched to hex offsets, and added match for 'process continue'. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61303/new/ https://reviews.llvm.org/D61303 Files: lldb/lit/Regi

[Lldb-commits] [PATCH] D61244: Re-enable gmodules tests on Linux

labath added a comment. In D61244#1482196 , @teemperor wrote: > In D61244#1482146 , @labath wrote: > > > LG, but note that this has no effect on the overall set of tests which will > > run as long as gmodules remai

[Lldb-commits] [PATCH] D61303: [lldb] [lit] Add write tests for MM/XMM registers

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. The assembly looks perfectly fine to me. The only thing I'd consider changing is writing the displacements in the `movq ... (%rbx)` instructions in hex. Comment at: lldb/lit

[Lldb-commits] [PATCH] D61235: Add more information to the log timer dump

labath added inline comments. Comment at: lldb/unittests/Utility/TimerTest.cpp:100-101 + << "String: " << ss.GetData(); + EXPECT_GT(total1 - child1, seconds1 - 0.001); + EXPECT_LT(total1 - child1, seconds1 + 0.001); + EXPECT_EQ(1, count1); aadsm wrote: >

[Lldb-commits] [PATCH] D61305: Add std::stack and std::queue support to CxxModuleHandler

teemperor created this revision. teemperor added reviewers: aprantl, shafik. teemperor added a project: C++ modules in LLDB. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rLLDB LLDB https://reviews.llvm.org/D61305 Files: lldb/packages/Python/lldbsuite/te

[Lldb-commits] [PATCH] D61303: [lldb] [lit] Add write tests for MM/XMM registers

mgorny created this revision. mgorny added reviewers: labath, JDevlieghere, krytarowski. NB: this time clang complained that I'm using too many registers (and gcc was happy) when I tried using separate operands for every value. So I learned how to use memory ;-). Since this isn't really educated

[Lldb-commits] [lldb] r359546 - Sort containers alphabetically in CxxModuleHandler [NFC]

Author: teemperor Date: Tue Apr 30 03:27:31 2019 New Revision: 359546 URL: http://llvm.org/viewvc/llvm-project?rev=359546&view=rev Log: Sort containers alphabetically in CxxModuleHandler [NFC] Modified: lldb/trunk/source/Symbol/CxxModuleHandler.cpp Modified: lldb/trunk/source/Symbol/CxxModul

[Lldb-commits] [PATCH] D61299: Rename Minion to ASTImporterDelegate

teemperor created this revision. teemperor added reviewers: aprantl, shafik. Herald added a reviewer: martong. Herald added a reviewer: a.sidorin. Herald added subscribers: lldb-commits, abidh. Herald added a project: LLDB. I think there universal agreement that Minion isn't the best name for this

[Lldb-commits] [PATCH] D59537: Instantiate 'std' templates explicitly in the expression evaluator

teemperor marked an inline comment as done. teemperor added inline comments. Comment at: lldb/include/lldb/Symbol/ClangASTImporter.h:249 +/// it at the end of the scope. Supports being used multiple times on the +/// same Minion instance in nested scopes. +class CxxMo

[Lldb-commits] [PATCH] D59537: Instantiate 'std' templates explicitly in the expression evaluator

This revision was automatically updated to reflect the committed changes. Closed by commit rL359538: Instantiate 'std' templates explicitly in the expression evaluator (authored by teemperor, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to c

[Lldb-commits] [lldb] r359538 - Instantiate 'std' templates explicitly in the expression evaluator

Author: teemperor Date: Tue Apr 30 01:41:35 2019 New Revision: 359538 URL: http://llvm.org/viewvc/llvm-project?rev=359538&view=rev Log: Instantiate 'std' templates explicitly in the expression evaluator Summary: This patch is a follow-up for D58125. It implements the manual instantiation and mer