mgorny marked an inline comment as done.
mgorny added inline comments.
================
Comment at: lldb/lit/Register/Inputs/x86-mm-xmm-write.cpp:10
+int main() {
+ constexpr uint64_t mm_fill = 0x0F0F0F0F0F0F0F0F;
+ constexpr xmm_t xmm_fill = { mm_fill, mm_fill };
----------------
labath wrote:
> It looks like `mm_fill` is unused.
It's used to fill `xmm_fill` ;-). Should I inline it?
================
Comment at: lldb/lit/Register/x86-64-write.test:1
+# XFAIL: system-windows
+# REQUIRES: native && (target-x86 || target-x86_64) && native-cpu-sse
----------------
JDevlieghere wrote:
> This fails on Darwin for me:
> ```
> # CHECK-DAG: xmm8 = 0x030507090b0d0f00020406080a0c0e01
> ^
> <stdin>:38:1: note: scanning from here
> r8 = 0x0102030405060708
> ^
> <stdin>:46:1: note: possible intended match here
> xmm8 = 0x0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f
> ```
Could you run it without FileCheck, and paste the full output? Manually would
be something alike:
clang++ Inputs/x86-64-write.cpp
lldb -b -s x86-64-write.test a.out
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61303/new/
https://reviews.llvm.org/D61303
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
