labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
The assembly looks perfectly fine to me. The only thing I'd consider changing
is writing the displacements in the `movq ... (%rbx)` instructions in hex.
================
Comment at: lldb/lit/Register/Inputs/x86-mm-xmm-write.cpp:10
+int main() {
+ constexpr uint64_t mm_fill = 0x0F0F0F0F0F0F0F0F;
+ constexpr xmm_t xmm_fill = { mm_fill, mm_fill };
----------------
It looks like `mm_fill` is unused.
================
Comment at: lldb/lit/Register/x86-mm-xmm-write.test:27
+process continue
+# CHECK-DAG: mm0 = 0x0102030405060708
+# CHECK-DAG: mm1 = 0x1112131415161718
----------------
When looking at the jenkins output from the failed gp-write run, I realized
that the failure message isn't very helpful because FileCheck suggests the
"register write" line above as a "possible intended match".
I think it may be possible to improve on that by adding a `CHECK: process
continue` here so that all subsequent checks only look at the process output,
and not the commands setting the values.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61303/new/
https://reviews.llvm.org/D61303
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
