[Lldb-commits] [PATCH] D12877: [LLDB] Switch to assembly view if source is moved

mohit.bhakkad created this revision. mohit.bhakkad added a reviewer: clayborg. mohit.bhakkad added subscribers: jaydeep, bhushan, sagar, nitesh.jain, lldb-commits. mohit.bhakkad set the repository for this revision to rL LLVM. Repository: rL LLVM http://reviews.llvm.org/D12877 Files: source

[Lldb-commits] [PATCH] D12876: [MIPS] Debug bare-iron targets lacking support for qC /qfThreadInfo

jaydeep created this revision. jaydeep added a reviewer: clayborg. jaydeep added subscribers: lldb-commits, bhushan, sagar, mohit.bhakkad, nitesh.jain. jaydeep set the repository for this revision to rL LLVM. Refer to for discuss

Re: [Lldb-commits] [PATCH] D12794: [MIPS] Add support for DT_MIPS_RLD_MAP_REL

bhushan closed this revision. bhushan added a comment. Closed by commit http://reviews.llvm.org/rL247666 Repository: rL LLVM http://reviews.llvm.org/D12794 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/ma

[Lldb-commits] [lldb] r247666 - [LLDB][MIPS] Add support for DT_MIPS_RLD_MAP_REL

Author: bhushan.attarde Date: Tue Sep 15 00:45:29 2015 New Revision: 247666 URL: http://llvm.org/viewvc/llvm-project?rev=247666&view=rev Log: [LLDB][MIPS] Add support for DT_MIPS_RLD_MAP_REL SUMMARY: This patch provides support for MIPS specific DT_MIPS_RLD_MAP_REL tag in LLDB. T

Re: [Lldb-commits] [PATCH] D12079: [MIPS] microMIPS breakpoints, disassembly and compressed addresses

jaydeep updated this revision to Diff 34782. jaydeep added a comment. Addressed review comments Repository: rL LLVM http://reviews.llvm.org/D12079 Files: source/Core/Address.cpp source/Plugins/Disassembler/llvm/DisassemblerLLVMC.cpp source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp sou

[Lldb-commits] [lldb] r247665 - Mark TestMultipleDebuggers as flakey on Darwin.

Author: tfiala Date: Tue Sep 15 00:31:27 2015 New Revision: 247665 URL: http://llvm.org/viewvc/llvm-project?rev=247665&view=rev Log: Mark TestMultipleDebuggers as flakey on Darwin. See if this gets us past a few machines that are failing it when it is expected to pass. Modified: lldb/trunk/t

Re: [Lldb-commits] [PATCH] D12831: Add JUnit/XUnit-formatted output to the lldb test run system

tfiala updated this revision to Diff 34779. tfiala added a comment. Updated patch against svn r247664. http://reviews.llvm.org/D12831 Files: test/dosep.py test/dotest.py test/dotest_args.py test/dotest_channels.py test/settings/TestSettings.py test/test_results.py Index: test/test_

[Lldb-commits] [lldb] r247664 - Fixed up TestConstVariables for Linux/FreeBSD, take 2.

Author: tfiala Date: Mon Sep 14 23:53:14 2015 New Revision: 247664 URL: http://llvm.org/viewvc/llvm-project?rev=247664&view=rev Log: Fixed up TestConstVariables for Linux/FreeBSD, take 2. Marked XFAIL for: clang - all versions < 3.5. I verified the first version it passes on Linux is 3.5. clang

[Lldb-commits] [PATCH] D12873: Return false, not 0, for bools.

brucem created this revision. brucem added a reviewer: clayborg. brucem added a subscriber: lldb-commits. http://reviews.llvm.org/D12873 Files: source/Symbol/ClangASTContext.cpp source/Symbol/CompilerType.cpp Index: source/Symbol/CompilerType.cpp =

[Lldb-commits] [lldb] r247663 - Coding style fix.

Author: brucem Date: Mon Sep 14 23:50:56 2015 New Revision: 247663 URL: http://llvm.org/viewvc/llvm-project?rev=247663&view=rev Log: Coding style fix. Modified: lldb/trunk/source/Symbol/GoASTContext.cpp Modified: lldb/trunk/source/Symbol/GoASTContext.cpp URL: http://llvm.org/viewvc/llvm-pro

[Lldb-commits] [lldb] r247662 - Use uint64_t for GoArray size.

Author: brucem Date: Mon Sep 14 23:33:48 2015 New Revision: 247662 URL: http://llvm.org/viewvc/llvm-project?rev=247662&view=rev Log: Use uint64_t for GoArray size. Summary: This was int64_t, but all usages of it came from code that was passing in unsigned values. The usages of the array size, exc

Re: [Lldb-commits] [PATCH] D12872: Use uint64_t for GoArray size.

This revision was automatically updated to reflect the committed changes. Closed by commit rL247662: Use uint64_t for GoArray size. (authored by brucem). Changed prior to commit: http://reviews.llvm.org/D12872?vs=34775&id=34776#toc Repository: rL LLVM http://reviews.llvm.org/D12872 Files:

Re: [Lldb-commits] [PATCH] D12872: Use uint64_t for GoArray size.

ribrdb accepted this revision. ribrdb added a comment. This revision is now accepted and ready to land. Looks good http://reviews.llvm.org/D12872 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinf

Re: [Lldb-commits] [PATCH] D12872: Use uint64_t for GoArray size.

brucem added a comment. This is meant to fix this warning: llvm/tools/lldb/source/Symbol/GoASTContext.cpp:1107:40: warning: comparison of integers of different signs: 'size_t' (aka 'unsigned long') and 'int64_t' (aka 'long long') [-Wsign-compare] if (ignore_array_bounds || idx < a->

[Lldb-commits] [PATCH] D12872: Use uint64_t for GoArray size.

brucem created this revision. brucem added reviewers: ribrdb, clayborg. brucem added a subscriber: lldb-commits. This was int64_t, but all usages of it came from code that was passing in unsigned values. The usages of the array size, except for one, were also treating it as an unsigned value. The

Re: [Lldb-commits] [PATCH] D12115: [LLDB-MI] Fix -data-info-line and -symbol-list-lines when Windows filenames are used.

dawn updated this revision to Diff 34769. dawn added a comment. Patch fixed to remove uses of lldb_private classes. Repository: rL LLVM http://reviews.llvm.org/D12115 Files: test/tools/lldb-mi/symbol/Makefile test/tools/lldb-mi/symbol/TestMiSymbol.py test/tools/lldb-mi/symbol/main.cpp

Re: [Lldb-commits] [PATCH] D12115: [LLDB-MI] Fix -data-info-line and -symbol-list-lines when Windows filenames are used.

dawn added a comment. In http://reviews.llvm.org/D12115#244049, @zturner wrote: > The FileSpec is not even used for anything is it? No, that was a carry over from a previous patch - now deleted. > If you want to use the > RegularExpression, then use llvm's regular expression. Honestly LLDB'

Re: [Lldb-commits] [PATCH] D12658: Search variables based on clang::DeclContext and clang::Decl tree

paulherman updated this revision to Diff 34768. paulherman added a comment. Search variables based on clang::DeclContext and clang::Decl tree Moved the DeclLinkToObject inside Variable::GetDecl. http://reviews.llvm.org/D12658 Files: include/lldb/Symbol/ClangASTContext.h include/lldb/Symbol

[Lldb-commits] [lldb] r247648 - Revert "Fixup XFAIL marking on TestConstVariables for clang version"

Author: chaoren Date: Mon Sep 14 19:52:00 2015 New Revision: 247648 URL: http://llvm.org/viewvc/llvm-project?rev=247648&view=rev Log: Revert "Fixup XFAIL marking on TestConstVariables for clang version" Summary: Linux with ToT clang (3.8) fails. This reverts commit r247633. Reviewers: tfiala S

Re: [Lldb-commits] [PATCH] D12868: Revert "Fixup XFAIL marking on TestConstVariables for clang version"

This revision was automatically updated to reflect the committed changes. Closed by commit rL247648: Revert "Fixup XFAIL marking on TestConstVariables for clang version" (authored by chaoren). Changed prior to commit: http://reviews.llvm.org/D12868?vs=34764&id=34766#toc Repository: rL LLVM

[Lldb-commits] [lldb] r247647 - Fix error on windows:

Author: ribrdb Date: Mon Sep 14 19:50:43 2015 New Revision: 247647 URL: http://llvm.org/viewvc/llvm-project?rev=247647&view=rev Log: Fix error on windows: c:\buildbot\lldb-windows-x86\lldb-windows-x86\llvm\tools\lldb\source\symbol\goastcontext.cpp(906) : warning C4715: 'lldb_private::GoASTContex

[Lldb-commits] [PATCH] D12868: Revert "Fixup XFAIL marking on TestConstVariables for clang version"

chaoren created this revision. chaoren added a reviewer: tfiala. chaoren added a subscriber: lldb-commits. Linux with ToT clang (3.8) fails. This reverts commit r247633. http://reviews.llvm.org/D12868 Files: test/lang/c/const_variables/TestConstVariables.py Index: test/lang/c/const_variables

Re: [Lldb-commits] [PATCH] D12658: Search variables based on clang::DeclContext and clang::Decl tree

paulherman added a comment. I just ran a grep through the source. It seems that everywhere it is created as a shared_ptr. In a previous attempt I tried storing it in the TypeSystem map from decl to object as Variable* instead of VariableSP and it seemed like at some point between launching a qu

Re: [Lldb-commits] [PATCH] D12658: Search variables based on clang::DeclContext and clang::Decl tree

clayborg added a comment. We only really need variable to inherit from std::shared_from_this if we have any classes or API that use a "Variable *" as ivars or parameters. If we do, feel free to make it inherit from shared_from_this, but I would like to avoid it if possible to save on space. Als

Re: [Lldb-commits] [PATCH] D12658: Search variables based on clang::DeclContext and clang::Decl tree

paulherman added a comment. In http://reviews.llvm.org/D12658#245851, @clayborg wrote: > So I don't like it in ParseVariableDIE() because it means we must create the > decl right away for the variable when parsing it. ParseVariableDIE is used to > parse all variables everywhere and we don't nee

Re: [Lldb-commits] [PATCH] D12658: Search variables based on clang::DeclContext and clang::Decl tree

clayborg added a comment. So I don't like it in ParseVariableDIE() because it means we must create the decl right away for the variable when parsing it. ParseVariableDIE is used to parse all variables everywhere and we don't need the CompilerDecl in order to display the Variable, so we don't ne

[Lldb-commits] [lldb] r247641 - Avoid a crash in the test suite where if we have a ObjC "id" type and we ask it for the PointeeType() we would get a CompilerType with a valid TypeSystem, but invalid o

Author: gclayton Date: Mon Sep 14 18:55:01 2015 New Revision: 247641 URL: http://llvm.org/viewvc/llvm-project?rev=247641&view=rev Log: Avoid a crash in the test suite where if we have a ObjC "id" type and we ask it for the PointeeType() we would get a CompilerType with a valid TypeSystem, but in

Re: [Lldb-commits] [PATCH] D12658: Search variables based on clang::DeclContext and clang::Decl tree

paulherman added a comment. I thought about the problem a bit more and I believe that having the call to DeclLinkDeclToObject inside ParseVariableDIE makes sense since this gets called only when the variable will actually be used in a search together with its context. Also, since ParseVariableD

[Lldb-commits] [lldb] r247639 - Marked TestEvents test as flakey on Linux.

Author: tfiala Date: Mon Sep 14 18:35:00 2015 New Revision: 247639 URL: http://llvm.org/viewvc/llvm-project?rev=247639&view=rev Log: Marked TestEvents test as flakey on Linux. It's passing all the time for me (50/50), and was passing what looks like 9/10 times for the originator. Modified: l

[Lldb-commits] [lldb] r247638 - Darwin has a debug info format that stores module types in stand alone files and it uses some of the DWO attributes. Don't assert in SymbolFileDWARFDwo, just return nul

Author: gclayton Date: Mon Sep 14 18:34:26 2015 New Revision: 247638 URL: http://llvm.org/viewvc/llvm-project?rev=247638&view=rev Log: Darwin has a debug info format that stores module types in stand alone files and it uses some of the DWO attributes. Don't assert in SymbolFileDWARFDwo, just ret

[Lldb-commits] [lldb] r247633 - Fixup XFAIL marking on TestConstVariables for clang version

Author: tfiala Date: Mon Sep 14 18:17:15 2015 New Revision: 247633 URL: http://llvm.org/viewvc/llvm-project?rev=247633&view=rev Log: Fixup XFAIL marking on TestConstVariables for clang version Linux/clang on clang 3.6+ is passing this test. As OS X was in a similar position, I'm guessing this wa

[Lldb-commits] [lldb] r247631 - Fix the Xcode project to compile Cocoa.cpp instead of Coca.cpp.

Author: gclayton Date: Mon Sep 14 17:57:25 2015 New Revision: 247631 URL: http://llvm.org/viewvc/llvm-project?rev=247631&view=rev Log: Fix the Xcode project to compile Cocoa.cpp instead of Coca.cpp. Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified: lldb/trunk/lldb.xcodeproj/proj

[Lldb-commits] [lldb] r247630 - Remove include that isn't needed.

Author: gclayton Date: Mon Sep 14 17:56:46 2015 New Revision: 247630 URL: http://llvm.org/viewvc/llvm-project?rev=247630&view=rev Log: Remove include that isn't needed. Modified: lldb/trunk/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp Modified: lldb/trunk/source/Plugins/SymbolFile/DW

[Lldb-commits] [lldb] r247628 - Fix CMake build.

Author: chaoren Date: Mon Sep 14 17:39:34 2015 New Revision: 247628 URL: http://llvm.org/viewvc/llvm-project?rev=247628&view=rev Log: Fix CMake build. - Typo: Coca.cpp -> Cocoa.cpp - Missing include. Added: lldb/trunk/source/Plugins/Language/ObjC/Cocoa.cpp - copied, changed from r24762

Re: [Lldb-commits] [PATCH] D12791: Complete register kind naming cleanups in lldb -- required touching all register table definitions

jasonmolenda added a comment. Thanks Tamas. I'll figure out what's happening there before I commit. http://reviews.llvm.org/D12791 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D12831: Add JUnit/XUnit-formatted output to the lldb test run system

tfiala added a comment. @zturner, how does this look on Windows? If you need a refresh with recent changes (there was at least one change outside to dosep.py), I can update the patch. http://reviews.llvm.org/D12831 ___ lldb-commits mailing list ll

[Lldb-commits] [lldb] r247615 - ClangExpressionDeclMap should only disable the Clang parser-specific state on

Author: spyffe Date: Mon Sep 14 16:03:44 2015 New Revision: 247615 URL: http://llvm.org/viewvc/llvm-project?rev=247615&view=rev Log: ClangExpressionDeclMap should only disable the Clang parser-specific state on Clang persistent variables. Modified: lldb/trunk/source/Expression/ClangExpression

Re: [Lldb-commits] [PATCH] D12658: Search variables based on clang::DeclContext and clang::Decl tree

paulherman added a comment. If I move the call to DeclLinkDeclToObject inside any of the GetDeclXXX methods, then there is no way to access the VariableSP needed for the call and it is probably harder to reconstruct the parameters needed for ParseVariableDIE starting from just the DIE itself.

Re: [Lldb-commits] [PATCH] D12658: Search variables based on clang::DeclContext and clang::Decl tree

clayborg added a comment. In http://reviews.llvm.org/D12658#245547, @paulherman wrote: > Are you suggesting that the DeclLinkToObject is moved inside the GetDecl call > and I only remove that? Yes, actually you can probably move it into SymbolFileDWARF::GetDeclForUID(). there should be a cach

Re: [Lldb-commits] [PATCH] D12809: Better scheme to lookup alternate mangled name when looking up function address.

sivachandra added inline comments. Comment at: source/Expression/ClangExpressionDeclMap.cpp:661 @@ -603,4 +660,3 @@ { -FindCodeSymbolInContext( -demangled, m_parser_vars->m_sym_ctx, eFunctionNameTypeFull, sc_list); -

Re: [Lldb-commits] [PATCH] D12658: Search variables based on clang::DeclContext and clang::Decl tree

paulherman added a comment. Are you suggesting that the DeclLinkToObject is moved inside the GetDecl call and I only remove that? This is the only place where GetDecl is called, so it would be equivalent from a computational point of view. http://reviews.llvm.org/D12658

Re: [Lldb-commits] [PATCH] D12809: Better scheme to lookup alternate mangled name when looking up function address.

spyffe requested changes to this revision. spyffe added a comment. I LOVE the idea of getting rid of those horrid "alternate manglings." We knew what the mangling was during name lookup, we should be able to recognize them later! As listed in my inline comments, I have some concerns about the s

[Lldb-commits] [lldb] r247608 - Final unexpected success cleanup for OS X.

Author: tfiala Date: Mon Sep 14 15:16:34 2015 New Revision: 247608 URL: http://llvm.org/viewvc/llvm-project?rev=247608&view=rev Log: Final unexpected success cleanup for OS X. Top of tree is running with no unexpected successes with this change, on latest available El Capitan and Xcode betas. Mo

Re: [Lldb-commits] [PATCH] D12658: Search variables based on clang::DeclContext and clang::Decl tree

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. Yes, it would be nice to not have to get a variable's decl right up front. Maybe the Variable::GetDecl() could register this mapping if/when the variable decl is made the first t

[Lldb-commits] [lldb] r247605 - Fixes lldb-server commandline test xpass for OS X and Linux; resolves llvm.org/pr20273

Author: tfiala Date: Mon Sep 14 14:53:00 2015 New Revision: 247605 URL: http://llvm.org/viewvc/llvm-project?rev=247605&view=rev Log: Fixes lldb-server commandline test xpass for OS X and Linux; resolves llvm.org/pr20273 Modified: lldb/trunk/test/python_api/target/TestTargetAPI.py lldb/tr

[Lldb-commits] [lldb] r247602 - Another round of macosx unexpected success corrections.

Author: tfiala Date: Mon Sep 14 14:25:22 2015 New Revision: 247602 URL: http://llvm.org/viewvc/llvm-project?rev=247602&view=rev Log: Another round of macosx unexpected success corrections. Modified: lldb/trunk/test/functionalities/process_launch/TestProcessLaunch.py lldb/trunk/test/functi

[Lldb-commits] [lldb] r247601 - OS X unexpected success cleanup

Author: tfiala Date: Mon Sep 14 14:12:56 2015 New Revision: 247601 URL: http://llvm.org/viewvc/llvm-project?rev=247601&view=rev Log: OS X unexpected success cleanup TestPersistObjCPointeeType and TestObjCNewSyntax marked up to expect success on clang >= 7.0.0. TestMultipleDebuggers passed 25/25

Re: [Lldb-commits] [PATCH] D12658: Search variables based on clang::DeclContext and clang::Decl tree

paulherman added a comment. I think the only concern left might be the call to DeclLinkToObject in ParseVariableDIE. It doesn't have anything to do with clang but I feel like there should be a way to do this lazily. Otherwise, I believe that the comments have been addressed. Thank you! http:

Re: [Lldb-commits] [PATCH] D12809: Better scheme to lookup alternate mangled name when looking up function address.

sivachandra added a comment. I could very well be missing something obvious. However, let me explain what I am trying to solve here. Lets take the example of std::vector::size method. The DWARF we get when compiled with GCC is as follows: < 3><0x20a3>DW_TAG_subprogram

Re: [Lldb-commits] [PATCH] D12658: Search variables based on clang::DeclContext and clang::Decl tree

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. I believe you have addressed all of my concerns. Read through my previous comments and make sure, and if so, this is good to go. Nice patch, thanks for working through the abtracting issue

Re: [Lldb-commits] [PATCH] D12658: Search variables based on clang::DeclContext and clang::Decl tree

paulherman added a comment. In http://reviews.llvm.org/D12658#245466, @clayborg wrote: > In http://reviews.llvm.org/D12658#244710, @paulherman wrote: > > > [WIP] Search variables based on clang::DeclContext and clang::Decl tree > > > > This revision fixes some of the comments. There are some thin

[Lldb-commits] [lldb] r247596 - Remove expectedFailureFreeBSD from now-passing test

Author: emaste Date: Mon Sep 14 13:50:23 2015 New Revision: 247596 URL: http://llvm.org/viewvc/llvm-project?rev=247596&view=rev Log: Remove expectedFailureFreeBSD from now-passing test ExprCommandCallUserDefinedFunction::test_with_dwarf llvm.org/pr20274 Modified: lldb/trunk/test/expression

Re: [Lldb-commits] [PATCH] D12658: Search variables based on clang::DeclContext and clang::Decl tree

clayborg added a comment. In http://reviews.llvm.org/D12658#244710, @paulherman wrote: > [WIP] Search variables based on clang::DeclContext and clang::Decl tree > > This revision fixes some of the comments. There are some things I'm not sure > about. The problem is that at some point there will

Re: [Lldb-commits] [PATCH] D12658: Search variables based on clang::DeclContext and clang::Decl tree

clayborg added a comment. In http://reviews.llvm.org/D12658#243953, @paulherman wrote: > I believe that the approach of CompilerDeclContext::FindDecls could be > better. But then this kind of forces CompilerDeclContext to inherit > CompilerDecl (a function is both a DeclContext and a Decl) and

[Lldb-commits] [lldb] r247594 - Correct XFAIL OS list after r247576

Author: emaste Date: Mon Sep 14 13:40:52 2015 New Revision: 247594 URL: http://llvm.org/viewvc/llvm-project?rev=247594&view=rev Log: Correct XFAIL OS list after r247576 In ConstVariableTestCase::test_with_dwarf_and_run_command - the test fails with Clang (and presumably ICC) also on FreeBSD. Mod

Re: [Lldb-commits] [lldb] r247589 - Remove a debugging printf that got left in SymbolFileDWARFDebugMap.

Did this happen *again*? I think I took that out a few weeks ago... On Mon, Sep 14, 2015 at 11:28 AM, Jim Ingham via lldb-commits < lldb-commits@lists.llvm.org> wrote: > Author: jingham > Date: Mon Sep 14 13:28:28 2015 > New Revision: 247589 > > URL: http://llvm.org/viewvc/llvm-project?rev=24758

Re: [Lldb-commits] [lldb] r247576 - Cleaned up a few unexpected successes on OS X

The fix for this went in here (with a couple more XPASS cleanups): Sendingtest/expression_command/radar_9673664/TestExprHelpExamples.py Sendingtest/functionalities/avoids-fd-leak/TestFdLeak.py Sendingtest/lang/c/const_variables/TestConstVariables.py Transmitting file data .

[Lldb-commits] [lldb] r247591 - Fix up bad compiler spec on ConstVariableTestCase; fixup two more OS X unexpected successes.

Author: tfiala Date: Mon Sep 14 13:34:36 2015 New Revision: 247591 URL: http://llvm.org/viewvc/llvm-project?rev=247591&view=rev Log: Fix up bad compiler spec on ConstVariableTestCase; fixup two more OS X unexpected successes. Modified: lldb/trunk/test/expression_command/radar_9673664/TestExp

Re: [Lldb-commits] [PATCH] D12849: Add support for DW_OP_GNU_const_index to dwarf expression

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good. http://reviews.llvm.org/D12849 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/li

Re: [Lldb-commits] [PATCH] D12079: [MIPS] microMIPS breakpoints, disassembly and compressed addresses

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. So everywhere that we want to display a code address for MicroMIPS needs to now add code that creates a callable address? I still say that Address::Dump() is what should be modif

[Lldb-commits] [lldb] r247589 - Remove a debugging printf that got left in SymbolFileDWARFDebugMap.

Author: jingham Date: Mon Sep 14 13:28:28 2015 New Revision: 247589 URL: http://llvm.org/viewvc/llvm-project?rev=247589&view=rev Log: Remove a debugging printf that got left in SymbolFileDWARFDebugMap. Modified: lldb/trunk/source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDebugMap.cpp Modified:

Re: [Lldb-commits] [PATCH] D12658: Search variables based on clang::DeclContext and clang::Decl tree

paulherman updated this revision to Diff 34711. paulherman added a comment. Search variables based on clang::DeclContext and clang::Decl tree I think this fixes the comments. It also adds a cache for clang::decl so that there is no memory wasted. http://reviews.llvm.org/D12658 Files: includ

Re: [Lldb-commits] [lldb] r247576 - Cleaned up a few unexpected successes on OS X

Yep you're right, I just found this and verified it on Linux. I'll get that fixed ASAP. On Mon, Sep 14, 2015 at 11:17 AM, Ed Maste wrote: > On 14 September 2015 at 12:25, Todd Fiala via lldb-commits > wrote: > > > > Author: tfiala > > Date: Mon Sep 14 11:25:34 2015 > > New Revision: 247576 > >

Re: [Lldb-commits] [PATCH] D12809: Better scheme to lookup alternate mangled name when looking up function address.

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. So let me try to understand. When we are asked during expressions to lookup some mangled named for "std::string::length()", it doesn't exist in GCC binaries. So we want to then f

Re: [Lldb-commits] [lldb] r247576 - Cleaned up a few unexpected successes on OS X

On 14 September 2015 at 12:25, Todd Fiala via lldb-commits wrote: > > Author: tfiala > Date: Mon Sep 14 11:25:34 2015 > New Revision: 247576 > > URL: http://llvm.org/viewvc/llvm-project?rev=247576&view=rev > Log: > Cleaned up a few unexpected successes on OS X > ... > -@expectedFailureClang('1

Re: [Lldb-commits] [PATCH] D12804: Fix several issues around dwo symbol file handling

clayborg added a comment. I should clarify: mach-o files do have functions at zero and these are legal DWARF and we need to read this DWARF correctly. We might be able to ask the SymbolFile's ObjectFile about this address and if it can be a valid function address using: AddressClass ObjectFi

[Lldb-commits] [PATCH] D12849: Add support for DW_OP_GNU_const_index to dwarf expression

tberghammer created this revision. tberghammer added a reviewer: clayborg. tberghammer added a subscriber: lldb-commits. Add support for DW_OP_GNU_const_index to dwarf expression DW_OP_GNU_const_index is a new opcode used when split dwarf is enabled http://reviews.llvm.org/D12849 Files: inclu

Re: [Lldb-commits] [PATCH] D12804: Fix several issues around dwo symbol file handling

tberghammer added inline comments. Comment at: source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:2242-2248 @@ -2241,2 +2241,9 @@ lldb::addr_t highest_func_addr = func_ranges.GetMaxRangeEnd (0); + +// lowest_func_addr is a file address what can't be 0 because

Re: [Lldb-commits] [PATCH] D12804: Fix several issues around dwo symbol file handling

clayborg added a comment. I meant can't check for zero function start address in DWARFASTParserClang.cpp. http://reviews.llvm.org/D12804 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-co

Re: [Lldb-commits] [PATCH] D12804: Fix several issues around dwo symbol file handling

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. Just can't check for zero in SymbolFileDWARF, other than that it looks good. Comment at: source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:2242-2248 @@ -22

Re: [Lldb-commits] [PATCH] D12794: [MIPS] Add support for DT_MIPS_RLD_MAP_REL

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good. Repository: rL LLVM http://reviews.llvm.org/D12794 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm

Re: [Lldb-commits] [PATCH] D12659: Use SI_KERNEL on platforms defining it

sas closed this revision. sas added a comment. Committed as r247579. Repository: rL LLVM http://reviews.llvm.org/D12659 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r247579 - Use SI_KERNEL on platforms defining it

Author: sas Date: Mon Sep 14 11:51:58 2015 New Revision: 247579 URL: http://llvm.org/viewvc/llvm-project?rev=247579&view=rev Log: Use SI_KERNEL on platforms defining it Summary: Linux and FreeBSD occasionally send SI_KERNEL codes, nonexistent on other platforms. Problem caught on NetBSD. Revie

Re: [Lldb-commits] [PATCH] D12831: Add JUnit/XUnit-formatted output to the lldb test run system

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good. http://reviews.llvm.org/D12831 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/li

[Lldb-commits] [lldb] r247576 - Cleaned up a few unexpected successes on OS X

Author: tfiala Date: Mon Sep 14 11:25:34 2015 New Revision: 247576 URL: http://llvm.org/viewvc/llvm-project?rev=247576&view=rev Log: Cleaned up a few unexpected successes on OS X TestCallStdStringFunction TestCallWithTimeout TestConstVariables TestClassTypes Modified: lldb/trunk/test/expres

Re: [Lldb-commits] [PATCH] D12791: Complete register kind naming cleanups in lldb -- required touching all register table definitions

tberghammer added a comment. I tried out this change and it compiles both on Linux and on arm, but it causes 2 test failure: TestLldbGdbServer.LldbGdbServerTestCase.test_qRegisterInfo_returns_all_valid_results_llgs_dwarf TestLldbGdbServer.LldbGdbServerTestCase.test_qRegisterInfo_returns_one_valid

[Lldb-commits] [lldb] r247574 - Skip TestBatchMode for remote platforms

Author: labath Date: Mon Sep 14 11:11:11 2015 New Revision: 247574 URL: http://llvm.org/viewvc/llvm-project?rev=247574&view=rev Log: Skip TestBatchMode for remote platforms the test does not know how to run executables on the remote platform. Modified: lldb/trunk/test/driver/batch_mode/TestB

[Lldb-commits] [lldb] r247571 - Fix a possible SEGV in SymbolFileDWARF

Author: tberghammer Date: Mon Sep 14 10:44:29 2015 New Revision: 247571 URL: http://llvm.org/viewvc/llvm-project?rev=247571&view=rev Log: Fix a possible SEGV in SymbolFileDWARF The iterator pointing to an element of a dense map was used after the element from was removed from the map what isn't g

Re: [Lldb-commits] [PATCH] D12746: The pipe2(2) call is supported on NetBSD

This revision was automatically updated to reflect the committed changes. Closed by commit rL247568: The pipe2(2) call is supported on NetBSD (authored by emaste). Changed prior to commit: http://reviews.llvm.org/D12746?vs=34512&id=34674#toc Repository: rL LLVM http://reviews.llvm.org/D1274

[Lldb-commits] [lldb] r247568 - The pipe2(2) call is supported on NetBSD

Author: emaste Date: Mon Sep 14 10:12:49 2015 New Revision: 247568 URL: http://llvm.org/viewvc/llvm-project?rev=247568&view=rev Log: The pipe2(2) call is supported on NetBSD Patch by Kamil Rytarowski. Differential Revision: http://reviews.llvm.org/D12746 Modified: lldb/trunk/source/Host/po

[Lldb-commits] Missing enum OMPArraySection case in ClangASTContext::GetEncoding

On 29 June 2015 at 11:17, Ed Maste wrote: > On 24 June 2015 at 19:13, Enrico Granata wrote: >> Author: enrico >> Date: Wed Jun 24 18:13:23 2015 >> New Revision: 240606 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=240606&view=rev >> Log: >> Handle (or at least don't crash) trying to get the

[Lldb-commits] [lldb] r247567 - Removed XFAIL marker from passing tests, rdars 18684124, 15367233

Author: tfiala Date: Mon Sep 14 09:48:53 2015 New Revision: 247567 URL: http://llvm.org/viewvc/llvm-project?rev=247567&view=rev Log: Removed XFAIL marker from passing tests, rdars 18684124, 15367233 Related to these two test case classes: test/driver/batch_mode/TestBatchMode.py test/functionaliti

[Lldb-commits] [lldb] r247566 - Add expectedFlakeyFreeBSD to TestMultithreaded tests

Author: emaste Date: Mon Sep 14 09:42:22 2015 New Revision: 247566 URL: http://llvm.org/viewvc/llvm-project?rev=247566&view=rev Log: Add expectedFlakeyFreeBSD to TestMultithreaded tests One or more of these tests failed in 25 of 100 dotest.py runs. Modified: lldb/trunk/test/api/multithreaded

[Lldb-commits] [lldb] r247565 - Enable StopHookForMultipleThreadsTestCase::test_stop_hook_multiple_threads_with_dwarf on FreeBSD

Author: emaste Date: Mon Sep 14 09:41:58 2015 New Revision: 247565 URL: http://llvm.org/viewvc/llvm-project?rev=247565&view=rev Log: Enable StopHookForMultipleThreadsTestCase::test_stop_hook_multiple_threads_with_dwarf on FreeBSD This test passes locally but was disabled due to pexpect issues o

[Lldb-commits] [lldb] r247564 - Remove expectedFailureFreeBSD from passing test_inferior_asserting_disassemble

Author: emaste Date: Mon Sep 14 09:40:22 2015 New Revision: 247564 URL: http://llvm.org/viewvc/llvm-project?rev=247564&view=rev Log: Remove expectedFailureFreeBSD from passing test_inferior_asserting_disassemble llvm.org/pr18533 Modified: lldb/trunk/test/functionalities/inferior-assert/TestI

[Lldb-commits] [lldb] r247563 - Remove expectedFailureFreeBSD from passing test_with_dwarf_formatters_api

Author: emaste Date: Mon Sep 14 09:31:46 2015 New Revision: 247563 URL: http://llvm.org/viewvc/llvm-project?rev=247563&view=rev Log: Remove expectedFailureFreeBSD from passing test_with_dwarf_formatters_api llvm.org/pr24282 Modified: lldb/trunk/test/python_api/formatters/TestFormattersSBAPI.

[Lldb-commits] [lldb] r247562 - Remove expectedFailureFreeBSD from passing test_process_list

Author: emaste Date: Mon Sep 14 09:27:05 2015 New Revision: 247562 URL: http://llvm.org/viewvc/llvm-project?rev=247562&view=rev Log: Remove expectedFailureFreeBSD from passing test_process_list This test passes locally but was marked XFAIL due to failures on the FreeBSD buildbot. That buildbot ha

[Lldb-commits] [lldb] r247561 - Move RegisterContextPOSIX.h to FreeBSD subdir

Author: emaste Date: Mon Sep 14 09:20:56 2015 New Revision: 247561 URL: http://llvm.org/viewvc/llvm-project?rev=247561&view=rev Log: Move RegisterContextPOSIX.h to FreeBSD subdir It is now used only by the FreeBSD in-process ptrace implementation. Added: lldb/trunk/source/Plugins/Process/Fre

Re: [Lldb-commits] [PATCH] D12830: Limit scope of RegisterContextPOSIX.h header

This revision was automatically updated to reflect the committed changes. Closed by commit rL247558: Limit scope of RegisterContextPOSIX.h header (authored by emaste). Changed prior to commit: http://reviews.llvm.org/D12830?vs=34631&id=34666#toc Repository: rL LLVM http://reviews.llvm.org/D

[Lldb-commits] [lldb] r247558 - Limit scope of RegisterContextPOSIX.h header

Author: emaste Date: Mon Sep 14 08:16:59 2015 New Revision: 247558 URL: http://llvm.org/viewvc/llvm-project?rev=247558&view=rev Log: Limit scope of RegisterContextPOSIX.h header RegisterContextPOSIX.h is poorly named and contains only the declaration of POSIXBreakpointProtocol, which is used for

[Lldb-commits] [lldb] r247552 - Remove XTIMEOUT from TestChangeProcessGroup on linux

Author: labath Date: Mon Sep 14 07:31:47 2015 New Revision: 247552 URL: http://llvm.org/viewvc/llvm-project?rev=247552&view=rev Log: Remove XTIMEOUT from TestChangeProcessGroup on linux Modified: lldb/trunk/test/dosep.py Modified: lldb/trunk/test/dosep.py URL: http://llvm.org/viewvc/llvm-pr

Re: [Lldb-commits] [PATCH] D12659: Use SI_KERNEL on platforms defining it

krytarowski added a comment. Please commit it if it's OK. Repository: rL LLVM http://reviews.llvm.org/D12659 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D12746: The pipe2(2) call is supported on NetBSD

krytarowski added a comment. Please commit it if it's OK. Repository: rL LLVM http://reviews.llvm.org/D12746 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D12658: Search variables based on clang::DeclContext and clang::Decl tree

tberghammer added a subscriber: tberghammer. tberghammer added a comment. Generally looks good to me with a few minor comments, but please wait for a review from Greg or Jim. Comment at: source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:3201 @@ +3200,3 @@ +

Re: [Lldb-commits] [PATCH] D12795: Switch default disposition of realtime signals

This revision was automatically updated to reflect the committed changes. Closed by commit rL247537: Switch default disposition of realtime signals (authored by labath). Changed prior to commit: http://reviews.llvm.org/D12795?vs=34534&id=34661#toc Repository: rL LLVM http://reviews.llvm.org

[Lldb-commits] [lldb] r247537 - Switch default disposition of realtime signals

Author: labath Date: Mon Sep 14 04:05:43 2015 New Revision: 247537 URL: http://llvm.org/viewvc/llvm-project?rev=247537&view=rev Log: Switch default disposition of realtime signals Summary: Realtime signals generally do not represent an error condition in an application but are more like a regula