tberghammer added a subscriber: tberghammer.
tberghammer added a comment.
Generally looks good to me with a few minor comments, but please wait for a
review from Greg or Jim.
================
Comment at: source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:3201
@@ +3200,3 @@
+
+ if (attributes.ExtractFormValueAtIndex(i, form_value) && attr
== DW_AT_type)
+ return dwarf->ResolveTypeUID(DIERef(form_value).GetUID());
----------------
(nit): Please swap the order of the condition as ExtractFormValueAtIndex will
be slower then the comparision
================
Comment at: source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:3883-3884
@@ +3882,4 @@
+ {
+ dw_offset_t spec_uid = form_value.Reference();
+ if (UserIDMatches(spec_uid))
+ {
----------------
This check don't make sense here because dw_offset_t is 32bit and and
UserIDMatches expects a 64bit value ant checks the symbol file id against the
upper 32bit.
================
Comment at: test/lang/cpp/nsimport/TestCppNsImport.py:19
@@ -18,2 +18,3 @@
+ @expectedFailureAll
@dwarf_test
----------------
Please add a bug number, or at least a short comment about why this test is
XFAIL-ed
http://reviews.llvm.org/D12658
_______________________________________________
lldb-commits mailing list
[email protected]
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
