paulherman added a comment.

In http://reviews.llvm.org/D12658#245851, @clayborg wrote:

> So I don't like it in ParseVariableDIE() because it means we must create the 
> decl right away for the variable when parsing it. ParseVariableDIE is used to 
> parse all variables everywhere and we don't need the CompilerDecl in order to 
> display the Variable, so we don't need to create it right away. We can always 
> associate it in the Variable::GetDecl() call.


Okay, I understand that. In order to accomplish this, Variable should probably 
inherit from std::enable_shared_from_this so that we only have one SP to the 
variable. Is this acceptable?


http://reviews.llvm.org/D12658



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to