paulherman added a comment.

If I move the call to DeclLinkDeclToObject inside any of the GetDeclXXX 
methods, then there is no way to access the VariableSP needed for the call and 
it is probably harder to reconstruct the parameters needed for ParseVariableDIE 
starting from just the DIE itself.

Also, the call is already lazy since ParseVariableDIE is lazy (i.e. whenever 
the VariableSP is needed, the Decl is needed). I don't think there is any way 
to separate the call to DeclLinkDeclToObject from ParseVariableDIE, only to 
make sure that DeclLinkDeclToObject doesn't do any work if it is called with a 
previously encountered variable.


http://reviews.llvm.org/D12658



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to