clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.

So let me try to understand. When we are asked during expressions to lookup 
some mangled named for "std::string::length()", it doesn't exist in GCC 
binaries. So we want to then find any alternate manglings and we do this by 
asking the symbol file to find alternate manglings for "std::string::length"? 
I.E. we remove the parens and any arguments and lookup just the fully qualified 
function name?

If so, we should just lookup functions using:

  size_t
  Module::FindFunctions (const ConstString &name,
                 const CompilerDeclContext *parent_decl_ctx,
                 uint32_t name_type_mask, 
                 bool symbols_ok,
                 bool inlines_ok,
                 bool append, 
                 SymbolContextList& sc_list);

And then look at all of the symbol contexts in sc_list and find a function that 
we want? I don't really see the need for any of the new 
SymbolFile::GetMangledNamesForFunction() functions.


http://reviews.llvm.org/D12809



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to