Re: tqm5200s phy link toggles between up and down

2012-12-18 Thread Wolfgang Grandegger
On 12/18/2012 10:57 AM, Wolfgang Grandegger wrote: > On 12/18/2012 10:44 AM, Johannes Braun wrote: >> Hello, >> >> I hope someone could help me with my problem. Currently I am porting >> a new kernel (3.3.8) for a tqm5200s based board. > > This is not really

Re: tqm5200s phy link toggles between up and down

2012-12-18 Thread Wolfgang Grandegger
On 12/18/2012 10:44 AM, Johannes Braun wrote: > Hello, > > I hope someone could help me with my problem. Currently I am porting > a new kernel (3.3.8) for a tqm5200s based board. This is not really a new kernel. > The previous kernel was 2.6.23. The new kernel version is needed because > of supp

Re: [PATCH v13 0/6] flexcan: Add support for powerpc flexcan (freescale p1010)

2011-10-18 Thread Wolfgang Grandegger
Hi Kumar, On 10/18/2011 07:44 AM, Kumar Gala wrote: > > On Aug 16, 2011, at 10:32 PM, Robin Holt wrote: > >> David, >> >> The following set of patches have been reviewed by the above parties and >> all comments have been integrated. Although the patches stray from the >> drivers/net/can directo

[PATCH net-next] ibm/emac: fix improper cleanup when device is removed to allow re-bind

2011-11-17 Thread Wolfgang Grandegger
The re-binding (unbind..bind) of an EMAC device fails because the static variable "busy_phy_map" is not updated when the device is removed. Signed-off-by: Wolfgang Grandegger --- drivers/net/ethernet/ibm/emac/core.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) di

[PATCH net-next v2 3/4] can: cc770: add platform bus driver for the CC770 and AN82527

2011-11-25 Thread Wolfgang Grandegger
This driver works with both, static platform data and device tree bindings. It has been tested on a TQM855L board with two AN82527 CAN controllers on the local bus. CC: devicetree-disc...@lists.ozlabs.org CC: linuxppc-...@ozlabs.org CC: Kumar Gala Signed-off-by: Wolfgang Grandegger

[PATCH net-next v2 4/4] powerpc: tqm8548/tqm8xx: add and update CAN device nodes

2011-11-25 Thread Wolfgang Grandegger
This patch enables or updates support for the CC770 and AN82527 CAN controller on the TQM8548 and TQM8xx boards. CC: devicetree-disc...@lists.ozlabs.org CC: linuxppc-...@ozlabs.org CC: Kumar Gala Signed-off-by: Wolfgang Grandegger --- arch/powerpc/boot/dts/tqm8548-bigflash.dts | 19

[PATCH net-next v3 4/4] powerpc: tqm8548/tqm8xx: add and update CAN device nodes

2011-11-28 Thread Wolfgang Grandegger
This patch enables or updates support for the CC770 and AN82527 CAN controller on the TQM8548 and TQM8xx boards. CC: devicetree-disc...@lists.ozlabs.org CC: linuxppc-...@ozlabs.org CC: Kumar Gala Signed-off-by: Wolfgang Grandegger --- arch/powerpc/boot/dts/tqm8548-bigflash.dts | 19

[PATCH net-next v3 3/4] can: cc770: add platform bus driver for the CC770 and AN82527

2011-11-28 Thread Wolfgang Grandegger
This driver works with both, static platform data and device tree bindings. It has been tested on a TQM855L board with two AN82527 CAN controllers on the local bus. CC: devicetree-disc...@lists.ozlabs.org CC: linuxppc-...@ozlabs.org CC: Kumar Gala Signed-off-by: Wolfgang Grandegger

[PATCH net-next v4 4/4] powerpc: tqm8548/tqm8xx: add and update CAN device nodes

2011-11-29 Thread Wolfgang Grandegger
This patch enables or updates support for the CC770 and AN82527 CAN controller on the TQM8548 and TQM8xx boards. CC: devicetree-disc...@lists.ozlabs.org CC: linuxppc-...@ozlabs.org CC: Kumar Gala Signed-off-by: Wolfgang Grandegger --- arch/powerpc/boot/dts/tqm8548-bigflash.dts | 19

[PATCH net-next v4 3/4] can: cc770: add platform bus driver for the CC770 and AN82527

2011-11-29 Thread Wolfgang Grandegger
This driver works with both, static platform data and device tree bindings. It has been tested on a TQM855L board with two AN82527 CAN controllers on the local bus. CC: devicetree-disc...@lists.ozlabs.org CC: linuxppc-...@ozlabs.org CC: Kumar Gala Signed-off-by: Wolfgang Grandegger Acked-by

[PATCH net-next v5 4/4] powerpc: tqm8548/tqm8xx: add and update CAN device nodes

2011-11-30 Thread Wolfgang Grandegger
This patch enables or updates support for the CC770 and AN82527 CAN controller on the TQM8548 and TQM8xx boards. CC: devicetree-disc...@lists.ozlabs.org CC: linuxppc-...@ozlabs.org CC: Kumar Gala Signed-off-by: Wolfgang Grandegger --- arch/powerpc/boot/dts/tqm8548-bigflash.dts | 19

[PATCH net-next v5 3/4] can: cc770: add platform bus driver for the CC770 and AN82527

2011-11-30 Thread Wolfgang Grandegger
This driver works with both, static platform data and device tree bindings. It has been tested on a TQM855L board with two AN82527 CAN controllers on the local bus. CC: devicetree-disc...@lists.ozlabs.org CC: linuxppc-...@ozlabs.org CC: Kumar Gala Signed-off-by: Wolfgang Grandegger Acked-by

[PATCH net-next v5 4/4] powerpc: tqm8548/tqm8xx: add and update CAN device nodes

2011-11-30 Thread Wolfgang Grandegger
This patch enables or updates support for the CC770 and AN82527 CAN controller on the TQM8548 and TQM8xx boards. CC: devicetree-disc...@lists.ozlabs.org CC: linuxppc-...@ozlabs.org CC: Kumar Gala Signed-off-by: Wolfgang Grandegger --- arch/powerpc/boot/dts/tqm8548-bigflash.dts | 19

[PATCH net-next v5 3/4] can: cc770: add platform bus driver for the CC770 and AN82527

2011-11-30 Thread Wolfgang Grandegger
This driver works with both, static platform data and device tree bindings. It has been tested on a TQM855L board with two AN82527 CAN controllers on the local bus. CC: devicetree-disc...@lists.ozlabs.org CC: linuxppc-...@ozlabs.org CC: Kumar Gala Signed-off-by: Wolfgang Grandegger Acked-by

[PATCH net-next v6 4/4] powerpc: tqm8548/tqm8xx: add and update CAN device nodes

2011-12-01 Thread Wolfgang Grandegger
This patch enables or updates support for the CC770 and AN82527 CAN controller on the TQM8548 and TQM8xx boards. CC: devicetree-disc...@lists.ozlabs.org CC: linuxppc-...@ozlabs.org CC: Kumar Gala Signed-off-by: Wolfgang Grandegger --- arch/powerpc/boot/dts/tqm8548-bigflash.dts | 19

[PATCH net-next v6 3/4] can: cc770: add platform bus driver for the CC770 and AN82527

2011-12-01 Thread Wolfgang Grandegger
This driver works with both, static platform data and device tree bindings. It has been tested on a TQM855L board with two AN82527 CAN controllers on the local bus. CC: devicetree-disc...@lists.ozlabs.org CC: linuxppc-...@ozlabs.org CC: Kumar Gala Signed-off-by: Wolfgang Grandegger Acked-by

Re: [PATCH net-next v6 4/4] powerpc: tqm8548/tqm8xx: add and update CAN device nodes

2011-12-07 Thread Wolfgang Grandegger
On 12/07/2011 08:34 AM, Benjamin Herrenschmidt wrote: > On Thu, 2011-12-01 at 10:41 +0100, Wolfgang Grandegger wrote: >> This patch enables or updates support for the CC770 and AN82527 >> CAN controller on the TQM8548 and TQM8xx boards. > > I'm a bit confused by the n

OF modalias

2009-08-19 Thread Wolfgang Grandegger
Hello, I'm confused by the modalias'es created by OF devices, e.g.: # cat /sys/devices/f000.soc5200/ff00.spi/modalias of:NspiTCfsl,mpc5200b-spiCfsl,mpc5200-spi First of all, the string "" looks like an error. I could then dynamically load a driver module for the SPI using: # mo

Re: AW: LITE5200 configuration

2009-08-27 Thread Wolfgang Grandegger
new Lite5200B has *two* slots. IIRC, there are also early Lite5200B boards using MPC5200 v1.2 chips. Wolfgang (Grandegger) ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH] mpc5200: support for the MAN mpc5200 based board uc101

2009-09-14 Thread Wolfgang Grandegger
Hello Heiko, Heiko Schocher wrote: > Hello Grant, > > Grant Likely wrote: >> Thanks for the patch. Comments below. >> >> g. >> >> On Mon, Sep 14, 2009 at 2:05 AM, Heiko Schocher wrote: >>> - serial Console on PSC1 >>> - 64MB SDRAM >>> - MTD CFI Flash >>> - Ethernet FEC >>> - I2C with PCF8563 an

Re: [PATCH] i2c-mpc: Do not generate STOP after read.

2009-09-25 Thread Wolfgang Grandegger
he first read, but when the whole transaction ends. > > Signed-off-by: Joakim Tjernlund Tested-by: Wolfgang Grandegger on a MPC8548 board with an up-to-date kernel. I did not realize any problems. Wolfgang. ___ Linuxppc-dev mailing list Linux

Re: [PATCH v2] net/fec_mpc52xx: Fix kernel panic on FEC error

2009-10-14 Thread Wolfgang Grandegger
Grant Likely wrote: > From: John Bonesio > > The MDIO bus cannot be accessed at interrupt context, but on an FEC > error, the fec_mpc52xx driver reset function also tries to reset the > PHY. Since the error is detected at IRQ context, and the PHY functions > try to sleep, the kernel ends up pani

Re: [PATCH] net/can: add driver for mscan family & mpc52xx_mscan

2009-11-15 Thread Wolfgang Grandegger
David Miller wrote: > From: Wolfram Sang > Date: Fri, 13 Nov 2009 17:14:52 +0100 > >> Taken from socketcan-svn, fixed remaining todos, cleaned up, tested with a >> phyCORE-MPC5200B-IO and a custom board. >> >> Signed-off-by: Wolfram Sang > > Applied. Unfortunately too early. I will send my rev

Re: [PATCH] net/can: add driver for mscan family & mpc52xx_mscan

2009-11-16 Thread Wolfgang Grandegger
Grant Likely wrote: > On Fri, Nov 13, 2009 at 9:14 AM, Wolfram Sang wrote: >> Taken from socketcan-svn, fixed remaining todos, cleaned up, tested with a >> phyCORE-MPC5200B-IO and a custom board. >> >> Signed-off-by: Wolfram Sang >> Cc: Wolfgang Grandegger

Re: [PATCH] net/can: add driver for mscan family & mpc52xx_mscan

2009-11-16 Thread Wolfgang Grandegger
m Sang > Cc: Wolfgang Grandegger > Cc: Grant Likely > Cc: David Miller > --- > > This patch is based on net-next as of yesterday. > > To make the review easier for those who are already familiar with earlier > versions of this driver (especially for Wolfgang), I put

Re: [PATCH] net/can: add driver for mscan family & mpc52xx_mscan

2009-11-16 Thread Wolfgang Grandegger
Hi Wolfram, Wolfram Sang wrote: > Hi Wolfgang, > > On Mon, Nov 16, 2009 at 09:44:05AM +0100, Wolfgang Grandegger wrote: >> Hi Wolfram, >> >> thanks for pushing this driver to mainline. I think you should also add >> a CC to the Devicetree-discuss ML. > >

Re: updates to the mscan-driver in net-next

2009-11-17 Thread Wolfgang Grandegger
David Miller wrote: > From: Wolfram Sang > Date: Mon, 16 Nov 2009 23:57:43 +0100 > >> here are the patches which fix the issues for the mscan & mpc52xx_can drivers >> raised by Wolfgang Grandegger and Grant Likely. They are based on the initial >> version of th

Re: [PATCH] net/can: add driver for mscan family & mpc52xx_mscan

2009-11-17 Thread Wolfgang Grandegger
Wolfgang Grandegger wrote: > Wolfram Sang wrote: >> Hi Grant, >> >> Wolfgang commented on some points already, I will pick up the other remarks, >> just one question: >> >>>> + clk_src = of_get_property(np, "fsl,mscan-clk-src", NULL);

Re: [PATCH] net/can: add driver for mscan family & mpc52xx_mscan

2009-11-17 Thread Wolfgang Grandegger
Wolfram Sang wrote: > Hi Grant, > > Wolfgang commented on some points already, I will pick up the other remarks, > just one question: > >>> + clk_src = of_get_property(np, "fsl,mscan-clk-src", NULL); >>> + if (clk_src && strcmp(clk_src, "ip") == 0) >> Should protect against non-null.

[PATCH 0/3] PowerPC: MPC85xx: TQM85xx: dts and defconfig fixes

2009-03-16 Thread Wolfgang Grandegger
The following patch series fixes some issues with the DTS files of the TQM85xx modules and the defconfig for the TQM8548 modules. The patches are against the "next" branch of Kumar's "powerpc" GIT tree. Wolfgang. ___ Linuxppc-dev mailing list Linuxppc-d

[PATCH 1/3] PowerPC: MPC85xx: TQM85xx: correct address of LM75 I2C device nodes

2009-03-16 Thread Wolfgang Grandegger
Commit 0f73a449a649acfca91404a98a35353a618b9555 added I2C device nodes for the LM75 thermal sensor on the TQM85xx modules, unfortunately with the wrong I2C address. The LM75s are located at address 0x48. Signed-off-by: Wolfgang Grandegger --- arch/powerpc/boot/dts/tqm8540.dts |4

[PATCH 2/3] PowerPC: MPC85xx: TQM8548: use proper phy-handles for enet2 and enet3

2009-03-16 Thread Wolfgang Grandegger
For enet2 and enet3 the wrong phy-handles have been used in DTS files of the TQM8548 modules. Signed-off-by: Wolfgang Grandegger --- arch/powerpc/boot/dts/tqm8548-bigflash.dts |4 ++-- arch/powerpc/boot/dts/tqm8548.dts |4 ++-- 2 files changed, 4 insertions(+), 4 deletions

[PATCH 3/3] PowerPC: MPC85xx: TQM8548: update defconfig

2009-03-16 Thread Wolfgang Grandegger
Enable highmem support for the TQM8548-AG modules and NAND support for the TQM8548-BE modules. Furthermore disable USB, Wireless and IDE support because it's not available on the STK85xx starter kit. Signed-off-by: Wolfgang Grandegger --- arch/powerpc/configs/85xx/tqm8548_defconfig |

Re: [PATCH 4/4] powerpc/85xx: TQM8548: Update DTS file for multi-chip support

2009-03-18 Thread Wolfgang Grandegger
Anton Vorontsov wrote: > On Tue, Mar 17, 2009 at 10:12:22AM +0100, Wolfgang Grandegegr wrote: >> From: Wolfgang Grandegger >> >> This patch adds multi-chip support for the Micron MT29F8G08FAB NAND >> flash memory on the TQM8548 modules. >> >> This patch sho

Re: [PATCH 1/4] NAND: FSL-UPM: add multi chip support

2009-03-18 Thread Wolfgang Grandegger
Anton Vorontsov wrote: > On Tue, Mar 17, 2009 at 10:12:19AM +0100, Wolfgang Grandegegr wrote: >> From: Wolfgang Grandegger >> >> This patch adds support for multi-chip NAND devices to the FSL-UPM >> driver. This requires support for multiple GPIOs for the RNB pins. &g

[RFC] powerpc: i2c-mpc: make I2C bus speed configurable

2009-03-18 Thread Wolfgang Grandegger
The I2C driver for the MPC still uses a fixed clock divider hard-coded into the driver. This issue has already been discussed twice: http://www.mail-archive.com/linuxppc-dev@ozlabs.org/msg21933.html http://www.mail-archive.com/linuxppc-dev@ozlabs.org/msg26923.html Let's code speak ;-). The atta

[PATCH v2 0/5] NAND: Multi-chip support for FSL-UPM for TQM8548 modules

2009-03-19 Thread Wolfgang Grandegger
This is the 2nd version of the patch series adding generic support for multi-chip NAND devices to the FSL-UPM driver and support for the Micron MT29F8G08FAB NAND flash memory on the TQM8548 modules. It addresses the issues reported on the mailing list, e.g. the new bindings are now documented: [PA

[PATCH v2 5/5] powerpc/85xx: TQM8548: Update DTS file for multi-chip support

2009-03-19 Thread Wolfgang Grandegger
This patch adds multi-chip support for the Micron MT29F8G08FAB NAND flash memory on the TQM8548 modules. Signed-off-by: Wolfgang Grandegger --- arch/powerpc/boot/dts/tqm8548-bigflash.dts |7 ++- arch/powerpc/boot/dts/tqm8548.dts |7 ++- 2 files changed, 12 insertions

[PATCH v2 4/5] powerpc: NAND: FSL UPM: document new bindings

2009-03-19 Thread Wolfgang Grandegger
This patch adds documentation for the new NAND FSL UPM bindings for: NAND: FSL-UPM: add multi chip support NAND: FSL-UPM: Add wait flags to support board/chip specific delays NAND: FSL-UPM: add support for selecting chips via MAR Signed-off-by: Wolfgang Grandegger --- .../powerpc/dts

[PATCH v2 2/5] NAND: FSL-UPM: add support for selecting chips via MAR

2009-03-19 Thread Wolfgang Grandegger
For the NAND chips on the TQM8548 modules, a special chip-select logic is used. It uses dedicated address lines to be set via UPM machine address register (mar). This patch also adds that support to the FSL-UPM driver. Signed-off-by: Wolfgang Grandegger --- arch/powerpc/sysdev/fsl_lbc.c |2

[PATCH v2 1/5] NAND: FSL-UPM: add multi chip support

2009-03-19 Thread Wolfgang Grandegger
This patch adds support for multi-chip NAND devices to the FSL-UPM driver. This requires support for multiple GPIOs for the RNB pins. Signed-off-by: Wolfgang Grandegger --- drivers/mtd/nand/fsl_upm.c | 88 +-- 1 files changed, 67 insertions(+), 21

[PATCH v2 3/5] NAND: FSL-UPM: Add wait flags to support board/chip specific delays

2009-03-19 Thread Wolfgang Grandegger
delay points. To manage these extra delays in a more general way, I introduced the "wait-flags" property allowing the board-specific driver to specify various types of extra delay. Signed-off-by: Wolfgang Grandegger --- drivers/mtd/nand/fsl_upm.c | 20 ++-- 1 fi

Re: powerpc/85xx: Add support for the "socrates" board (MPC8544)

2009-03-20 Thread Wolfgang Grandegger
Grant Likely wrote: > I agree 100% with David's comments, and I have some additional ones below. OK. > On Thu, Mar 19, 2009 at 9:26 AM, Wolfgang Grandegger > wrote: >> + soc8...@e000 { >> + #address-cells = <1>; >

Re: powerpc/85xx: Add support for the "socrates" board (MPC8544)

2009-03-20 Thread Wolfgang Grandegger
David Gibson wrote: > On Thu, Mar 19, 2009 at 04:26:44PM +0100, Wolfgang Grandegger wrote: [snip] > [snip[ >> +disp...@2,0 { >> +compatible = "fujitsu,lime"; > > This compat string looks slightly worryingly non-specific. The node

Re: powerpc/85xx: Add support for the "socrates" board (MPC8544)

2009-03-20 Thread Wolfgang Grandegger
Hi Kumar, Kumar Gala wrote: > > On Mar 19, 2009, at 10:26 AM, Wolfgang Grandegger wrote: > >> +m...@24520 { >> +#address-cells = <1>; >> +#size-cells = <0>; >> +compatible = "fsl,

Re: powerpc/85xx: Add support for the "socrates" board (MPC8544)

2009-03-20 Thread Wolfgang Grandegger
David Gibson wrote: > On Thu, Mar 19, 2009 at 04:26:44PM +0100, Wolfgang Grandegger wrote: >> This patch adds support for the "socrates" board based on the MPC8544. >> Supported are Ethernet, serial console, I2C, I2C-based RTC and >> temperature sensors, NOR and NAN

Re: [PATCH v2 4/5] powerpc: NAND: FSL UPM: document new bindings

2009-03-24 Thread Wolfgang Grandegger
Scott Wood wrote: > On Thu, Mar 19, 2009 at 04:16:07PM +0100, Wolfgang Grandegger wrote: >> +Optional properties: >> +- fsl,upm-mar-offset : use the UPM machine address register to drive a >> + custom chip select logic using the specified >> +

[PATCH v3 0/4] NAND: Multi-chip support for FSL-UPM for TQM8548 modules

2009-03-25 Thread Wolfgang Grandegger
This is my third version of the patch series adding generic support for multi-chip NAND devices to the FSL-UPM driver and support for the Micron MT29F8G08FAB NAND flash memory on the TQM8548 modules. It addresses the issues reported on the mailing list, e.g. the new bindings are now documented as w

[PATCH v3 3/4] powerpc: NAND: FSL UPM: document new bindings

2009-03-25 Thread Wolfgang Grandegger
This patch adds documentation for the new NAND FSL UPM bindings for: NAND: FSL-UPM: add multi chip support NAND: FSL-UPM: Add wait flags to support board/chip specific delays Signed-off-by: Wolfgang Grandegger --- .../powerpc/dts-bindings/fsl/upm-nand.txt | 39

[PATCH v3 2/4] NAND: FSL-UPM: Add wait flags to support board/chip specific delays

2009-03-25 Thread Wolfgang Grandegger
delay points. To manage these extra delays in a more general way, I introduced the "wait-flags" property allowing the board-specific driver to specify various types of extra delay. Signed-off-by: Wolfgang Grandegger --- drivers/mtd/nand/fsl_upm.c | 20 ++-- 1 fi

[PATCH v3 4/4] powerpc/85xx: TQM8548: Update DTS file for multi-chip support

2009-03-25 Thread Wolfgang Grandegger
This patch adds multi-chip support for the Micron MT29F8G08FAB NAND flash memory on the TQM8548 modules. Signed-off-by: Wolfgang Grandegger --- arch/powerpc/boot/dts/tqm8548-bigflash.dts |6 +- arch/powerpc/boot/dts/tqm8548.dts |6 +- 2 files changed, 10 insertions

[PATCH v3 1/4] NAND: FSL-UPM: add multi chip support

2009-03-25 Thread Wolfgang Grandegger
This patch adds support for multi-chip NAND devices to the FSL-UPM driver. This requires support for multiple GPIOs for the RNB pins. The NAND chips are selected through address lines defined by the FDT property "chip-offset". Signed-off-by: Wolfgang Grandegger --- arch/powerpc/sysdev

Re: [PATCH v3 1/4] NAND: FSL-UPM: add multi chip support

2009-03-25 Thread Wolfgang Grandegger
Singh, Vimal wrote: >> +static void fun_select_chip(struct mtd_info *mtd, int chip_nr) >> +{ >> + struct nand_chip *chip = mtd->priv; >> + struct fsl_upm_nand *fun = to_fsl_upm_nand(mtd); >> + >> + if (chip_nr == -1) { >> + chip->cmd_ctrl(mtd, NAND_CMD_NONE, 0 | >>

Re: [PATCH v3 1/4] NAND: FSL-UPM: add multi chip support

2009-03-25 Thread Wolfgang Grandegger
Grant Likely wrote: > On Wed, Mar 25, 2009 at 7:31 AM, Grant Likely > wrote: >> On Wed, Mar 25, 2009 at 4:08 AM, Wolfgang Grandegger >> wrote: >>> This patch adds support for multi-chip NAND devices to the FSL-UPM >>> driver. This requires support for mult

Re: [PATCH v3 1/4] NAND: FSL-UPM: add multi chip support

2009-03-25 Thread Wolfgang Grandegger
Hi Anton, Anton Vorontsov wrote: > Hi Wolfgang, > > On Wed, Mar 25, 2009 at 11:08:18AM +0100, Wolfgang Grandegger wrote: >> This patch adds support for multi-chip NAND devices to the FSL-UPM >> driver. This requires support for multiple GPIOs for the RNB pins. >>

Re: [RFC] powerpc: i2c-mpc: make I2C bus speed configurable

2009-03-25 Thread Wolfgang Grandegger
Grant Likely wrote: > (cc'ing the devicetree-discuss mailing list) > > On Wed, Mar 18, 2009 at 1:56 PM, Wolfgang Grandegger > wrote: >> The I2C driver for the MPC still uses a fixed clock divider hard-coded >> into the driver. This issue has already been discussed

Re: [PATCH v3 3/4] powerpc: NAND: FSL UPM: document new bindings

2009-03-25 Thread Wolfgang Grandegger
Grant Likely wrote: > (cc'ing devicetree-discuss) > > On Wed, Mar 25, 2009 at 4:08 AM, Wolfgang Grandegger > wrote: >> This patch adds documentation for the new NAND FSL UPM bindings for: >> >> NAND: FSL-UPM: add multi chip support >> NAND: FSL-

Re: [PATCH v3 3/4] powerpc: NAND: FSL UPM: document new bindings

2009-03-26 Thread Wolfgang Grandegger
Grant Likely wrote: > On Wed, Mar 25, 2009 at 2:48 PM, Wolfgang Grandegger > wrote: >> Grant Likely wrote: >>> For the chip offset, it's not clear what the meaning is. First, does >>> the UPM controller support access of multiple chips simultaneously? >

Re: [PATCH v3 3/4] powerpc: NAND: FSL UPM: document new bindings

2009-03-26 Thread Wolfgang Grandegger
Grant Likely wrote: > On Thu, Mar 26, 2009 at 1:42 AM, Wolfgang Grandegger > wrote: >> Grant Likely wrote: >>> On Wed, Mar 25, 2009 at 2:48 PM, Wolfgang Grandegger >>> wrote: >>>> Grant Likely wrote: >>>>> For the chip offset, it&#x

Re: [PATCH v3 3/4] powerpc: NAND: FSL UPM: document new bindings

2009-03-26 Thread Wolfgang Grandegger
Grant Likely wrote: > On Thu, Mar 26, 2009 at 9:33 AM, Wolfgang Grandegger > wrote: >> Grant Likely wrote: >>> Does using the reg property give the driver enough information to >>> reliably program the MAR for NAND connections that use the address >>> li

Re: [PATCH v3 3/4] powerpc: NAND: FSL UPM: document new bindings

2009-03-26 Thread Wolfgang Grandegger
Anton Vorontsov wrote: > On Thu, Mar 26, 2009 at 11:02:06AM -0600, Grant Likely wrote: > [] Here is another thought. The binding is describing that address lines are used to activate CS lines. Offset for chip access purposes is derived from the address line, but it doesn't directly

Re: [PATCH v3 3/4] powerpc: NAND: FSL UPM: document new bindings

2009-03-27 Thread Wolfgang Grandegger
Grant Likely wrote: > On Thu, Mar 26, 2009 at 4:14 PM, Wolfgang Grandegger > wrote: >> Anton Vorontsov wrote: >>> On Thu, Mar 26, 2009 at 11:02:06AM -0600, Grant Likely wrote: >>>> In other words, this device is not register-level compatible with the >>&

[PATCH v4 0/4] NAND: Multi-chip support for FSL-UPM for TQM8548 modules

2009-03-30 Thread Wolfgang Grandegger
This is my forth version of the patch series adding generic support for multi-chip NAND devices to the FSL-UPM driver and support for the Micron MT29F8G08FAB NAND flash memory on the TQM8548 modules. It addresses the issues reported on the mailing list, e.g. the new bindings are now documented as w

[PATCH v4 2/4] NAND: FSL-UPM: Add wait flags to support board/chip specific delays

2009-03-30 Thread Wolfgang Grandegger
delay points. To manage these extra delays in a more general way, I introduced the "fsl,ump-wait-flags" property allowing the board- specific driver to specify various types of extra delay. Signed-off-by: Wolfgang Grandegger --- drivers/mtd/nand/fsl_upm.c | 20 ++-- 1 f

[PATCH v4 1/4] NAND: FSL-UPM: add multi chip support

2009-03-30 Thread Wolfgang Grandegger
This patch adds support for multi-chip NAND devices to the FSL-UPM driver. This requires support for multiple GPIOs for the RNB pins. The NAND chips are selected through address lines defined by the FDT property "fsl,upm-addr-line-cs-offsets". Signed-off-by: Wolfgang Grandegger --- ar

[PATCH v4 4/4] powerpc/85xx: TQM8548: Update DTS file for multi-chip support

2009-03-30 Thread Wolfgang Grandegger
This patch adds multi-chip support for the Micron MT29F8G08FAB NAND flash memory on the TQM8548 modules. Signed-off-by: Wolfgang Grandegger --- arch/powerpc/boot/dts/tqm8548-bigflash.dts |7 +-- arch/powerpc/boot/dts/tqm8548.dts |7 +-- 2 files changed, 10 insertions

[PATCH v4 3/4] powerpc: NAND: FSL UPM: document new bindings

2009-03-30 Thread Wolfgang Grandegger
This patch adds documentation for the new NAND FSL UPM bindings for: NAND: FSL-UPM: add multi chip support NAND: FSL-UPM: Add wait flags to support board/chip specific delays It also documents the old binding for "chip-delay". Signed-off-by: Wolfgang Grandegger --- Documentation/p

Inconsistent fsl_get_sys_freq() implementation

2009-03-31 Thread Wolfgang Grandegger
Hello, we realized an inconsistent implementation of fsl_get_sys_freq(): http://lxr.linux.no/linux+v2.6.29/arch/powerpc/sysdev/fsl_soc.c#L80 For 826x and 827x boards, the function is available but it cannot be used because the "bus-frequency" property is not defined for the SOC and U-Boot also d

Re: Inconsistent fsl_get_sys_freq() implementation

2009-03-31 Thread Wolfgang Grandegger
Grant Likely wrote: > On Tue, Mar 31, 2009 at 1:28 AM, Wolfgang Grandegger > wrote: >> Hello, >> >> we realized an inconsistent implementation of fsl_get_sys_freq(): >> >> http://lxr.linux.no/linux+v2.6.29/arch/powerpc/sysdev/fsl_soc.c#L80 >> &g

Re: powerpc/85xx: Add support for the "socrates" board (MPC8544)

2009-03-31 Thread Wolfgang Grandegger
Grant Likely wrote: > I agree 100% with David's comments, and I have some additional ones below. > > On Thu, Mar 19, 2009 at 9:26 AM, Wolfgang Grandegger > wrote: >> + soc8...@e000 { >> + #address-cells = <1>;

[PATCH 4/8] powerpc: i2c-mpc: preserve I2C clocking

2009-03-31 Thread Wolfgang Grandegger
The I2c node property "fsl,preserve-clocking" allows to overtake the clock settings from the boot loader and avoids the hard-coded setting. Signed-off-by: Wolfgang Grandegger --- drivers/i2c/busses/i2c-mpc.c | 24 1 file changed, 16 insertions(+), 8

[PATCH 6/8] --- arch/powerpc/boot/dts/socrates.dts | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-)

2009-03-31 Thread Wolfgang Grandegger
Index: linux-2.6/arch/powerpc/boot/dts/socrates.dts === --- linux-2.6.orig/arch/powerpc/boot/dts/socrates.dts 2009-03-31 13:24:38.078719288 +0200 +++ linux-2.6/arch/powerpc/boot/dts/socrates.dts2009-03-31 13:47:56.986720719

[PATCH 0/8] powerpc: i2c-mpc: make I2C bus speed configurable

2009-03-31 Thread Wolfgang Grandegger
Following (most of) Grant's suggestions to my RFC: http://ozlabs.org/pipermail/linuxppc-dev/2009-March/069820.html this new patch series now uses: - the I2c node property "fsl,preserve-clocking" to overtake the clock settings from the boot loader. The first patch provides this feature and ca

[PATCH 5/8] powerpc: i2c-mpc: make I2C bus speed configurable

2009-03-31 Thread Wolfgang Grandegger
the comptible CPU. It used arch-specific tables and functions to determine the proper Freqency Divider Register (fdr). Furthermore dev_dbg() and dev_info() are now used to profit from a more comprehensive output. Signed-off-by: Wolfgang Grandegger --- arch/powerpc/platforms/52xx/mpc52xx_c

[PATCH 2/8] [PATCH 01/28] RTC: Add support for RX8025 chip.

2009-03-31 Thread Wolfgang Grandegger
egree Signed-off-by: Wolfgang Grandegger Signed-off-by: Sergei Poselenov Signed-off-by: Yuri Tikhonov Signed-off-by: Dmitry Rakhchev Signed-off-by: Matthias Fuchs --- drivers/rtc/Kconfig |9 drivers/rtc/Makefile |1 drivers/rtc/rtc-rx8025.c | 891 +++

[PATCH 7/8] Re: [PATCH 1/2] NAND: Add support for oob size 128

2009-03-31 Thread Wolfgang Grandegger
* Wolfgang Grandegger | 2009-03-25 11:48:37 [+0100]: >Signed-off-by: Ilya Yanok >Acked-by: Wolfgang Grandegger You seem to forgot a few bits (subpage_sft & max page size). I had this patch in my tree like for ever and forgot post it here. I did however merge the mtd-utils bit

[PATCH 8/8] NAND: Add support for NAND on the Socrates board

2009-03-31 Thread Wolfgang Grandegger
Signed-off-by: Ilya Yanok Acked-by: Wolfgang Grandegger --- drivers/mtd/nand/Kconfig |6 drivers/mtd/nand/Makefile|1 drivers/mtd/nand/socrates_nand.c | 324 +++ 3 files changed, 331 insertions(+) Index: linux-2.6/drivers/mtd/nand

[PATCH 1/2] powerpc: i2c-mpc: preserve I2C clocking

2009-03-31 Thread Wolfgang Grandegger
The I2c node property "fsl,preserve-clocking" allows to overtake the clock settings from the boot loader and avoids the hard-coded setting. Signed-off-by: Wolfgang Grandegger --- drivers/i2c/busses/i2c-mpc.c | 24 1 file changed, 16 insertions(+), 8

[PATCH 0/2] test

2009-03-31 Thread Wolfgang Grandegger
test ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

[PATCH 2/2] powerpc: i2c-mpc: make I2C bus speed configurable

2009-03-31 Thread Wolfgang Grandegger
the comptible CPU. It used arch-specific tables and functions to determine the proper Freqency Divider Register (fdr). Furthermore dev_dbg() and dev_info() are now used to profit from a more comprehensive output. Signed-off-by: Wolfgang Grandegger --- arch/powerpc/platforms/52xx/mpc52xx_c

Re: [PATCH 0/8] powerpc: i2c-mpc: make I2C bus speed configurable

2009-03-31 Thread Wolfgang Grandegger
Please *FORGET* this series of patches. Only the I2C related patches are relevant but I accidentally sent out the complete patch stack :-(. I will resent them in a second. Sorry for any inconvenience this has caused. Wolfgang. Wolfgang Grandegger wrote: > Following (most of) Grant's sug

[PATCH 0/2] powerpc: i2c-mpc: make I2C bus speed configurable

2009-03-31 Thread Wolfgang Grandegger
Following (most of) Grant's suggestions to my RFC: http://ozlabs.org/pipermail/linuxppc-dev/2009-March/069820.html this new patch series now uses: - the I2c node property "fsl,preserve-clocking" to overtake the clock settings from the boot loader. The first patch provides this feature and ca

[PATCH 2/2] powerpc: i2c-mpc: make I2C bus speed configurable

2009-03-31 Thread Wolfgang Grandegger
the comptible CPU. It used arch-specific tables and functions to determine the proper Freqency Divider Register (fdr). Furthermore dev_dbg() and dev_info() are now used to profit from a more comprehensive output. Signed-off-by: Wolfgang Grandegger --- arch/powerpc/platforms/52xx/mpc52xx_c

Re: powerpc/85xx: Add support for the "socrates" board (MPC8544)

2009-03-31 Thread Wolfgang Grandegger
Grant Likely wrote: > On Tue, Mar 31, 2009 at 3:35 AM, Wolfgang Grandegger > wrote: >> Grant Likely wrote: >>> I agree 100% with David's comments, and I have some additional ones below. >>> >>> On Thu, Mar 19, 2009 at 9:26 AM, Wolfgang Grandegge

[PATCH 1/2] powerpc: i2c-mpc: preserve I2C clocking

2009-03-31 Thread Wolfgang Grandegger
The I2c node property "fsl,preserve-clocking" allows to overtake the clock settings from the boot loader and avoids the hard-coded setting. Signed-off-by: Wolfgang Grandegger --- drivers/i2c/busses/i2c-mpc.c | 24 1 file changed, 16 insertions(+), 8

Re: [PATCH 1/2] powerpc: i2c-mpc: preserve I2C clocking

2009-03-31 Thread Wolfgang Grandegger
Wolfram Sang wrote: > On Tue, Mar 31, 2009 at 02:50:29PM +0200, Wolfgang Grandegger wrote: >> The I2c node property "fsl,preserve-clocking" allows to overtake the >> clock settings from the boot loader and avoids the hard-coded setting. >> >> Signed-off-by: Wo

Re: [PATCH 3/8] powerpc/85xx: Add support for the "socrates" board (MPC8544).

2009-03-31 Thread Wolfgang Grandegger
Hi Grant, Grant Likely wrote: > On Tue, Mar 31, 2009 at 6:37 AM, Wolfgang Grandegger > wrote: >> Supported are Ethernet, serial console, I2C, I2C-based RTC and >> temperature sensors, NOR and NAND flash, PCI, USB, CAN and Lime >> display controller. >> >>

[PATCH v2] powerpc: i2c-mpc: preserve I2C clocking

2009-03-31 Thread Wolfgang Grandegger
The i2c node property "fsl,preserve-clocking" allows to overtake the clock settings from the boot loader avoiding the hard-coded settings. Signed-off-by: Wolfgang Grandegger --- Documentation/powerpc/dts-bindings/fsl/i2c.txt |2 ++ drivers/i2c/busses/i2c-mpc.c

Re: [PATCH 1/2] powerpc: i2c-mpc: preserve I2C clocking

2009-03-31 Thread Wolfgang Grandegger
Grant Likely wrote: > 2009/3/31 Wolfram Sang : > - > - mpc_i2c_setclock(i2c); > + > + if (set_clock) > + mpc_i2c_setclock(i2c); Can't we drop 'set_clock' with something like this here? + if (!of_get_property(op->node, "fsl,preserve-clocking", NULL)) {

Re: [PATCH 6/8] --- arch/powerpc/boot/dts/socrates.dts | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-)

2009-04-01 Thread Wolfgang Grandegger
Hi David, this patch went out by mistake, sorry. David Gibson wrote: > On Tue, Mar 31, 2009 at 02:37:33PM +0200, Wolfgang Grandegger wrote: >> Index: linux-2.6/arch/powerpc/boot/dts/socrates.dts >> === >> --

Re: powerpc/85xx: Add support for the "socrates" board (MPC8544)

2009-04-01 Thread Wolfgang Grandegger
Anton Vorontsov wrote: > On Tue, Mar 31, 2009 at 09:05:28AM -0600, Grant Likely wrote: > [...] >>> + soc8...@e000 { >>> + #address-cells = <1>; >>> + #size-cells = <1>; >>> + device_type = "soc"; >> Drop device_type here too. >

Re: [PATCH 1/2] powerpc: i2c-mpc: preserve I2C clocking

2009-04-01 Thread Wolfgang Grandegger
David Gibson wrote: > On Tue, Mar 31, 2009 at 02:43:39PM +0200, Wolfgang Grandegger wrote: >> The I2c node property "fsl,preserve-clocking" allows to overtake the >> clock settings from the boot loader and avoids the hard-coded setting. > > Hrm. This is dubious. T

Re: [PATCH 5/8] powerpc: i2c-mpc: make I2C bus speed configurable

2009-04-01 Thread Wolfgang Grandegger
Grant Likely wrote: > On Tue, Mar 31, 2009 at 6:37 AM, Wolfgang Grandegger > wrote: >> This patch makes the I2C bus speed configurable by using the I2C node >> property "clock-frequency". If the property is not defined, the old >> fixed clock settings will

Re: [PATCH 6/8] --- arch/powerpc/boot/dts/socrates.dts | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-)

2009-04-01 Thread Wolfgang Grandegger
David Gibson wrote: > On Wed, Apr 01, 2009 at 09:31:34AM +0200, Wolfgang Grandegger wrote: >> Hi David, >> >> this patch went out by mistake, sorry. >> >> David Gibson wrote: >>> On Tue, Mar 31, 2009 at 02:37:33PM +0200, Wolfgang Grandegger wrote: &

Re: powerpc/85xx: Add support for the "socrates" board (MPC8544)

2009-04-01 Thread Wolfgang Grandegger
Grant Likely wrote: > On Wed, Apr 1, 2009 at 1:36 AM, Wolfgang Grandegger > wrote: >> Anton Vorontsov wrote: >>> On Tue, Mar 31, 2009 at 09:05:28AM -0600, Grant Likely wrote: >>> [...] >>>>>>>>> + soc8...

[PATCH v2] powerpc: i2c-mpc: make I2C bus speed configurable

2009-04-01 Thread Wolfgang Grandegger
5xx, MPC86xx, MPC5200 and MPC5200B. The i2c->flags field and the corresponding FSL_I2C_DEV_* definitions have been removed as they are obsolete. Furthermore dev_dbg() and dev_info() are now used to profit from a more comprehensive output. Signed-off-by: Wolfgang Grandegger --- Documentation/po

Re: [PATCH 5/8] powerpc: i2c-mpc: make I2C bus speed configurable

2009-04-01 Thread Wolfgang Grandegger
Grant Likely wrote: > On Wed, Apr 1, 2009 at 1:51 AM, Wolfgang Grandegger > wrote: >> Grant Likely wrote: >>> The table definition is more verbose this way, but I think it results >>> in more understandable and easier to extend code. It also adds lets >>>

Re: [PATCH 5/8] powerpc: i2c-mpc: make I2C bus speed configurable

2009-04-01 Thread Wolfgang Grandegger
Wolfgang Grandegger wrote: > Grant Likely wrote: >> On Wed, Apr 1, 2009 at 1:51 AM, Wolfgang Grandegger >> wrote: >>> Grant Likely wrote: >>>> The table definition is more verbose this way, but I think it results >>>> in more understandable and ea

Re: [PATCH v2] powerpc: i2c-mpc: make I2C bus speed configurable

2009-04-01 Thread Wolfgang Grandegger
Grant Likely wrote: > On Wed, Apr 1, 2009 at 7:44 AM, Grant Likely > wrote: >> On Wed, Apr 1, 2009 at 7:13 AM, Wolfgang Grandegger >> wrote: >>> This patch makes the I2C bus speed configurable by using the I2C node >>> property "clock-frequency&

Re: powerpc/85xx: Add support for the "socrates" board (MPC8544)

2009-04-01 Thread Wolfgang Grandegger
Hi Kumar, Kumar Gala wrote: > > On Apr 1, 2009, at 8:10 AM, Wolfgang Grandegger wrote: > >> Grant Likely wrote: >>> On Wed, Apr 1, 2009 at 1:36 AM, Wolfgang Grandegger >>> wrote: >>>> Anton Vorontsov wrote: >>>>>

  1   2   3   4   >