Wolfgang Grandegger wrote: > Wolfram Sang wrote: >> Hi Grant, >> >> Wolfgang commented on some points already, I will pick up the other remarks, >> just one question: >> >>>> + clk_src = of_get_property(np, "fsl,mscan-clk-src", NULL); >>>> + if (clk_src && strcmp(clk_src, "ip") == 0) >>> Should protect against non-null. strncmp() maybe? >> "ip" is null-terminated, or what do you mean? > > Imagine somebody defines: > > fsl,mscan-clk-src = <0xbaeee>;
Forget my comment. I will not harm in the above case. I was just worried about non-null-teminated strings. Wolfgang. _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
