Hi David, this patch went out by mistake, sorry.
David Gibson wrote: > On Tue, Mar 31, 2009 at 02:37:33PM +0200, Wolfgang Grandegger wrote: >> Index: linux-2.6/arch/powerpc/boot/dts/socrates.dts >> =================================================================== >> --- linux-2.6.orig/arch/powerpc/boot/dts/socrates.dts 2009-03-31 >> 13:24:38.078719288 +0200 >> +++ linux-2.6/arch/powerpc/boot/dts/socrates.dts 2009-03-31 >> 13:47:56.986720719 +0200 >> @@ -52,6 +52,7 @@ >> soc8...@e0000000 { >> #address-cells = <1>; >> #size-cells = <1>; >> + device_type = "soc"; > > You should not be adding device_type to a new board's dts. You > *especially* shouldn't be doing that with no patch comment explaining > why. In the final patch I have removed the device_type = "soc", but it makes trouble as some mpc85xx rely on it. Removing it would also break U-Boot compatibility. Is it worth that? The issue is discussed on the thread http://ozlabs.org/pipermail/linuxppc-dev/2009-April/070020.html. Wolfgang. _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev