David Gibson wrote:
> On Thu, Mar 19, 2009 at 04:26:44PM +0100, Wolfgang Grandegger wrote:
>> This patch adds support for the "socrates" board based on the MPC8544.
>> Supported are Ethernet, serial console, I2C, I2C-based RTC and
>> temperature sensors, NOR and NAND flash, PCI, USB, CAN and Lime
>> display controller.
>>
>> The multiplexing of FPGA interrupts onto PowerPC interrupt lines is
>> supported through our own fpga_pic interrupt controller driver.
>>
>> For example the SJA1000 controller is level low sensitive connected to
>> fpga_pic line 2 and is routed to the second (of three) irq lines to
>> the CPU:
>
> A few minor device tree nits.
>
>> + soc8...@e0000000 {
>> + #address-cells = <1>;
>> + #size-cells = <1>;
>> + device_type = "soc";
>> +
>> + ranges = <0x00000000 0xe0000000 0x00100000>;
>> + reg = <0xe0000000 0x00001000>; // CCSRBAR 1M
>> + bus-frequency = <0>; // Filled in by U-Boot
>> + compatible = "fsl,socrates-immr", "simple-bus";
>
> This should probably refer to 8544 instead of socrates. Unless you
> really do have a board-specific version of the SoC...
OK, that should then be:
+ compatible = "fsl,mpc8544-immr", "simple-bus";
It should always be with the prefix "mpc", I guess. But some of the
following compatible names are without that prefix:
$ grep -h '\-l2-cache-controller' *
compatible = "fsl,8540-l2-cache-controller";
compatible = "fsl,mpc8536-l2-cache-controller";
compatible = "fsl,8540-l2-cache-controller";
compatible = "fsl,8541-l2-cache-controller";
compatible = "fsl,8544-l2-cache-controller";
compatible = "fsl,8548-l2-cache-controller";
compatible = "fsl,8555-l2-cache-controller";
compatible = "fsl,8540-l2-cache-controller";
compatible = "fsl,8568-l2-cache-controller";
compatible = "fsl,mpc8572-l2-cache-controller";
compatible = "fsl,mpc8572-l2-cache-controller";
compatible = "fsl,mpc8572-l2-cache-controller";
compatible = "fsl,8548-l2-cache-controller";
compatible = "fsl,8560-l2-cache-controller";
compatible = "fsl,mpc8544-l2-cache-controller";
compatible = "fsl,mpc8544-l2-cache-controller";
compatible = "fsl,8540-l2-cache-controller";
compatible = "fsl,8540-l2-cache-controller";
compatible = "fsl,8540-l2-cache-controller";
compatible = "fsl,mpc8548-l2-cache-controller";
compatible = "fsl,mpc8548-l2-cache-controller";
compatible = "fsl,8540-l2-cache-controller";
compatible = "fsl,8540-l2-cache-controller";
That's confusing.
Wolfgang.
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
