> }
>
> - for (np = NULL;
> - (np = of_find_compatible_node(np, "usb", "fsl-usb2-dr")) != NULL;
> - i++) {
> + for_each_compatible_node(np, NULL, "fsl-usb2-dr") {
Same here.
--
s well). Sorry
about not mentioning this last time and it is a trivial change that
should not stop this stuff going in.
> +static int __init sbc8560_probe(void)
> +{
> +unsigned long root = of_get_flat_dt_root();
> +
> +return of_flat_dt_is_compatible(root, "SBC
> old include file references that managed to
> creep in recently.
>
> These are the last few in arch/powerpc directly.
> If you could pick this up for .25, that be good!
Thanks for doing this.
--
Cheers,
Stephen Rothwell[EMAIL PROTECTED]
http://www.canb.auug
tch_node(
> - const struct of_device_id *matches, const struct device_node *node);
> extern const struct of_device_id *of_match_device(
> const struct of_device_id *matches, const struct of_device *dev);
So you should really change all the callers of of_match_node to include
l
, the SSI device driver won't get probed. */
> + of_platform_bus_probe(NULL, mpc8610_ids, NULL);
> +
> + return 0;
> +}
> +device_initcall(mpc8610_declare_of_platform_devices);
We have machine_device_initcall for this now.
--
Cheers,
Stephen Rothwell
id gpt_ids[] = {
> + const static struct of_device_id gpt_ids[] = {
Again __initdata?
> + const static struct of_device_id cdm_ids[] = {
And again?
--
Cheers,
Stephen Rothwell[EMAIL PROTECTED]
http://www.canb.auug.org.au/~sfr/
pgpWOaDsQRdDt.pgp
Description:
;& (prop->length == 32)) {
> + const u32 *iprop = prop->value;
> +
> + for (i = 0; i < ARRAY_SIZE(qe_firmware_info.vtraps); i++)
> + qe_firmware_info.vtraps[i] = iprop[i];
> + }
And similarly?
--
Cheers,
Stephen Rothwell[EMAIL P
_pfn = start_pfn + nr_pages;
> +
> + for (i=start_pfn; i <= end_pfn; i++) {
spaces around '='
> +static int __init phyp_dump_setup(void)
> +{
> +}
> +
> +subsys_initcall(phyp_dump_setup);
Normally we don't leave a blank line here.
some bisecting autobuilder tries to configure it.
--
Cheers,
Stephen Rothwell[EMAIL PROTECTED]
http://www.canb.auug.org.au/~sfr/
pgpY5DXld7bCF.pgp
Description: PGP signature
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
gt; + if (dump_header == NULL) {
> + release_all();
> + return 0;
> + }
--
Cheers,
Stephen Rothwell[EMAIL PROTECTED]
http://www.canb.auug.org.au/~sfr/
pgpOilA6GewxA.pgp
Description: PGP signature
___
Linuxppc-dev
_start - phyp_dump_info->init_reserve_start;
> +
> if (dump_header == NULL) {
> - release_all();
> - return 0;
> + register_dump_area (&phdr, dump_area_start);
Ditto.
--
Cheers,
Stephen Rothwell[EMAIL PROTECTED]
http://www.canb.a
Hi Manish,
Just a trivial comment.
On Mon, 07 Jan 2008 18:35:09 -0600 Manish Ahuja <[EMAIL PROTECTED]> wrote:
>
> + printk(KERN_INFO "dump disk section = %d\n",ph->dump_disk_section);
Please put a space after the ','. Here and later.
--
Cheers,
Stephen
phyp_dump_info->init_reserve_start, second_addr_range);
This indentation should be (probably) two tabs.
> + /* re-register the dump area, if old dump was invalid */
> + if ((dump_header) && (dump_header->status & DUMP_ERROR_FLAG)) {
^ ^
E
rq != NO_IRQ){
> + iic_interrupt_mode(dev, 0);
> + free_irq(dev->irq, dev);
> + }
> + iounmap(dev->vaddr);
> + kfree(dev);
Should these last two be after the below brace?
> + }
> +
> +
On Tue, 08 Jan 2008 00:56:27 -0500 Sean MacLennan <[EMAIL PROTECTED]> wrote:
>
> Stephen Rothwell wrote:
> >
> > On Mon, 07 Jan 2008 21:03:12 -0500 Sean MacLennan <[EMAIL PROTECTED]> wrote:
> >
> > Please don't post patches as attachments.
>
&
ariants straight into the
> include/linux/ version of the file or not. Seems there will
> come a point when the sparc and powerpc variants will need
> to be more unified...
Some more unification should be possible over time, but that is much
harder.
--
Cheers,
Stephen Roth
; +
> + mm_gc->of_gc.gc.base = ret;
> +
> + np->data = &mm_gc->of_gc;
> +
> + ret = gpiochip_add(&mm_gc->of_gc.gc);
> + if (ret)
> + goto err2;
> +
> + of_node_get(np);
Why do you this of_node_get(np) when you do not keep
Hi Stephen,
On Tue, 8 Jan 2008 11:35:06 -0800 Stephen Neuendorffer <[EMAIL PROTECTED]>
wrote:
>
> +static struct of_device_id xilinx_of_bus_ids[] = {
Should be __initdata.
--
Cheers,
Stephen Rothwell[EMAIL PROTECTED]
http://www.canb.auug.org.au/~sfr/
pgpvn
> + */
> + ipic_set_default_priority();
> +}
This needs an of_node_put(np) somewhere.
--
Cheers,
Stephen Rothwell[EMAIL PROTECTED]
http://www.canb.auug.org.au/~sfr/
pgptvghvAhukg.pgp
Description: PGP signature
__
512x_uart_of_probe,
> + .remove = mpc512x_uart_of_remove,
> +#ifdef CONFIG_PM
> + .suspend = mpc512x_uart_of_suspend,
> + .resume = mpc512x_uart_of_resume,
> +#endif
> + .driver = {
> +.name = "mpc52xx-psc-uart",
> +},
> +};
-
0);
> + mpic_assign_isu(mpic, 3, paddr + 0x10260);
> + mpic_assign_isu(mpic, 4, paddr + 0x10280);
> + mpic_assign_isu(mpic, 5, paddr + 0x11120);
> + mpic_assign_isu(mpic, 6, paddr + 0x11140);
> +
> + mpic_init(mpic);
> +}
The above needs a of_
On Wed, 9 Jan 2008 14:16:49 +1100 Stephen Rothwell <[EMAIL PROTECTED]> wrote:
>
> On Tue, 8 Jan 2008 09:01:33 -0700 John Rigby <[EMAIL PROTECTED]> wrote:
> >
> > +++ b/drivers/serial/mpc512x_uart.c
> >
> > +#include
>
> Purely to avoid
ather than respin
> the sbc8560 patches again and leave the mpc8560mds behind.
> Assuming everyone else is OK with this approach.
Fine by me.
--
Cheers,
Stephen Rothwell[EMAIL PROTECTED]
http://www.canb.auug.org.au/~sfr/
pgp3xKJPpicGU.p
devices(void);
We don't mark things __init in header files. It is unnecessary and can
get out of sync - which causes unexpected results.
> +/* mpc52xx_pci.c */
> #ifdef CONFIG_PCI
> extern int __init mpc52xx_add_bridge(struct device_node *node);
> extern void __init mpc52xx_s
t ps3_repository_read_pu_id(unsigned int pu_index, u64 *pu_id)
> +{
> + int result;
> + u64 v1;
> +
> + v1 = 0;
> + result = read_node(PS3_LPAR_ID_CURRENT,
> + make_first_field("bi", 0),
> + make_field("pu", pu_ind
itcall(sbc834x_declare_of_platform_devices);
machine_device_initcall(sbc834x, ...
--
Cheers,
Stephen Rothwell[EMAIL PROTECTED]
http://www.canb.auug.org.au/~sfr/
pgpqtBsvlrjSc.pgp
Description: PGP signature
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
On Wed, 9 Jan 2008 11:01:38 +0100 (CET) Geert Uytterhoeven <[EMAIL PROTECTED]>
wrote:
>
> On Wed, 9 Jan 2008, Stephen Rothwell wrote:
> > On Tue, 08 Jan 2008 22:35:36 -0800 Geoff Levand <[EMAIL PROTECTED]> wrote:
> > >
> > > +int ps3_r
Hi Anton,
Juts one small trivial comment (could be fixed later).
On Wed, 9 Jan 2008 22:10:41 +0300 Anton Vorontsov <[EMAIL PROTECTED]> wrote:
>
> +static struct of_device_id pata_of_platform_match[] = {
This could be declared const.
--
Cheers,
Stephen Rothwell
On Wed, 9 Jan 2008 18:36:34 -0600 Olof Johansson <[EMAIL PROTECTED]> wrote:
>
> On Thu, Jan 10, 2008 at 10:40:48AM +1100, Stephen Rothwell wrote:
> > Hi Anton,
> >
> > Juts one small trivial comment (could be fixed later).
> >
> > On Wed, 9 Jan 2
ns if we find no node?
> + mpc52xx_cdm = of_iomap(np, 0);
> + of_node_put(np);
> }
--
Cheers,
Stephen Rothwell[EMAIL PROTECTED]
http://www.canb.auug.org.au/~sfr/
pgpeZoPnntxuz.pgp
Description: PGP signature
___
On Thu, 10 Jan 2008 08:01:09 -0700 "Grant Likely" <[EMAIL PROTECTED]> wrote:
>
> On 1/10/08, Stephen Rothwell <[EMAIL PROTECTED]> wrote:
> > Hi Grant,
> >
> > On Wed, 09 Jan 2008 22:26:30 -0700 Grant Likely <[EMAIL PROTECTED]>
become __initdata as well.
> + char *plat_name;
> +} of_rtc_table[] = {
> + { "ds1743-nvram", "rtc-ds1742" },
> +};
> + platform_device_register_simple(plat_name, -1, res, 1);
Do we care if this fails?
--
Cheers,
St
he entire
> + * fpga space, which is over 8k.
> + */
> + if(of_address_to_resource(np, 0, &res) ||
> +(fpga = ioremap(res.start, 0x24)) == NULL) {
and again
> + printk(KERN_ERR __FILE__ ": Unable to map FPGA\n");
> +
Hi Sean,
On Fri, 11 Jan 2008 02:10:45 -0500 Sean MacLennan <[EMAIL PROTECTED]> wrote:
>
> Stephen Rothwell wrote:
> > On Wed, 09 Jan 2008 15:19:13 -0500 Sean MacLennan <[EMAIL PROTECTED]> wrote:
> >
> >> No comments? I really thought I would get
tern in the C file, but that
can be dealt with later.
--
Cheers,
Stephen Rothwell[EMAIL PROTECTED]
http://www.canb.auug.org.au/~sfr/
pgpA2gsQG0Vh2.pgp
Description: PGP signature
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
> + struct i2c_device_id *id_table;
Any reason that this is not const? Making it const would allow divers to
make their tables const.
These are just small things (apart from the wrapping) that can be fixed
up with followup patches.
--
Cheers,
Stephen Rothwell[EM
devices(&i2c->adap, op->node);
> +
> + return result;
> +
> +fail_add:
dev_set_dvdata(&op->dev, NULL);
> + free_irq(i2c->irq, i2c);
> +fail_request:
> + irq_dispose_mapping(i2c->irq);
> +fail_irq:
> + iounmap(i2c->base);
>
+ }
> +
> + /* We do not call of_iomap here since it would map in the entire
> + * fpga space, which is over 8k.
> + */
> + if (of_address_to_resource(np, 0, &res)) {
of_node_put(np);
> + printk(KERN_ERR __FILE__ ":
> +
> + of_platform_bus_probe(NULL, of_bus_ids, NULL);
> + of_register_platform_driver(&ep8248e_mdio_driver);
> +
> + return 0;
> +}
> +device_initcall(declare_of_platform_devices);
machine_device_initcall(ep8248, declare_of_platform_devices);
Then remove the mac
tname = of_get_property(pp, "label", &len);
> + if (!partname)
> + partname = of_get_property(pp, "name", &len);
> + (*pparts)[i].name = (char *)partname;
> +
> + if (of_get_property(pp, "read-only&qu
lbc_match[] = {
const, please.
> +static struct of_platform_driver fsl_elbc_ctrl_driver = {
.driver = {
> + .name = "fsl-elbc",
},
> + .match_table = fsl_elbc_match,
> + .probe = fsl_elbc_ctrl_probe,
> + .remove = __devexit_p(fsl_elbc_c
gt; + partname = of_get_property(pp, "label", &len);
> + if (!partname)
> + partname = of_get_property(pp, "name", &len);
> + (*pparts)[i].name = (char *)partname;
> +
> +
c struct of_device_id fsl_elbc_match[] = {
const, please.
> +static struct of_platform_driver fsl_elbc_ctrl_driver = {
.driver = {
> + .name = "fsl-elbc",
},
> + .match_table = fsl_elbc_match,
> + .probe = fsl_elbc_ctrl_probe,
> + .remov
Signed-off-by: Stephen Rothwell <[EMAIL PROTECTED]>
---
arch/powerpc/kernel/ibmebus.c |7 ++-
1 files changed, 2 insertions(+), 5 deletions(-)
diff --git a/arch/powerpc/kernel/ibmebus.c b/arch/powerpc/kernel/ibmebus.c
index 1844359..2a6a388 100644
--- a/arch/powerpc/kernel/ibm
ty's value
if name is non-NULL, *name points to ...
> + * if lenp is non-NULL, *lenp contains the length of the property
> + * value (>=0)
--
Cheers,
Stephen Rothwell[EMAIL PROTECTED]
http://www.canb.auug.org.au/~sfr/
pgpFVOLH
On Mon, 14 Jan 2008 16:44:33 -0600 Scott Wood <[EMAIL PROTECTED]> wrote:
>
> Stephen Rothwell wrote:
> >> +++ b/libfdt/libfdt.h
> >
> >> +#define FDT_ERR_BADDEPTH 8
> >
> > Wouldn't it have been less intrusive to just use the next error numb
Hi Mark,
On Mon, 14 Jan 2008 15:51:50 -0700 "Mark A. Greer" <[EMAIL PROTECTED]> wrote:
>
> +++ b/arch/powerpc/sysdev/mv64x60.h
> @@ -3,10 +3,32 @@
>
> #include
>
> +#include
You probably meant to include linux/of.h here
--
Cheers,
Stephen Rothwel
+ hose = pci_find_hose_for_OF_device(phb);
> + of_node_put(phb);
> + return hose;
> + }
> + }
> +
> + return NULL;
> +}
I would think that this is way to big to inline ...
--
Cheers,
Stephen Rot
_init();
> +#endif
Maybe there should be a stub of mv64x60_pci_init for the non PCI case -
that would save the ifdefs in C code.
> + np = of_find_compatible_node(NULL, NULL, "katana750i,cpld");
> + reg = of_get_property(np, "reg", NULL);
What if np == NULL?
#x27;emac_probe' and 'zmii_probe')
> WARNING: vmlinux.o(.init.text+0x16bb4): Section mismatch: reference to
> .exit.text:mal_unregister_commac (between 'emac_probe' and 'zmii_probe')
These will be similar but function calls.
> Any hints as
On Mon, 14 Jan 2008 23:45:17 -0500 Sean MacLennan <[EMAIL PROTECTED]> wrote:
>
> Stephen Rothwell wrote:
> > On Mon, 14 Jan 2008 23:15:41 -0500 Sean MacLennan <[EMAIL PROTECTED]> wrote:
> >
> >> I keep getting these link(?) warnings:
> >>
> >
at each use conflict. So just make it __initdata.
> +static __initdata const struct of_device_id __initdata of_bus_ids[] = {
Same here.
--
Cheers,
Stephen Rothwell[EMAIL PROTECTED]
http://www.canb.auug.org.au/~sfr/
pgpJvyX9VwcW0.pgp
Des
__initdata const struct of_device_id of_bus_ids[] = {
Here as well.
--
Cheers,
Stephen Rothwell[EMAIL PROTECTED]
http://www.canb.auug.org.au/~sfr/
pgp21hBoyeTYM.pgp
Description: PGP signature
___
Linuxppc-dev mailing list
Linuxp
On Tue, 15 Jan 2008 17:43:06 -0600 Scott Wood <[EMAIL PROTECTED]> wrote:
>
> Stephen Rothwell wrote:
> >> + nr_parts = 0;
> >> + for (pp = node->child; pp; pp = pp->sibling)
> >
> > for_each_child_of_node(node, pp)
>
> "for_each_ch
On Wed, 16 Jan 2008 11:09:24 +1100 Paul Mackerras <[EMAIL PROTECTED]> wrote:
>
> Grant Likely writes:
>
> > Any comments/concerns on this patch?
>
> I'm about to throw it into my tree.
Fine by me.
--
Cheers,
Stephen Rothwell[EMAIL PROTEC
LL, "fsl,ipic");
> + if (!np)
> + return;
> +
> + ipic_init(np, 0);
You need an op_node_put(np) here. ipic_init will do another of_node_get()
if it keeps a reference to np.
--
Cheers,
Stephen Rothwell[EMAIL PROTECTED]
http://www.canb.
cpld_base = ioremap(paddr, reg[1]);
> + }
> + }
You need an of_node_put(np) for the !reg case above. Maybe you should
just put it after the else clause instead of in it.
--
Cheers,
Stephen Rothwell[EMAIL PROTECTED]
http://www.canb.auug
On Wed, 16 Jan 2008 18:29:45 -0500 Sean MacLennan <[EMAIL PROTECTED]> wrote:
>
> Everybody happy with this patch?
I am happy (about this patch at least :-))
--
Cheers,
Stephen Rothwell[EMAIL PROTECTED]
http://www.canb.auug.org.au/~sfr/
pgpb2vylEkYSL.pgp
Desc
hen you shouldn't need the __KERNEL__ protectors.
But it is, indeed, 2008. :-)
--
Cheers,
Stephen Rothwell[EMAIL PROTECTED]
http://www.canb.auug.org.au/~sfr/
pgpT1IX7ZuiUv.pgp
Description: PGP signature
___
Linuxppc-dev
*
> + * setjmp/longjmp and xmon_save_regs code by Paul Mackerras.
^^
This doesn't exist here.
--
Cheers,
Stephen Rothwell[EMAIL PROTECTED]
http://www.canb.auug.org.au/~sfr/
pgpymGEdfn7M
ot/Makefile |2 +-
> arch/powerpc/boot/cpm-serial.c |6
> arch/powerpc/boot/cuboot-8xx.c |1 +
> arch/powerpc/boot/ops.h|2 +
> arch/powerpc/boot/watchdog.c | 65
>
I am just wondering if maybe that file n
How about "[POWERPC] make ibmebus use of_(un)register_driver"
(http://patchwork.ozlabs.org/linuxppc/patch?id=16128)? It was acked by
Joachim.
--
Cheers,
Stephen Rothwell[EMAIL PROTECTED]
http://www.canb.auug.org.au/~sfr/
pgpjwxUAFOBBV.pgp
Description: PGP
Signed-off-by: Stephen Rothwell <[EMAIL PROTECTED]>
---
arch/powerpc/kernel/systbl_chk.c |2 +-
arch/powerpc/kernel/systbl_chk.sh |2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
Patchwork strikes again. :-(
diff --git a/arch/powerpc/kernel/systbl_chk.c b/arch/powerpc/
;No label property provided for LED %s\n",
> + op->node->full_name);
> + err = -EINVAL;
> + goto err_free;
goto err;
> +static struct of_device_id mpled_match[] = {
Make this const, please.
--
Cheers,
Stephen Rothwell
+ b/arch/powerpc/platforms/52xx/lite5200_pm.c
> @@ -43,6 +43,12 @@ static int lite5200_pm_set_target(suspend_state_t state)
> static int lite5200_pm_prepare(void)
> {
> struct device_node *np;
> + struct of_device_id immr_ids[] = {
This should be static and cons
Hi Scott,
Just one small thing.
On Thu, 17 Jan 2008 16:31:40 -0600 Scott Wood <[EMAIL PROTECTED]> wrote:
>
> +static __initdata struct of_device_id __initdata of_bus_ids[] = {
You don't need to mark it __initdata twice ...
--
Cheers,
Stephen Rothwell[EMAI
i = sprintf (buf, "vio:T%sS%s\n", of_node->type, compat ?
> compat : "");
^
Or here.
It would be nice if we could factor out the "vio:T%sS%s" string as it is
also used in vio_hotplug().
--
Cheers,
Stephen Rothwell
Hi Michael,
On Tue, 22 Jan 2008 22:04:40 +1100 (EST) Michael Ellerman <[EMAIL PROTECTED]>
wrote:
>
> +#include
You must have missed the lectures :-) Please use linux/of_platform.h
> +static struct of_device_id axon_msi_device_id[] = {
const, please.
--
Cheers,
S
ister);
> void of_device_unregister(struct of_device *ofdev)
> {
> device_remove_file(&ofdev->dev, &dev_attr_devspec);
> + device_remove_file(&ofdev->dev, &dev_attr_modalias);
> device_unregister(&ofdev->dev);
> }
> EXPORT_SYMBO
parc guys
([EMAIL PROTECTED]) since they share this stuff with us, now.
--
Cheers,
Stephen Rothwell[EMAIL PROTECTED]
http://www.canb.auug.org.au/~sfr/
pgpoKOfgtHzYD.pgp
Description: PGP signature
___
Linuxppc-dev mailing list
Linuxp
pec);
> + device_remove_file(&ofdev->dev, &dev_attr_modalias);
> device_unregister(&ofdev->dev);
> }
> EXPORT_SYMBOL(of_device_unregister);
> ___
> Linuxppc-dev mailing list
> Linuxppc-dev@ozlabs.org
>
the reasons why
it should be decalred in a header file ...)
The others look good, though.
--
Cheers,
Stephen Rothwell[EMAIL PROTECTED]
http://www.canb.auug.org.au/~sfr/
pgpR5Viq4x1PD.pgp
Description: PGP signature
___
Linuxppc-dev
Hi Wade,
On Tue, 22 Jan 2008 09:47:12 -0700 Wade Farnsworth <[EMAIL PROTECTED]> wrote:
>
> +static struct of_device_id mpc86xx_ids[] = {
__initdata, please.
--
Cheers,
Stephen Rothwell[EMAIL PROTECTED]
http://www.canb.auug.org.au/~sfr/
pgpPE23LG4t6d.pgp
Desc
On Tue, 22 Jan 2008 13:17:45 -0700 Wade Farnsworth <[EMAIL PROTECTED]> wrote:
>
> +static struct of_device_id of_bus_ids[] = {
You forgot the __initdata.
--
Cheers,
Stephen Rothwell[EMAIL PROTECTED]
http://www.canb.auug.org.au/~sfr/
pgpdMHQWtQtfS.pgp
Desc
"reg", &size);
> + paddr = (phys_addr_t)of_translate_address(dnp, prop);
What happens of "prop" is NULL?
--
Cheers,
Stephen Rothwell[EMAIL PROTECTED]
http://www.canb.auug.org.au/~sfr/
pgpzxaLdNOYq2.pgp
Description: PGP signature
___
> delete mode 100644 drivers/i2c/busses/i2c-mpc.c
Adding -M or -C to the "git diff" should identify renames and
makes this sort of patch much easier to review.
--
Cheers,
Stephen Rothwell[EMAIL PROTECTED]
http://www.canb.
rintk(KERN_ERR "i2c-mpc.c: invalid entry, missing
> compatible attribute\n");
Some of these printk lines are a bit long.
--
Cheers,
Stephen Rothwell[EMAIL PROTECTED]
http://www.canb.auug.org.au/~sfr/
pgp7cv0rEF5Zk.pgp
Description: PGP signature
___
"No label property provided for LED %s\n",
> + op->node->full_name);
> + err = -EINVAL;
> + goto err_free;
You need an iounmap(mpled->gpt) here - or preferably jump to the one in
the error path below.
--
Cheers,
Stephen Rothwe
e(u_char bus, u_char devfn)
> #endif /* CONFIG_PCI */
>
> #ifdef CONFIG_RAPIDIO
> +extern void mpc85xx_rio_setup(int law_start, int law_size);
Third time lucky? :-)
--
Cheers,
Stephen Rothwell[EMAIL PROTECTED]
http://www.canb.a
e damaged this patch.
--
Cheers,
Stephen Rothwell[EMAIL PROTECTED]
http://www.canb.auug.org.au/~sfr/
pgpa4bRCYKSgk.pgp
Description: PGP signature
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
return;
You need an of_node_put(dnp) before you return.
--
Cheers,
Stephen Rothwell[EMAIL PROTECTED]
http://www.canb.auug.org.au/~sfr/
pgpd4vhBbH8XK.pgp
Description: PGP signature
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
ge(np);
> +#endif
> +
> +#ifdef CONFIG_QUICC_ENGINE
> + qe_reset();
> +
> + np = of_find_compatible_node(NULL, NULL, "fsl,qe-pario");
> + if (!np) {
> + pr_warning("QE PIO not initialized!\n");
> + return;
You need an o
tdm_c->dma_input_addr);
> +
You need to unmap the uf_reg and the irq.
> +static struct of_device_id ucc_tdm_match[] = {
const, please.
> + {
> + .type = "tdm",
> + .compatible = "fsl,ucc-tdm",
> + }, {},
We euld normall format this like:
= -EINVAL;
> + goto err;
This goto is redundant.
> + }
> +err: return ret;
Put the label on a line by itself and indent it one space (that means that
"diff -p will reference the funstion anem instead of the label).
> @@ -152,6 +152,10 @@ struct ucc_fast_inf
[] = {
__initdata and not const, please.
> +static int __init stx_gp3_probe(void)
> +{
> +unsigned long root = of_get_flat_dt_root();
> +
> +return of_flat_dt_is_compatible(root, "stx,gp3-8560");
You should include to use the flattened device tree accessors.
--
Hi Anton,
On Thu, 24 Jan 2008 16:29:01 +0300 Anton Vorontsov <[EMAIL PROTECTED]> wrote:
>
> On Thu, Jan 24, 2008 at 01:22:01PM +1100, Stephen Rothwell wrote:
> > On Wed, 23 Jan 2008 23:45:07 +0300 Anton Vorontsov <[EMAIL PROTECTED]>
> > wrote:
> > >
Hi Olaf,
[Sorry, been on vacation]
On Fri, 25 Jan 2008 18:09:14 +0100 Olaf Hering <[EMAIL PROTECTED]> wrote:
>
> On Wed, Jan 23, Stephen Rothwell wrote:
>
> > It would be nice if we could factor out the "vio:T%sS%s" string as it is
> > also used in vio_hot
gned long root = of_get_flat_dt_root();
> +
> + return of_flat_dt_is_compatible(root, "fsl,mpc8377rdb") ||
> +of_flat_dt_is_compatible(root, "fsl,mpc8378rdb") ||
> +of_flat_dt_is_compatible(root, "fsl,mpc8379rdb");
You
On Mon, 4 Feb 2008 16:46:17 +0300 Anton Vorontsov <[EMAIL PROTECTED]> wrote:
>
> On Tue, Feb 05, 2008 at 12:13:18AM +1100, Stephen Rothwell wrote:
> >
> > If you don't care about the returned length (argument three to
> > of_get_property), you can just
rg-frequency", &size);
> - brg_clk = *prop;
> - of_node_put(qe);
> - };
> + qe = of_find_compatible_node(NULL, NULL, "fsl,qe");
> + if (!qe) {
> + qe = of_find_node_by_type(NULL, "qe");
> +
h/powerpc/platforms/83xx/mpc8313_rdb.c
> + * arch/powerpc/platforms/83xx/mpc831x_rdb.c
Just remove the file name from the comment.
--
Cheers,
Stephen Rothwell[EMAIL PROTECTED]
http://www.canb.auug.org.au/~sfr/
pgp6efnUHqYpt.pgp
e function .init.text:.free_property()
> ...
>
> <-- snip -->
>
> Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
Acked-by: Stephen Rothwell <[EMAIL PROTECTED]>
--
Cheers,
Stephen Rothwell[EMAIL PROTECTED]
http://www.
ode. This fixes it by localising the ref counting
a bit. As a side effect, the warning goes away.
Signed-off-by: Stephen Rothwell <[EMAIL PROTECTED]>
---
arch/powerpc/platforms/cell/axon_msi.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/powerpc/platforms/ce
WARNING: vmlinux.o(.text+0x3017c): Section mismatch in reference from the
function .vio_create_viodasd() to the function
.devinit.text:.vio_register_device_node()
Signed-off-by: Stephen Rothwell <[EMAIL PROTECTED]>
---
arch/powerpc/kernel/vio.c |2 +-
include/asm-powerpc/vio.h |2
WARNING: drivers/cdrom/viocd.o(.text+0x504): Section mismatch in reference from
the function .viocd_probe() to the function .init.text:.find_capability()
Signed-off-by: Stephen Rothwell <[EMAIL PROTECTED]>
---
drivers/cdrom/viocd.c |2 +-
1 files changed, 1 insertions(+), 1 del
WARNING: vmlinux.o(.text+0x25dca0): Section mismatch in reference from the
function .veth_probe() to the function .init.text:.veth_probe_one()
Signed-off-by: Stephen Rothwell <[EMAIL PROTECTED]>
---
drivers/net/iseries_veth.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
ut(test_np);
> + if (alias)
> + break;
This could be:
of_node_put(test_np);
if (test_np == np) {
alias = pp->name + prefix_len;
break;
}
As you can still test for pointer equality after d
appens if either of these properties is missing?
> +static struct of_device_id fsl_of_rio_rpn_ids[] = {
This should be "const" please.
--
Cheers,
Stephen Rothwell[EMAIL PROTECTED]
http://www.canb.auug.org.au/~sfr/
pgpgauT5Azp25.pgp
Description: PGP signature
_
On Tue, 05 Feb 2008 13:32:33 -0500 Jeff Garzik <[EMAIL PROTECTED]> wrote:
>
> it's trivial enough to not matter, and faster to just... applied
> (if you'll pardon the bad grammar)
Thanks.
--
Cheers,
Stephen Rothwell[EMAIL PROTECTED]
http://
Signed-off-by: Stephen Rothwell <[EMAIL PROTECTED]>
---
include/asm-powerpc/systbl.h |4 +++-
include/asm-powerpc/unistd.h |6 --
2 files changed, 7 insertions(+), 3 deletions(-)
Kernel built for ppc64_defconfig, pseries_defconfig, iseries_defconfig,
cell_defconf
801 - 900 of 1869 matches
Mail list logo
