On Mon, 07 Jan 2008 18:21:57 -0600 Manish Ahuja <[EMAIL PROTECTED]> wrote:
>
> +static int __init phyp_dump_setup(void)
> +{
>
> +     /* Is there dump data waiting for us? */
> +     rtas = of_find_node_by_path("/rtas");
> +     dump_header = of_get_property(rtas, "ibm,kernel-dump", &header_len);
                                                               ^^^^^^^^^^^
You could pass NULL here as header_len appears to be unused. Also you
need "of_node_put(rtas)" somewhere (probably just here would do).

> +     if (dump_header == NULL) {
> +             release_all();
> +             return 0;
> +     }
-- 
Cheers,
Stephen Rothwell                    [EMAIL PROTECTED]
http://www.canb.auug.org.au/~sfr/

Attachment: pgpOilA6GewxA.pgp
Description: PGP signature

_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev

Reply via email to