On Wed, 23 Jan 2008 23:45:07 +0300 Anton Vorontsov <[EMAIL PROTECTED]> wrote:
>
> +++ b/arch/powerpc/platforms/83xx/mpc836x_rdk.c
> +static int __init mpc836x_rdk_declare_of_platform_devices(void)
> +{
> + const struct of_device_id mpc836x_rdk_ids[] = {
Please change this to static, __initdata and not const, thanks. These
arrays are usually defined outside a function, but that is not really a
problem.
> +static void __init mpc836x_rdk_setup_arch(void)
> +{
> + struct device_node *np;
!defined(CONFIG_PCI) && !defined(CONFIG_QUICC_ENGINE) will produce a
warning here.
> + if (ppc_md.progress)
> + ppc_md.progress("mpc836x_rdk_setup_arch()", 0);
> +
> +#ifdef CONFIG_PCI
> + for_each_compatible_node(np, "pci", "fsl,mpc8349-pci")
> + mpc83xx_add_bridge(np);
> +#endif
> +
> +#ifdef CONFIG_QUICC_ENGINE
> + qe_reset();
> +
> + np = of_find_compatible_node(NULL, NULL, "fsl,qe-pario");
> + if (!np) {
> + pr_warning("QE PIO not initialized!\n");
> + return;
You need an of_node_put(np) before the return.
--
Cheers,
Stephen Rothwell [EMAIL PROTECTED]
http://www.canb.auug.org.au/~sfr/
pgpdavOHvOtLk.pgp
Description: PGP signature
_______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
