Hi Michael, Just a couple of things.
On Tue, 22 Jan 2008 22:04:40 +1100 (EST) Michael Ellerman <[EMAIL PROTECTED]>
wrote:
>
> +static void of_platform_device_shutdown(struct device * dev)
^
No space, please.
Also, I wonder if we should check that the drivers that already have
specified a shutdown routine (drivers/input/misc/sparcspkr.c,
drivers/usb/host/ohci-ppc-of.c and drivers/watchdog/mpc5200_wdt.c) are
actually ok if it actually gets called. :-)
Also, patches like this should be cc'd to (at least) the sparc guys
([EMAIL PROTECTED]) since they share this stuff with us, now.
--
Cheers,
Stephen Rothwell [EMAIL PROTECTED]
http://www.canb.auug.org.au/~sfr/
pgpoKOfgtHzYD.pgp
Description: PGP signature
_______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
