On Mon, 14 Jan 2008 23:45:17 -0500 Sean MacLennan <[EMAIL PROTECTED]> wrote: > > Stephen Rothwell wrote: > > On Mon, 14 Jan 2008 23:15:41 -0500 Sean MacLennan <[EMAIL PROTECTED]> wrote: > > > >> I keep getting these link(?) warnings: > >> > >> WARNING: vmlinux.o(.data+0x16178): Section mismatch: reference to > >> .init.text:emac_of_bus_notify (between 'emac_of_bus_notifier' and > >> 'emac_phy_map_lock') > > > emac_of_bus_notify is marked __devinit and is referred to by > > emac_of_bus_notifier (which is not marked thus) (in > > drivers/net/ibm_newemac/core.c). > > Adding the __devinit to emacs_of_bus_notifier causes a problem with > emac_phy_map_lock (a mutex). But removing the __devinit from > emac_of_bus_notify cleans up that warning. Is the __devinit really > necessary?
What problem do you get. The correct fix is to mark emac_of_bus_notifier as __devinitdata. The __devinit marking of emac_of_bus_notify is not strictly necessary, but some people care about the size of their kernels. -- Cheers, Stephen Rothwell [EMAIL PROTECTED] http://www.canb.auug.org.au/~sfr/
pgpPINUmIZMo0.pgp
Description: PGP signature
_______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
