On Mon, 14 Jan 2008 16:44:33 -0600 Scott Wood <[EMAIL PROTECTED]> wrote:
>
> Stephen Rothwell wrote:
> >> +++ b/libfdt/libfdt.h
> > 
> >> +#define FDT_ERR_BADDEPTH  8
> > 
> > Wouldn't it have been less intrusive to just use the next error number
> > rather than inserting this here?
> 
> Yes, but then either the order in errtable[] wouldn't match the order in 
> the header file, or the error type grouping would be broken.
> 
> If we want to maintain such a grouping, we should probably leave some 
> number space between the groups.

OK.

> "pointer to a string" could be interpreted as "char *", not "char **".

Yeah, it has always been a bit ambiguous.

> I'll fix the others; thanks for pointing them out.

No worries.
-- 
Cheers,
Stephen Rothwell                    [EMAIL PROTECTED]
http://www.canb.auug.org.au/~sfr/

Attachment: pgpBynU8UiaYC.pgp
Description: PGP signature

_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev

Reply via email to